strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clang-tidy modernize-pass-by-value in xmlreader

Browse source 
Change-Id: I448d3119129a864e79dbef336e46545f9aca8b25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137584
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2022-07-29 09:49:47 +02:00
parent baf433a2f7
commit af65e892dc
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/xmlreader/xmlreader.hxx
View file

@ -35,7 +35,7 @@ namespace xmlreader {
class OOO_DLLPUBLIC_XMLREADER XmlReader {
public:
explicit XmlReader(OUString const & fileUrl);
explicit XmlReader(OUString fileUrl);
~XmlReader();

5
xmlreader/source/xmlreader.cxx
View file

@ -30,6 +30,7 @@
#include <rtl/ustring.hxx>
#include <sal/log.hxx>
#include <sal/types.h>
#include <utility>
#include <xmlreader/pad.hxx>
#include <xmlreader/span.hxx>
#include <xmlreader/xmlreader.hxx>
@ -52,8 +53,8 @@ bool isSpace(char c) {
}
XmlReader::XmlReader(OUString const & fileUrl)
: fileUrl_(fileUrl)
XmlReader::XmlReader(OUString fileUrl)
: fileUrl_(std::move(fileUrl))
, fileHandle_(nullptr)
{
oslFileError e = osl_openFile(