From b1af7083b469eec48783b7a1aaff6d080901fc7f Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 2 Sep 2021 09:16:09 +0200 Subject: [PATCH] clang-tidy:readability-redundant-member-init Change-Id: I39b9ac81d65f4a269293824642c1b2ec593c0584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121490 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sot/source/sdstor/stgdir.cxx | 4 ++-- sot/source/sdstor/stgio.cxx | 2 +- sot/source/sdstor/ucbstorage.cxx | 3 --- starmath/source/cfgitem.cxx | 4 ---- starmath/source/node.cxx | 1 - starmath/source/parse5.cxx | 3 +-- stoc/source/corereflection/crefl.cxx | 1 - store/source/lockbyte.cxx | 4 ++-- store/source/stordir.cxx | 3 +-- store/source/storlckb.cxx | 4 +--- svgio/source/svgreader/svgcharacternode.cxx | 11 +--------- svgio/source/svgreader/svgdocument.cxx | 5 +---- svgio/source/svgreader/svgdocumenthandler.cxx | 1 - svgio/source/svgreader/svggradientnode.cxx | 10 ---------- .../source/svgreader/svggradientstopnode.cxx | 3 +-- svgio/source/svgreader/svgimagenode.cxx | 7 +------ svgio/source/svgreader/svgmarkernode.cxx | 2 -- svgio/source/svgreader/svgnode.cxx | 2 -- svgio/source/svgreader/svgpathnode.cxx | 3 +-- svgio/source/svgreader/svgpatternnode.cxx | 7 ------- svgio/source/svgreader/svgstyleattributes.cxx | 20 ------------------- svgio/source/svgreader/svgstylenode.cxx | 1 - svgio/source/svgreader/svgsvgnode.cxx | 6 ------ svgio/source/svgreader/svgsymbolnode.cxx | 3 +-- svgio/source/svgreader/svgtextnode.cxx | 3 +-- svgio/source/svgreader/svgtextpathnode.cxx | 5 +---- svgio/source/svgreader/svgtitledescnode.cxx | 3 +-- svgio/source/svgreader/svgtrefnode.cxx | 3 +-- svgio/source/svgreader/svgtspannode.cxx | 3 +-- svgio/source/svgreader/svgusenode.cxx | 5 ----- 30 files changed, 19 insertions(+), 113 deletions(-) diff --git a/sot/source/sdstor/stgdir.cxx b/sot/source/sdstor/stgdir.cxx index 312b07870952..b12feb594482 100644 --- a/sot/source/sdstor/stgdir.cxx +++ b/sot/source/sdstor/stgdir.cxx @@ -45,14 +45,14 @@ // Problem of implementation: No hierarchical commits. Therefore only // overall transaction-oriented or direct. -StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen, sal_uInt64 nUnderlyingStreamSize, bool * pbOk ) : StgAvlNode() +StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen, sal_uInt64 nUnderlyingStreamSize, bool * pbOk ) { *pbOk = m_aEntry.Load( pBuffer, nBufferLen, nUnderlyingStreamSize ); InitMembers(); } -StgDirEntry::StgDirEntry( const StgEntry& r ) : StgAvlNode(), m_aEntry( r ) +StgDirEntry::StgDirEntry( const StgEntry& r ) : m_aEntry( r ) { InitMembers(); } diff --git a/sot/source/sdstor/stgio.cxx b/sot/source/sdstor/stgio.cxx index 304be0e35d92..604d082828f7 100644 --- a/sot/source/sdstor/stgio.cxx +++ b/sot/source/sdstor/stgio.cxx @@ -33,7 +33,7 @@ // This class holds the storage header and all internal streams. -StgIo::StgIo() : StgCache() +StgIo::StgIo() { m_pTOC = nullptr; m_pDataFAT = nullptr; diff --git a/sot/source/sdstor/ucbstorage.cxx b/sot/source/sdstor/ucbstorage.cxx index 09b435550feb..6a14ce1dc4e1 100644 --- a/sot/source/sdstor/ucbstorage.cxx +++ b/sot/source/sdstor/ucbstorage.cxx @@ -1440,7 +1440,6 @@ UCBStorage_Impl::UCBStorage_Impl( const ::ucbhelper::Content& rContent, const OU , m_bIsLinked( true ) , m_bListCreated( false ) , m_nFormat( SotClipboardFormatId::NONE ) - , m_aClassId( SvGlobalName() ) , m_bRepairPackage( bIsRepair ) , m_xProgressHandler( xProgressHandler ) { @@ -1469,7 +1468,6 @@ UCBStorage_Impl::UCBStorage_Impl( const OUString& rName, StreamMode nMode, UCBSt , m_bIsLinked( false ) , m_bListCreated( false ) , m_nFormat( SotClipboardFormatId::NONE ) - , m_aClassId( SvGlobalName() ) , m_bRepairPackage( bIsRepair ) , m_xProgressHandler( xProgressHandler ) { @@ -1515,7 +1513,6 @@ UCBStorage_Impl::UCBStorage_Impl( SvStream& rStream, UCBStorage* pStorage, bool , m_bIsLinked( false ) , m_bListCreated( false ) , m_nFormat( SotClipboardFormatId::NONE ) - , m_aClassId( SvGlobalName() ) , m_bRepairPackage( false ) { // opening in direct mode is too fuzzy because the data is transferred to the stream in the Commit() call, diff --git a/starmath/source/cfgitem.cxx b/starmath/source/cfgitem.cxx index ce765f09a7d7..814e4101ed29 100644 --- a/starmath/source/cfgitem.cxx +++ b/starmath/source/cfgitem.cxx @@ -340,10 +340,6 @@ OUString SmFontFormatList::GetNewFontFormatId() const SmMathConfig::SmMathConfig() : ConfigItem("Office.Math") - , pFormat() - , pOther() - , pFontFormatList() - , pSymbolMgr() , bIsOtherModified(false) , bIsFormatModified(false) { diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx index 4a20216a3771..43d5ca7429e7 100644 --- a/starmath/source/node.cxx +++ b/starmath/source/node.cxx @@ -1716,7 +1716,6 @@ void SmFontNode::Arrange(OutputDevice &rDev, const SmFormat &rFormat) SmPolyLineNode::SmPolyLineNode(const SmToken &rNodeToken) : SmGraphicNode(SmNodeType::PolyLine, rNodeToken) , maPoly(2) - , maToSize() , mnWidth(0) { } diff --git a/starmath/source/parse5.cxx b/starmath/source/parse5.cxx index 23ffb17d19d3..a3b253bfd308 100644 --- a/starmath/source/parse5.cxx +++ b/starmath/source/parse5.cxx @@ -2686,8 +2686,7 @@ std::unique_ptr SmParser5::DoError(SmParseError eError) // end grammar SmParser5::SmParser5() - : AbstractSmParser() - , m_nCurError(0) + : m_nCurError(0) , m_nBufferIndex(0) , m_nTokenIndex(0) , m_nRow(0) diff --git a/stoc/source/corereflection/crefl.cxx b/stoc/source/corereflection/crefl.cxx index 1f53572ff0c6..723e0711fa59 100644 --- a/stoc/source/corereflection/crefl.cxx +++ b/stoc/source/corereflection/crefl.cxx @@ -46,7 +46,6 @@ namespace stoc_corefl IdlReflectionServiceImpl::IdlReflectionServiceImpl( const Reference< XComponentContext > & xContext ) : OComponentHelper( _aComponentMutex ) - , _aElements() { xContext->getValueByName( "/singletons/com.sun.star.reflection.theTypeDescriptionManager" ) >>= _xTDMgr; diff --git a/store/source/lockbyte.cxx b/store/source/lockbyte.cxx index 91de98023c48..4a163fff6c9f 100644 --- a/store/source/lockbyte.cxx +++ b/store/source/lockbyte.cxx @@ -322,7 +322,7 @@ protected: } // namespace store FileLockBytes::FileLockBytes (FileHandle const & rFile) - : m_hFile (rFile.m_handle), m_nSize (SAL_MAX_UINT32), m_xAllocator() + : m_hFile (rFile.m_handle), m_nSize (SAL_MAX_UINT32) { } @@ -695,7 +695,7 @@ protected: } // namespace store MemoryLockBytes::MemoryLockBytes() - : m_pData (nullptr), m_nSize (0), m_xAllocator() + : m_pData (nullptr), m_nSize (0) {} MemoryLockBytes::~MemoryLockBytes() diff --git a/store/source/stordir.cxx b/store/source/stordir.cxx index 80cb2efc501c..9ebdc7693df3 100644 --- a/store/source/stordir.cxx +++ b/store/source/stordir.cxx @@ -69,8 +69,7 @@ const sal_uInt32 OStoreDirectory_Impl::m_nTypeId(0x89191107); * OStoreDirectory_Impl. */ OStoreDirectory_Impl::OStoreDirectory_Impl() - : m_xManager (), - m_aDescr (0, 0, 0), + : m_aDescr (0, 0, 0), m_nPath (0), m_hTextCvt (nullptr) {} diff --git a/store/source/storlckb.cxx b/store/source/storlckb.cxx index 1aaf2cbc0a77..09c4f73136c8 100644 --- a/store/source/storlckb.cxx +++ b/store/source/storlckb.cxx @@ -43,9 +43,7 @@ const sal_uInt32 OStoreLockBytes::m_nTypeId(0x94190310); * OStoreLockBytes. */ OStoreLockBytes::OStoreLockBytes() - : m_xManager (), - m_xNode (), - m_bWriteable (false) + : m_bWriteable (false) { } diff --git a/svgio/source/svgreader/svgcharacternode.cxx b/svgio/source/svgreader/svgcharacternode.cxx index eb7037d17f2c..d561a447384f 100644 --- a/svgio/source/svgreader/svgcharacternode.cxx +++ b/svgio/source/svgreader/svgcharacternode.cxx @@ -28,13 +28,7 @@ namespace svgio::svgreader { SvgTextPositions::SvgTextPositions() - : maX(), - maY(), - maDx(), - maDy(), - maRotate(), - maTextLength(), - mbLengthAdjust(true) + : mbLengthAdjust(true) { } @@ -563,11 +557,8 @@ namespace svgio::svgreader const InfoProvider& rInfoProvider, const SvgTextPositions& rSvgTextPositions) : mpParent(pParent), - maX(), // computed below - maY(), // computed below maRotate(solveSvgNumberVector(rSvgTextPositions.getRotate(), rInfoProvider)), mfTextLength(0.0), - maPosition(), // computed below mnRotationIndex(0), mbLengthAdjust(rSvgTextPositions.getLengthAdjust()), mbAbsoluteX(false) diff --git a/svgio/source/svgreader/svgdocument.cxx b/svgio/source/svgreader/svgdocument.cxx index 458f4d1ceff9..2b1d534ffd72 100644 --- a/svgio/source/svgreader/svgdocument.cxx +++ b/svgio/source/svgreader/svgdocument.cxx @@ -22,10 +22,7 @@ namespace svgio::svgreader { SvgDocument::SvgDocument(const OUString& rAbsolutePath) - : maNodes(), - maAbsolutePath(rAbsolutePath), - maIdTokenMapperList(), - maIdStyleTokenMapperList() + : maAbsolutePath(rAbsolutePath) { } diff --git a/svgio/source/svgreader/svgdocumenthandler.cxx b/svgio/source/svgreader/svgdocumenthandler.cxx index ccc0bc306c8b..fa620831aa4c 100644 --- a/svgio/source/svgreader/svgdocumenthandler.cxx +++ b/svgio/source/svgreader/svgdocumenthandler.cxx @@ -136,7 +136,6 @@ namespace SvgDocHdl::SvgDocHdl(const OUString& aAbsolutePath) : maDocument(aAbsolutePath), mpTarget(nullptr), - maCssContents(), bSkip(false) { } diff --git a/svgio/source/svgreader/svggradientnode.cxx b/svgio/source/svgreader/svggradientnode.cxx index 0b2ad5cabaf4..6520c4066b81 100644 --- a/svgio/source/svgreader/svggradientnode.cxx +++ b/svgio/source/svgreader/svggradientnode.cxx @@ -37,19 +37,9 @@ namespace svgio::svgreader SvgNode* pParent) : SvgNode(aType, rDocument, pParent), maSvgStyleAttributes(*this), - maX1(), - maY1(), - maX2(), - maY2(), - maCx(), - maCy(), - maR(), - maFx(), - maFy(), maGradientUnits(SvgUnits::objectBoundingBox), maSpreadMethod(drawinglayer::primitive2d::SpreadMethod::Pad), mbResolvingLink(false), - maXLink(), mpXLink(nullptr) { OSL_ENSURE(aType == SVGToken::LinearGradient || aType == SVGToken::RadialGradient, "SvgGradientNode should only be used for Linear and Radial gradient (!)"); diff --git a/svgio/source/svgreader/svggradientstopnode.cxx b/svgio/source/svgreader/svggradientstopnode.cxx index 980333576e92..5c7c0542ab95 100644 --- a/svgio/source/svgreader/svggradientstopnode.cxx +++ b/svgio/source/svgreader/svggradientstopnode.cxx @@ -25,8 +25,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Stop, rDocument, pParent), - maSvgStyleAttributes(*this), - maOffset() + maSvgStyleAttributes(*this) { } diff --git a/svgio/source/svgreader/svgimagenode.cxx b/svgio/source/svgreader/svgimagenode.cxx index 445e78a2646c..2dba10c6631b 100644 --- a/svgio/source/svgreader/svgimagenode.cxx +++ b/svgio/source/svgreader/svgimagenode.cxx @@ -41,15 +41,10 @@ namespace svgio::svgreader SvgNode* pParent) : SvgNode(SVGToken::Rect, rDocument, pParent), maSvgStyleAttributes(*this), - maSvgAspectRatio(), maX(0), maY(0), maWidth(0), - maHeight(0), - maXLink(), - maUrl(), - maMimeType(), - maData() + maHeight(0) { } diff --git a/svgio/source/svgreader/svgmarkernode.cxx b/svgio/source/svgreader/svgmarkernode.cxx index b16d03dd004d..0c930685c7f9 100644 --- a/svgio/source/svgreader/svgmarkernode.cxx +++ b/svgio/source/svgreader/svgmarkernode.cxx @@ -25,9 +25,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Marker, rDocument, pParent), - aPrimitives(), maSvgStyleAttributes(*this), - maSvgAspectRatio(), maRefX(0), maRefY(0), maMarkerUnits(MarkerUnits::strokeWidth), diff --git a/svgio/source/svgreader/svgnode.cxx b/svgio/source/svgreader/svgnode.cxx index 44c323920281..e940acbe6a07 100644 --- a/svgio/source/svgreader/svgnode.cxx +++ b/svgio/source/svgreader/svgnode.cxx @@ -267,10 +267,8 @@ namespace svgio::svgreader mrDocument(rDocument), mpParent(pParent), mpAlternativeParent(nullptr), - maChildren(), maXmlSpace(XmlSpace::NotSet), maDisplay(Display::Inline), - maCssStyleVector(), mbDecomposing(false), mbCssStyleVectorBuilt(false) { diff --git a/svgio/source/svgreader/svgpathnode.cxx b/svgio/source/svgreader/svgpathnode.cxx index d32a92b6a8c5..f3637bcf410f 100644 --- a/svgio/source/svgreader/svgpathnode.cxx +++ b/svgio/source/svgreader/svgpathnode.cxx @@ -26,8 +26,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Path, rDocument, pParent), - maSvgStyleAttributes(*this), - maPathLength() + maSvgStyleAttributes(*this) { } diff --git a/svgio/source/svgreader/svgpatternnode.cxx b/svgio/source/svgreader/svgpatternnode.cxx index ff92896fa350..e0fa2214be0f 100644 --- a/svgio/source/svgreader/svgpatternnode.cxx +++ b/svgio/source/svgreader/svgpatternnode.cxx @@ -34,15 +34,8 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Pattern, rDocument, pParent), - aPrimitives(), maSvgStyleAttributes(*this), - maSvgAspectRatio(), - maX(), - maY(), - maWidth(), - maHeight(), mbResolvingLink(false), - maXLink(), mpXLink(nullptr) { } diff --git a/svgio/source/svgreader/svgstyleattributes.cxx b/svgio/source/svgreader/svgstyleattributes.cxx index fc072882d864..df7efce88a85 100644 --- a/svgio/source/svgreader/svgstyleattributes.cxx +++ b/svgio/source/svgreader/svgstyleattributes.cxx @@ -1249,41 +1249,21 @@ namespace svgio::svgreader SvgStyleAttributes::SvgStyleAttributes(SvgNode& rOwner) : mrOwner(rOwner), mpCssStyleParent(nullptr), - maFill(), - maStroke(), maStopColor(basegfx::BColor(0.0, 0.0, 0.0), true), - maStrokeWidth(), - maStopOpacity(), - maFillOpacity(), - maStrokeDasharray(), - maStrokeDashOffset(), maStrokeLinecap(StrokeLinecap::notset), maStrokeLinejoin(StrokeLinejoin::notset), - maStrokeMiterLimit(), - maStrokeOpacity(), - maFontFamily(), maFontSize(), - maFontSizeNumber(), maFontStretch(FontStretch::notset), maFontStyle(FontStyle::notset), maFontWeight(FontWeight::notset), maTextAlign(TextAlign::notset), maTextDecoration(TextDecoration::notset), maTextAnchor(TextAnchor::notset), - maColor(), - maOpacity(), maVisibility(Visibility::notset), - maTitle(), - maDesc(), - maClipPathXLink(), mpClipPathXLink(nullptr), - maMaskXLink(), mpMaskXLink(nullptr), - maMarkerStartXLink(), mpMarkerStartXLink(nullptr), - maMarkerMidXLink(), mpMarkerMidXLink(nullptr), - maMarkerEndXLink(), mpMarkerEndXLink(nullptr), maFillRule(FillRule::notset), maClipRule(FillRule::nonzero), diff --git a/svgio/source/svgreader/svgstylenode.cxx b/svgio/source/svgreader/svgstylenode.cxx index d9a335fede12..5f31482e833e 100644 --- a/svgio/source/svgreader/svgstylenode.cxx +++ b/svgio/source/svgreader/svgstylenode.cxx @@ -27,7 +27,6 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Style, rDocument, pParent), - maSvgStyleAttributes(), mbTextCss(false) { } diff --git a/svgio/source/svgreader/svgsvgnode.cxx b/svgio/source/svgreader/svgsvgnode.cxx index 082b8f89a715..71246df49a05 100644 --- a/svgio/source/svgreader/svgsvgnode.cxx +++ b/svgio/source/svgreader/svgsvgnode.cxx @@ -35,12 +35,6 @@ namespace svgio::svgreader SvgNode* pParent) : SvgNode(SVGToken::Svg, rDocument, pParent), maSvgStyleAttributes(*this), - maSvgAspectRatio(), - maX(), - maY(), - maWidth(), - maHeight(), - maVersion(), mbStyleAttributesInitialized(false) // #i125258# { } diff --git a/svgio/source/svgreader/svgsymbolnode.cxx b/svgio/source/svgreader/svgsymbolnode.cxx index c7a61217d0f5..b505a7500dc0 100644 --- a/svgio/source/svgreader/svgsymbolnode.cxx +++ b/svgio/source/svgreader/svgsymbolnode.cxx @@ -25,8 +25,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Svg, rDocument, pParent), - maSvgStyleAttributes(*this), - maSvgAspectRatio() + maSvgStyleAttributes(*this) { } diff --git a/svgio/source/svgreader/svgtextnode.cxx b/svgio/source/svgreader/svgtextnode.cxx index 99d2cf0c6a10..bda316cae4a4 100644 --- a/svgio/source/svgreader/svgtextnode.cxx +++ b/svgio/source/svgreader/svgtextnode.cxx @@ -31,8 +31,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Text, rDocument, pParent), - maSvgStyleAttributes(*this), - maSvgTextPositions() + maSvgStyleAttributes(*this) { } diff --git a/svgio/source/svgreader/svgtextpathnode.cxx b/svgio/source/svgreader/svgtextpathnode.cxx index e04b8380735e..925bfc4d1944 100644 --- a/svgio/source/svgreader/svgtextpathnode.cxx +++ b/svgio/source/svgreader/svgtextpathnode.cxx @@ -120,7 +120,6 @@ namespace svgio::svgreader mrTextStart(rTextStart), mnMaxIndex(rPolygon.isClosed() ? rPolygon.count() : rPolygon.count() - 1), mnIndex(0), - maCurrentSegment(), mfCurrentSegmentLength(0.0), mfSegmentStartPosition(0.0) { @@ -242,9 +241,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::TextPath, rDocument, pParent), - maSvgStyleAttributes(*this), - maXLink(), - maStartOffset() + maSvgStyleAttributes(*this) { } diff --git a/svgio/source/svgreader/svgtitledescnode.cxx b/svgio/source/svgreader/svgtitledescnode.cxx index b71b38fb716f..8498762cc611 100644 --- a/svgio/source/svgreader/svgtitledescnode.cxx +++ b/svgio/source/svgreader/svgtitledescnode.cxx @@ -27,8 +27,7 @@ namespace svgio::svgreader SVGToken aType, SvgDocument& rDocument, SvgNode* pParent) - : SvgNode(aType, rDocument, pParent), - maText() + : SvgNode(aType, rDocument, pParent) { OSL_ENSURE(aType == SVGToken::Title || aType == SVGToken::Desc, "SvgTitleDescNode should only be used for Title and Desc (!)"); } diff --git a/svgio/source/svgreader/svgtrefnode.cxx b/svgio/source/svgreader/svgtrefnode.cxx index 07198265346d..44b34a0cf3db 100644 --- a/svgio/source/svgreader/svgtrefnode.cxx +++ b/svgio/source/svgreader/svgtrefnode.cxx @@ -26,8 +26,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Tref, rDocument, pParent), - maSvgStyleAttributes(*this), - maXLink() + maSvgStyleAttributes(*this) { } diff --git a/svgio/source/svgreader/svgtspannode.cxx b/svgio/source/svgreader/svgtspannode.cxx index b709a24d667c..e751237289f2 100644 --- a/svgio/source/svgreader/svgtspannode.cxx +++ b/svgio/source/svgreader/svgtspannode.cxx @@ -25,8 +25,7 @@ namespace svgio::svgreader SvgDocument& rDocument, SvgNode* pParent) : SvgNode(SVGToken::Tspan, rDocument, pParent), - maSvgStyleAttributes(*this), - maSvgTextPositions() + maSvgStyleAttributes(*this) { } diff --git a/svgio/source/svgreader/svgusenode.cxx b/svgio/source/svgreader/svgusenode.cxx index 9e3630a2bebb..a5a2d5e8ad57 100644 --- a/svgio/source/svgreader/svgusenode.cxx +++ b/svgio/source/svgreader/svgusenode.cxx @@ -28,11 +28,6 @@ namespace svgio::svgreader SvgNode* pParent) : SvgNode(SVGToken::Use, rDocument, pParent), maSvgStyleAttributes(*this), - maX(), - maY(), - maWidth(), - maHeight(), - maXLink(), mbDecomposingSvgNode(false) { }