strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

do not leak memory

Browse source
This commit is contained in:
David Tardon 2011-05-12 08:05:42 +02:00
parent 6be5742c15
commit b7f5f3fea1
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
fpicker/source/office/fpsmartcontent.cxx
View file

@ -76,8 +76,18 @@ namespace svt
//--------------------------------------------------------------------
SmartContent::~SmartContent()
{
//Do not delete the content. Because the content will be used by the cache.
//DELETEZ( m_pContent );
/* This destructor originally contained the following blurb: "Do
not delete the content. Because the content will be used by
the cache." This is just plain silly, because it relies on
the provider caching created contents (which is done by
ucbhelper::ContentProviderImplHelper, but we do not actually
expect all providers to use that, right?) Otherwise we are
just leaking memory.
TODO: If there is real need for caching the content, it must
be done here.
*/
delete m_pContent;
}
//--------------------------------------------------------------------