strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed documentation references to the custom shape generate script

Browse source 
* Fixed references to the custom shape generation script in the
  oox/README.md to use generate.sh instead of README.md
* Added README.md to oox/source/drawingml/customshapes folder
* Moved documentation parts from the script to the README.md

The README script was renamed to generate.sh before in the commit
59577dbb84

Change-Id: Id167b32c7a101806c33126ea1642a0194d693231
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119376
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
This commit is contained in:
Hossein 2021-07-31 17:17:42 +02:00 committed by Ilmari Lauhakangas
parent ecfc229b09
commit ba89f16143
3 changed files with 34 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
oox/README.md
View file

@ -19,10 +19,11 @@ preset type and the adjustment values, the reset can
be taken from the shape definition.
example of drawingml preset:
```xml
<a:prstGeom prst="star5">
<a:avLst/>
</a:prstGeom>
```
example of drawingml custom shape (equal to star5 preset):
```xml
@ -134,11 +135,11 @@ needed.
In order to convert preset shapes to LO's enhanced custom shape,
we need to load shape definition of preset shapes. The procedure
to convert the definition from OOXML spec for LO is documented
(also a script) in `oox/source/drawingml/customshapes/README.md`.
The scripts in `oox/source/drawingml/customshapes/` also generate pptx
in `oox/source/drawingml/customshapes/README.md`.
The `oox/source/drawingml/customshapes/generate.sh` script generate pptx
files for single presets and also for all presets
`cshape-all.pptx`. The cshape-all.pptx file is then loaded into Impress
build with debug enabled in oox and the command line output contains
`cshape-all.pptx`. The `cshape-all.pptx` file is then loaded into Impress
build with debug enabled in `oox` and the command line output contains
information. The generated definition is `oox-drawingml-cs-presets`.
Check `CustomShapeProperties::initializePresetDataMap()` to see how
@ -152,9 +153,14 @@ the cshape-all.pptx can be used to test the round trips. there's small
problem with these pptx as they cannot be imported into powerpoint,
but that can be fixed quickly. when fixed, we can use it to
test powerpoint odp export and see how complete it is regarding
custom shapes. OpenXML SDK tools might help when fixing
`cshape-all.pptx`
<http://www.microsoft.com/en-us/download/details.aspx?id=30425>
custom shapes. OpenXML SDK might help when fixing `cshape-all.pptx`
<https://github.com/OfficeDev/Open-XML-SDK>
Also, "OOXML Viewer VSCode Extension" is a useful tool for debugging
OOXML documents.
<https://github.com/yuenm18/ooxml-viewer-vscode>
## Export
Here is how LO's enhanced custom shapes are exported:

19
oox/source/drawingml/customshapes/README.md Normal file
View file

@ -0,0 +1,19 @@
# Generating Custom Shape Presets
The Perl code (`generatePresetsData.pl` and `generatePresetsPPTXs.pl`) is used
to generate the custom shape presets.
The `generate.sh` script which invokes the above Perl files, should be invoked
from the libreoffice core top-level source folder:
```
oox/source/drawingml/customshapes/generate.sh
```
The logs will be created in the file:
```
oox/source/drawingml/customshapes/custom-shapes.log
```
The output would be placed in this folder:
```
oox/source/drawingml/customshapes/pptx/
```

12
oox/source/drawingml/customshapes/generate.sh
View file

@ -1,21 +1,11 @@
#!/bin/bash
# The Perl code here is used to generate the custom shape presets
# source code.
# This file is both a README and also, if run as a shell script, does what
# it describes.
# It should be invoked from the libreoffice core top-level source folder:
# ./oox/source/drawingml/customshapes/generate.sh
# The logs will be created in the file:
# ./oox/source/drawingml/customshapes/custom-shapes.log
# This script is used to generate the custom shape presets
# We want to exit on errors...
set -o errexit
# To re-generate the code, you need to be on Linux (I think).
# It is not necessary to do a make test-install, just run from instdir.
# oox needs to be build with dbglevel=2 so that DEBUG is defined.
make oox.clean && make oox dbglevel=2