strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#163486: PVS: Identical branches

Browse source 
V1037 Two or more case-branches perform the same actions. Check lines: 921, 924
V1037 Two or more case-branches perform the same actions. Check lines: 1003, 1160

Change-Id: I42e78f2960b97a67625bfdb524b7f615833332ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175230
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
This commit is contained in:
Bogdan Buzea 2024-10-20 08:02:42 +02:00 committed by David Gilbert
parent 645b37039f
commit bb70ecfdfd
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
sc/source/filter/excel/excform.cxx
View file

@ -918,8 +918,6 @@ ConvErr ExcelToSc::Convert( ScRangeListTabs& rRangeList, XclImpStream& aIn, std:
{ // SDK4 SDK5
case 0x01: // Array Formula [325 ]
// Array Formula or Shared Formula [ 277]
nIgnore = (meBiff == EXC_BIFF2) ? 3 : 4;
break;
case 0x02: // Data Table [325 277]
nIgnore = (meBiff == EXC_BIFF2) ? 3 : 4;
break;
@ -1000,6 +998,9 @@ ConvErr ExcelToSc::Convert( ScRangeListTabs& rRangeList, XclImpStream& aIn, std:
nIgnore = 1;
break;
case 0x1E: // Integer [315 266]
case 0x58:
case 0x78:
case 0x38: // Command-Equivalent Function [333 ]
nIgnore = 2;
break;
case 0x1F: // Number [315 266]
@ -1154,11 +1155,6 @@ ConvErr ExcelToSc::Convert( ScRangeListTabs& rRangeList, XclImpStream& aIn, std:
case 0x2F: // Incomplete Reference Subexpression... [332 282]
nIgnore = (meBiff == EXC_BIFF2) ? 1 : 2;
break;
case 0x58:
case 0x78:
case 0x38: // Command-Equivalent Function [333 ]
nIgnore = 2;
break;
case 0x59:
case 0x79:
case 0x39: // Name or External Name [ 275]