cid#1546021 Using invalid iterator

and :

cid#1545983 Using invalid iterator
cid#1545969 Using invalid iterator
cid#1545949 Using invalid iterator
cid#1545929 Using invalid iterator
cid#1545911 Using invalid iterator
cid#1545910 Using invalid iterator
cid#1545886 Using invalid iterator
cid#1545870 Using invalid iterator
cid#1545813 Using invalid iterator

Change-Id: I2ad10c2a9affd348050a4abe0917a90927a52547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160317
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

cui/source/dialogs/SpellDialog.cxx

@@ -1247,7 +1247,10 @@ namespace
     void ExtractErrorDescription(const EECharAttrib& rEECharAttrib, SpellErrorDescription& rSpellErrorDescription)
     {
         css::uno::Sequence<css::uno::Any> aSequence;
-        static_cast<const SfxGrabBagItem*>(rEECharAttrib.pAttr)->GetGrabBag().find("SpellErrorDescription")->second >>= aSequence;
+        const auto pGrabBag = static_cast<const SfxGrabBagItem*>(rEECharAttrib.pAttr)->GetGrabBag();
+        const auto iter = pGrabBag.find("SpellErrorDescription");
+        assert(iter != pGrabBag.end());
+        iter->second >>= aSequence;
         rSpellErrorDescription.fromSequence(aSequence);
     }
 }

editeng/source/misc/svxacorr.cxx

@@ -1750,7 +1750,11 @@ bool SvxAutoCorrect::AddWordStartException( const OUString& rNew,
         if (iter != m_aLangTable.end())
             pLists = &iter->second;
         else if(CreateLanguageFile(aLangTagUndetermined))
-            pLists = &m_aLangTable.find(aLangTagUndetermined)->second;
+        {
+            iter = m_aLangTable.find(aLangTagUndetermined);
+            assert(iter != m_aLangTable.end());
+            pLists = &iter->second;
+        }
     }
     OSL_ENSURE(pLists, "No auto correction file!");
     return pLists && pLists->AddToWordStartExceptList(rNew);
@@ -2030,7 +2034,9 @@ const SvxAutocorrWord* SvxAutoCorrect::SearchWordsInList(
             CreateLanguageFile(aLanguageTag, false))
     {
         //the language is available - so bring it on
-        SvxAutoCorrectLanguageLists& rList = m_aLangTable.find(aLanguageTag)->second;
+        const auto iter = m_aLangTable.find(aLanguageTag);
+        assert(iter != m_aLangTable.end());
+        SvxAutoCorrectLanguageLists& rList = iter->second;
         pRet = lcl_SearchWordsInList( &rList, rTxt, rStt, nEndPos );
         if( pRet )
         {

oox/source/drawingml/texteffectscontext.cxx

@@ -91,8 +91,9 @@ OUString const & lclGetGrabBagName(sal_uInt32 aId)
         { OOX_TOKEN(w14, stylisticSets), "CharStylisticSetsTextEffect" },
         { OOX_TOKEN(w14, cntxtAlts)    , "CharCntxtAltsTextEffect" },
     };
-
-    return aGrabBagNameMap.find(aId)->second;
+    const auto iter = aGrabBagNameMap.find(aId);
+    assert(iter != aGrabBagNameMap.end());
+    return iter->second;
 }
 
 }

reportdesign/source/filter/xml/xmlExport.cxx

@@ -755,6 +755,7 @@ void ORptExport::exportContainer(const Reference< XSection>& _xSection)
     TGrid::const_iterator aRowEnd = aFind->second.end();
 
     TGridStyleMap::const_iterator aRowFind = m_aRowStyleNames.find(_xSection);
+    assert(aRowFind != m_aRowStyleNames.end());
     auto aHeightIter = aRowFind->second.cbegin();
     OSL_ENSURE(aRowFind->second.size() == aFind->second.size(),"Different count for rows");
 

sc/source/core/data/SolverSettings.cxx

@@ -368,7 +368,9 @@ void SolverSettings::WriteParamValue(SolverParameter eParam, OUString sValue, bo
     if (bQuoted)
         ScGlobal::AddQuotes(sValue, '"');
 
-    OUString sRange = m_mNamedRanges.find(eParam)->second;
+    const auto iter = m_mNamedRanges.find(eParam);
+    assert(iter != m_mNamedRanges.end());
+    OUString sRange = iter->second;
     ScRangeData* pNewEntry = new ScRangeData(m_rDoc, sRange, sValue);
     m_pRangeName->insert(pNewEntry);
 }

sc/source/ui/namedlg/namedefdlg.cxx

@@ -186,11 +186,15 @@ void ScNameDefDlg::AddPushed()
     ScRangeName* pRangeName = nullptr;
     if(aScope == maGlobalNameStr)
     {
-        pRangeName = maRangeMap.find(STR_GLOBAL_RANGE_NAME)->second;
+        const auto iter = maRangeMap.find(STR_GLOBAL_RANGE_NAME);
+        assert(iter != maRangeMap.end());
+        pRangeName = iter->second;
     }
     else
     {
-        pRangeName = maRangeMap.find(aScope)->second;
+        const auto iter = maRangeMap.find(aScope);
+        assert(iter != maRangeMap.end());
+        pRangeName = iter->second;
     }
     if (!pRangeName)
         return;

soltools/mkdepend/collectdircontent.cxx

@@ -68,6 +68,7 @@ bool IncludesCollection::exists(std::string filePath) {
         add_to_collection(dirPath);
         mapIter = allIncludes.find(dirPath);
     }
+    assert(mapIter != allIncludes.end());
     DirContent dirContent = (*mapIter).second;
     DirContent::iterator dirIter = dirContent.find(fileName);
     return dirIter != dirContent.end();

sw/source/core/layout/paintfrm.cxx

@@ -2775,7 +2775,7 @@ void SwTabFramePainter::FindStylesForLine( Point& rStartPoint,
     if ( bHori )
     {
         aMapIter = maVertLines.find( rEndPoint.X() );
-        OSL_ENSURE( aMapIter != maVertLines.end(), "FindStylesForLine: Error" );
+        assert(aMapIter != maVertLines.end() && "FindStylesForLine: Error");
         const SwLineEntrySet& rVertSet2 = (*aMapIter).second;
 
         for ( const SwLineEntry& rEntry : rVertSet2 )

vcl/source/cnttype/mcnttype.cxx

@@ -63,7 +63,9 @@ OUString SAL_CALL CMimeContentType::getParameterValue( const OUString& aName )
     if ( !hasParameter( lower ) )
         throw css::container::NoSuchElementException( );
 
-    return m_ParameterMap.find( lower )->second;
+    const auto iter = m_ParameterMap.find(lower);
+    assert(iter != m_ParameterMap.end());
+    return iter->second;
 }
 
 void CMimeContentType::init( const OUString& aCntType )