strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move loplugin:fpcomparison to store/

Browse source 
...after bc4e8de8ee "Silence new
loplugin:fpcomparison for now":

> Nov 30 08:33:16 <sberg> noelgrandin, thoughts on whether fpcomparison is actually worth it, seeing the loooooooong blacklist there?
> Nov 30 08:34:11 <noelgrandin> sberg, that's wasn't my idea, can't remember who came up with it. vmiklos was that you?
> Nov 30 08:34:36 <noelgrandin> sberg, the original commit message was "Find code that compares floating point values with == or !=
> Nov 30 08:34:36 <noelgrandin>     It should rather use rtl::math::approxEqual"
> Nov 30 08:34:45 <noelgrandin> so in theory the replacement should be fairly manual
> Nov 30 08:34:48 <vmiklos> i don't think so :)
> Nov 30 08:35:15 <noelgrandin> might have been moggi, but he's not around so.... just disable it
> Nov 30 08:36:19 <sberg> noelgrandin, yeah, in theory; in practice, I guess there's also cases where x==1.0 is what you want exactly (given x tends not to be a computed value after all, but some literal that's being passed around)
> Nov 30 08:36:33 <sberg> noelgrandin, yeah, I'll disable it then

Change-Id: I35f5328efa0ec02d9be837c12efab2b03a3dae52
Reviewed-on: https://gerrit.libreoffice.org/45550
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann 2017-11-30 08:43:10 +01:00
parent 226c4c010e
commit bf59f89d88
2 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

0
compilerplugins/clang/fpcomparison.cxx → compilerplugins/clang/store/fpcomparison.cxx
View file

2
solenv/clang-format/blacklist
View file

@ -1741,7 +1741,6 @@ compilerplugins/clang/faileddyncast.cxx
compilerplugins/clang/finalclasses.cxx
compilerplugins/clang/finalprotected.cxx
compilerplugins/clang/flatten.cxx
compilerplugins/clang/fpcomparison.cxx
compilerplugins/clang/fragiledestructor.cxx
compilerplugins/clang/functionaddress.hxx
compilerplugins/clang/getimplementationname.cxx
@ -1800,6 +1799,7 @@ compilerplugins/clang/store/defaultparams.cxx
compilerplugins/clang/store/deletedspecial.cxx
compilerplugins/clang/store/derivedclass.cxx
compilerplugins/clang/store/findoncontainer.cxx
compilerplugins/clang/store/fpcomparison.cxx
compilerplugins/clang/store/lclstaticfix.cxx
compilerplugins/clang/store/lclstaticfix.hxx
compilerplugins/clang/store/manualrefcount.cxx