Related tdf#160226 - Math inline editing Off by default

Introduced per
I63672c054d1ead269863079e7f9c118a44b3ba19
Ib2ca942c537e466f6ff100be7f95adaead99f1d5

Change-Id: Iff2bd250c004e57800c84287483965ec3ae49187
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172241
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
This commit is contained in:
Heiko Tietze 2024-08-22 10:57:05 +02:00 committed by Heiko Tietze
parent 1fefb68a91
commit cd2eba5c69
4 changed files with 9 additions and 9 deletions

View file

@ -301,7 +301,7 @@
<info>
<desc>Enables inline (visual) editing mode.</desc>
</info>
<value>true</value>
<value>false</value>
</prop>
<prop oor:name="IgnoreSpacesRight" oor:type="xs:boolean" oor:nillable="false">
<info>

View file

@ -72,8 +72,8 @@ static Sequence<OUString> lcl_GetOtherPropertyNames()
return Sequence<OUString>{ u"LoadSave/IsSaveOnlyUsedSymbols"_ustr,
u"Misc/AutoCloseBrackets"_ustr,
u"Misc/DefaultSmSyntaxVersion"_ustr,
u"Misc/IgnoreSpacesRight"_ustr,
u"Misc/InlineEditEnable"_ustr,
u"Misc/IgnoreSpacesRight"_ustr,
u"Misc/SmEditWindowZoomFactor"_ustr,
u"Print/FormulaText"_ustr,
u"Print/Frame"_ustr,
@ -168,7 +168,7 @@ SmCfgOther::SmCfgOther()
, bPrintFrame(true)
, bIsSaveOnlyUsedSymbols(true)
, bIsAutoCloseBrackets(true)
, bInlineEditEnable(true)
, bInlineEditEnable(false)
, bIgnoreSpacesRight(true)
, bToolboxVisible(true)
, bAutoRedraw(true)
@ -1424,8 +1424,8 @@ void SmMathConfig::ItemSetToConfig(const SfxItemSet &rSet)
{ bVal = pRedrawItem->GetValue();
SetAutoRedraw( bVal );
}
if (const SfxBoolItem* pSpacesItem = rSet.GetItemIfSet(SID_INLINE_EDIT_ENABLE))
{ bVal = pSpacesItem->GetValue();
if (const SfxBoolItem* pInlineEditItem = rSet.GetItemIfSet(SID_INLINE_EDIT_ENABLE))
{ bVal = pInlineEditItem->GetValue();
SetInlineEditEnable( bVal );
}
if (const SfxBoolItem* pSpacesItem = rSet.GetItemIfSet(SID_NO_RIGHT_SPACES))

View file

@ -57,11 +57,11 @@ class SimpleMathTest(UITestCase):
xElement.executeAction("DOUBLECLICK", tuple())
xEditView = xMathDoc.getChild("editview")
xEditView.executeAction("TYPE", mkPropertyValues({"KEYCODE":"F4"}))
type_text(xEditView, "1")
xEditView.executeAction("TYPE", mkPropertyValues({"KEYCODE":"F4"}))
type_text(xEditView, "2")
self.assertEqual("{ 1 <> 2 }", get_state_as_dict(xEditView)["Text"])
self.assertEqual("1 <> 2 ", get_state_as_dict(xEditView)["Text"])
# vim: set shiftwidth=4 softtabstop=4 expandtab:

View file

@ -26,7 +26,7 @@ class Tdf147755(UITestCase):
xEditView = xMathDoc.getChild("editview")
# Without the fix in place, this test would have failed with
# AssertionError: '%arRay' != ''
self.assertEqual("%arRay", get_state_as_dict(xEditView)["Text"])
# AssertionError: '%arRay ' != ''
self.assertEqual("%arRay ", get_state_as_dict(xEditView)["Text"])
# vim: set shiftwidth=4 softtabstop=4 expandtab: