strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mnOriginalTextPos is only written to, never read

Browse source 
Change-Id: Iaca97dc3a0534847cbe96816a0827549a8f8d371
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177685
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara 2024-12-02 12:01:47 +00:00
parent 9a730cd079
commit d4d74fc3b4
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
filter/source/msfilter/svdfppt.cxx
View file

@ -4408,8 +4408,7 @@ PPTStyleSheet::~PPTStyleSheet()
}
PPTParaPropSet::PPTParaPropSet()
: mnOriginalTextPos(0)
, mxParaSet( new ImplPPTParaPropSet )
: mxParaSet( new ImplPPTParaPropSet )
{
mxParaSet->mnHasAnm = 1;
}
@ -4417,7 +4416,6 @@ PPTParaPropSet::PPTParaPropSet()
PPTParaPropSet::PPTParaPropSet( PPTParaPropSet const & rParaPropSet )
{
mxParaSet = rParaPropSet.mxParaSet;
mnOriginalTextPos = rParaPropSet.mnOriginalTextPos;
}
PPTParaPropSet::~PPTParaPropSet()
@ -4429,7 +4427,6 @@ PPTParaPropSet& PPTParaPropSet::operator=( const PPTParaPropSet& rParaPropSet )
if ( this != &rParaPropSet )
{
mxParaSet = rParaPropSet.mxParaSet;
mnOriginalTextPos = rParaPropSet.mnOriginalTextPos;
}
return *this;
}
@ -5069,7 +5066,6 @@ void PPTStyleTextPropReader::ReadParaProps(SvStream& rIn, const DffRecordHeader&
OSL_FAIL( "SJ:PPTStyleTextPropReader::could not get this PPT_PST_StyleTextPropAtom by reading the paragraph attributes" );
}
PPTParaPropSet* pPara = new PPTParaPropSet( aParaPropSet );
pPara->mnOriginalTextPos = nCharReadCnt;
aParaPropList.emplace_back( pPara );
if ( nCharCount )
{
@ -5079,7 +5075,6 @@ void PPTStyleTextPropReader::ReadParaProps(SvStream& rIn, const DffRecordHeader&
if ( pDat[ nCount ] == 0xd )
{
pPara = new PPTParaPropSet( aParaPropSet );
pPara->mnOriginalTextPos = nCharReadCnt + nCount + 1;
aParaPropList.emplace_back( pPara );
}
}

1
include/filter/msfilter/svdfppt.hxx
View file

@ -903,7 +903,6 @@ struct ImplPPTParaPropSet final : public salhelper::SimpleReferenceObject
struct PPTParaPropSet
{
sal_uInt32 mnOriginalTextPos;
rtl::Reference<ImplPPTParaPropSet> mxParaSet;
PPTParaPropSet();