From d676bd620afe47a0b7a445d864bfcdd2e6e3473f Mon Sep 17 00:00:00 2001 From: Douglas Mencken Date: Mon, 7 Mar 2016 06:23:31 -0500 Subject: [PATCH] apple_remote: autorelease --> release in dealloc (destructor) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit using autorelease here leads to “just leaking” because there's no autorelease pool for thread besides, make sure that released fields do not contain used•to•be•a•valid•pointer value Change-Id: Id6cb37643230f64dbe9f6128f52236f04d0c88e4 Reviewed-on: https://gerrit.libreoffice.org/22981 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- apple_remote/source/RemoteMainController.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apple_remote/source/RemoteMainController.m b/apple_remote/source/RemoteMainController.m index 1972c5fc523f..79af22fd9f3e 100644 --- a/apple_remote/source/RemoteMainController.m +++ b/apple_remote/source/RemoteMainController.m @@ -155,9 +155,9 @@ } - (void) dealloc { - [remoteControl autorelease]; - [remoteControlBehavior autorelease]; - [super dealloc]; + [ remoteControl release ]; remoteControl = nil; + [ remoteControlBehavior release ]; remoteControlBehavior = nil; + [super dealloc]; } // for bindings access