strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better report unknown constant names by including their values

Browse source 
Change-Id: Id93dedf39ad0e2d1968e80878dd1a1bb07d94b61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137336
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This commit is contained in:
Colomban Wendling 2022-07-21 17:43:34 +02:00 committed by Michael Weghorn
parent 98180644fe
commit d6ce547a1a
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
test/source/a11y/AccessibilityTools.cxx
View file

@ -112,6 +112,11 @@ bool AccessibilityTools::equals(const uno::Reference<accessibility::XAccessibleC
return equals(xctx1->getAccessibleParent(), xctx2->getAccessibleParent());
}
static OUString unknownName(const sal_Int64 value)
{
return "unknown (" + OUString::number(value) + ")";
}
OUString AccessibilityTools::getRoleName(const sal_Int16 role)
{
switch (role)
@ -291,7 +296,7 @@ OUString AccessibilityTools::getRoleName(const sal_Int16 role)
case accessibility::AccessibleRole::WINDOW:
return "WINDOW";
};
return "unknown";
return unknownName(role);
}
OUString AccessibilityTools::debugAccessibleStateSet(const sal_Int64 nCombinedState)
@ -411,6 +416,9 @@ OUString AccessibilityTools::debugAccessibleStateSet(const sal_Int64 nCombinedSt
case accessibility::AccessibleStateType::VISIBLE:
name = "VISIBLE";
break;
default:
name = unknownName(state);
break;
}
if (combinedName.getLength())
combinedName += " | ";
@ -509,7 +517,7 @@ OUString AccessibilityTools::getEventIdName(const sal_Int16 event_id)
case accessibility::AccessibleEventId::VISIBLE_DATA_CHANGED:
return "VISIBLE_DATA_CHANGED";
}
return "unknown";
return unknownName(event_id);
}
OUString AccessibilityTools::getRelationTypeName(const sal_Int16 rel_type)
@ -539,7 +547,7 @@ OUString AccessibilityTools::getRelationTypeName(const sal_Int16 rel_type)
case accessibility::AccessibleRelationType::SUB_WINDOW_OF:
return "SUB_WINDOW_OF";
}
return "unknown";
return unknownName(rel_type);
}
OUString AccessibilityTools::debugName(accessibility::XAccessibleContext* ctx)