From da3aa26efddebbbe2af2a1895f89198f66b5c27c Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 11 May 2022 13:39:48 +0200 Subject: [PATCH] Library_syssh must link against expat when using StaticLibrary_shell_xmlparser ...which in turn uses expat, so this caused a Linux build of mine to fail with > [LNK] Library/libsysshlo.so > ld.lld: error: undefined symbol: XML_ParserCreate > >>> referenced by xml_parser.cxx:74 (shell/source/all/xml_parser.cxx:74) > >>> xml_parser.o:(xml_parser::xml_parser()) in archive workdir/LinkTarget/StaticLibrary/libshell_xmlparser.a etc. (No idea why that only started to hit me now, seemingly out of the blue, but it looks plausible that we need that fix.) Change-Id: I1d0efabf8cc809bd82ce30ec67d16ce1eb547de0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134167 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- shell/Library_syssh.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/shell/Library_syssh.mk b/shell/Library_syssh.mk index d059d6c5b671..72ff73842dc3 100644 --- a/shell/Library_syssh.mk +++ b/shell/Library_syssh.mk @@ -37,6 +37,10 @@ $(eval $(call gb_Library_use_static_libraries,syssh,\ shell_xmlparser \ )) +$(eval $(call gb_Library_use_externals,syssh, \ + expat \ +)) + $(eval $(call gb_Library_set_componentfile,syssh,shell/source/unix/exec/syssh,services)) $(eval $(call gb_Library_add_exception_objects,syssh,\