From da4259bd7fef35185418cad7a695268add6341a2 Mon Sep 17 00:00:00 2001 From: Christian Lohmaier Date: Tue, 4 Jun 2024 14:32:08 +0200 Subject: [PATCH] windows packaging: reduce parallelism further to three Some jenkins daily builders still run into issues from time to time, and even at a reduced parallelism of three it doesn't affect overall buildtime when building with just two or three languages and also not when building with all languages. There might be a number of languages where this has a penalty, but probably not a significant one. Change-Id: I778b5fe21fe8f9bb1fcca1da3c4c0eeeda6c29d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168403 Tested-by: Jenkins Reviewed-by: Christian Lohmaier --- solenv/bin/job-limiter.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/solenv/bin/job-limiter.cpp b/solenv/bin/job-limiter.cpp index 9111ead35127..ee1bd8e6edab 100644 --- a/solenv/bin/job-limiter.cpp +++ b/solenv/bin/job-limiter.cpp @@ -79,12 +79,12 @@ int wmain(int argc, wchar_t* argv[]) // system. So when it creates a new one to use, and then releases one it would hit the max // limit otherwise. This only happens when nothing else is waiting for a slot anymore, // i.e. when there are already fewer jobs than imposed by the limiter. - // A limit of four (main installer and 3 controlled by this limiter) was chosen because that + // A limit of three (main installer + 2 controlled by this limiter) was chosen because that // won't affect overall build time (creating the main installer with multiple languages // takes much longer than all the helppackages and the single sdk package combined, even // when those are limited to three jobs), and seems to be low enough to avoid the random // cscript/WiLangId.vbs failures. - semaphore_handle = CreateSemaphoreW(NULL, 3, 4, semaphorename); + semaphore_handle = CreateSemaphoreW(NULL, 2, 3, semaphorename); // keep this process alive for other jobs to grab the semaphore, otherwise it is gone too // quickly and everything creates their own semaphore that immediately has enough slots, // completely bypassing the point of having a limiter...