strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#163945 Lower priority of Skia flush timer

Browse source 
Commit f4c2c7c79c fixed tdf#157312
by lowering the timer priority to TaskPriority::POST_PAINT. But
it caused tdf#163734 so it was reverted to TaskPriority::HIGHEST
in commit 5a38e4f979.

While reverting to TaskPriority::HIGHEST did not cause tdf#157312
to reoccur, it did cause tdf#163945 so set the timer priority to
TaskPriority::HIGH_IDLE. This priority appears to be low enough to
fix tdf#16394 without causing tdf#163734 to reoccur.

Change-Id: Ifc2833a886d52117d46c02a80c88c674ad080824
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176698
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
This commit is contained in:
Patrick Luby 2024-11-17 19:35:56 -05:00 committed by Patrick Luby
parent 3c371b7bde
commit dbe8a75f79
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
vcl/skia/gdiimpl.cxx
View file

@ -269,7 +269,16 @@ public:
{
mpGraphics->performFlush();
Stop();
SetPriority(TaskPriority::HIGHEST);
// tdf#163945 Lower priority of Skia flush timer
// Commit f4c2c7c79cfe4464ac596afda37b8904d06969db fixed tdf#157312
// by lowering the timer priority to TaskPriority::POST_PAINT. But
// it caused tdf#163734 so it was reverted to TaskPriority::HIGHEST
// in commit 5a38e4f9798c5ff247aa57581adf2671485627fd.
// While reverting to TaskPriority::HIGHEST did not cause tdf#157312
// to reoccur, it did cause tdf#163945 so set the timer priority to
// TaskPriority::HIGH_IDLE. This priority appears to be low enough to
// fix tdf#16394 without causing tdf#163734 to reoccur.
SetPriority(TaskPriority::HIGH_IDLE);
}
};