loplugin:finalclasses in h*,i*,j*

Change-Id: I3b5f319a88dbe6a9c2ffbfdf991345beda9a2fcd
Reviewed-on: https://gerrit.libreoffice.org/44154
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

hwpfilter/source/hfont.h

@@ -32,9 +32,8 @@ class HWPFile;
  * The HWPFont class has the font list for the document when it's saved.
  * @short Font information
  */
-class DLLEXPORT HWPFont
+class DLLEXPORT HWPFont final
 {
-    protected:
 /**
  * System font count for each language
  * NLanguage is 7 in common case.

i18npool/inc/collator_unicode.hxx

@@ -32,7 +32,7 @@
 
 namespace i18npool {
 
-class Collator_Unicode : public cppu::WeakImplHelper < css::i18n::XCollator, css::lang::XServiceInfo >
+class Collator_Unicode final : public cppu::WeakImplHelper < css::i18n::XCollator, css::lang::XServiceInfo >
 {
 public:
     // Constructors
@@ -61,9 +61,8 @@ public:
     virtual sal_Bool SAL_CALL supportsService(const OUString& ServiceName) override;
     virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() override;
 
-protected:
-    const sal_Char *implementationName;
 private:
+    const sal_Char *implementationName;
     RuleBasedCollator *uca_base, *collator;
 #ifndef DISABLE_DYNLOADING
     oslModule hModule;

i18npool/inc/indexentrysupplier.hxx

@@ -29,7 +29,7 @@ namespace i18npool {
 
 //  class IndexEntrySupplier
 
-class IndexEntrySupplier : public cppu::WeakImplHelper
+class IndexEntrySupplier final : public cppu::WeakImplHelper
 <
     css::i18n::XExtendedIndexEntrySupplier,
     css::lang::XServiceInfo
@@ -82,7 +82,6 @@ private:
     css::uno::Reference < css::i18n::XExtendedIndexEntrySupplier > const & SAL_CALL getLocaleSpecificIndexEntrySupplier(
         const css::lang::Locale& rLocale, const OUString& rSortAlgorithm);
 
-protected:
     css::lang::Locale aLocale;
     OUString          aSortAlgorithm;
 };

i18npool/inc/transliteration_caseignore.hxx

@@ -23,7 +23,7 @@
 
 namespace i18npool {
 
-class Transliteration_caseignore: public Transliteration_body
+class Transliteration_caseignore final : public Transliteration_body
 {
 public:
     Transliteration_caseignore();
@@ -48,13 +48,13 @@ public:
         const OUString& s1,
         const OUString& s2) override;
 
-protected:
-    TransliterationFlags moduleLoaded;
 private:
     /// @throws css::uno::RuntimeException
     sal_Int32 SAL_CALL compare(
         const OUString& str1, sal_Int32 pos1, sal_Int32 nCount1, sal_Int32& nMatch1,
         const OUString& str2, sal_Int32 pos2, sal_Int32 nCount2, sal_Int32& nMatch2);
+
+    TransliterationFlags moduleLoaded;
 };
 
 }

include/i18nutil/oneToOneMapping.hxx

@@ -60,7 +60,7 @@ protected:
     size_t                  mnSize;
 };
 
-class I18NUTIL_DLLPUBLIC oneToOneMappingWithFlag : public oneToOneMapping
+class I18NUTIL_DLLPUBLIC oneToOneMappingWithFlag final : public oneToOneMapping
 {
 private:
     oneToOneMappingWithFlag(const oneToOneMappingWithFlag&) = delete;
@@ -77,7 +77,7 @@ public:
 
     // index search
     virtual sal_Unicode find( const sal_Unicode nKey ) const override;
-protected:
+private:
     UnicodePairWithFlag  *mpTableWF;
     UnicodePairFlag       mnFlag;
     UnicodePairWithFlag **mpIndex[256];

jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx

@@ -49,10 +49,8 @@ namespace jfw_plugin {
    To test if the version is ok, that is this object can be compared to others,
    use the bool conversion operator.
  */
-class SunVersion
+class SunVersion final
 {
-protected:
-
     enum PreRelease
     {
         Rel_NONE,
@@ -103,7 +101,7 @@ public:
      */
     OUString usVersion;
 
-protected:
+private:
     bool init(const char * szVer);
 
     bool m_bValid;

l10ntools/inc/xmlparse.hxx

@@ -145,7 +145,7 @@ typedef std::unordered_map<OString, sal_Bool> TagMap;
 
 /** Holds information of a XML file, is root node of tree
  */
-class XMLFile : public XMLParentNode
+class XMLFile final : public XMLParentNode
 {
 public:
     XMLFile(
@@ -173,7 +173,7 @@ public:
     void SetName( const OString &rFilename ) { m_sFileName = rFilename; }
     const std::vector<OString>& getOrder() const { return m_vOrder; }
 
-protected:
+private:
 
     void InsertL10NElement( XMLElement* pElement);
 

lingucomponent/source/languageguessing/guess.hxx

@@ -33,7 +33,7 @@ using namespace std;
 /**
 @author Jocelyn Merand
  */
-class Guess{
+class Guess final {
     public:
 
         /**
@@ -51,7 +51,7 @@ class Guess{
         const string& GetLanguage() { return language_str;}
         const string& GetCountry() { return country_str;}
 
-    protected:
+    private:
         string language_str;
         string country_str;
         string encoding_str;

lingucomponent/source/languageguessing/simpleguesser.hxx

@@ -32,7 +32,7 @@ using namespace std;
 /**
 @author Jocelyn Merand
 */
-class SimpleGuesser{
+class SimpleGuesser final {
 public:
     /**inits the object with conf file "./conf.txt"*/
     SimpleGuesser();
@@ -98,7 +98,7 @@ public:
     */
     void SetDBPath(const char* thePathOfConfFile, const char* prefix);
 
-protected:
+private:
 
     //Where typical fingerprints (n-gram tables) are stored
     void* h;