strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#147868 Disable add sheet when structure is protected

Browse source 
Using "Tools > Protect Spreadsheet Structure...", it is possible to
protect the structure of a spreadsheet document. Without this patch in
place, the [+] (add new sheet) button is clickable but it does not work.
This is confusing for the user, so it was decided that the button should
be disabled when the structure is protected.

This patch disables the [+] button just after the structure is protected
using the above toggle menu option. The menu option becomes checked, and
the [+] button gets disabled immediately. After choosing the same toggle
menu option again, the check mark goes away, and the [+] button becomes
enabled immediately.

In this patch, GetDocument().IsDocEditable() is used to check if the
document structure is protected. The argument for this choice is that
the same function is used when renaming a sheet with
ScDocFunc::RenameTable().

Change-Id: If812d94841d3efd98d7ef898cc1f4b2f1387130b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137365
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
This commit is contained in:
Hossein 2022-07-22 16:44:29 +02:00
parent 78071a36de
commit e2b7f59c74
3 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
include/svtools/tabbar.hxx
View file

@ -496,6 +496,7 @@ public:
void SetSelectHdl( const Link<TabBar*,void>& rLink ) { maSelectHdl = rLink; }
void SetSplitHdl( const Link<TabBar*,void>& rLink ) { maSplitHdl = rLink; }
void SetScrollAreaContextHdl( const Link<const CommandEvent&,void>& rLink ) { maScrollAreaContextHdl = rLink; }
void SetAddButtonEnabled(bool bAddButtonEnabled);
// accessibility
virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override;

1
sc/source/ui/view/tabview5.cxx
View file

@ -383,6 +383,7 @@ void ScTabView::UpdateLayerLocks()
pDrawView->SetLayerLocked( pLayer->GetName(), bProt || bShared );
pDrawView->SetLayerVisible( pLayer->GetName(), false);
}
pTabControl->SetAddButtonEnabled(aViewData.GetDocument().IsDocEditable());
}
void ScTabView::DrawDeselectAll()

5
svtools/source/control/tabbar.cxx
View file

@ -2494,6 +2494,11 @@ tools::Rectangle TabBar::GetPageArea() const
Size(mnLastOffX - mnOffX + 1, GetSizePixel().Height() - mnOffY));
}
void TabBar::SetAddButtonEnabled(bool bAddButtonEnabled)
{
mpImpl->mxButtonBox->m_xAddButton->set_sensitive(bAddButtonEnabled);
}
css::uno::Reference<css::accessibility::XAccessible> TabBar::CreateAccessible()
{
return mpImpl->maAccessibleFactory.getFactory().createAccessibleTabBar(*this);