From e3adb51c54089a961cea1a33c5f54f6e552a4590 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 3 Jul 2020 16:28:42 +0200 Subject: [PATCH] reduce number of framework libraries Change-Id: I18bfdba3d26593f796d8b0bda87720e31066d5e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97968 Tested-by: Jenkins Reviewed-by: Noel Grandin --- Repository.mk | 2 - bin/update_pch | 1 - desktop/Pagein_common.mk | 1 - filter/CppunitTest_filter_msfilter.mk | 1 - filter/CppunitTest_filter_priority.mk | 1 - framework/Library_fwk.mk | 23 ++ framework/Library_fwl.mk | 74 ------ framework/Library_fwm.mk | 59 ----- framework/Module_framework.mk | 2 - framework/inc/pch/precompiled_fwl.cxx | 12 - framework/inc/pch/precompiled_fwl.hxx | 211 ------------------ .../source/register/register3rdcomponents.cxx | 45 ---- framework/source/register/registertemp.cxx | 10 +- framework/util/fwk.component | 68 +++++- framework/util/fwl.component | 79 ------- framework/util/fwm.component | 31 --- postprocess/Rdb_services.mk | 2 - sd/Library_sdui.mk | 1 - .../gbuild/extensions/pre_MergedLibsList.mk | 1 - 19 files changed, 98 insertions(+), 526 deletions(-) delete mode 100644 framework/Library_fwl.mk delete mode 100644 framework/Library_fwm.mk delete mode 100644 framework/inc/pch/precompiled_fwl.cxx delete mode 100644 framework/inc/pch/precompiled_fwl.hxx delete mode 100644 framework/source/register/register3rdcomponents.cxx delete mode 100644 framework/util/fwl.component delete mode 100644 framework/util/fwm.component diff --git a/Repository.mk b/Repository.mk index 4f5f77921888..5d3be2f78188 100644 --- a/Repository.mk +++ b/Repository.mk @@ -365,8 +365,6 @@ $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \ frm \ fsstorage \ fwk \ - fwl \ - fwm \ $(if $(filter WNT,$(OS)),gdipluscanvas) \ guesslang \ $(if $(filter DESKTOP,$(BUILD_TYPE)),helplinker) \ diff --git a/bin/update_pch b/bin/update_pch index 0dd9d62d34da..e5939e7a441c 100755 --- a/bin/update_pch +++ b/bin/update_pch @@ -77,7 +77,6 @@ DEFAULTS = \ 'editeng.editeng' : ( 5, EXCLUDE, INCLUDE, EXCLUDE), # 13.0 'forms.frm' : ( 2, EXCLUDE, EXCLUDE, EXCLUDE), # 14.2 'framework.fwk' : ( 7, EXCLUDE, INCLUDE, INCLUDE), # 14.8 - 'framework.fwl' : ( 5, EXCLUDE, INCLUDE, INCLUDE), # 5.1 'hwpfilter.hwp' : ( 3, EXCLUDE, INCLUDE, INCLUDE), # 6.0 'lotuswordpro.lwpft' : ( 2, EXCLUDE, EXCLUDE, EXCLUDE), # 11.6 'oox.oox' : ( 6, EXCLUDE, EXCLUDE, INCLUDE), # 28.2 diff --git a/desktop/Pagein_common.mk b/desktop/Pagein_common.mk index cd96e9a25b25..d0a0e689c2d2 100644 --- a/desktop/Pagein_common.mk +++ b/desktop/Pagein_common.mk @@ -20,7 +20,6 @@ $(eval $(call gb_Pagein_add_objects,common,\ lng \ xo \ fwk \ - fwl \ package2 \ ucpfile1 \ ucb1 \ diff --git a/filter/CppunitTest_filter_msfilter.mk b/filter/CppunitTest_filter_msfilter.mk index ad4596d4edb0..cf4347342f62 100644 --- a/filter/CppunitTest_filter_msfilter.mk +++ b/filter/CppunitTest_filter_msfilter.mk @@ -32,7 +32,6 @@ $(eval $(call gb_CppunitTest_use_components,filter_msfilter,\ configmgr/source/configmgr \ filter/source/config/cache/filterconfig1 \ framework/util/fwk \ - framework/util/fwl \ i18npool/util/i18npool \ ucb/source/core/ucb1 \ ucb/source/ucp/file/ucpfile1 \ diff --git a/filter/CppunitTest_filter_priority.mk b/filter/CppunitTest_filter_priority.mk index 5f9042dd0859..d942f5d019f5 100644 --- a/filter/CppunitTest_filter_priority.mk +++ b/filter/CppunitTest_filter_priority.mk @@ -29,7 +29,6 @@ $(eval $(call gb_CppunitTest_use_components,filter_priority,\ configmgr/source/configmgr \ filter/source/config/cache/filterconfig1 \ framework/util/fwk \ - framework/util/fwl \ i18npool/util/i18npool \ ucb/source/core/ucb1 \ ucb/source/ucp/file/ucpfile1 \ diff --git a/framework/Library_fwk.mk b/framework/Library_fwk.mk index 4adab569be94..61bb9d825906 100644 --- a/framework/Library_fwk.mk +++ b/framework/Library_fwk.mk @@ -28,6 +28,7 @@ $(eval $(call gb_Library_set_componentfile,fwk,framework/util/fwk)) $(eval $(call gb_Library_set_include,fwk,\ -I$(SRCDIR)/framework/source/inc \ -I$(SRCDIR)/framework/inc \ + -I$(WORKDIR)/CustomTarget/officecfg/registry \ $$(INCLUDE) \ )) @@ -78,6 +79,12 @@ $(eval $(call gb_Library_add_exception_objects,fwk,\ framework/source/dispatch/loaddispatcher \ framework/source/dispatch/startmoduledispatcher \ framework/source/dispatch/windowcommanddispatch \ + framework/source/dispatch/dispatchdisabler \ + framework/source/dispatch/mailtodispatcher \ + framework/source/dispatch/oxt_handler \ + framework/source/dispatch/popupmenudispatcher \ + framework/source/dispatch/servicehandler \ + framework/source/dispatch/systemexec \ framework/source/helper/dockingareadefaultacceptor \ framework/source/helper/ocomponentaccess \ framework/source/helper/ocomponentenumeration \ @@ -92,6 +99,8 @@ $(eval $(call gb_Library_add_exception_objects,fwk,\ framework/source/helper/vclstatusindicator \ framework/source/helper/wakeupthread \ framework/source/interaction/quietinteraction \ + framework/source/jobs/helponstartup \ + framework/source/jobs/shelljob \ framework/source/fwe/classes/actiontriggercontainer \ framework/source/fwe/classes/actiontriggerpropertyset \ framework/source/fwe/classes/actiontriggerseparatorpropertyset \ @@ -139,6 +148,9 @@ $(eval $(call gb_Library_add_exception_objects,fwk,\ framework/source/layoutmanager/uielement \ framework/source/loadenv/loadenv \ framework/source/loadenv/targethelper \ + framework/source/recording/dispatchrecorder \ + framework/source/recording/dispatchrecordersupplier \ + framework/source/register/registertemp \ framework/source/services/ContextChangeEventMultiplexer \ framework/source/services/autorecovery \ framework/source/services/desktop \ @@ -150,6 +162,8 @@ $(eval $(call gb_Library_add_exception_objects,fwk,\ framework/source/services/substitutepathvars \ framework/source/services/taskcreatorsrv \ framework/source/services/urltransformer \ + framework/source/services/mediatypedetectionhelper \ + framework/source/services/uriabbreviation \ framework/source/uiconfiguration/CommandImageResolver \ framework/source/uiconfiguration/ImageList \ framework/source/uiconfiguration/globalsettings \ @@ -199,6 +213,15 @@ $(eval $(call gb_Library_add_exception_objects,fwk,\ framework/source/uielement/toolbarmerger \ framework/source/uielement/toolbarwrapper \ framework/source/uielement/uicommanddescription \ + framework/source/uielement/fontmenucontroller \ + framework/source/uielement/fontsizemenucontroller \ + framework/source/uielement/footermenucontroller \ + framework/source/uielement/headermenucontroller \ + framework/source/uielement/langselectionmenucontroller \ + framework/source/uielement/macrosmenucontroller \ + framework/source/uielement/newmenucontroller \ + framework/source/uielement/toolbarmodemenucontroller \ + framework/source/uielement/toolbarsmenucontroller \ framework/source/uifactory/addonstoolbarfactory \ framework/source/uifactory/factoryconfiguration \ framework/source/uifactory/menubarfactory \ diff --git a/framework/Library_fwl.mk b/framework/Library_fwl.mk deleted file mode 100644 index 1917c57b6551..000000000000 --- a/framework/Library_fwl.mk +++ /dev/null @@ -1,74 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the "License"); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# - -$(eval $(call gb_Library_Library,fwl)) - -$(eval $(call gb_Library_set_componentfile,fwl,framework/util/fwl)) - -$(eval $(call gb_Library_set_include,fwl,\ - -I$(SRCDIR)/framework/inc \ - -I$(SRCDIR)/framework/source/inc \ - -I$(WORKDIR)/CustomTarget/officecfg/registry \ - $$(INCLUDE) \ -)) - -$(eval $(call gb_Library_use_external,fwl,boost_headers)) - -$(eval $(call gb_Library_set_precompiled_header,fwl,framework/inc/pch/precompiled_fwl)) - -$(eval $(call gb_Library_use_sdk_api,fwl)) - -$(eval $(call gb_Library_use_libraries,fwl,\ - comphelper \ - cppu \ - cppuhelper \ - fwk \ - i18nlangtag \ - sal \ - svl \ - svt \ - tk \ - tl \ - utl \ - vcl \ -)) - -$(eval $(call gb_Library_add_exception_objects,fwl,\ - framework/source/dispatch/mailtodispatcher \ - framework/source/dispatch/oxt_handler \ - framework/source/dispatch/popupmenudispatcher \ - framework/source/dispatch/servicehandler \ - framework/source/recording/dispatchrecorder \ - framework/source/recording/dispatchrecordersupplier \ - framework/source/register/registertemp \ - framework/source/dispatch/dispatchdisabler \ - framework/source/services/mediatypedetectionhelper \ - framework/source/services/uriabbreviation \ - framework/source/uielement/fontmenucontroller \ - framework/source/uielement/fontsizemenucontroller \ - framework/source/uielement/footermenucontroller \ - framework/source/uielement/headermenucontroller \ - framework/source/uielement/langselectionmenucontroller \ - framework/source/uielement/macrosmenucontroller \ - framework/source/uielement/newmenucontroller \ - framework/source/uielement/toolbarmodemenucontroller \ - framework/source/uielement/toolbarsmenucontroller \ -)) - -# vim: set noet sw=4 ts=4: diff --git a/framework/Library_fwm.mk b/framework/Library_fwm.mk deleted file mode 100644 index 061a6d362ba7..000000000000 --- a/framework/Library_fwm.mk +++ /dev/null @@ -1,59 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the "License"); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# - -$(eval $(call gb_Library_Library,fwm)) - -$(eval $(call gb_Library_set_componentfile,fwm,framework/util/fwm)) - -$(eval $(call gb_Library_use_custom_headers,fwm,\ - officecfg/registry \ -)) - -$(eval $(call gb_Library_set_include,fwm,\ - -I$(SRCDIR)/framework/inc \ - -I$(SRCDIR)/framework/source/inc \ - $$(INCLUDE) \ -)) - -$(eval $(call gb_Library_use_external,fwm,boost_headers)) - -$(eval $(call gb_Library_use_sdk_api,fwm)) - -$(eval $(call gb_Library_use_libraries,fwm,\ - comphelper \ - cppu \ - cppuhelper \ - fwk \ - sal \ - svl \ - svt \ - tk \ - tl \ - utl \ - vcl \ -)) - -$(eval $(call gb_Library_add_exception_objects,fwm,\ - framework/source/dispatch/systemexec \ - framework/source/jobs/helponstartup \ - framework/source/jobs/shelljob \ - framework/source/register/register3rdcomponents \ -)) - -# vim: set noet sw=4 ts=4: diff --git a/framework/Module_framework.mk b/framework/Module_framework.mk index 7fb48a527b9a..4baf948abd9d 100644 --- a/framework/Module_framework.mk +++ b/framework/Module_framework.mk @@ -21,8 +21,6 @@ $(eval $(call gb_Module_Module,framework)) $(eval $(call gb_Module_add_targets,framework,\ Library_fwk \ - Library_fwl \ - Library_fwm \ Package_dtd \ UIConfig_startmodule \ )) diff --git a/framework/inc/pch/precompiled_fwl.cxx b/framework/inc/pch/precompiled_fwl.cxx deleted file mode 100644 index 28c5149d5d6c..000000000000 --- a/framework/inc/pch/precompiled_fwl.cxx +++ /dev/null @@ -1,12 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - */ - -#include "precompiled_fwl.hxx" - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/framework/inc/pch/precompiled_fwl.hxx b/framework/inc/pch/precompiled_fwl.hxx deleted file mode 100644 index 6031e80fb914..000000000000 --- a/framework/inc/pch/precompiled_fwl.hxx +++ /dev/null @@ -1,211 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - */ - -/* - This file has been autogenerated by update_pch.sh. It is possible to edit it - manually (such as when an include file has been moved/renamed/removed). All such - manual changes will be rewritten by the next run of update_pch.sh (which presumably - also fixes all possible problems, so it's usually better to use it). - - Generated on 2020-04-25 20:55:03 using: - ./bin/update_pch framework fwl --cutoff=5 --exclude:system --include:module --include:local - - If after updating build fails, use the following command to locate conflicting headers: - ./bin/update_pch_bisect ./framework/inc/pch/precompiled_fwl.hxx "make framework.build" --find-conflicts -*/ - -#if PCH_LEVEL >= 1 -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#endif // PCH_LEVEL >= 1 -#if PCH_LEVEL >= 2 -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#endif // PCH_LEVEL >= 2 -#if PCH_LEVEL >= 3 -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#endif // PCH_LEVEL >= 3 -#if PCH_LEVEL >= 4 -#include -#include -#endif // PCH_LEVEL >= 4 - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/framework/source/register/register3rdcomponents.cxx b/framework/source/register/register3rdcomponents.cxx deleted file mode 100644 index 4878a30e393c..000000000000 --- a/framework/source/register/register3rdcomponents.cxx +++ /dev/null @@ -1,45 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -#include - -/*================================================================================================================= - Add new include and new register info to for new services. - - Example: - - #include - #include - - COMPONENTGETFACTORY ( IFFACTORIE( Service1 ) - else - IFFACTORIE( Service2 ) - ) -=================================================================================================================*/ -#include -#include -#include - -COMPONENTGETFACTORY ( fwm, - IFFACTORY( ::framework::HelpOnStartup ) else - IFFACTORY( ::framework::SystemExec ) else - IFFACTORY( ::framework::ShellJob ) - ) - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/framework/source/register/registertemp.cxx b/framework/source/register/registertemp.cxx index 35add0a5ef31..5e0e767818b7 100644 --- a/framework/source/register/registertemp.cxx +++ b/framework/source/register/registertemp.cxx @@ -51,8 +51,11 @@ #include #include #include +#include +#include +#include -COMPONENTGETFACTORY ( fwl, +COMPONENTGETFACTORY ( fwk, IFFACTORY( ::framework::MediaTypeDetectionHelper ) IFFACTORY( ::framework::MailToDispatcher ) else IFFACTORY( ::framework::ServiceHandler ) else @@ -71,7 +74,10 @@ COMPONENTGETFACTORY ( fwl, IFFACTORY( ::framework::FooterMenuController ) else IFFACTORY( ::framework::HeaderMenuController ) else IFFACTORY( ::framework::LanguageSelectionMenuController ) else - IFFACTORY( ::framework::Oxt_Handler ) + IFFACTORY( ::framework::Oxt_Handler ) else + IFFACTORY( ::framework::HelpOnStartup ) else + IFFACTORY( ::framework::SystemExec ) else + IFFACTORY( ::framework::ShellJob ) ) /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/framework/util/fwk.component b/framework/util/fwk.component index bf321d0c0c12..5ea3ee56d500 100644 --- a/framework/util/fwk.component +++ b/framework/util/fwk.component @@ -18,7 +18,7 @@ --> + prefix="fwk" xmlns="http://openoffice.org/2010/uno-components"> @@ -212,4 +212,70 @@ constructor="com_sun_star_comp_framework_ResourceMenuController_get_implementation"> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/framework/util/fwl.component b/framework/util/fwl.component deleted file mode 100644 index 75e10b9c1b6f..000000000000 --- a/framework/util/fwl.component +++ /dev/null @@ -1,79 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/framework/util/fwm.component b/framework/util/fwm.component deleted file mode 100644 index 4724e64697bf..000000000000 --- a/framework/util/fwm.component +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - - - - - - - - - diff --git a/postprocess/Rdb_services.mk b/postprocess/Rdb_services.mk index b521dfb346fe..71f9421f6a90 100644 --- a/postprocess/Rdb_services.mk +++ b/postprocess/Rdb_services.mk @@ -42,8 +42,6 @@ $(eval $(call gb_Rdb_add_components,services,\ formula/util/for \ $(call gb_Helper_optional,DESKTOP,fpicker/source/office/fps_office) \ framework/util/fwk \ - framework/util/fwl \ - framework/util/fwm \ hwpfilter/source/hwp \ i18npool/source/search/i18nsearch \ i18npool/util/i18npool \ diff --git a/sd/Library_sdui.mk b/sd/Library_sdui.mk index abd25d24e15d..c776e2eed532 100644 --- a/sd/Library_sdui.mk +++ b/sd/Library_sdui.mk @@ -46,7 +46,6 @@ $(eval $(call gb_Library_use_libraries,sdui,\ cppuhelper \ editeng \ i18nlangtag \ - fwl \ fwk \ sal \ salhelper \ diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk b/solenv/gbuild/extensions/pre_MergedLibsList.mk index b56ce6b0b075..a1b1e6134f9b 100644 --- a/solenv/gbuild/extensions/pre_MergedLibsList.mk +++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk @@ -41,7 +41,6 @@ MERGE_LIBRARY_LIST := \ frm \ fsstorage \ fwk \ - fwl \ $(if $(filter WNT,$(OS)),gdipluscanvas) \ guesslang \ $(call gb_Helper_optional,DESKTOP,helplinker) \