From e8599a29c6540c05802d257671f3f4c572c73abc Mon Sep 17 00:00:00 2001
From: Gabor Kelemen <kelemen.gabor2@nisz.hu>
Date: Fri, 20 Sep 2019 00:33:41 +0200
Subject: [PATCH] tdf#42949 Fix IWYU warnings in xmlhelp/

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I266367d4f9e2b9bf637fc103a5e4876bd6b1d2b9
Reviewed-on: https://gerrit.libreoffice.org/79261
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
---
 xmlhelp/IwyuFilter_xmlhelp.yaml                       |  9 +++++++++
 xmlhelp/source/cxxhelp/inc/qe/DocGenerator.hxx        |  4 ----
 xmlhelp/source/cxxhelp/inc/tvfactory.hxx              |  6 ++----
 xmlhelp/source/cxxhelp/inc/tvread.hxx                 |  5 +----
 xmlhelp/source/cxxhelp/provider/content.cxx           |  6 +-----
 xmlhelp/source/cxxhelp/provider/content.hxx           |  1 -
 xmlhelp/source/cxxhelp/provider/databases.cxx         |  9 ---------
 xmlhelp/source/cxxhelp/provider/databases.hxx         |  3 ---
 xmlhelp/source/cxxhelp/provider/db.cxx                |  1 -
 xmlhelp/source/cxxhelp/provider/inputstream.cxx       |  1 -
 xmlhelp/source/cxxhelp/provider/inputstream.hxx       |  2 --
 xmlhelp/source/cxxhelp/provider/provider.cxx          |  6 +-----
 xmlhelp/source/cxxhelp/provider/resultset.hxx         |  3 ---
 xmlhelp/source/cxxhelp/provider/resultsetbase.cxx     |  3 ---
 xmlhelp/source/cxxhelp/provider/resultsetbase.hxx     |  1 -
 xmlhelp/source/cxxhelp/provider/resultsetforquery.hxx |  1 -
 xmlhelp/source/cxxhelp/provider/resultsetforroot.hxx  |  1 -
 xmlhelp/source/cxxhelp/provider/services.cxx          |  1 -
 xmlhelp/source/cxxhelp/provider/urlparameter.cxx      | 11 +----------
 xmlhelp/source/cxxhelp/provider/urlparameter.hxx      |  1 -
 xmlhelp/source/treeview/tvfactory.cxx                 |  1 +
 xmlhelp/source/treeview/tvread.cxx                    |  1 -
 22 files changed, 16 insertions(+), 61 deletions(-)
 create mode 100644 xmlhelp/IwyuFilter_xmlhelp.yaml

diff --git a/xmlhelp/IwyuFilter_xmlhelp.yaml b/xmlhelp/IwyuFilter_xmlhelp.yaml
new file mode 100644
index 000000000000..1430d6a09245
--- /dev/null
+++ b/xmlhelp/IwyuFilter_xmlhelp.yaml
@@ -0,0 +1,9 @@
+---
+assumeFilename: xmlhelp/source/cxxhelp/provider/content.cxx
+blacklist:
+    xmlhelp/source/cxxhelp/provider/content.cxx:
+    # Needed for CPPU_TYPE_REF macro
+    - com/sun/star/ucb/XCommandInfo.hpp
+    xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx:
+    # Needed for CLuceneError as a pass-through header
+    - CLucene.h
diff --git a/xmlhelp/source/cxxhelp/inc/qe/DocGenerator.hxx b/xmlhelp/source/cxxhelp/inc/qe/DocGenerator.hxx
index c0aa93c87eb2..45eb6005730b 100644
--- a/xmlhelp/source/cxxhelp/inc/qe/DocGenerator.hxx
+++ b/xmlhelp/source/cxxhelp/inc/qe/DocGenerator.hxx
@@ -19,10 +19,6 @@
 #ifndef INCLUDED_XMLHELP_SOURCE_CXXHELP_INC_QE_DOCGENERATOR_HXX
 #define INCLUDED_XMLHELP_SOURCE_CXXHELP_INC_QE_DOCGENERATOR_HXX
 
-#include <rtl/ref.hxx>
-#include <rtl/ustring.hxx>
-#include <vector>
-
 namespace xmlsearch {
 
     namespace qe {
diff --git a/xmlhelp/source/cxxhelp/inc/tvfactory.hxx b/xmlhelp/source/cxxhelp/inc/tvfactory.hxx
index 0f34599542a4..9eb8b2f3f0c0 100644
--- a/xmlhelp/source/cxxhelp/inc/tvfactory.hxx
+++ b/xmlhelp/source/cxxhelp/inc/tvfactory.hxx
@@ -20,14 +20,12 @@
 #ifndef INCLUDED_XMLHELP_SOURCE_CXXHELP_INC_TVFACTORY_HXX
 #define INCLUDED_XMLHELP_SOURCE_CXXHELP_INC_TVFACTORY_HXX
 
-#include <rtl/ref.hxx>
 #include <rtl/ustring.hxx>
-#include <cppuhelper/weak.hxx>
-#include <ucbhelper/macros.hxx>
 #include <com/sun/star/uno/XInterface.hpp>
+#include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
-#include <com/sun/star/lang/XTypeProvider.hpp>
 #include <com/sun/star/lang/XMultiServiceFactory.hpp>
+#include <com/sun/star/lang/XSingleServiceFactory.hpp>
 #include <cppuhelper/implbase.hxx>
 
 
diff --git a/xmlhelp/source/cxxhelp/inc/tvread.hxx b/xmlhelp/source/cxxhelp/inc/tvread.hxx
index 05c6991ab28c..c466fbba682b 100644
--- a/xmlhelp/source/cxxhelp/inc/tvread.hxx
+++ b/xmlhelp/source/cxxhelp/inc/tvread.hxx
@@ -23,11 +23,8 @@
 #include <vector>
 #include <rtl/ref.hxx>
 #include <rtl/ustring.hxx>
-#include <ucbhelper/macros.hxx>
 #include <com/sun/star/uno/Type.hxx>
-#include <cppuhelper/weak.hxx>
-#include <com/sun/star/uno/XInterface.hpp>
-#include <com/sun/star/lang/XTypeProvider.hpp>
+#include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/container/XNameAccess.hpp>
 #include <com/sun/star/container/XHierarchicalNameAccess.hpp>
 #include <com/sun/star/util/XChangesNotifier.hpp>
diff --git a/xmlhelp/source/cxxhelp/provider/content.cxx b/xmlhelp/source/cxxhelp/provider/content.cxx
index d9e4813ae3b2..55fef768ffab 100644
--- a/xmlhelp/source/cxxhelp/provider/content.cxx
+++ b/xmlhelp/source/cxxhelp/provider/content.cxx
@@ -22,11 +22,9 @@
  **************************************************************************
 
  *************************************************************************/
-#include <com/sun/star/beans/PropertyAttribute.hpp>
-#include <com/sun/star/beans/XPropertyAccess.hpp>
+#include <com/sun/star/beans/PropertyValue.hpp>
 #include <com/sun/star/sdbc/XRow.hpp>
 #include <com/sun/star/ucb/OpenCommandArgument2.hpp>
-#include <com/sun/star/ucb/OpenMode.hpp>
 #include <com/sun/star/ucb/UnsupportedCommandException.hpp>
 #include <com/sun/star/ucb/XCommandInfo.hpp>
 #include <com/sun/star/io/XActiveDataSink.hpp>
@@ -34,8 +32,6 @@
 #include <com/sun/star/lang/IllegalAccessException.hpp>
 #include <com/sun/star/ucb/UnsupportedDataSinkException.hpp>
 #include <com/sun/star/io/XActiveDataStreamer.hpp>
-#include <com/sun/star/ucb/XPersistentPropertySet.hpp>
-#include <ucbhelper/contentidentifier.hxx>
 #include <ucbhelper/propertyvalueset.hxx>
 #include <ucbhelper/cancelcommandexecution.hxx>
 #include <ucbhelper/macros.hxx>
diff --git a/xmlhelp/source/cxxhelp/provider/content.hxx b/xmlhelp/source/cxxhelp/provider/content.hxx
index 5f639762ff05..b16c56efa2f3 100644
--- a/xmlhelp/source/cxxhelp/provider/content.hxx
+++ b/xmlhelp/source/cxxhelp/provider/content.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_XMLHELP_SOURCE_CXXHELP_PROVIDER_CONTENT_HXX
 
 #include <ucbhelper/contenthelper.hxx>
-#include <com/sun/star/io/XInputStream.hpp>
 
 #include "urlparameter.hxx"
 
diff --git a/xmlhelp/source/cxxhelp/provider/databases.cxx b/xmlhelp/source/cxxhelp/provider/databases.cxx
index c097c08a40b3..cf5e5c0fa128 100644
--- a/xmlhelp/source/cxxhelp/provider/databases.cxx
+++ b/xmlhelp/source/cxxhelp/provider/databases.cxx
@@ -21,8 +21,6 @@
 #include "db.hxx"
 #include <osl/diagnose.h>
 #include <osl/file.hxx>
-#include <osl/thread.h>
-#include <osl/process.h>
 #include <rtl/character.hxx>
 #include <rtl/uri.hxx>
 #include <rtl/ustrbuf.hxx>
@@ -40,12 +38,10 @@
 // Extensible help
 #include <com/sun/star/deployment/ExtensionManager.hpp>
 #include <com/sun/star/deployment/ExtensionRemovedException.hpp>
-#include <com/sun/star/deployment/thePackageManagerFactory.hpp>
 #include <comphelper/processfactory.hxx>
 #include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/ucb/XCommandEnvironment.hpp>
 #include <com/sun/star/beans/Optional.hpp>
-#include <com/sun/star/beans/PropertyValue.hpp>
 #include <com/sun/star/beans/NamedValue.hpp>
 #include <com/sun/star/configuration/theDefaultProvider.hpp>
 #include <com/sun/star/ucb/SimpleFileAccess.hpp>
@@ -54,16 +50,11 @@
 #include <com/sun/star/uri/XVndSunStarExpandUrl.hpp>
 #include <i18nlangtag/languagetag.hxx>
 
-#include <com/sun/star/awt/XToolkit.hpp>
-#include <com/sun/star/awt/XExtendedToolkit.hpp>
-#include <com/sun/star/awt/XWindowPeer.hpp>
 #include <com/sun/star/awt/XVclWindowPeer.hpp>
 #include <com/sun/star/awt/XTopWindow.hpp>
 
 #include <comphelper/storagehelper.hxx>
 
-#include <vcl/svapp.hxx>
-
 #include "databases.hxx"
 #include "urlparameter.hxx"
 
diff --git a/xmlhelp/source/cxxhelp/provider/databases.hxx b/xmlhelp/source/cxxhelp/provider/databases.hxx
index c7ffa765b348..ff1c6fd69271 100644
--- a/xmlhelp/source/cxxhelp/provider/databases.hxx
+++ b/xmlhelp/source/cxxhelp/provider/databases.hxx
@@ -23,7 +23,6 @@
 #include <sal/config.h>
 
 #include <memory>
-#include <set>
 #include <unordered_map>
 #include <unordered_set>
 #include <vector>
@@ -31,9 +30,7 @@
 #include <rtl/ustring.hxx>
 #include <rtl/string.hxx>
 #include <com/sun/star/uno/Sequence.hxx>
-#include <com/sun/star/ucb/XContent.hpp>
 #include <com/sun/star/container/XHierarchicalNameAccess.hpp>
-#include <com/sun/star/io/XInputStream.hpp>
 #include <com/sun/star/lang/XMultiComponentFactory.hpp>
 #include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/i18n/XCollator.hpp>
diff --git a/xmlhelp/source/cxxhelp/provider/db.cxx b/xmlhelp/source/cxxhelp/provider/db.cxx
index c99a07403104..bf8da3ce7f04 100644
--- a/xmlhelp/source/cxxhelp/provider/db.cxx
+++ b/xmlhelp/source/cxxhelp/provider/db.cxx
@@ -20,7 +20,6 @@
 
 #include "db.hxx"
 
-#include <rtl/alloc.h>
 #include <cstring>
 
 #include <com/sun/star/io/XSeekable.hpp>
diff --git a/xmlhelp/source/cxxhelp/provider/inputstream.cxx b/xmlhelp/source/cxxhelp/provider/inputstream.cxx
index e5f18bb5fcc9..8eaebf364320 100644
--- a/xmlhelp/source/cxxhelp/provider/inputstream.cxx
+++ b/xmlhelp/source/cxxhelp/provider/inputstream.cxx
@@ -27,7 +27,6 @@
 
 using namespace chelp;
 using namespace com::sun::star;
-using namespace com::sun::star::ucb;
 
 
 XInputStream_impl::XInputStream_impl( const OUString& aUncPath )
diff --git a/xmlhelp/source/cxxhelp/provider/inputstream.hxx b/xmlhelp/source/cxxhelp/provider/inputstream.hxx
index 9c37cd9d5b4f..d3292ec1967e 100644
--- a/xmlhelp/source/cxxhelp/provider/inputstream.hxx
+++ b/xmlhelp/source/cxxhelp/provider/inputstream.hxx
@@ -23,10 +23,8 @@
 #include <rtl/ustring.hxx>
 #include <osl/file.hxx>
 #include <cppuhelper/weak.hxx>
-#include <com/sun/star/uno/XInterface.hpp>
 #include <com/sun/star/io/XSeekable.hpp>
 #include <com/sun/star/io/XInputStream.hpp>
-#include <com/sun/star/ucb/XContentProvider.hpp>
 
 
 namespace chelp {
diff --git a/xmlhelp/source/cxxhelp/provider/provider.cxx b/xmlhelp/source/cxxhelp/provider/provider.cxx
index 865f4066fbe8..b82ba4917d24 100644
--- a/xmlhelp/source/cxxhelp/provider/provider.cxx
+++ b/xmlhelp/source/cxxhelp/provider/provider.cxx
@@ -19,14 +19,10 @@
 
 #include <config_folders.h>
 
-#include <stdio.h>
 #include <officecfg/Office/Common.hxx>
 #include <officecfg/Setup.hxx>
-#include <osl/file.hxx>
-#include <ucbhelper/contentidentifier.hxx>
-#include <com/sun/star/beans/PropertyAttribute.hpp>
-#include <com/sun/star/beans/PropertyValue.hpp>
 #include <com/sun/star/container/XContainer.hpp>
+#include <com/sun/star/ucb/IllegalIdentifierException.hpp>
 #include <com/sun/star/uno/XComponentContext.hpp>
 #include <comphelper/processfactory.hxx>
 #include <cppuhelper/supportsservice.hxx>
diff --git a/xmlhelp/source/cxxhelp/provider/resultset.hxx b/xmlhelp/source/cxxhelp/provider/resultset.hxx
index 24891246d766..2d276fa36dc4 100644
--- a/xmlhelp/source/cxxhelp/provider/resultset.hxx
+++ b/xmlhelp/source/cxxhelp/provider/resultset.hxx
@@ -22,9 +22,6 @@
 
 #include <memory>
 #include <ucbhelper/resultsethelper.hxx>
-#include <rtl/ref.hxx>
-
-#include "content.hxx"
 
 namespace chelp {
 
diff --git a/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx b/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
index 911a74a4b0b9..e4d74404b7fd 100644
--- a/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
+++ b/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
@@ -19,11 +19,8 @@
 
 #include <ucbhelper/contentidentifier.hxx>
 #include <com/sun/star/sdbc/SQLException.hpp>
-#include <com/sun/star/ucb/OpenMode.hpp>
 #include <com/sun/star/uno/Reference.h>
 #include <com/sun/star/beans/PropertyAttribute.hpp>
-#include <com/sun/star/ucb/ListActionType.hpp>
-#include <com/sun/star/ucb/XSourceInitialization.hpp>
 #include <ucbhelper/resultsetmetadata.hxx>
 #include <cppuhelper/queryinterface.hxx>
 
diff --git a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx b/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx
index 8c6e0cfcd713..50cd31e971c1 100644
--- a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx
+++ b/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx
@@ -30,7 +30,6 @@
 #include <com/sun/star/sdbc/XResultSet.hpp>
 #include <com/sun/star/sdbc/XRow.hpp>
 #include <com/sun/star/sdbc/XResultSetMetaDataSupplier.hpp>
-#include <com/sun/star/ucb/NumberedSortingInfo.hpp>
 #include <com/sun/star/ucb/XContentProvider.hpp>
 #include <com/sun/star/ucb/XContentIdentifier.hpp>
 #include <com/sun/star/uno/XComponentContext.hpp>
diff --git a/xmlhelp/source/cxxhelp/provider/resultsetforquery.hxx b/xmlhelp/source/cxxhelp/provider/resultsetforquery.hxx
index 98480b04e6d6..2a3127b2b5ac 100644
--- a/xmlhelp/source/cxxhelp/provider/resultsetforquery.hxx
+++ b/xmlhelp/source/cxxhelp/provider/resultsetforquery.hxx
@@ -22,7 +22,6 @@
 #include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/ucb/XContentProvider.hpp>
 #include <com/sun/star/beans/Property.hpp>
-#include <com/sun/star/ucb/NumberedSortingInfo.hpp>
 
 #include "resultsetbase.hxx"
 #include "urlparameter.hxx"
diff --git a/xmlhelp/source/cxxhelp/provider/resultsetforroot.hxx b/xmlhelp/source/cxxhelp/provider/resultsetforroot.hxx
index 6a54edd07c1a..17add2d3c0fc 100644
--- a/xmlhelp/source/cxxhelp/provider/resultsetforroot.hxx
+++ b/xmlhelp/source/cxxhelp/provider/resultsetforroot.hxx
@@ -22,7 +22,6 @@
 #include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/ucb/XContentProvider.hpp>
 #include <com/sun/star/beans/Property.hpp>
-#include <com/sun/star/ucb/NumberedSortingInfo.hpp>
 
 #include "resultsetbase.hxx"
 #include "urlparameter.hxx"
diff --git a/xmlhelp/source/cxxhelp/provider/services.cxx b/xmlhelp/source/cxxhelp/provider/services.cxx
index 52e0616f65c0..5778a27ce6e5 100644
--- a/xmlhelp/source/cxxhelp/provider/services.cxx
+++ b/xmlhelp/source/cxxhelp/provider/services.cxx
@@ -19,7 +19,6 @@
 
 #include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <com/sun/star/lang/XSingleServiceFactory.hpp>
-#include <com/sun/star/registry/XRegistryKey.hpp>
 
 #include "provider.hxx"
 #include <tvfactory.hxx>
diff --git a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx
index d77c70552bb9..8a395226e99f 100644
--- a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx
+++ b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx
@@ -19,16 +19,13 @@
 
 
 #include <string.h>
-#include <osl/diagnose.hxx>
 #include <osl/thread.h>
 #include <osl/file.hxx>
 #include <cppuhelper/weak.hxx>
 #include <cppuhelper/queryinterface.hxx>
 #include <comphelper/processfactory.hxx>
 #include <rtl/uri.hxx>
-#include <rtl/ustrbuf.hxx>
 #include <rtl/character.hxx>
-#include <libxslt/xslt.h>
 #include <libxslt/transform.h>
 #include <libxslt/xsltutils.h>
 #include <libxslt/security.h>
@@ -37,13 +34,7 @@
 #include <com/sun/star/io/XInputStream.hpp>
 #include <com/sun/star/io/XSeekable.hpp>
 #include <com/sun/star/lang/IllegalArgumentException.hpp>
-#include <com/sun/star/ucb/OpenCommandArgument2.hpp>
-#include <com/sun/star/ucb/OpenMode.hpp>
-#include <com/sun/star/ucb/XCommandProcessor.hpp>
-#include <com/sun/star/ucb/XCommandEnvironment.hpp>
-#include <com/sun/star/ucb/XContentIdentifier.hpp>
-#include <com/sun/star/ucb/XContentProvider.hpp>
-#include <com/sun/star/ucb/XContentIdentifierFactory.hpp>
+#include <com/sun/star/ucb/IllegalIdentifierException.hpp>
 #include <com/sun/star/container/XHierarchicalNameAccess.hpp>
 
 #include "urlparameter.hxx"
diff --git a/xmlhelp/source/cxxhelp/provider/urlparameter.hxx b/xmlhelp/source/cxxhelp/provider/urlparameter.hxx
index 4104c2a13cb2..7adc4c1aa4e9 100644
--- a/xmlhelp/source/cxxhelp/provider/urlparameter.hxx
+++ b/xmlhelp/source/cxxhelp/provider/urlparameter.hxx
@@ -22,7 +22,6 @@
 
 #include <rtl/ustring.hxx>
 #include <rtl/string.hxx>
-#include <com/sun/star/ucb/IllegalIdentifierException.hpp>
 #include <com/sun/star/io/XActiveDataSink.hpp>
 #include <com/sun/star/io/XOutputStream.hpp>
 
diff --git a/xmlhelp/source/treeview/tvfactory.cxx b/xmlhelp/source/treeview/tvfactory.cxx
index e4fc02c58e41..9f59b66e4025 100644
--- a/xmlhelp/source/treeview/tvfactory.cxx
+++ b/xmlhelp/source/treeview/tvfactory.cxx
@@ -23,6 +23,7 @@
 #include <comphelper/processfactory.hxx>
 #include <comphelper/propertysequence.hxx>
 #include <cppuhelper/supportsservice.hxx>
+#include <cppuhelper/factory.hxx>
 #include <tvfactory.hxx>
 #include <tvread.hxx>
 
diff --git a/xmlhelp/source/treeview/tvread.cxx b/xmlhelp/source/treeview/tvread.cxx
index 4ae8f7a0aff8..6a6ea52552b9 100644
--- a/xmlhelp/source/treeview/tvread.cxx
+++ b/xmlhelp/source/treeview/tvread.cxx
@@ -28,7 +28,6 @@
 #include <unotools/configmgr.hxx>
 #include <com/sun/star/configuration/theDefaultProvider.hpp>
 #include <com/sun/star/ucb/SimpleFileAccess.hpp>
-#include <com/sun/star/beans/PropertyValue.hpp>
 
 #include <comphelper/processfactory.hxx>
 #include <comphelper/propertysequence.hxx>