strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cid#1607042 silence Overflowed integer argument

Browse source 
Change-Id: I416f9f22c6ba464ef6a3416a3a0cebc34f2b6725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172094
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara 2024-08-17 20:54:36 +01:00
parent b6ff644abc
commit edb352c241
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
connectivity/source/drivers/hsqldb/HStorageAccess.cxx
View file

@ -364,22 +364,22 @@ extern "C" SAL_JNI_EXPORT void JNICALL Java_com_sun_star_sdbcx_comp_hsqldb_Nativ
Reference< XOutputStream> xOut = pHelper->getOutputStream(); Reference< XOutputStream> xOut = pHelper->getOutputStream();
OSL_ENSURE(xOut.is(),"No output stream!"); OSL_ENSURE(xOut.is(),"No output stream!");
::sal_Int64 diff = position - nLen; sal_Int64 diff = position - nLen, n;
sal_Int32 n; while (diff != 0)
while( diff != 0 )
{ {
if ( BUFFER_SIZE < diff ) if (diff > BUFFER_SIZE)
{ {
n = static_cast<sal_Int32>(BUFFER_SIZE); n = BUFFER_SIZE;
diff = diff - BUFFER_SIZE; diff = diff - BUFFER_SIZE;
} }
else else
{ {
n = static_cast<sal_Int32>(diff); n = diff;
diff = 0; diff = 0;
} }
Sequence< ::sal_Int8 > aData(n); assert(n >= 0 && n <= SAL_MAX_INT32 && "this fits in sal_Int32");
memset(aData.getArray(),0,n); Sequence<sal_Int8> aData(n);
memset(aData.getArray(), 0, n);
xOut->writeBytes(aData); xOut->writeBytes(aData);
#ifdef HSQLDB_DBG #ifdef HSQLDB_DBG
aDataLog.write( aData.getConstArray(), n ); aDataLog.write( aData.getConstArray(), n );