strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#62032 sw List Level UI: don't require old value

Browse source 
I added the qualification at the last minute,
in imitation of other properties which according
to coverity scans could actually hit the qualifier.

Well, as Seth's testing shows, very often there is no
such oldvalue (for example on the default paragraph style),
and so this should not prevent us from setting something.

I can imagine that editEng paragraphs could issue an exception
if we try to set this property. However, in the testing I did
(against a comment's paragraph) this tab page did
not come up.

Change-Id: I0fcc45d100b01716b87316c1bbb9f69eb7c577f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148129
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
This commit is contained in:
Justin Luth 2023-03-02 10:18:43 -05:00
parent bd6dad1bbc
commit f2c581c7b6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sw/source/ui/chrdlg/numpara.cxx
View file

@ -127,7 +127,7 @@ bool SwParagraphNumTabPage::FillItemSet( SfxItemSet* rSet )
if (m_xListLvLB->get_value_changed_from_saved())
{
if (m_xListLvBX->get_visible() && GetOldItem(*rSet, RES_PARATR_LIST_LEVEL))
if (m_xListLvBX->get_visible())
{
sal_Int16 nListLevel = m_xListLvLB->get_active();
// Does List Level need to be set to be the same as Outline Level?