strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clang-tidy modernize-pass-by-value in avmedia

Browse source 
Change-Id: Ia579341951d3fa0a227cdfa888c380b032e2ee2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135312
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2022-06-02 15:57:49 +02:00
parent d16122e3e9
commit f5e3ad701e
3 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
avmedia/source/viewer/mediawindow.cxx
View file

@ -23,6 +23,7 @@
#include <bitmaps.hlst>
#include <strings.hrc>
#include <tools/urlobj.hxx>
#include <utility>
#include <vcl/graph.hxx>
#include <vcl/svapp.hxx>
#include <vcl/weld.hxx>
@ -459,9 +460,9 @@ void MediaWindow::dispatchInsertAVMedia(const css::uno::Reference<css::frame::XD
xDispatch->dispatch(aDispatchURL, aArgs);
}
PlayerListener::PlayerListener(const std::function<void(const css::uno::Reference<css::media::XPlayer>&)> &rFn)
PlayerListener::PlayerListener(std::function<void(const css::uno::Reference<css::media::XPlayer>&)> fn)
: PlayerListener_BASE(m_aMutex)
, m_aFn(rFn)
, m_aFn(std::move(fn))
{
}

5
include/avmedia/mediaitem.hxx
View file

@ -27,6 +27,7 @@
#include <string_view>
#include <o3tl/typed_flags_set.hxx>
#include <utility>
namespace com::sun::star::embed { class XStorage; }
namespace com::sun::star::frame { class XModel; }
@ -151,8 +152,8 @@ OUString GetFilename(OUString const& rSourceURL);
struct AVMEDIA_DLLPUBLIC MediaTempFile
{
OUString const m_TempFileURL;
MediaTempFile(OUString const& rURL)
: m_TempFileURL(rURL)
MediaTempFile(OUString aURL)
: m_TempFileURL(std::move(aURL))
{}
~MediaTempFile();
};

2
include/avmedia/mediawindow.hxx
View file

@ -66,7 +66,7 @@ namespace avmedia
using WeakComponentImplHelperBase::disposing;
public:
PlayerListener(const std::function<void(const css::uno::Reference<css::media::XPlayer>&)> &rFn);
PlayerListener(std::function<void(const css::uno::Reference<css::media::XPlayer>&)> fn);
virtual void SAL_CALL dispose() override;
virtual ~PlayerListener() override;