strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove dead less-than-zero conditional checks.

Browse source 
A large number of conditionals in accessibility.cxx checked that
their values were above zero at some point, but that code was
commented out; this removes those (unused) checks completely.

Signed-off-by: Phil Bordelon <phil@thenexusproject.org>
This commit is contained in:
Phil Bordelon 2010-09-30 10:43:59 -05:00 committed by Cédric Bosdonnat
parent 217e648d84
commit f6f2659f6e
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
starmath/source/accessibility.cxx
View file

@ -464,7 +464,7 @@ sal_Bool SAL_CALL SmGraphicAccessible::setCaretPosition( sal_Int32 nIndex )
{
xub_StrLen nIdx = (xub_StrLen) nIndex;
String aTxt( GetAccessibleText_Impl() );
if (!(/*0 <= nIdx &&*/ nIdx < aTxt.Len()))
if (!(nIdx < aTxt.Len()))
throw IndexOutOfBoundsException();
return sal_False;
}
@ -476,7 +476,7 @@ sal_Unicode SAL_CALL SmGraphicAccessible::getCharacter( sal_Int32 nIndex )
xub_StrLen nIdx = (xub_StrLen) nIndex;
String aTxt( GetAccessibleText_Impl() );
if (!(/*0 <= nIdx &&*/ nIdx < aTxt.Len()))
if (!(nIdx < aTxt.Len()))
throw IndexOutOfBoundsException();
return aTxt.GetChar( nIdx );
}
@ -694,8 +694,8 @@ OUString SAL_CALL SmGraphicAccessible::getTextRange(
String aTxt( GetAccessibleText_Impl() );
xub_StrLen nStart = (xub_StrLen) Min(nStartIndex, nEndIndex);
xub_StrLen nEnd = (xub_StrLen) Max(nStartIndex, nEndIndex);
if (!(/*0 <= nStart &&*/ nStart <= aTxt.Len()) ||
!(/*0 <= nEnd &&*/ nEnd <= aTxt.Len()))
if (!(nStart <= aTxt.Len()) ||
!(nEnd <= aTxt.Len()))
throw IndexOutOfBoundsException();
return aTxt.Copy( nStart, nEnd - nStart );
}
@ -706,7 +706,7 @@ OUString SAL_CALL SmGraphicAccessible::getTextRange(
String aTxt( GetAccessibleText_Impl() );
xub_StrLen nIdx = (xub_StrLen) nIndex;
//!! nIndex is allowed to be the string length
if (!(/*0 <= nIdx &&*/ nIdx <= aTxt.Len()))
if (!(nIdx <= aTxt.Len()))
throw IndexOutOfBoundsException();
::com::sun::star::accessibility::TextSegment aResult;
@ -727,7 +727,7 @@ OUString SAL_CALL SmGraphicAccessible::getTextRange(
String aTxt( GetAccessibleText_Impl() );
xub_StrLen nIdx = (xub_StrLen) nIndex;
//!! nIndex is allowed to be the string length
if (!(/*0 <= nIdx &&*/ nIdx <= aTxt.Len()))
if (!(nIdx <= aTxt.Len()))
throw IndexOutOfBoundsException();
::com::sun::star::accessibility::TextSegment aResult;
@ -749,7 +749,7 @@ OUString SAL_CALL SmGraphicAccessible::getTextRange(
String aTxt( GetAccessibleText_Impl() );
xub_StrLen nIdx = (xub_StrLen) nIndex;
//!! nIndex is allowed to be the string length
if (!(/*0 <= nIdx &&*/ nIdx <= aTxt.Len()))
if (!(nIdx <= aTxt.Len()))
throw IndexOutOfBoundsException();
::com::sun::star::accessibility::TextSegment aResult;