Commit graph

430956 commits

Author SHA1 Message Date
Tor Lillqvist
54c2e3c83a Don't create temp file in save destination folder when sandboxed
In a sandboxed environment we don't want to attempt to create
temporary files in the same directory where the user has selected an
output file to be stored. The sandboxed process has permission only to
create the specifically named output file that the user chose in the
system file dialog in that directory.

Change-Id: I65274b4c433bd66b436429bea4b287a0505b72c9
2018-11-22 22:03:31 +02:00
Stephan Bergmann
3afe0c79fa --enable-dbgutil --disable-assert-always-abort fixes
...which <https://ci.libreoffice.org/job/lo_tb_random_config_linux/>
occasionally stumbles across; plus some related loplugin:staticmethods fixes

Change-Id: If6998c302cfbabfcad626d9c68d94d3368548a41
Reviewed-on: https://gerrit.libreoffice.org/63808
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22 21:02:07 +01:00
Michael Meeks
f19dfaf817 Avoid busy-loop related to layout when dragging objects.
Change-Id: I4fb437356bc154cfefc5958592ae5888e24d59c3
Reviewed-on: https://gerrit.libreoffice.org/63804
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-22 19:09:12 +01:00
Regina Henschel
fbc95e77d2 tdf#121425 Use better Bezier curves to approximate circle arc
The distance between curve point and control point was calculated
as linear scaling with ratio of central angle of the arc to pi/2.
The patch replaces this with the mathematical correct formula.

Change-Id: I0195e40bb99cd4bbcce95f7ac896158b7e7e3d29
Reviewed-on: https://gerrit.libreoffice.org/63659
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 18:55:33 +01:00
Noel Grandin
170df072a6 improve function-local statics in toolkit
Change-Id: I2a134d1cc74eaeaad46f4249fadd215b2391ba19
Reviewed-on: https://gerrit.libreoffice.org/63789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 18:54:21 +01:00
Adolfo Jayme Barrientos
c5b920dc88 Update git submodules
* Update helpcontent2 from branch 'master'
  - tdf#119415 Widen search box and style placeholder
    
    Change-Id: I0f60cfea338e695e778d16a208153597ec6d19ca
2018-11-22 18:54:10 +01:00
László Németh
d1ee27cf9b tdf#121597 DOCX: don't export empty paragraphs at tracked deletion
of non-empty multiple paragraphs. Complete the fix for
"tdf#115521 DOCX export: keep empty paragraphs in tracked deletion"
in commit 2cdc870a7e

Change-Id: Ic3446e2a2118e604a7a4d269c8fed1f9f157846f
Reviewed-on: https://gerrit.libreoffice.org/63731
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-22 18:04:32 +01:00
Armin Le Grand
10a58ec154 tdf#116931 Fix scale when calc cells move indirectly
For the anchor mode 'To Cell (resize with cell)' there
were errors e.g. when the cell the object is in does
not scale but move. If that move went further than the
object is, wrong offsets emerged.
Also added full linear per-cell scale instead of only
scale (no translation through scale). Overhauled to
use liner transfomations, too.

Change-Id: Icff0fad168476c68ea10fd5830bf53bd7294b89f
Reviewed-on: https://gerrit.libreoffice.org/63803
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-11-22 17:33:40 +01:00
Noel Grandin
d05dbf61d2 remove unused enums DocumentTextDirection and RendererPaneStyle::Side
Change-Id: I5409a1b1ea3e7619bd1dc4a430c65987269f6204
Reviewed-on: https://gerrit.libreoffice.org/63753
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 17:21:42 +01:00
Caolán McNamara
750ccfb2a6 tdf#120703 PVS: V637 rename inconsistent < and == operators
i.e. lets not have...

if (a == b)
{
    if (a < b)
}

Change-Id: I8ffb8a1e591cbd5f9bf24fbef497660700ed47b0
Reviewed-on: https://gerrit.libreoffice.org/63802
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 17:09:47 +01:00
Stephan Bergmann
1947012abc SAL_USE_VCLPLUGIN is a UNO bootstrap variable
...(which includes environment variables), so read it as one (as is already done
in e.g. CreateSalInstance in vcl/source/app/salplug.cxx), esp. so since
lo_initialize in desktop/source/lib/init.cxx doesn't set it as an environment
variable

Change-Id: I557ecf4fcc5daba1e748af789847c8bbb9f563d6
Reviewed-on: https://gerrit.libreoffice.org/63801
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22 16:44:06 +01:00
Sabri Unal
340ed84c84 Related: tdf#121340: Do wizards steps Title Case
Change-Id: I4ac17e520a93678a1a0e8dfd5fd849eaf276219d
Reviewed-on: https://gerrit.libreoffice.org/63776
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-22 16:43:33 +01:00
Ilmari Lauhakangas
d937f1ffd8 Update git submodules
* Update helpcontent2 from branch 'master'
  - Stop index headers from being linkified
    
    Change-Id: If445b693feb17fd943eced3a222a20b26039891d
    Reviewed-on: https://gerrit.libreoffice.org/63759
    Tested-by: Jenkins
    Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-22 16:31:18 +01:00
Thorsten Behrens
ccae6c0faa python tests: fix user config for autotext functions
Seems that the code in SwGlossaries::GetGlosDoc() expects subdirs
to exist in user config, and would otherwise fail miserably.

Change-Id: I2da6bca46ae5e0d9d90bc23eb710396dbede37f4
Reviewed-on: https://gerrit.libreoffice.org/63798
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22 16:24:21 +01:00
Caolán McNamara
205aeffda1 tdf#121607 defer other requests until password dialog is dismissed
Change-Id: I82b308f482cc5eb40a00afd01a6848afc3fb8ab1
Reviewed-on: https://gerrit.libreoffice.org/63793
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 16:09:41 +01:00
Caolán McNamara
278a3910fc Resolves: tdf#121607 set parent for password dialogs
Change-Id: I02210a61d103aed4a181b0e907ea2fd141e5f587
Reviewed-on: https://gerrit.libreoffice.org/63787
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 15:49:57 +01:00
Caolán McNamara
445ea4cbca tdf#120703 PVS: V765 simplfy assignment
Change-Id: I4cf55dfd0a4b4684b6e8fed2c36a8e79bbf138c1
Reviewed-on: https://gerrit.libreoffice.org/63799
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 15:49:43 +01:00
Serge Krot
7878a30e09 sw: new unit test for XCloseable
Change-Id: I1c89abffcc985d6f5b2e0f570fcb82601d923b5e
Reviewed-on: https://gerrit.libreoffice.org/61091
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22 15:27:47 +01:00
Noel Grandin
28d82c3313 improve function-local statics in vbahelper
Change-Id: Id54660390baa337d8bd54a19924e138c2ccb0bc7
Reviewed-on: https://gerrit.libreoffice.org/63790
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 14:27:18 +01:00
Stephan Bergmann
dd0e684929 Temporarily drop --disable-c++17 from Coverity builds
...to see whether the Coverity issue has solved itself by now (see
0f3b0ec973 "Avoid C++17 mode for Coverity Scan"
for details)

Change-Id: I1086d6b79217af51a84e347a0d13f323429b37d0
2018-11-22 13:49:33 +01:00
Noel Grandin
0d653000a6 improve function-local statics in sw
Change-Id: I36b0e9b2819a442f01182f551dbc2bf7d5c878f4
Reviewed-on: https://gerrit.libreoffice.org/63788
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 13:34:17 +01:00
Noel Grandin
7f91d6ccee remove unused enum RedlineFunc
Change-Id: Ibbe870680e22cf91d6c421df98cf7b8a098d6e3f
Reviewed-on: https://gerrit.libreoffice.org/63752
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 13:07:33 +01:00
Stephan Bergmann
39b81921d7 Pass some env vars into all kinds of tests
...not only CppunitTests, as had been changed with
d5ed903618 "Set CppunitTest-related env vars only
during CppunitTest".  Despite those env vars having been deceptively set up
in solenv/gbuild/CppunitTest.mk, at least some of them may also be useful during
other tests, and may actually have been relied upon by other tests in the past.

Change-Id: I854dfb1786bb5e9e2de5fd77cb6323299320b544
Reviewed-on: https://gerrit.libreoffice.org/63784
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22 13:03:57 +01:00
Noel Grandin
06ad764cfb improve function-local statics in scripting..svtools
Change-Id: Idf3785a1fbc6fc5b8efbdc4cd363047709f3af91
Reviewed-on: https://gerrit.libreoffice.org/63782
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 12:46:56 +01:00
Noel Grandin
a73494cf13 improve function-local statics in sc
Change-Id: Ibde8aa9393591fe405bfad8ddb23ceda77723a35
Reviewed-on: https://gerrit.libreoffice.org/63781
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 12:44:43 +01:00
Eike Rathke
266aab73a8 Resolves: tdf#113898 create JumpMatrix for svExternalDoubleRef scalar values
Change-Id: I45d2a1e573a7e4923aaaf5b69f3c4b39215aacc2
Reviewed-on: https://gerrit.libreoffice.org/63778
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2018-11-22 12:33:33 +01:00
Noel Grandin
85acc270fc improve function-local statics in sal
Change-Id: I0853cf13162bae44cf8a5c44a4546a73f05772d9
Reviewed-on: https://gerrit.libreoffice.org/63780
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 12:07:54 +01:00
Jan Holesovsky
eea439b4b1 git hooks: Tell what to do in another problematic submodules case.
Change-Id: I6247df16c021c13c97471cae16d3a1c0f3ddc691
2018-11-22 11:53:07 +01:00
Jan Holesovsky
e1f067151f git hooks: Check that you are not committing to submodules by accident.
And also for a dangerous setting in the configuration that hides the
changes from you.

Change-Id: I99bad8024baf7048696d9602e857c253c20cb5c2
Reviewed-on: https://gerrit.libreoffice.org/63389
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-22 11:25:10 +01:00
Tomaž Vajngerl
1874d71576 remove printf
Change-Id: I00394e7c9880bd96a4f68b6695f1b85fa95689b4
Reviewed-on: https://gerrit.libreoffice.org/63442
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-11-22 11:18:51 +01:00
Noel Grandin
94ef4c1313 improve function-local statics in svx
Change-Id: I636fcc8ba1012d774d98f6a880bf29eb4b233128
Reviewed-on: https://gerrit.libreoffice.org/63783
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 11:06:58 +01:00
Michael Meeks
7b34fb18a4 Re-factor internal filter logic, and impl. preload properly.
Change-Id: I4c55ceb19d5db2c1e4756901d0d8b14878641a99
Reviewed-on: https://gerrit.libreoffice.org/63761
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-22 10:27:50 +01:00
Noel Grandin
4c19552052 remove some unused enum values and defines in soltools
which led to a whole bunch of dead code

Change-Id: If138a05cf7f09b3020e27489b90c32776b859bcf
Reviewed-on: https://gerrit.libreoffice.org/63751
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 10:15:40 +01:00
Aron Budea
1e603213e7 Don't check page size on Win for tdf#112690 unit test
Since ec11c1aee0,
lo_tb_master_win consistently fails in CppunitTest_vcl_pdfexport with
double equality assertion failed, expected: 793.7, actual: 793,
delta 0.01.

The difference is significant, previously before tdf#112690 fix the
incorrect width was 793.67, but the reason is unknown.

Let's disable the check in Win for now.

Change-Id: If1569131217d83054875b7cb72787e1a6ef7023c
Reviewed-on: https://gerrit.libreoffice.org/63726
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-11-22 10:13:41 +01:00
Martin van Zijl
a995d10e27 tdf#119991 save checkbox tristate in oox format
Change-Id: I313bff6115d56c2567a4586daa43851a1db12b0b
Reviewed-on: https://gerrit.libreoffice.org/63670
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-22 09:59:53 +01:00
Noel Grandin
3c51ab7573 remove unused toktype::IDENT
Change-Id: I4222902d9ef93e92dfbcbd089d6aaf7d724fa0de
Reviewed-on: https://gerrit.libreoffice.org/63750
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 08:47:33 +01:00
Stephan Bergmann
f15274a9d9 Completely remove obsolete HAVE_BROKEN_STATIC_INITIALIZER_LIST check
...after it had already been phased out almost two years ago with
721116c7ad "Phase out support for
HAVE_BROKEN_STATIC_INITIALIZER_LIST"

Change-Id: Idfc216f10ecff9dab6a3218ba234d458d7816839
Reviewed-on: https://gerrit.libreoffice.org/63766
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22 08:22:16 +01:00
Noel Grandin
9decbd5998 convert SwTableAutoFormat::UpdateFlags to scoped enum
and remove unused UPDATE_ALL

Change-Id: Ib8f21dcddec66947fff8e9cda63f10711da02883
Reviewed-on: https://gerrit.libreoffice.org/63748
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:40:55 +01:00
Noel Grandin
507dc611bd remove unused PAGESIDE enum
Change-Id: I45185865ec0645040b129885beb97bebafefe70a
Reviewed-on: https://gerrit.libreoffice.org/63747
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:39:35 +01:00
Noel Grandin
ecd6b4f373 remove unused enum AutoFormatLine
Change-Id: I8e39be5a5f2306121358eaaf07bb026c2f577bf3
Reviewed-on: https://gerrit.libreoffice.org/63744
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:38:17 +01:00
Noel Grandin
4d60a038c9 convert JumpToMarks to scoped enum
and remove unused JUMPTO_FRAME

Change-Id: Ic12350c66612a7be5f930d1cddd0481b397f3c53
Reviewed-on: https://gerrit.libreoffice.org/63746
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:37:12 +01:00
Noel Grandin
2a78a49508 remove unused SmTokenType values
Change-Id: Ie15425758f17bba3d088f3cd6925aec9fbf63c91
Reviewed-on: https://gerrit.libreoffice.org/63749
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:36:54 +01:00
Noel Grandin
667decbb4c remove unused ColTopBig/ColTopSmall
There once was code to implement this, mapped to
   KEY_UP/KEY_DOWN in combination with KEY_MOD2 | KEY_SHIFT
introduced in
    commit aa5a224ede
    Date:   Thu Sep 27 10:40:19 2007 +0000
    INTEGRATION: CWS swwarnings (1.140.102); FILE MERGED
but it was commented out and removed in
    commit 43a36b3698
    Date:   Mon Nov 1 02:50:47 2010 +0200
    Commented out code, bogus comments removed, some german comments
translated.

Change-Id: I67c1d1ed96b18d3bb8b20eae5994b476b07af31d
Reviewed-on: https://gerrit.libreoffice.org/63745
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:36:41 +01:00
Noel Grandin
49d074451c convert FieldDialogPressedButton to scoped enum
and removed unused EDIT

Change-Id: I1bd4ac135f280e19ffbf51364f406f8068130874
Reviewed-on: https://gerrit.libreoffice.org/63743
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:36:10 +01:00
Noel Grandin
54addc81de remove unused broadcast_type enum
Change-Id: I2939928e393ef2e306e840488053ca50957c10ce
Reviewed-on: https://gerrit.libreoffice.org/63742
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:35:57 +01:00
Noel Grandin
542ad7cb20 convert INetURLObject::PrefixInfo::Kind to scoped enum
and drop unused ALIAS

Change-Id: Ifc0c6aba681bb166c515380ebb1b0f45d232d2d2
Reviewed-on: https://gerrit.libreoffice.org/63741
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:35:26 +01:00
Noel Grandin
58bc1cba20 convert LineType to scoped enum
and remove unused LINE_HORIZONTAL

Change-Id: I39ee05b444b4da46758ff30176e041a02bee54e8
Reviewed-on: https://gerrit.libreoffice.org/63740
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:34:59 +01:00
Noel Grandin
fe39cd0df3 convert SalRGB to scoped enum
and remove unused values

Change-Id: Id10c18e832d54a6e530c3fe197b230d2d511d79c
Reviewed-on: https://gerrit.libreoffice.org/63739
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:34:34 +01:00
Noel Grandin
bab2753312 loplugin:unusedenumconstants in EEControlBits
(*) remove effectivly unused enum constants

(*) tweak the plugins heuristics some more to remove false+ in this enum

(*) twweak the python post-processing step to avoid a KeyError

Change-Id: I2943ec94c00f71dcd049f5c9ef33db259c005ba3
Reviewed-on: https://gerrit.libreoffice.org/63709
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:34:15 +01:00
Noel Grandin
2e6a38b7f0 improve function-local statics in dbaccess..filter
Change-Id: I64939ad4b6c53696e33300114db384abfe73f13f
Reviewed-on: https://gerrit.libreoffice.org/63702
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22 07:33:56 +01:00