Commit graph

404544 commits

Author SHA1 Message Date
Stephan Bergmann
5222dd86dd loplugin:loopvartoosmall
Change-Id: Ifd83cb180072304511ad8eb031dcf2a867e97e62
2017-02-25 10:10:02 +01:00
Zdeněk Crhonek
8d5086d571 add CHISQ.TEST,CHISQDIST,CHISQINV,CHITEST,SEARCH test case
Change-Id: Ib0fcb9756049bc741b21fb608e1985c1f7c6e7d6
Reviewed-on: https://gerrit.libreoffice.org/34631
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-25 08:19:05 +00:00
Markus Mohrhard
73f2944618 Revert "convert spell menu to .ui"
This reverts commit 51d5cb5de2.
2017-02-25 03:21:12 +01:00
Markus Mohrhard
c63ff2a769 xPoolHelper is empty in a clipboard doc
Found by the crashreporter:
http://crashreport.libreoffice.org/stats/signature/ScDocument::IsClipboardSource()

Change-Id: I3fb030921b653396deb46a9e98d30d5df9c9ce15
2017-02-25 03:20:47 +01:00
Tamás Zolnai
7a66f9491c ChartDumpTest: Convert test docs to use Liberation Mono font
Liberation Mono is a bundled, monospaced font, which
is better for testing, shows smaller differences.

Change-Id: If56597cede90fc81c722a69fd71e099d22a65d1f
Reviewed-on: https://gerrit.libreoffice.org/34618
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-24 23:26:02 +00:00
Bartosz Kosiorek
a1b1ed766d tdf#50916 Allow dynamically increase number of columns according to needs
Change-Id: I08b1d70b6aafb01738bb5dec3f4eafd7b21e6bb5
Reviewed-on: https://gerrit.libreoffice.org/33724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-02-24 23:15:48 +00:00
Markus Mohrhard
cffa23b8d0 fix crash in pdfimport
Found by the crashreporter:
http://crashreport.libreoffice.org/stats/crash_details/2eaeda85-849d-4098-b215-a8e64fe82089

Change-Id: I113f4dfc4a4f45511102c417d39fe15db6050daa
Reviewed-on: https://gerrit.libreoffice.org/34628
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-24 21:04:16 +00:00
Markus Mohrhard
ece3c97ca6 prevent crash in PaletteManager
Found by the crashreporter:
http://crashreport.libreoffice.org/stats/signature/PaletteManager::ReloadColorSet(SvxColorValueSet%20&)

Change-Id: I82c5e3f7588615700ec3b5540ac94e331df783bb
Reviewed-on: https://gerrit.libreoffice.org/34627
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-24 21:00:17 +00:00
Caolán McNamara
d1ef5f86a2 Updated core
Project: help  a43b8eb31d44f4a3193029f7593281152ed2e5f9

update helpids for .ui spell menu conversion

Change-Id: I89488bd75c33fb732e780c5ffc45888815c0615b
2017-02-24 20:59:55 +00:00
Caolán McNamara
51d5cb5de2 convert spell menu to .ui
Change-Id: I96a4b852fd396883385d5e2d43728dc8c2b20ce3
2017-02-24 20:52:41 +00:00
Eike Rathke
49e6d5e496 update to language-subtag-registry-2017-01-20
Change-Id: Ia62815e19b3414b6ba78c70ccb2520a0836b22c4
2017-02-24 20:59:33 +01:00
Eike Rathke
6db32fab2e adapt comment to reality
The code now does what the original questioning comment suggested.

Change-Id: I359c99a30d2e6822fe9164bb9f903876095c9f6f
2017-02-24 20:12:49 +01:00
Caolán McNamara
a14efb9b2c start to get make fuzzers working again
Change-Id: I36dc621e8a69bf6d22fdce62bb7de6c18208931d
2017-02-24 17:43:07 +00:00
Eike Rathke
9f77a73e2d grml.. and do that right
Change-Id: I71bc423bde1f7df576175120741c8a08100b08dd
2017-02-24 18:19:45 +01:00
Eike Rathke
7c6902cf8f replace a leftover OSL_DEBUG_LEVEL >1
Change-Id: Ic5e5e72a2c79e68752c3108de9f3722fbcb8e7b3
2017-02-24 18:15:14 +01:00
Tamás Zolnai
4b8cb3e3b9 ChartDumpTest: Add a minimal test showing text size issue
Change-Id: Iea0f7f6cfaee546c3478b936053659b3ecd27e6c
Reviewed-on: https://gerrit.libreoffice.org/34617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-24 17:14:43 +00:00
Stephan Bergmann
653a3c2599 loplugin:loopvartoosmall
Change-Id: Ic85a715e11bc1eac531fa23e8b4a9b6c6520b862
2017-02-24 17:41:52 +01:00
Varun Dhall
685767dbe7 Added Test for EditEngine - Copy/Paste using Legacy Format
Change-Id: I3153010f4e327abd2ef48bdefa50ade1c0ba2f81
Reviewed-on: https://gerrit.libreoffice.org/34552
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-02-24 16:41:12 +00:00
Stephan Bergmann
f21994e7a2 Make JVM -Xrunjdwp option work on macOS
I hope loading the jvm library as SAL_LOADMODULE_GLOBAL has no negative
consequences (at least, there is prior art in the LINUX case already).

Change-Id: If18b65bd96f7205fdf9fd41389e64e786c15af16
2017-02-24 17:00:28 +01:00
Miklos Vajna
58eac1105f vcl: add initial CppunitTest_vcl_pdfexport
Invoke the PDF export filter and then use the PDF tokenizer from
xmlsecurity to assert the contents of created PDF file. The testcase
fails with commit 6db0f1feb1 (tdf#106059
PDF export: create a reference XObject for PDF images, 2017-02-22)
reverted.

Change-Id: I90526fef41d9560ae447f586df766bc50a491c43
Reviewed-on: https://gerrit.libreoffice.org/34609
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24 15:49:15 +00:00
Caolán McNamara
3cc3dc176e hwpfilter needs a new filter for each document
setUp is called just once at the start of the sequence of loads
so we're reusing the previous import state which isn't what this
filter expects

This reverts commit 0af436083e.

Change-Id: Iae355ed6099086fd3cc1c79203786017507d4ed4
2017-02-24 15:48:52 +00:00
Caolán McNamara
3a74745367 vector::data seems more natural than &vector::front
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-24 15:48:51 +00:00
Caolán McNamara
c9126dfbab &front may not be null in empty vector case, but that's not true here anyway
Change-Id: I6cd89c7e081dada7fb7a179ecd8aa65e98ed13a9
2017-02-24 15:48:51 +00:00
Caolán McNamara
6ceaec7396 no need to take address of front()
Change-Id: Ib952e480c486f8ffeb6a4383a192edde005c3c4f
2017-02-24 15:48:51 +00:00
Khaled Hosny
8dc27a0bbf Always enable liblangtag
The license should not be an issue any more since liblangtag now has an
LGPL/MPLv2 dual licence.

Change-Id: I4dfffcccf5d710bd16b21c3254c1449ae041b8ab
Reviewed-on: https://gerrit.libreoffice.org/34511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-24 15:46:41 +00:00
Eike Rathke
2793561bb6 correct description
Change-Id: I830e81985243e7a552716ede163466bf7adfcd9a
2017-02-24 16:32:53 +01:00
Eike Rathke
5d9f7548bc a first stab against the note caption ownership mess
This should not change any existing behavior, but may help tracking down
what happens where and when. The final goal is to let ScCaptionPtr also
handle deletion of caption objects once they're unreferenced and guard
against dangling pointers and double delete, and/or to manage transfer
of ownership to the drawing layer. Further improvement to the structure
could involve a head data element so that the duplicated (and unused
except in head) mnRefs field could be eliminated and the walk simplified
when removing an element from the list.

Change-Id: Ifbb2fb1d9dc4d2594a1eae2a8489270dd1fe0d0c
Reviewed-on: https://gerrit.libreoffice.org/34616
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24 15:24:28 +00:00
Eike Rathke
860527e009 maybe try ROUNDSIG(...,9) ...?
Change-Id: Ib72c2776c54f905f369be756a4a14a25c3149616
Reviewed-on: https://gerrit.libreoffice.org/34615
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24 15:23:55 +00:00
Julien Nabet
41f95c4a35 Remove SC_DPOUT_MAXLEVELS limit in Pivot
by using vectors instead of fixed arrays

Change-Id: I4bd070e05ccc464c80722ffd05e70b7acac17d5f
Reviewed-on: https://gerrit.libreoffice.org/34408
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-02-24 15:23:32 +00:00
Mike Kaganski
237685fdfa Restructure sprm value definition using ispmd, fSpec, sgc, spra
... from [MS-DOC] documentation.
This also makes operand size explicit.

Change-Id: I5adb439a5b26f4692a2152433279b0baa77ed00a
Reviewed-on: https://gerrit.libreoffice.org/34612
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-02-24 15:12:15 +00:00
Mike Kaganski
2213bfefb3 Rename sprm ids to match [MS-DOC] documentation
Change-Id: Iab5b7c10c635dfdf832df3d0864939a7984282d1
Reviewed-on: https://gerrit.libreoffice.org/34599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-02-24 15:12:02 +00:00
Caolán McNamara
40e55cf24d add hwp fuzzer
Change-Id: I07fe351a182328f9ef98cb9866529637a6688c64
Reviewed-on: https://gerrit.libreoffice.org/34570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-24 14:04:58 +00:00
Caolán McNamara
71a84b69ae Resolves: tdf#106123 store and restore the PaM around the menu Execute
because the loss of focus in the current editeng causes writer annotations to
save their contents, making the pContent of the current EditMaps invalid

Change-Id: Ic01379291fa66dd58246d33287b18801f5da49c0
2017-02-24 13:58:48 +00:00
Katarina Behrens
6017732e0b gpg4libre: include also plain C headers from internal gpgme
Change-Id: Iddae7a3e664273b53a49450527f55814a9ef6f55
Reviewed-on: https://gerrit.libreoffice.org/34610
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-24 13:31:53 +00:00
Michael Stahl
bdef778d32 sw: re-add handling of Center footnote alignment
... that was erroneously removed from SwFootnoteContFrame::PaintLine().

Fixes the assert when loading tdf96579-1.odt.

(regression from f052855343)

Change-Id: I33549bea3e5954fc347b05aa713e5982cde401ec
2017-02-24 14:08:38 +01:00
Miklos Vajna
7737457558 xmlsecurity PDF verify: handle multiple startxref in the last 1024 bytes
Usually this is not a problem, but it's easy to construct a document
manually that contains multiple startxref tokens at the last 1024 bytes.
Make sure we read the last of those, not the first one.

This is triggered by an upcoming unit test for tdf#106059.

Change-Id: I94fbb5d407c4a03b7c2c6e207200127bb374e750
Reviewed-on: https://gerrit.libreoffice.org/34607
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24 12:45:51 +00:00
Tor Lillqvist
b61a2db728 Similar to 3386519e7e
Change-Id: I5ca799cf3a383c4a76f2ee81387f8040c176d046
2017-02-24 14:00:22 +02:00
Michael Stahl
21f8277c6d Revert "oss-fuzz runs under docker"
This reverts commit 210f594773.

Just disable the check if running inside docker

http://stackoverflow.com/questions/23513045/how-to-check-if-a-process-is-running-inside-docker-container

Change-Id: Ib11a2ccb7f0b2bd5e174b9b3adaf8a28474f2908
Reviewed-on: https://gerrit.libreoffice.org/34544
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-24 11:52:19 +00:00
Tor Lillqvist
3386519e7e Bin pointless macro
It is hard to see what the programmer thought the gain of using this
macro was.

It is not any shorter than its expansion. It is also repeated on every
one of the lines in question. If such a macro would be useful,
shouldn't there be some more global place for it, and shouldn't it be
used everywhere then? Why come up with that convention just for this
one file? Etc.

But yeah, I guess the programmer was guarding against mistyping
com.sun.star in some of the lines. As if all those lines would have
been manually typed in character by character anyway.

Change-Id: I2e4354363181ffa55e0a51832e9799f616a7c9f1
2017-02-24 13:41:01 +02:00
Caolán McNamara
b1a1bdec2d ofz: slow unit
Change-Id: I482a6c95810d03e47a5be18e6b45ee4db19f56e4
2017-02-24 11:38:33 +00:00
Caolán McNamara
c7cf94f70f clarify this code a little bit
no logic change intended

Change-Id: I620822e71386bae05312474423c22b84d8608cbd
2017-02-24 11:29:09 +00:00
David Ostrovsky
2f6f58a062 configure.ac: Add missing result message
Change-Id: Ib5d84e67d36e41d20e137ce96ce66f758b110198
Reviewed-on: https://gerrit.libreoffice.org/34596
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-02-24 10:55:08 +00:00
Caolán McNamara
f3ba1e9f8f rtfrow-crash.rtf throws a o3tl::divide_by_zero
from writerfilter/source/dmapper/DomainMapperTableManager.cxx

Change-Id: I69fca8376166850cdedbc7c2b3908d7336e8bed9
2017-02-24 10:53:59 +00:00
Noel Grandin
e146741ec9 better fix for tdf#103830
the first fix in commit 3a404ea870
did not take into account that this a multimap, not a map.

Thanks to Aron Budea for spotting that.

Change-Id: I86d2d2a9d6cb08fd3cee3965a5b787d5691f0352
Reviewed-on: https://gerrit.libreoffice.org/34604
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-24 10:50:21 +00:00
Marco Cecchetti
288d694ff6 LOK - Calc: Text is not visible in cell when entering numerical input
Problem
The issue occurs when you double click and enter a numerical input in
a cell which belongs to one of the front colums.

Findings
After a bit of investigation I detected that the problem shows up when
the spreedsheet width is increased by invoking
ScViewData::SetMaxTiledCol.
Indeed the problem occurs whenever the spreadsheet width is larger
than 2^16 twips.

Solution
By changing the type of some variables from sal_uInt16 to long in all
involved contexts, the problem disappeared.

Change-Id: Ia6c6c258b0644f03c897e7b4bcaded967f21537c
Reviewed-on: https://gerrit.libreoffice.org/34597
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-02-24 10:25:22 +00:00
Caolán McNamara
9124264578 coverity#1399161 the explicit Font::SetLanguage is unnecessary here
the new language is set from the font this is a copy of, and has
already been copied in the copy ctor

Change-Id: I7c0f1bab56aefc7b4e7e66660a16596fcfa48c2d
2017-02-24 10:19:36 +00:00
Caolán McNamara
30847af563 don't have to create SfxApplication if it doesn't already exist
Change-Id: I3ade4e2c2513f334217a85c676ada93c5ed683ff
2017-02-24 10:19:36 +00:00
Noel Grandin
48e83f7be2 makeAny->Any in cppuhelper..cui
Change-Id: Ia54e6e9b71df68bd04c304a0bb02da8ebac74420
Reviewed-on: https://gerrit.libreoffice.org/34603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-24 09:17:34 +00:00
Szymon Kłos
3422dfc1b6 Notebookbar: Better resize support
Change-Id: I0bb5a5600be60a68e53132f2c3c42f79c958b2b3
Reviewed-on: https://gerrit.libreoffice.org/34491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-24 08:58:58 +00:00
andreas kainz
c2a9e9abdc update notebookbar menu icon use a burger icon
Change-Id: I154e8f10270ec59b4e72cb48ea9f2777a06343d7
Reviewed-on: https://gerrit.libreoffice.org/34595
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-24 08:58:28 +00:00