git show -w is empty on this commit
Change-Id: Ifc139cf4557ae9c2664057d2ed87e020330d17c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109194
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This reverts commit 71ec214d75.
and partially 54b5e6b4e0
freeze/thaw functionality was added so no longer needed.
Change-Id: Iee29fa79bcebfd409fd3cea4f11cb1d48053daa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108509
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
When typing into a protected section (or other read-only area), the code
goes through SwEditWin::KeyInput(), which checks for HasReadonlySel(),
and calls into sw::DocumentContentOperationsManager::InsertString() in
the read-write case.
When typing via ExtTextInput (e.g. Online), then SwEditWin::Command()
called into sw::DocumentContentOperationsManager::InsertString() without
such a check.
The convention is to do a read-only check in the first Writer function
called by vcl, so handle this in SwEditWin::Command(), to have exactly 1
read-only popup on typing a character.
Change-Id: I7d002e7d76bffeb6f16750de735c5bbf13a7bba9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109186
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Selection listener is needed so it is possible to react when the
selection changes in the document.
Change-Id: I94e9da06b3ceedbad13dd203f690037f3eafdb13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108259
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
This change is needed so we can use the same data in GfxLink and
in VectorGraphicData. Currently the data needed to be duplicated,
which is less than ideal.
Change-Id: I79419921d09681fa8f0b1ac4bf8ea84199d4aae6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108440
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Without setting mbSelectAll properly the selection cursor
is converted to a SwShellTableCursor, which can't handle
if a selection is extended outside of the table.
Change-Id: Ibd43097ac782b9fc02ff818d3911ebcd20efbd21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109185
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109205
Tested-by: Jenkins
This avoids clang-cl
> In file included from core/connectivity/source/drivers/ado/Aolevariant.cxx:20:
> connectivity/source/inc\ado/Aolevariant.hxx(72,40): error: replace function parameter of type 'const rtl::OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
> OLEVariant(const OUString& us)
> ~~~~~~~~~~~~~~~~^~
which would make that OLEVariant ctor overload redundant with the existing
OLEVariant(std::u16string_view us);
overload, but with the OUString overload gone, implicit conversions from
OUString to OLEVariant would no longer work, e.g.,
> connectivity/source/drivers/ado/AColumn.cxx(184,76): error: no viable conversion from 'rtl::OUString' to 'const connectivity::ado::OLEVariant'
> OTools::putValue(m_aColumn.get_Properties(), sAdoPropertyName, getString(rValue));
> ^~~~~~~~~~~~~~~~~
Change-Id: I92a5cc29d9fd2a5ff1a951f79df64879d0f71743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109180
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
seeing as these are created from CreateScSubTotalDlg and that
is always called with a aArgSet containing a ScSubTotalItem
with a non-null ScViewData set
Change-Id: I1e3d243e4b00d54f9f5015a543556c39d6053f07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109069
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
this just changes the Get/Set methods, the constructor and internal
representation of Color is not changed.
Change-Id: Idb6e07cc08bbaa5bd55b6bd4b585e648aef507b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109074
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This is the second patch in the series.
When you start a new document, Writer compat setting
"Expand word space on lines with manual breaks
in justified paragraphs" is on.
Now, when saving and reloading it with LoadUserSettings disabled,
it is still the program default of "on", instead of "off".
So this one is slightly more dangerous because it will prevent
setting old behaviours for MULTIPLE settings which are
not listed in the UI.
(Anything that trusts that ConsiderWrapOnObjPos to indicate a
very old document.)
The fact that we are explicitly not loading ConsiderWrapOnObjPos
from the document should not imply that this document is an old one.
At this far point away from StarOffice 8, it is probably safer
to assume the document is new, not old.
P.S. I'm pretty sure the reset of ExpandWordSpace was a complete
error during a refactor.
(At that point, it was the only item that defaulted to true.)
The only scenario I can imagine is that at one point in time,
ExpandWordSpace was not part of the SvtCompatibilityOptions,
and so this would add it. But now it certainly is one of the
options, and so this pointless pre-init is simply overwritten.
Change-Id: Ibe160099839bcf40d5659f7d5246854c7c4fb5e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108546
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update helpcontent2 from branch 'master'
to 6d4dab0752d6a058ea6f57d079686c3bfbf888bf
- Use switches for Ctrl vs. Command on macOS
Change-Id: I03d2ee23802f1da02129f5f40852d231b94c16c0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109163
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Regression from commit d379d18666 (oox:
import WPS shape with text as shape with textbox, 2014-06-18), the
problem was that a textbox's shape + textframe are internally 2 sdr
objects, so once GraphicZOrderHelper knows the current shape should be
on top of a shape+frame pair, it should suggest a larger ZOrder.
This is necessary till there is no setter version of
SwTextBoxHelper::getOrdNum(), which would allow import filters to ignore
this complexity, but that would be a larger change.
Change-Id: Ibbb1bcd9301eb369f25f211120f62be7c59b0fd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109111
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Regression from commit 14a56533ff
(SmartArt Pyramid: Now lays out shapes, 2018-07-10), the added pyramid
algorithm by first centering the topmost children, then decrementing the
horizontal postion of each additional shape, with the end goal of having
0 horizontal position of the last children.
This means that simply avoiding the division in the 1-child case leads
to correct results, because in this case the only child is also the last
child at the sane time.
Change-Id: Ifd0027e9616b0909dbfde43e1555427b50de4dad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109161
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
this way, Jenkins executes this module on Windows and Mac as well.
Before I submitted this test, I ran
'make clean && make CppunitTest_sc_uicalc' on a Win machine
Change-Id: I5bb708e3b61f16c3bd53da2222f19f2b73742819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109106
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
its plausible that SfxViewFrame::Current() has returned null, use
pSh->GetDispatcher() instead protected by null check against pSh
Change-Id: Ibefdcabea09cb3a1a411678585af33a99f8a1c61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109084
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
SdrPageView::DrawPageViewGrid is called too for a ScDrawPage of a
RTL-sheet. In that case both the width of the SdrPage and the left
edge of the passed rectangle are negative. The x-values for drawing
the grid were wrong and a right-to-left sheet did not show the grid.
The patch adds a case distinction with correct x-values for case RTL.
Change-Id: I6d0c15bf7bbe8aff6ab2e72a440ba81f2e0e2281
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108989
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
While the struct is apparently modelled after a specific data format, all the
individual members are accessed by dedicated code, never via something like
memcpy.
Change-Id: I7eff8a251d9fa9f6d771cc425584b9765308d723
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109110
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The intent of this patch is to fix the crash reported at https://
bugzilla.redhat.com/show_bug.cgi?id=1913828 by reverting changes made to
cui/source/tabpages/paragraph.cxx in commit
849b837d1a and changing the change made to
svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx to use the
already available pointer to the current SfxViewFrame instead of calling
the SfxViewFrame::Current function again.
Change-Id: I0c440c576c2afe4fb98ed54d51d91ea16a7f902a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109152
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...in code introduced with 00140e3df4 "lok: send
chart line width updates". Falling back to zero is in line with the preceding,
similar
sal_uInt16 nLineTransparence = 0;
...
block (introduced with 3dc00a8de9 "handle line
dash in chart line panel"), but using o3tl::doAccess or o3tl::forceAccess might
be more appropriate.
Change-Id: I8c2286b386aa9052d1d2af0f9f25847829ca4df5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109081
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This reverts commit 9617bc9544 "WIN replace
clipboard update thread with Idle" plus follow-up commits
f5ab8bcbfd "WIN don't notify clipboard change with
SolarMutex" and c921f9bd64 "Release solar mutex
before using an apartment-threaded COM object".
The Gerrit Jenkins Windows builds had started to abort after timeout for almost
all builds now. Going back to before the youngest of the above three commits,
c921f9bd64 "Release solar mutex before using an
apartment-threaded COM object" did not improve things (see the
<https://gerrit.libreoffice.org/c/core/+/109100> "Test build #1, DO NOT SUBMIT"
chain, where three out of three of the Gerrit Jenkins Windows builds timed out).
But going back to before the oldest of the above three commits,
9617bc9544 "WIN replace clipboard update thread
with Idle", does look promising (see the
<https://gerrit.libreoffice.org/c/core/+/109155> "Test build #7, DO NOT SUBMIT"
chain, where three out of three of the Gerrit Jenkins Windows builds succeeded).
So the hope is that reverting all three commits brings back a green master,
allowing us to understand and fix the actual issue later.
Change-Id: Ie83ba742f216396b49f561d19c2cda7758740502
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109158
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Update helpcontent2 from branch 'master'
to 3a202a242eacd1bb7739686cc4803950cbe3d24f
- Update SF_Dictionary Help page
Improves text and adds new examples.
Change-Id: I17fca5debf0a0f4f952a3d624ba2a64cf1d596eb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109112
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to c825f67c94487cc177b515b8d13b78d013869348
- Basic error handling functions
- extra link to ScriptForge.Exception service
Change-Id: Id4842de06e7f45c2f5eec61f67ec1dfee9d8341b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109009
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to abc66a37199c42a8fe969e796e91d36b9565775f
- tdf#139498 update "Attributes" and "Find&Replace" help
This patch updates labels so that all Attributes in 7.2
are listed in this help page, and corrects some of the
explanations.
( shared/01/02100200.xhp ) (Attributes)
* Revise explanation of how to search for attributes, including
how to use "including styles" checkbox
+ add "Overline" attribute and explanation
* update labels and explanation for Case effects
* update label Scale -> "Character Scaling" and its explanation
* update label: "Split Paragraphs" --> "Do not split paragraph" and
improve explanation
* correction to "Individual words" explanation
* removed specification of Underlining types and Strikethough
types (because many more have been added, and they all work)
* improved explanations for "Outline", "Relief", "Shadow" and
"Page line-spacing"
* add <relatedtopics> section and embed to
"Find and Replace" and "Searching with Attributes"
* update to <h3>
This patch makes a general review of Find and Replace
( shared/01/02100000.xhp ) (Find and Replace)
* fix switch that prevented showing of header and explanation
for Calc and Writer
* change h2 to h3 for controls that are in a section to give better
visual impression of relationships among controls
* move notes to more appropriate places
* combined two notes that overlapped
* move position of "Comments" control for Writer
* update to <h1>,<h2>,<h3>,<note>,<tip>,<keycode>
Change-Id: I224eff872ffe3e584263bdc6da8bd6dfa3dbe2ff
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108995
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
