...which had been removed in 18bdf78e15 "Azul is
just another OpenJDK variant", when fixing the previously mis-classified Azul
JRE from "uses OtherInfo" to "uses SunInfo". But the IBM Semeru Runtime
(<https://developer.ibm.com/languages/java/semeru-runtimes/downloads/>) is
another arguably mis-classified case due to its java.vendor of "IBM Corporation"
(and where the
VENDOR_MAP_ENTRY<OtherInfo>("IBM Corporation"),
line in jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx might be relevant for
some other JRE from IBM; at least, that entry is present ever since the
introduction of vendorlist.cxx in 738e9b77b9
"INTEGRATION: CWS jl8").
So just generally support the bin/server/jvm.dll path here for "uses OtherInfo",
even though it should actually only be necessary for "uses SunInfo".
(See the mail thread starting at
<https://listarchives.libreoffice.org/global/users/2022/msg00246.html>
"[libreoffice-users] LibreOffice 7.3.3.2 Windows 64 bit seems not detect
AdoptOpenJdk JRE Windows 64 bit runtime".)
Change-Id: I3a4d02309b7c833c3cd32dc2dda4f4cb7b216693
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133827
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Nowadays the bin/find-unneeded-includes script is a better
solution for this problem
This essentially reverts the commits:
c716b3888e096c7e889f40e7eecb7e
Change-Id: I404a4b34176efaacf961605559af9de6d6cba10a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133540
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* Update translations from branch 'master'
to 87be4f00f4c2a9b269779ee4f1d6b2417a45a113
- update translations for master
and force-fix errors using pocheck
Change-Id: I6f0fe9f8928d5a663a14c9d21990e37f94ee18f6
Addresses this lint error:
> .../android/source/src/java/org/mozilla/gecko/gfx/SimpleScaleGestureDetector.java:146:
> Error: The logging tag can be at most 23 characters, was 31
> (GeckoSimpleScaleGestureDetector) [LongLogTag]
> Log.e(LOGTAG, "No gesture taking place in getFocusX()!");
Change-Id: I1d18fb3717ccea8dc36695bfef888d035efe8d55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133799
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Use `Cursor#getColumnIndexOrThrow` instead of
`Cursor#getColumnIndex` here, as suggested in the
`Cursor#getColumnIndex` doc [1]:
> Returns the zero-based index for the given column name, or -1 if the
> column doesn't exist. If you expect the column to exist use
> getColumnIndexOrThrow(java.lang.String) instead, which will make the
> error more clear.
As described in the `OpenableColumns` doc [2],
`OpenableColumns.DISPLAY_NAME` is one of the two
standard columns that must be supported:
> These are standard columns for openable URIs. Providers that serve
> openable URIs must support at least these columns when queried.
Addresses this lint error:
> .../android/source/src/java/org/libreoffice/ui/FileUtilities.java:139: Error: Value must be ≥ 0 [Range]
> displayName = cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Explanation for issues of type "Range":
> Some parameters are required to in a particular numerical range; this check
> makes sure that arguments passed fall within the range. For arrays, Strings
> and collections this refers to the size or length.
[1] https://developer.android.com/reference/android/database/Cursor#getColumnIndex(java.lang.String)
[2] https://developer.android.com/reference/android/provider/OpenableColumns
Change-Id: I946fcd32a905a4bb8c0527fc1199b9dcc52bccfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133798
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Addresses this lint error:
> android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java:253: Error:
> Overriding method should call super.onActivityResult [MissingSuperCall]
> protected void onActivityResult(int requestCode, int resultCode, Intent data) {
> ~~~~~~~~~~~~~~~~
>
> Explanation for issues of type "MissingSuperCall":
> Some methods, such as View#onDetachedFromWindow, require that you also call
> the super implementation as part of your method.
Change-Id: Iab2bdadae7a776e4f52d671a6fd47c1b8146b2a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133797
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
not one of mine for a change
Change-Id: Iaa4151f8fcb0b31d98514075473d2768fbadd69c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133810
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update helpcontent2 from branch 'master'
to 21955867dc01dbc9e897c585c3a85299eb8f36ad
- tdf#148444 corrections to Print Preview Bar and related pages
text/swriter/main0210.xhp (Print Preview Bar)
*change order of commands to match toolbar
+add <embed> to (new) Single Page Preview
+add "Jump to Specific Page" command (no icon exists)
+add Print command and icon
+add Close Preview command and icon
+add <embeds> to "zoom in" and "zoom out" icons
*refactor to <h1>
text/swriter/02/10040000.xhp
+ add this file for Single Page Preview, with icon table
text/swriter/02/10070000.xhp (Multiple Pages Preview)
+commit beginning with 0f337351 in 2013 accidentally removed
the <h1> line, now added back.
*changed description to match current behavior of command
+added More Options header
*refactor to <h3>
-remove colspan= rowspan=
*change image to .svg
*change image size to 1cm
text/swriter/02/10080000.xhp (Book preview)
*refactor to <h3>
*change image to .svg
*change image size to 1cm
text/swriter/02/10020000.xhp (Zoom out)
+add section to icon table
*refactor to <h1>
-remove colspan= rowspan=
*change image size to 1cm
*change image to .svg
text/swriter/02/10010000.xhp (Zoom in)
+add section to icon table
*change image to .svg
text/swriter/01/01120000.xhp (Print Preview)
+add link to Print Preview Bar page in description
-drop Related topics and link with incorrect label
*refactor to <h1>
Change-Id: I902fe42d7f0405e2cfe3600199f5ab3fcb7e459c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132610
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
by calculating and exporting adjustment values to avoid
of connector lines with bad turns overlapping the
connected shapes.
Change-Id: I615a20f3ba3c5d03ae73d87848dc41e9ecd29ae5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133635
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Paragraph of the anchoring point of the floating table
needs zero top and bottom margins, if the table was a
not floating table in the footnote originally, otherwise
docDefault (Standard) margins could result bigger vertical
spaces around the table.
Quasi regression from commit c46950fee1
"tdf#143583 DOCX import: fix lost empty paragraphs of footnotes"
(before this commit, empty paragraphs at the end of the footnotes
were removed by accident, which hid the real problem fixed now).
See also commit e11c51eefe
"tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes"
(Note: before this commit, only a single table was shown instead
of the eight tables of the eight footnotes.)
Change-Id: I4180a6f7d7c49faf0842637b23aa1c8c5680a76c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133752
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
that is used in the traditional code path, this will fix vcl RTL
scrollbars in otherwise LTR UI
Change-Id: I1451f7e17b93b0339ded6d33147df6415274ebfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133780
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Sharepoint uses properties like these:
"http://schemas.microsoft.com/repl/resourcetag"
"urn:schemas-microsoft-com:Win32CreationTime"
They aren't standard and don't match our own ucbprops namespace, and it
looks like they should be handled by an encoding to a name like
"<prop:Win32CreationTime xmlns:prop=\"urn:schemas-microsoft-com:\">"
Unfortunately WebDAVResponseParser::endElement() didn't do that when
handling a PROPFIND reply to get the property names.
This causes a crash when all properties are copied in
UniversalContentBroker::globalTransfer(), which is called by
SfxMedium::DoBackup_Impl() when the setting
"/org.openoffice.Office.Common/Save/Document/CreateBackup"
is in effect.
Change-Id: I2d6480bfd2f828b6e7fc431ba4b333d95ec12718
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133769
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
