Commit graph

476 commits

Author SHA1 Message Date
Jochen Nitschke
f7a75a66fa cleanup: remove unused Reference.h(xx) includes
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-02 19:01:24 +00:00
Stephan Bergmann
a3fd689663 Remove unused macros
Change-Id: Icc1f5dbe7bac1d80429cafda7e88061193dd137a
2016-03-08 16:05:22 +01:00
Rohan Kumar
856cf7115d tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionals
I removed OSL_DEBUG_LEVEL > 1 conditionals in order to
reduce debug levels.

Change-Id: Ia1890277aec8ba0b57e325564a107d7fe2f6e967
Reviewed-on: https://gerrit.libreoffice.org/23008
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-08 13:26:47 +00:00
Noel Grandin
0f8ec3036f [API CHANGE] add operator==/!= to UNO structs
this is useful now that we are storing UNO structs in std::vector

Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369
Reviewed-on: https://gerrit.libreoffice.org/22257
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-11 06:22:28 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Michael Stahl
9486dd0692 i18npool: why not document the state transitions
Change-Id: Ica5789dab22a49efb9e2da3a795e13aa7e2c4339
2016-01-21 19:42:57 +01:00
Michael Stahl
fefd1221be i18npool: handle non-BMP Unicode in cclass_Unicode::parseText()
The UTF-16 code unit limitation was mangling starmath import.

Change-Id: I087e5c5b7954799fdb73e7ee1a8d3d02669f8831
2016-01-21 19:42:56 +01:00
Stephan Bergmann
d01888302b tdf#82775: Make NumberFormatCodeMapper MT safe
Change-Id: I77f49f09ce9fe5897f78044c0522210978c904d1
2016-01-04 14:22:59 +01:00
Noel Grandin
60e61e4434 loplugin:unusedfields i18npool
Change-Id: I09dad8485f7a558dd389032a6052b88a8285afea
2015-11-20 15:07:05 +02:00
Noel Grandin
d9e6270392 loplugin:unnecessaryvirtual
update the plugin with lessons learned from the mergeclasses plugin and
re-run it

Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711
Reviewed-on: https://gerrit.libreoffice.org/20015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17 12:26:32 +00:00
Caolán McNamara
2d0341a23f coverity#1338596 Uncaught exception
Change-Id: Ic8b4c6a1718a10d0b9a5a99b069ef4e98de87518
2015-11-11 17:33:31 +00:00
Caolán McNamara
e660a05158 coverity#1338597 Uncaught exception
Change-Id: I1bcb4a70a2b2621a8718e5d4d0741e8eed3848cf
2015-11-11 17:32:54 +00:00
Caolán McNamara
2d30f347cc coverity#1338598 Uncaught exception
Change-Id: I22047ed53eb59716e3da7c6e799867a666d35921
2015-11-11 17:32:19 +00:00
Caolán McNamara
e9fcefe464 coverity#1338599 Uncaught exception
Change-Id: If1c2f5e8527855e8e537d082156bcd6582e50c58
2015-11-11 17:31:22 +00:00
Caolán McNamara
14e409188b coverity#1338600 Uncaught exception
Change-Id: I4a257a4eed1064a3fc09f6e2d37dbbc6be64a94c
2015-11-11 17:30:39 +00:00
Caolán McNamara
ce6eed613c coverity#1338601 Uncaught exception
Change-Id: I255273601fd460b22aa22e3e366dc040e0795a87
2015-11-11 17:30:09 +00:00
Caolán McNamara
9f90d98790 coverity#1338602 Uncaught exception
Change-Id: I81c71c02888e9c5cab28e77c1464dd5f6d4c1ee5
2015-11-11 17:29:26 +00:00
Stephan Bergmann
6a33fb16bd loplugin:nullptr (automatic rewrite)
Change-Id: I7af8d14bfe7337fea3f18dbbd41eb32e0f7ae331
2015-11-10 10:31:28 +01:00
Caolán McNamara
f24b5132eb coverity#1338234 Uncaught exception
Change-Id: Ice269b722e219ae7b51aa6ea11dea93cfd31f413
2015-11-06 09:20:56 +00:00
Noel Grandin
184637be60 com::sun::star->css in i18npool
Change-Id: I13a290cba0f38c79eb2d93148b972d3d931c3862
Reviewed-on: https://gerrit.libreoffice.org/19445
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-10-19 11:15:23 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Noel Grandin
7e776c0027 loplugin:unusedmethods
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 10:17:02 +02:00
Andrea Gelmini
a50539e2aa Fix typos
Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8
Reviewed-on: https://gerrit.libreoffice.org/18953
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 12:41:09 +00:00
Michael Stahl
9555d03c98 remove unused #include <sal/alloca.h>
Change-Id: I490841fd2c526e4ca6d6c94cc7b9dba318c932a1
2015-09-29 14:57:43 +02:00
Takeshi Abe
0a4c482a8a i18npool: tdf#88206 replace cppu::WeakImplHelper*
with the variadic variants.

Change-Id: I0381de7fde198df74556355984bdaba2ecdedd4b
Reviewed-on: https://gerrit.libreoffice.org/17768
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-18 07:12:26 +00:00
Noel Grandin
0ea54aed15 remove some unused defines
Change-Id: I85a9a2bc12681e13fc482374165ff9bd6858dc93
2015-08-03 11:12:31 +02:00
Noel Grandin
2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
Noel Grandin
95aad95fbe inline a handful of use-once #defines
Change-Id: Id2654555c4042f8c0bdbd6bab6507e705f08326b
2015-07-23 08:41:46 +02:00
Noel Grandin
e963a88912 formatting of public/private/protected section qualifiers
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 09:49:35 +00:00
Andrea Gelmini
420923ba76 Fix typos
Change-Id: Ie2bbe020fc6e3a4a4f913208c245f395849bb9ee
Reviewed-on: https://gerrit.libreoffice.org/16708
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:32:26 +00:00
Caolán McNamara
ac33fb8e74 coverity#1308466 Uncaught exception
Change-Id: I8b8c67ae0a6a14998852754ae938c137063b4851
2015-06-27 18:25:05 +01:00
Stephan Bergmann
10bd50c25d loplugin:cstylecast: deal with remaining pointer casts
Change-Id: Ifdfb96f77ee23a2aaa7200ecee01f957050a6700
2015-06-08 16:25:43 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Noel Grandin
35163715ea loplugin:staticmethods
Change-Id: Ie348778ea666c24e95e048386547f301083a0017
2015-04-09 10:13:18 +02:00
Noel Grandin
d1b27a1d9a loplugin:staticmethods
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-07 10:24:54 +02:00
Eike Rathke
cd528c3099 implement css::i18n::XCalendar4 and LocaleCalendar2 service, tdf#63230
Implementation only, new local date/time routines not used yet from the
outside in this step.
2015-01-26 18:12:10 +01:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
Stephan Bergmann
3b6ee58652 Remove unused BreakIterator_Unicode::wordRule
Change-Id: I8cde0dfd7b760d8075f53b9de8a8d3a81a57dc27
2014-10-15 23:04:36 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
Stephan Bergmann
381044bf28 i18npool: std::auto_ptr -> std::unique_ptr
Change-Id: I084e8dfd026d59374d92d9b4cb45d63af2aea470
2014-09-30 12:28:52 +02:00
Stephan Bergmann
d9645bf8a1 Prevent erroneous pick up of unrelated css::i18n::Maping
...from include/i18nutil/casefolding.hxx

Change-Id: I892a83b8e40dadcffc1b59eaa18bee2b782131f1
2014-09-11 12:53:25 +02:00
Stephan Bergmann
63bc11b81f Avoid name clash with generated C++ class corresponding to UNOIDL service
Change-Id: Id8201bc91c8e398b972b7294b8916d4ac76c787d
2014-09-11 12:37:10 +02:00
Stephan Bergmann
a610409292 Avoid name clash with generated C++ class corresponding to UNOIDL service
Change-Id: Ie76cab45f5fd609457b11cb3b9732cba2da3b023
2014-09-11 12:34:19 +02:00
Stephan Bergmann
91ba527a63 Avoid name clash with generated C++ class corresponding to UNOIDL service
Change-Id: I96582bf05787a30479d324ff8deb7cea758bb2c2
2014-09-11 12:31:47 +02:00
Matthew J. Francis
44ead04eb5 fdo#81272 Speed up break iterators
Change-Id: I7a45a61465f71a1cc6f583b9ffc68157d19e51fa
Reviewed-on: https://gerrit.libreoffice.org/11386
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-10 20:02:04 +00:00
Caolán McNamara
997d1387ab Revert "fdo#81272 Speed up break iterators"
hmm, make CppunitTest_i18npool_test_breakiterator fails after all

This reverts commit 693f72384e081429cddb29415276cc4d07b05645.
2014-09-10 16:39:48 +01:00
Matthew J. Francis
a34a8fca21 fdo#81272 Speed up break iterators
Change-Id: Idcd7de83ff7e551b350db0bf80e2ac78baa67686
Reviewed-on: https://gerrit.libreoffice.org/11374
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-10 14:10:16 +00:00
Isamu Mogi
4452ac2322 Fix hungarian prefix for calendars
Change-Id: I78b3c0a8d32610e86e09ab5ad6da6cc4e0395926
Reviewed-on: https://gerrit.libreoffice.org/9566
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:22:12 +00:00
Jens Carl
9e3cc6b474 fdo#68849: Add header guards to all include files
Added header guard to files in directories i18npool/, include/, and io/

Change-Id: I7ba5b5f0ffdf5dedb8fd40e8efa06936e7c23591
Reviewed-on: https://gerrit.libreoffice.org/9558
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-30 01:45:21 -05:00
Thomas Arnhold
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00