Commit graph

29 commits

Author SHA1 Message Date
Noel Grandin
1e8f0940e6 loplugin:constmethod in svx
Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb
Reviewed-on: https://gerrit.libreoffice.org/78396
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03 10:33:23 +02:00
Gabor Kelemen
3847676cf6 tdf#42949 Fix IWYU warnings in include/svx/[h-r]*
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9
Reviewed-on: https://gerrit.libreoffice.org/72534
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-22 08:56:11 +02:00
Maxim Monastirsky
1305aaefa4 Kill the useless PaletteManager "last color" thing
Change-Id: Iafd4677460bf6ee2cc5bb7cd3f67c2719865a151
Reviewed-on: https://gerrit.libreoffice.org/56360
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-25 01:55:12 +02:00
Caolán McNamara
b15244d526 move SvColorDialog to welded arguments
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a
Reviewed-on: https://gerrit.libreoffice.org/56162
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20 21:57:36 +02:00
Caolán McNamara
1f8d45c276 weld SvxColorTabPage
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c
Reviewed-on: https://gerrit.libreoffice.org/56111
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20 12:41:53 +02:00
Jochen Nitschke
9401c7c28a remove unused processfactory.hxx includes
and fix fallout

Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee
Reviewed-on: https://gerrit.libreoffice.org/52206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-01 12:11:26 +02:00
Caolán McNamara
7750df3d61 give color picker explicit parent
Change-Id: I73e9a29abd5d767b31850e9a6b1f2b8d757ee928
Reviewed-on: https://gerrit.libreoffice.org/51000
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09 17:03:42 +01:00
Caolán McNamara
6ddd8fcf5c Resolves: tdf#112680 start color picker with currently selected color
Change-Id: I939a0b88646b4654337505e985cceff883f09343
Reviewed-on: https://gerrit.libreoffice.org/42899
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-28 21:20:30 +02:00
Jochen Nitschke
febbad7263 cleanup unused css/frame/* includes
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12 13:05:38 +02:00
Caolán McNamara
64a708cba9 Revert "Reverts a commit series that cripple windows ci."
with addition of...

- svxlo-SvxColorListBox
+ svxcorelo-SvxColorListBox

This reverts commit db380aab10.

Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128
Reviewed-on: https://gerrit.libreoffice.org/30598
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07 21:04:50 +00:00
Norbert Thiebaud
db380aab10 Reverts a commit series that cripple windows ci.
Revert "SvxShadowTabPage::Construct was removed"
 f9a2c1c12e.
Revert "replace OColorPopup with SvxColorWindow"
 f300754bb1.
Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID"
 347c2c3345.
Revert "replace last ColorLB use with a listbox of colors"
 604b35bf55.
Revert "simplify, its just a vector of colors"
 351a97ce6b.
Revert "replace user draw with an Image of the color"
 df738e0f8c.
Revert "strip down to the used pieces"
 commit 08d6cd788f.
Revert "move now combined ColorLB to location of last user"
 a19b18ad7c.
Revert "fold ColorListBox and ColorLB together"
 a989a0b1f2.
Revert "move ColorListBox beside sole thing that uses it"
 760a198e69.
Revert "extensions leaks out details of Color Selector, patch it up"
 8bea644d61.
Revert "inherit FillAttrLB from ListBox not ColorListBox"
 d2ce812f1d.
Revert "unify color selectors"
 43bc303148.
2016-11-05 13:42:40 -05:00
Caolán McNamara
43bc303148 unify color selectors
Note: this removes the use of auto-color from writer's asian text grid, because
its always invisible as far as I can see in practice.

Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-04 17:14:26 +00:00
Caolán McNamara
6f11653287 Resolves: tdf#98097 no tooltip for colors in "Recent" colors area
cause the tip is the color name and that's not stored, so store
the name when we have one, generate a #rrggbb if there isn't one
and on loading the names, "repair" the names if the names didnt't
exist because this option didn't exist when the colors were last
saved

Change-Id: I33d373081e8a5a46ac585bc55fe449dba0519f99
2016-08-31 09:35:34 +01:00
Rishabh Kumar
571866eaba [GSoC] Rework of color tab
New Features -

1. Multiple Palettes in color tab.
2. Remember the selected palette.
3. Recent colors.
4. Custom colors.

Change-Id: I36a438a0c282059ddcbda35f934fcd90337fd451
Reviewed-on: https://gerrit.libreoffice.org/26868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-08-03 14:19:51 +00:00
Rishabh Kumar
7f262a4101 [GSoC] Fix recent colors in color popup widget
Save recent colors in user configuration.

Change-Id: I1637e9fe3150bd1892f72ff9df06dc2a7c3e1e9e
Reviewed-on: https://gerrit.libreoffice.org/27688
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29 14:52:56 +00:00
Rishabh Kumar
db8ee31829 [GSoC] Fix palette selection in sidebar/toolbar color widget
Remember palette selection after the popup is destroyed

Change-Id: Iecd7fd4aa89cf9d2d6842c5b544d037df6818aaf
Reviewed-on: https://gerrit.libreoffice.org/27474
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-25 09:22:12 +00:00
Noel Grandin
e9cded40c8 clang-tidy performance-unnecessary-value-param in svx
Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b
2016-04-11 15:12:10 +02:00
Markus Mohrhard
cf7db82262 handle new color picker correctly in chart sidebar
This implements the basics for that and implements it in the AreaPanel.

Change-Id: I6d9e5012bbcc2c953d478a09a839f35f2ef64c5b
2015-08-20 00:14:51 +02:00
Michael Stahl
5e6a0eed27 svx: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I512ed27ef812498e021e320259b1e0862969a10e
2015-07-24 10:58:54 +02:00
Caolán McNamara
5a308b1239 V801: Decreased performance
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
Caolán McNamara
efcdf9004d callcatcher: update unused code
Change-Id: I3010bdd736c15a086f3ce61cacbb34159f0b2abf
2014-09-18 14:12:21 +01:00
Tor Lillqvist
9de2ad3474 WaE: passing class rtl::OUString by value, rather pass by reference
Change-Id: Ie42cc9cbf13467d6c1644dc35e361250bd3a9533
2014-09-17 19:20:47 +03:00
Krisztian Pinter
93c4e3c934 Add recent colors
Change-Id: Id6b2239149bf7d0b3c9242efb7a72091e32c3384
2014-09-17 10:19:55 +02:00
Krisztian Pinter
b39f15cfcc Change vector<Palette*> to ptr_vector<Palette>
Change-Id: I1f2832235e8d2ea3517efdce809970ed5f1c6769
2014-09-17 10:19:52 +02:00
Krisztian Pinter
1bf3b9f2da Make color picker apply color immediately
Change-Id: I38695a43ced63bd5207b631a072231d81aa7e0f9
2014-09-17 10:19:51 +02:00
Krisztian Pinter
cfdefe488f Add loading .soc palettes
Change-Id: Ie0d084a70d9b135658840bb7529f2099a702d280
2014-09-17 10:19:41 +02:00
Krisztian Pinter
ecbbf4c7cf Change SvxColorWindow_Impl to use ComboBox for palette selection
Change-Id: I0fb9b46298f45bbdf9ae9198c145b9ea5e403bbf
2014-09-17 10:19:38 +02:00
Krisztian Pinter
ff17738a4a Add color picker to color palette
Change-Id: I651f485598ee57af815780e234031f101b63fa24
2014-09-17 10:19:37 +02:00
Krisztian Pinter
e3fcf5591e Add PaletteManager, refactor palette code
Change-Id: I7e30fc895834318514b51bc648d32aa6d297bfae
2014-09-17 10:19:34 +02:00