Similar to the way that GTK 4's native facilities for
video playback are used for the gtk4 VCL plugin, initially
added in commit
commit d0a527ec09
Author: Caolán McNamara <caolanm@redhat.com>
Date: Thu Feb 10 12:55:18 2022 +0000
first cut at using Gtk4 built in video playback
, implement media playback using QtMultimedia for the
Qt 6 based VCL plugins (qt6/kf6) via a new service
"com.sun.star.comp.avmedia.Manager_Qt".
Video playback with the mechanism used for qt5 no
longer works with qt6, as "qwidget5videosink"
that gets used on Wayland for qt5 wasn't ported
to Qt 6 and is unmaintained, s. the commit message of
commit 88d57cf241
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Sep 29 11:09:51 2021 +0200
qt6: Add a qt6 VCL plugin
for more details. Additionally, this also doesn't work
properly any more on X11/with the xcb Qt QPA platform, see
tdf#145735 comment 7.
Instead of using GStreamer directly, let Qt handle
the low-level stuff by using the QtMultimedia module [1]
instead.
This adds a new dependency on QtMultimedia.
For building, this requires installing the Qt 6 QtMultimedia
development headers (e.g. package `qt6-multimedia-dev`
on current Debian testing).
Except for WASM, the use of QtMultimedia is enabled by
default when building with autogen options `--enable-qt6`
or `--enable-kf6`, but can explicitly be disabled using
`--disable-qt6-multimedia`.
In tests with the qt6 VCL plugin on Debian testing, with a
sample presentation containing an embedded
video, attachment 145517 from tdf#120452, video playback
generally works for both, the xcb and the wayland
Qt QPA platforms:
* Video and audio are played as expected on the external
screen in presentation mode when using the presenter
console
* Video and audio playback work in non-presentation
mode by clicking on the video and using the controls
in the Impress sidebar (play, pause,...).
However, the following issues were observed with
the current implementation:
* There's an odd frame/margin around the video.
* In non-presentation mode, the placeholder
shown until the video gets started using the controls
in the sidebar is just an "audio icon", not a frame
from the actual video. (This might be related to the
fact that `QtPlayer::createFrameGrabber` currently
returns an empty reference.)
* At least on Wayland (issue not observed with
QT_QPA_PLATFORM=xcb so far), when using the presenter
console, video playback in the presenter console (i.e. on the
non-presentation screen) is unreliable: The video
sometimes shows, but sometimes doesn't. At least the
(more important) one on the presentation screen was
reliably shown in my tests, however.
Tested with git dev versions of qtbase
(as of commit 8d5e7d50d8dbf1ad79bd8ff9f6ef6028eba481c9),
qtwayland (as of commit 6f0ebd916f176f6fbe35af28caeb52b62768ac94)
and qtmultimedia (as of commit
264b7e8d7d5683252102b5e5149685c8b8a70c2d).
[1] https://doc.qt.io/qt-6/qtmultimedia-index.html
Change-Id: I29c3c7ded01c61b49b192fa5c313d8a92c942185
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167869
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to bfc9b74f251bd2aca3605732c30b61bd6715a7eb
- tdf#160382 Document new features in Slide Show Settings help page
In text/simpress/01/06080000.xhp
- Added additional index bookmark values to make the page easier to find.
- Remove screenshot because it does not represent current dialog options
- Updated the link to the embedded How to get section, to reflect changes to text/simpress/00/00000407.xhp.
- Added information for the
- Live-mode slideshow editing
- Buttons size
- Enable insecure WiFi connections
features.
- Added a heading to the description of the Download App option.
- Added Related Topics section.
In text/simpress/00/00000407.xhp
- Added TabUI instructions for accessing Slideshow Settings.
- Created a new section called "slide_show_settings" to allow multiple paragraphs to be linked.
In text/simpress/guide/presenter_console.xhp
- Add variable tag to heading so that the page can be easily linked from other pages.
Change-Id: I71a836cefd8f0aa176dfaec0d539f043b1e973c7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167824
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Access in the UI removed
Find the options under ooO.Writer.Comparison.IgnoreLength and IgnorePieces
Change-Id: Ic76277ba6838bf5cf858089303f4882bc9a7c2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167888
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
When /bin/sh is dash:
./configure: 35165: test: yes: unexpected operator
checking whether to enable breakpad... no
./configure: 35218: test: yes: unexpected operator
Causing HAVE_FEATURE_CURL not to be set to 1 and build to fail:
sw/source/ui/misc/translatelangselect.cxx:160:24: error: no member named 'TranslateDocumentCancellable' in namespace 'SwTranslateHelper'
160 | SwTranslateHelper::TranslateDocumentCancellable(m_rWrtSh, aConfig, m_bCancelTranslation);
| ~~~~~~~~~~~~~~~~~~~^
Introduced in:
5bf7c2fa57 ("Fix --disable-curl build", 2023-09-14)
Change-Id: Ifbc4bc1a7cde86101ff13b05ec7cee6836798605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167831
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
So that the grid isn't shown in the thumbnail.
This will need to be reverted later for cool#7406
Change-Id: I01fbc7ebc9e33a27fb866b7ea6dbaaac68ae8f9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167872
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 41130a39ad)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167826
Tested-by: Jenkins
On calc the native formula symbols were loaded once on start-up and
assumed to not change.
This adds a map language to symbols when LOK is active and chooses
the correct set of symbols on each call.
Change-Id: I821fb3ad4a06d764399e3fdf4a2ec628909312db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167870
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
(cherry picked from commit 421ef056cf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167825
Tested-by: Jenkins
dropdown part of the button
caused by commit I40cfc39501006146f7c6c04a1f3c7cf877c6f1c4
(tdf#161056 Show bullets used in document in bullets dropdown)
Change-Id: I215d7cb677825821917a4fd8c498deaaab9fc9b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167838
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
This was working for DOC already.
For DOCX, this was already enabled once with commit
f9982c2406 (tdf#58521 DOCX import: enable
ContinuousEndnotes compat flag, 2021-07-13), but then it was reverted
later with commit commit eeda1b35a6
(Revert "tdf#58521 DOCX import: enable ContinuousEndnotes compat flag",
2021-08-10), because of tdf#143456.
Enable it again, now that the section-based layout seems good enough to
handle larger number of endnotes, e.g. the 48 endnotes from tdf#143456.
Change-Id: Id221f31f9208e84db2c358546d4d6ceea991b6b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167881
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Create the `QAccessibleEvent`s passed to
`QAccessible::updateAccessibility` as local
stack variables instead of on the heap, to not leak
them, as `QAccessible::updateAccessibility` does
not take over ownership, i.e. doesn't delete them.
This is also what the example in the Qt doc [1]
does.
This fixes leaks reported by Valgrind, for example:
==104242== 416 bytes in 13 blocks are definitely lost in loss record 23,612 of 27,514
==104242== at 0x4840F83: operator new(unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==104242== by 0x186F6884: QtAccessibleEventListener::HandleStateChangedEvent(QAccessibleInterface*, com::sun:⭐:accessibility::AccessibleEventObject const&) (QtAccessibleEventListener.cxx:144)
==104242== by 0x186F8478: QtAccessibleEventListener::notifyEvent(com::sun:⭐:accessibility::AccessibleEventObject const&) (QtAccessibleEventListener.cxx:401)
==104242== by 0x61B2756: comphelper::AccessibleEventNotifier::addEvent(unsigned int, com::sun:⭐:accessibility::AccessibleEventObject const&) (accessibleeventnotifier.cxx:256)
==104242== by 0x61ADB50: comphelper::OCommonAccessibleComponent::NotifyAccessibleEvent(short, com::sun:⭐:uno::Any const&, com::sun:⭐:uno::Any const&, int) (accessiblecomponenthelper.cxx:127)
==104242== by 0xBAA46FB: VCLXAccessibleComponent::ProcessWindowChildEvent(VclWindowEvent const&) (vclxaccessiblecomponent.cxx:173)
==104242== by 0xBAA4285: VCLXAccessibleComponent::WindowChildEventListener(VclWindowEvent&) (vclxaccessiblecomponent.cxx:124)
==104242== by 0xBAA3BBC: VCLXAccessibleComponent::LinkStubWindowChildEventListener(void*, VclWindowEvent&) (vclxaccessiblecomponent.cxx:114)
==104242== by 0xD56C687: Link<VclWindowEvent&, void>::Call(VclWindowEvent&) const (link.hxx:111)
==104242== by 0xD56977E: vcl::Window::CallEventListeners(VclEventId, void*) (event.cxx:296)
==104242== by 0xD6C83A1: vcl::Window::ImplSetReallyVisible() (window.cxx:1328)
==104242== by 0xD6C846C: vcl::Window::ImplSetReallyVisible() (window.cxx:1344)
[1] https://doc.qt.io/qt-6/accessible-qwidget.html
Change-Id: I82af810f0c618ffd5c5e4c8f568f4b4358df5900
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167862
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
If a docx file contains a loop on the .rels files for headers and/or footers
the code would enter an infinite recursion while looking for embeddings.
Change-Id: I2122fd6b1677812f561e96a9511a61b0e938e94a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167784
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
since this is used in various performance sensitive places
Change-Id: Ibdce6bd0de458a5a970654a88b984aff49210ef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167863
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
In commits 6dd5a96e1e
(INTEGRATION: CWS unopkg1 (1.1.2); FILE ADDED, 2004-04-14),
19a10039a5 (INTEGRATION: CWS
unopkg2 (1.2.4); FILE MERGED, 2004-06-11), and
886715b6b6 (INTEGRATION: CWS
scriptingf7 (1.3.4); FILE MERGED, 2004-07-23), a hack was
introduced to allow empty substorages.
Later, in commits 0d6b24a721
(INTEGRATION: CWS tdoc3 (1.7.24); FILE MERGED, 2004-11-09)
and 5f4d17724f (INTEGRATION:
CWS scriptingf9 (1.6.2); FILE MERGED, 2004-12-23), that
hack was removed, but one place was kept, which is removed
now.
Change-Id: Iaaf46421ddbe942878ebe17ca1e585be9db5999d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167823
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
In sc/uiconfig/scalc/ui/tpviewpage.ui
- Updated extended tip for "Comment Indicator" to reflect the current appearance of the Tools > Options> Scalc > View dialog
Change-Id: Iff0d7b0c05d54099818816e6146bc678d06a1e32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167867
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to cbb8c2d8d957f8a4729b32ac098c8a88f72d797a
- tdf#160909 Update help page for Scalc View Options
In text/shared/optionen/01060100.xhp
- Added index bookmarks for new features
- Removed old comment.
- Updated "How to get" section to reflect current menu options.
- Updated help page to cover new options:
- Pointer
- Comment authorship
- Column/Row highlighting
- Edit cell highlighting
- Summary on search
- Removed the section describing the "Color" option because that option no longer appears in the "View" dialog.
In text/shared/optionen/01060000.xhp
- Added link and variable tags to the title, so that the page can be easily linked from other pages.
Change-Id: Ib738453b33efcded574576052b7add3cb6bb25c0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167463
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
I had skimmed the help file earlier, and concluded that { }
are used elsewhere to indicate optional paramaters.
However, there is --quickstart[=no], and -env:<VAR>[=<VALUE>]
which exactly match my optional addition.
Thanks Stéphane for pointing this out.
Also included are some other changes we made
to clarify the help wording in general,
so the documentation and the cmdline help are in sync.
We dropped
Files other than Impress documents are opened in
default mode, regardless of previous mode.
because:
-from an initial reading it doesn't convey any useful meaning.
-searching for other uses of "mode" in the file suggests it means
that prior --print/--convert-to/--view modes
no longer apply. This override of prior modes is true for all modes,
but only this argument tries to spell this out.
-it seems rather inconceivable that any user would attempt
to mix --show with any other arguments or more than one file.
Change-Id: I191e572506cf2b39ed6c9ff4ebaf66f258a176a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167633
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Vasily's commit aa5c6d1275
new ODF numbered list parameter loext:num-list-format
Internal LO format for list format is changed:
instead of placeholders like %1, %2, etc
we right now use %1%, %2%... Reason: for ODT documents,
having more than 9 levels there is ambiguity in "%10":
it is "%1" followed by "0" suffix, or "%10"?
It was introduced in 6.4.5 for DOCX support with
Vasily's commit 7459b9ecb5
tdf#116883: sw: support for lists level format string
Change-Id: I5962ed04c555356c6a3fc05ab7e036975d7eee40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167833
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
As soon as SetPrefix or SetSuffix are called,
any partially formed sListFormat is invalid (unless nothing changed).
ListFormat creates sPrefix/sSuffix as a convenience/compat item,
and changing it directly is NOT reflected in the sListFormat itself.
Trying to keep them in sync would be very complicated.
Any process that uses these functions OUGHT TO be doing it as
building blocks to eventually call SetListFormat(prefix, suffix, lvl),
at which point a proper sListFormat will be created.
Change-Id: I05f681c812ea5207cb8127b30dafbd543ffea219
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167832
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
After LO 7.4 (backported to 7.2.5) created this
function that manually identifies the Prefix/Suffix,
there was some work done to ensure
GetPrefix and GetSuffix were trustworthy in
LO 7.5's commit 835cda5612
Author: Justin Luth on Tue Aug 2 13:30:31 2022 -0400
related tdf#150197: use SetListFormat or SetPrefix/Suffix
GetListFormat DEPENDS on having managed prefix/suffix itself...
So, lets make sure we use and fix these functions in only one place.
make CppunitTest_sw_ooxmlexport21 \
CPPUNIT_TEST_NAME=testTdf156105_percentSuffix
Change-Id: I44c021a200ba45960e39983087c6af268751fbc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167792
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Jenkins
bug 156105's listWithPercents.odt is an example of a
properly defined ListFormat which contains a percent symbol
in the prefix and suffix, which looked fine in the document itself,
but was cut off short in the UI.
sw/qa/extras/ooxmlexport/data/tdf116883.docx is also an example,
which can be seen if you reduce the first entry to level 1
instead of level 2.
Level 1 is improperly defined as "1%>". This is invalid formatting,
so the entire thing should be considered a suffix.
MS Word also considers it to be a suffix.
This code segment still isn't completely comprehensive
because it won't properly parse "%1xyz%1%." and "%1xyz%10%."
but I'm losing patience.
There is still a potential problem with the
nInclUpperLevels calculation in case
a '%' is used as an in-between separator,
but that seems extremely theoretical and irrelevant to me.
IIUC, the main impact is that it shows some extra dots
in the bullets and numbering UI preview.
Change-Id: Ic1b8fbda62917ad4c7b88bf4fff136d72242f977
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167782
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Jenkins
In the same way that `vcl/Library_vclplug_gtk4.mk` does
it, set the `GTK4_CFLAGS` (which have the includes) via
`gb_Library_set_include`, not `gb_Library_add_cxxflags`.
This makes sure that they end up in the `INCLUDE`
section in `workdir/GbuildToJson/Library/libavmediagtk.so`
and thus end up in the IDE integrations as includes,
which makes Qt Creator's Clang Code Model find them
instead of showing an error
("gtkplayer.cxx:28:10: 'gtk/gtk.h' file not found").
See also this similar commit for more details:
commit 6a53832080
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Dec 17 15:35:58 2018 +0100
Use 'gb_Library_set_include' for GTK3_CFLAGS
Change-Id: I5ef01aff32073d37b8add0b2250402ccaa48b2dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167857
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
