Commit graph

451780 commits

Author SHA1 Message Date
Srijan Bhatia
ffe503b62f tdf#90978 add gap between the exit button and the right edge of the toolbar
Change-Id: I703f3bd21101daeaa58ce1c0659e275335f26727
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98601
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-13 00:35:02 +02:00
Olivier Hallot
dbece49a77 tdf#118148 Add extended tips to selectpathdialog.ui
also multiplathdialog.ui

Change-Id: I3e3baf1779d4f0c77ddec3829adbf4b06daa58e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98550
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-13 00:08:04 +02:00
Olivier Hallot
822783dc0e Remove pango markup from extended tips
After recommmendation by Caolán in
https://gerrit.libreoffice.org/c/core/+/98293

Change-Id: I254cf0ef7d9086cd51caf94d9886270827d78ed5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98593
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-12 23:18:22 +02:00
Mike Kaganski
840db2a536 Related: tdf#82184: consider installer language for UI list to install
If user has a language set as user locale, and installer is shown in that
language, it's likely that that language is needed for installation.

Change-Id: I37fb959291262b772ec8e1b35c687d64e0ee76a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98612
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-12 22:59:11 +02:00
Vasily Melenchuk
b88b681743 tdf#134570: doc import: list level format string fixed
List level placeholder is defined from char at defined
position, not only from position array.

Change-Id: I008e6711312435571f0d04544f6bfa42c1309f31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98500
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2020-07-12 21:56:15 +02:00
Noel Grandin
5653791d74 filter/pdf: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: Ieb73f2a75804013383195130e16472cc671a4ac8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98598
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12 21:50:05 +02:00
Caolán McNamara
220cebe66c drop unneeded include line
Change-Id: I3127c2ffe8d687098f516271581dbc68a65972ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98607
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 21:31:14 +02:00
Caolán McNamara
2f04d2c4d9 VerticalTabControl can be in private header
Change-Id: I95ee7a1477fb84eb9fcf2f70ab7d262b9eb47088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98606
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 21:30:57 +02:00
Mike Kaganski
c57865b796 tdf#134748: handle Kazakh language in langid_to_string
Change-Id: I8829597b7e90ea52dc4a4bdd88cd07730a0c4f12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98600
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-12 21:22:04 +02:00
Caolán McNamara
0b05a04f97 clarify what WantMouseEvent is for
and add tristate machine support that we also need

WantMouseEvent is if the first click in a browse cell that activates it should
be passed to the control that appears on click as if it was itself clicked on

primarily for the the CheckBoxController to toggle it immediately.
Rework to explicitly toggle the checkbox in that implementation rather than
rely on passing fake mouse click/release/tracking events.

seeing as the main dbaccess table design view doesn't auto-launch its listboxes
on clicking in a cell, but the sub create index dialog does, drop the auto-launch
in the index dialog to match the main table design rathern than add a feature
to weld::ComboBox to auto-launch the popup for that one solitary case

Change-Id: Ie3d3f2ecf55d3d5b0b02b85ca09a6ca64bb800e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98603
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 20:54:15 +02:00
Caolán McNamara
bcea211b66 move CheckBox to toolkit-only headers
Change-Id: Id1b2dd11bd0ebd9c88cf7e86d990a1990d760b2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98605
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 20:28:56 +02:00
Andrea Gelmini
fcadbd72c1 Fix typo in code
Change-Id: I3ec1df316299da647acb9865b710fc5db5a80f0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98488
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12 20:16:14 +02:00
Noel Grandin
74f4a1e4a8 filter/svg: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I6a049364726327d1be10f72174aced5bade271a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98571
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12 20:02:14 +02:00
Caolán McNamara
466e63ed69 m_pEntry may be null
Change-Id: I704ff31906437f0d998f3089cf1df43d29187e0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98604
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 20:00:44 +02:00
Olivier Hallot
66977fbfa2 tdf#118148 Extended tips in lingu compnents
Change-Id: I9bec436149f34b890884fefe44cd8a3d8420ce3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98551
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-12 18:26:34 +02:00
Andrea Gelmini
634d6441c0 Fix typo
Change-Id: I6e7adbf15e108d4a044a1b6a784687c20e721b7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98471
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12 18:22:11 +02:00
Andrea Gelmini
8611787aa3 Removed duplicated include
Change-Id: I8caa3f1be66ca8cf236e9ada8487ea81f45b1377
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98470
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12 18:21:32 +02:00
Andrea Gelmini
34fc69c7be Fix typo
Change-Id: Ib728bcd332400df7e6c5466387fcdbda97792382
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98489
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12 18:20:42 +02:00
Andrea Gelmini
7fc92da7ac Fix typo
Change-Id: Ifad92aedd6f72f837d1839638d9f76b92d0c29d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98585
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12 18:18:43 +02:00
Caolán McNamara
8328d84a0c weld CheckBoxControl
Change-Id: Iea057189ab17c1fdaf6663f1c328b9d288d97a18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98532
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 18:16:22 +02:00
Caolán McNamara
1663b961ce check if the "realhandler" is the tracking window
if the tracking window wasn't already found

Change-Id: Iadb42abcba615c1b55165450da6946a6129283ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98599
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 17:56:35 +02:00
Caolán McNamara
5c98c6a046 center check/radio buttons
Change-Id: Icae25573c09861e44a42c54daaeeebfec706bd37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98595
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 16:00:31 +02:00
Noel Grandin
6a9652b05c filter/storagefd: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I7329893b62a9fb511535f6caadcdb6e007aadfd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98580
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12 14:21:29 +02:00
Noel Grandin
58b4ea4486 filter/t602: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: Icf7829977f4225ec40a63f5f2b8cf23ab360e883
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98570
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12 14:21:06 +02:00
Caolán McNamara
acc1ba0614 missing trailing commas
Change-Id: I6a541d5c34f933a08f3ed48b23e85a18d7e36afe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98594
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 13:55:45 +02:00
Noel Grandin
d4ff756769 filter/xmlfilteradaptor: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I44392add5b0ed6d3184e4ecdd2e8da729a78169c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98569
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12 13:20:37 +02:00
Olivier Hallot
f821efb6e6 tdf#118148 Extended tips in editmodulesdialog.ui
Change-Id: I1dacc63149dbbf16668ed15635e466d3558f39d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98565
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-12 13:13:21 +02:00
Caolán McNamara
b050b7eeff update pches
Change-Id: I75602277a5a26b012a12f2c4f4b7ff5bb663b0b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98474
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 12:20:05 +02:00
Caolán McNamara
ec9b4bf1b6 cid#1465260 Unchecked return value
Change-Id: I0f4a71e4735bd5038b45a259bd5136ebcc4c66a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98572
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 12:19:34 +02:00
Caolán McNamara
535ce8116f cid#1465256 silence Uncaught exception
Change-Id: I1356f311b8eb71549ab9570ae7e568f52c301070
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98581
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 12:18:28 +02:00
Caolán McNamara
e203f47774 cid#1465252 Dereference null return value
Change-Id: I8884218bb93a5684fb8f0754013fa00215bbc002
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98578
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 12:18:02 +02:00
Caolán McNamara
bb99e03cf2 cid#1465253 Unchecked return value
Change-Id: I796fa775f6447801fa9e5f0eef023cf3b2ce8908
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98577
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 12:17:35 +02:00
Caolán McNamara
01fdee33a8 cid#1465254 Uninitialized pointer field
Change-Id: I256b55e55a9c1bf04f165a4b2de667881d714c59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98576
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12 12:17:00 +02:00
Tomaž Vajngerl
fbecbb6872 add test for editing of annotations (using .uno:EditAnnotation)
Change-Id: Ic798ab94bb63a3ae80882e77cf1582d875e27d4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98583
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-12 10:36:12 +02:00
Tomaž Vajngerl
e350318840 allow .uno:EditAnnotation also for Draw not just Impress
Change-Id: I0a0e7e3db3830e7f8a21b600249daffd28a253e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98582
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-12 08:06:23 +02:00
Olivier Hallot
10d42094e6 Update git submodules
* Update helpcontent2 from branch 'master'
  to d949d2a2013b810295294067aa8d45b95398c7e4
  - Housekeeping on XML
    
    Change-Id: I2459b37ae6f5ca20a377c3882d72cb08dc36abed
2020-07-11 22:32:09 +02:00
Caolán McNamara
9c8d3f32ad cid#1465255 Unchecked dynamic_cast
Change-Id: I564bcde3ee6a96307ae133e550888f41b610e904
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98575
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11 22:28:52 +02:00
Caolán McNamara
acaa81b626 cid#1465258 Uninitialized pointer field
Change-Id: Ie2646cecfcbf85cc2b24d06786ed9773fcbb7c56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98574
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11 22:28:36 +02:00
Caolán McNamara
a26351a17c cid#1465259 silence Arguments in wrong order
Change-Id: I67e82a3ec9128a486ef882f803c900b7c94a4529
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98573
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11 22:09:26 +02:00
Noel Grandin
629cdd66b5 filter/xmlfilterdetect: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: Ie16b3a2a11c4b5fee579c05d041d287d753ab2a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98567
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11 21:52:24 +02:00
Noel Grandin
24e1ea0b29 filter/xslt: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I7aae8e370a31a69f84dcbb4372077e5b8e0781fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98566
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11 21:51:58 +02:00
Caolán McNamara
976367d5d0 use accessible description before querying help
Change-Id: I1b5814566fd0750b92797cbf8581da0bee003630
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98568
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11 21:08:46 +02:00
Caolán McNamara
ddca00556c unoxml_component_getFactory doesn't exist anymore
Change-Id: Iaf1ba4753c481f92096afd062ef0dd6210f0628e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98579
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11 21:02:25 +02:00
Caolán McNamara
098e26eef7 use an aux modify handler instead of listening for VclEventId::EditModify
Change-Id: Ie35ad08a24b8b0c989806c4739bfe925fd9ab746
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98545
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11 19:55:14 +02:00
Noel Grandin
255d96a3e1 connectivity: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: Id678e4c51459429dd3953c0e54558d2c36e85eee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98562
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11 19:54:57 +02:00
Noel Grandin
4c12a78b00 desktop/deployment: create instances with uno constructors
See tdf#74608 for motivation

Change-Id: I11fe446e07e9a807c1267c4037922877d987003c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98472
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11 18:35:31 +02:00
Noel Grandin
92cccb9a7e dtrans/mcnttype: create instances with uno constructors
See tdf#74608 for motivation.

Also drop mutex, no need to lock when we're just constructing
something.

Change-Id: I5e845ae2fbb03fc4f38d0ee85b2061891fa0993f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98560
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11 18:33:18 +02:00
Noel Grandin
45c8885705 vbahelper: create instances with uno constructors
See tdf#74608 for motivation

Change-Id: I190d58fe45aa0b724b7239f5417bd0293d6dca80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98234
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11 14:54:24 +02:00
Olivier Hallot
a97224fe77 Update git submodules
* Update helpcontent2 from branch 'master'
  to 21609114dcc627949bca327ffe29b6df6e3b097f
  - Add title to Help page
    
    Change-Id: Ie43d7c4b68110bb31c7c21aa4ffbedc73b8c7ab9
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/98556
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-11 14:10:29 +02:00
Noel Grandin
cb444989d3 desktop/deployment: create instances with uno constructors
See tdf#74608 for motivation

Change-Id: I1559c29286c8877f5fc75cdb293403f5e5e5a538
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98473
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11 11:34:08 +02:00