part of the process of hiding the internals of SwPosition
Change-Id: Iecac4bd1e7836022182eba7c9b6d25bb827dbe5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141019
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I8b5bf3c38c87ec5117aeeef5307bde37aed0fc0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141015
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
to match the possible length of OUString
Change-Id: I561d1a7685d10fbd3b404ec91b486a9f5eb54932
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141013
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: Icc684368fb8517743f45eeb9ed83e37e598ea291
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141017
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Impress slides are exported to SVG via a metafile. In case shape text
has a string like "A\tB", that was exported as "AB", loosing the tab
character.
The relevant shape is exported as a metafile, with two text array
metafile actions (one for "A", one for "B") and the tab needs no
explicit action as both "A" and "B" has an explicit position. The SVG
contained no explicit position for "B", so the tab was lost visually.
Fix the problem by detecting when the doc model has a "\t" without a
matching metafile action and emitting the explicit position in that
case.
An alternative would be to use implWriteTextPortion() to write a <tspan>
for the tab, but that doesn't guarantee that the width of the tab in the
SVG is the same as in Impress.
Change-Id: Ie21bffce9d09194159e460fb28ab23fbefd52102
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141014
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
which is not unexpected for gtk where we don't use that label
Change-Id: Ieed1a6498cc9f40cbf6546f996f723ec9cd3aba9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141005
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
which results that we can rename "Save" to "Export" in pdf export dialog
Change-Id: I8186a9ea3d18bfb383b07ba54f2fd7a5cd71e7b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141004
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This reverts commit f3b73cce60.
lingucomponent_LanguageToolGrammarChecker_get_implementation is already
listed, so it was listed twice
Change-Id: I93eada023fa3cd9636abe5de5d6ecc9f50c8fd1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141000
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
If FORM_OnAfterLoadPage() is called, then FPDFAnnot_GetFontSize() can do
what we need.
Change-Id: I8aa3acbbda5c040f30b28db36f8b3332115b50e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140997
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
this is a similar case to:
commit 76a0b31706
Author: Caolán McNamara <caolanm@redhat.com>
Date: Fri Jan 10 16:49:19 2014 +0000
Resolves: fdo#35779 set the bg color of the editeng from the text shape
Change-Id: Ib7ca42426397346e5d7473b93e60f853e646a423
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140995
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
In Calc, when you drag a tab to move it, the arrows pointing to where the tab will be positioned are always in black, even in dark mode.
This patch fixes this issue.
Change-Id: I9079099c5ac1a8fb767eaa105cf8863e54d0ec3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140760
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
After latest changes we no longer need HarfBuzz buffer level
MONOTONE_CHARACTERS (which was needed to allow us to address individual
combining marks). With the default cluster level, combining marks get
the same cluster as their base and so we need not do any thing special.
I had to update testTdf139627 because this results in using ActualText
spans in the PDF, and PDFium support for them is lacking.
Change-Id: I0011072330fdbf409c30ff781fd3beaceae400f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140994
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>
to fit in 768px height (with default UI font size)
Change-Id: I2359e39205e7c13335a7ed266dd367cf45e5dcb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140988
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
just the immediate children of the supplied parent node
Change-Id: I79595fd940257615f0d012cb9a4556aea51d7db9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140986
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
In which combobox wherever it was added, the correct SfxItem will
be updated and at least when switching to another dialog tab and
back it will appear in the correct list.
(shouldn't tabbing out of the combobox already trigger that?)
Change-Id: I5aa78797dc24527c753c97d0357c3058271fa4d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140991
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
This was preventing doc event-macros from round-tripping.
Its original purpose was to "fix" doc->sxw export.
We no longer export to sxw, and the OOo bug doc exports fine to ODT.
Change-Id: I3a22db1b3bf9eaa2d64ac963f0c41892ba604e8d
--- https://bz.apache.org/ooo/show_bug.cgi?id=20540 ---
caolanm 2003-10-20 14:43:31 UTC
Setting a target for this bug, fixed for 2.0 in
portlaoisefilterteam16, and for 1.1.1 in droghedafilterteam15
MIB->CMC:
The document contains a Draw 4.0 OLE object, and the problem is the
import of that object in the Word filter.
During the import, the object's storage is copied into the document
storage (in SvxMSDffManager::CreateSdrOLEFromStorage, msdffimp.cxx,
5117). It now is contained in the document storage in the 3.o format,
but it is not in the child list of SvPersist.
Some time later, SvxMSDffManager::ImportGraphic calls a
SdrOLE2Obj::SetModel, that again calls SdrOLE2Obj::Connect. This
method notices that the object is not in the persist child list, and
for that reasdon call SvPersist::Move to add it to the list
(svdoole2.cxx, 374). Move converts the object into the OOo 1.0 format.
The destination storage is the object's storage, so the 1.0 format is
added to the existing 3.0 format, and the object storage remains an
OLE strorage and does not get a package. This situation is not
permitted and cannot be saved in the SXW format.
Change-Id: I24e55e5d47c3a7d10d6609ddbf9cc2374a47a37b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140950
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Changing row height showed the rows hidden
by AutoFilter, removing the result of the filtering.
Change-Id: Iecc8eb03ed563de126e7a376dad41a4ab2434f0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139883
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
With a LanguageTag::ScriptType a language tag appears in the
corresponding Western/Asian/Complex language list.
Change-Id: Ifa7fe784ebee33990b552e8df0f5555dc98667f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140974
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Similar to 07aa8138db
"tdf#151260: crash in SfxItemPool::SetDefaults
(reportdesign/ReportController)"
Since 9a444884c3
"tdf#150222 reporbuilder, set font for a text box crashes"
Change-Id: I07e5808f1d74a470d7c6f73160f8335254e033fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140940
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
All of the test cases in this suite use CPPUNIT_TEST_FIXTURE() directly,
so this is never called.
Change-Id: I709edb7f1a3fcbe9383396f9a48fba728da2a431
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140952
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
regression from
commit 258a8d133d
Author: Noel Grandin <noel.grandin@collabora.co.uk>
tdf#150034 very slow opening pathological chart
if nNewLen is < 10, we can get stuck in an infinite loop
because the calculation will not actually decrement nNewLen
Change-Id: I98920deaa087713c44531a7f6506d1d5d32b2e98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
OpenXMLFilterSettings has nothing to do with macros,
but was moved there in LO 6.3.
In 6.2 it was placed just before Extension Manager,
so that is where I returned it.
Change-Id: Id80b5984c785dc66e66aeb3215d8f1ef8c837442
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140739
Tested-by: Justin Luth <jluth@mail.com>
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
This patch makes the lines in the Special Characters dialog visible in dark mode. The Insert Symbols widget is also fixed with this patch.
Tested in gen, gtk3 and kf5.
Change-Id: Id1ee21557f2a0ea4ad8b60973d3de71e4d6d5d09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140759
Tested-by: Jenkins
Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
