Commit graph

416071 commits

Author SHA1 Message Date
Miklos Vajna
bfaf5740bb ios: blacklist newly pushed non-formatted files
Commit ed885a3cdb (iOS, do not use
different C compilers, 2017-11-23) was pushed directly and clang-format
wasn't used locally, either -- so just blacklist these new files.

Change-Id: Id6e39e68ac112494139e982ebcf7c32531184ec2
2017-11-23 09:57:44 +01:00
Caolán McNamara
6d5aeece56 move preventduplicateinteraction from framework to sfx2 consumer
Change-Id: I1388a88ba20b5cde65cd1d88694775b071a0dff6
Reviewed-on: https://gerrit.libreoffice.org/45099
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23 09:52:15 +01:00
Jens Carl
a8681f24d7 tdf#45904 Move _XScenarioEnhanced Java test to C++
Change-Id: Ibc99dc0d50e612bc6cdebaf5f9c5f828e5af859f
Reviewed-on: https://gerrit.libreoffice.org/45123
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-23 09:51:49 +01:00
Julien Nabet
d3c607b4bb Replace list by vector in incomingrequest (binaryurp)
Change-Id: Ic08f45f614cfa4643b55142e85e8eeac223abd82
Reviewed-on: https://gerrit.libreoffice.org/44893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23 09:32:45 +01:00
Tor Lillqvist
b469ba0e76 Don't warn about the installer unless we are building an installer
Change-Id: Iefb40baab9eeaab6923a0f95681466afc6dc6643
2017-11-23 10:05:25 +02:00
jan Iversen
ed885a3cdb iOS, do not use different C compilers
LibreOfficeKit.c was compiled with an xcode project and not like
all other sources. Changed to use clang with same switches as
rest of LO.

Separated resource generation in own makefile

Removed project LibreOfficeKit which was responsible for prelink.

Change-Id: Iaf9fbb4b652501af0b7f3643ed3efcc2ed93b611
2017-11-23 08:53:39 +01:00
jan Iversen
62da53e52c iOS, unicode not used in swift interface
remove include not needed

Change-Id: Ibad12f510a5d947ba2754dae192413852e63ab03
2017-11-23 08:53:39 +01:00
jan Iversen
8d18f1e98b iOS, cleaned unused parameter
Change-Id: Iac097d9a4578ef7dcb47006a422703ab06a8284e
2017-11-23 08:53:39 +01:00
Jens Carl
39c5ade7bb tdf#45904 Move _XSheetAuditing Java tests to C++
Change-Id: I057447494ff488546d43d2d3068a65d5c0d402e0
Reviewed-on: https://gerrit.libreoffice.org/45120
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-23 08:41:48 +01:00
Stephan Bergmann
0e2f224d07 An anonymous GraphicObject instance suffices here
Change-Id: I13156c3194497a2e554cdfe3a92a4ff83e0ea2f1
Reviewed-on: https://gerrit.libreoffice.org/45073
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23 07:54:33 +01:00
Stephan Bergmann
d7f2de780e put GraphicObject on stack instead of heap
Change-Id: Ia673a88a397d3a4e5c3b2ff31a60d04ea9e70d1f
Reviewed-on: https://gerrit.libreoffice.org/45062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23 07:54:05 +01:00
Stephan Bergmann
1f56087504 reduce scope of var
Change-Id: If9f4974fa1bf664b14c81e243f7dcd36abd3a1ce
Reviewed-on: https://gerrit.libreoffice.org/45061
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23 07:53:45 +01:00
Stephan Bergmann
c7e0f494bf use std::unique_ptr
Change-Id: I28e3f253cc8d0d35275c6aa3bcf17a93e2f0c631
Reviewed-on: https://gerrit.libreoffice.org/45060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23 07:53:30 +01:00
Julien Nabet
4ccddab6ef Replace some lists by vectors in vcl/headless
+use for range loops when loops included "std::list"

Change-Id: Ic261571ef64b1a710233ff949c4feeb3cc4756cd
Reviewed-on: https://gerrit.libreoffice.org/45109
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23 07:05:46 +01:00
Julien Nabet
3c508bf9fc Replace list by vector for m_aJPGs pdfwriter_impl (vcl)
+use for range loop just for the loop containing "std::list"

Change-Id: Ie30dc016e9a001d0bb4ecd31a75749093326e2f6
Reviewed-on: https://gerrit.libreoffice.org/45112
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23 07:05:03 +01:00
Julien Nabet
86cda9ab3c Revert partly 9d1f61a618
The use of erase/remove idiom is wrong here since "there can be multiple
registrations of the same listener"

See Stephan's comments in https://gerrit.libreoffice.org/#/c/44892/3/binaryurp/source/bridge.cxx

Change-Id: Iebf979ca25520392ba9de6439d5bf19b8e3446b2
Reviewed-on: https://gerrit.libreoffice.org/45104
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23 07:03:58 +01:00
Noel Grandin
a675428e34 TypedWhichId for sc constants
Change-Id: I25a07d84ae24fdd3b4fbd303beea755169eb9acb
Reviewed-on: https://gerrit.libreoffice.org/45084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23 07:02:59 +01:00
Noel Grandin
7a1c21e53f loplugin:simplifybool for negation of comparison operator
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23 06:59:31 +01:00
Stephan Bergmann
c24c32bf71 ofz#4366 Divide-by-zero
Change-Id: I3d0eb3bb6a69d09e71ce8bf91051f66e204eb0df
Reviewed-on: https://gerrit.libreoffice.org/45098
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-11-22 23:59:52 +01:00
Christian Lohmaier
54e1441949 cairo: drop no longer needed patch for android
Change-Id: I7f52cc8686556e21b9d2b5fdf43ce13307bcfac0
2017-11-22 23:15:02 +01:00
Michael Meeks
df755b1b39 Avoid using the hideous std::stack -> deque inside ::Interpret
dequeue loves to allocate and free memory crazily, vector is much saner.

Change-Id: Idcd2c1d693594f280ce94423161651502f25dc2d
Reviewed-on: https://gerrit.libreoffice.org/45086
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-22 22:08:02 +01:00
Michael Meeks
7ced0f88e0 Don't re-create the interpreter context for each row.
Change-Id: I272c9dc09806d47add26866f517e6ea07282c35f
Reviewed-on: https://gerrit.libreoffice.org/45087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-22 22:04:25 +01:00
Christian Lohmaier
dbe2747322 Updated core
Project: translations  a0c08eb77f9fd9e3b53f5c40abb554e83195fa27

update translations for 6.0 beta1

and force-fix errors using pocheck

Change-Id: Ie5900800b8c1f0e6064d00b2b028afcf51e84e20
2017-11-22 21:23:36 +01:00
qzheng
1783b33b52 tdf#112689 Replace chained O(U)StringBuffer::append with operator+
Change OUStringBuffer::append() to operator+.

Change-Id: I13232cb69b1d62acfcf15d5ba5a2d72e5ab5d253
Reviewed-on: https://gerrit.libreoffice.org/44703
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-22 21:18:41 +01:00
Eike Rathke
95da9d4c8f Follow our naming conventions, tdf#39593 follow-up
Change-Id: Iee95b5bf0dd42169447163a41be5b2aa1899e83c
2017-11-22 21:14:35 +01:00
Noel Grandin
5ee141ee2f tdf#113935 Switching from read-only to edit mode slow
Regression introduced by

    commit 389da66dfc
    remove unused uno::Reference vars

I'm guessing this variable keeps some kind of cache alive which prevents
us from re-parsing the PDF file when we switch to edit mode - which is
clearly what we are doing when I remove the line.

Change-Id: Iea2cf9640d876028a78806e717b930d4a063dc9b
Reviewed-on: https://gerrit.libreoffice.org/45093
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22 20:41:21 +01:00
Stephan Bergmann
72ef2b5d98 Make loplugin:unnecessaryparen warn about (x) ? ... : ... after all
...which had been left out because "lots of our code uses this style, which I'm
loathe to bulk-fix as yet", but now in
<https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have
caused an otherwise innocent-looking code change to trigger a
loplugin:unnecessaryparen warning for

  pFormat = (pGrfObj)
      ? ...

(barring a change to ignoreAllImplicit in
compilerplugins/clang/unnecessaryparen.cxx similar to that in
<https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in
loplugin:simplifybool consistent", which should also have caused the warning to
disappear for the modified code, IIUC).

Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2
Reviewed-on: https://gerrit.libreoffice.org/45088
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22 19:16:52 +01:00
jan Iversen
b140f92531 iOS, remove unused script.
This script is no longer used for the iOS development,
and in order to prevent anybody wasting time porting it,
it is nuked.

Change-Id: I46d520fa9b8aeabee78cfe1f02a25e4d1ead3d7f
2017-11-22 18:59:33 +01:00
Thorsten Behrens
c11c7c4765 fix build
Change-Id: Ibb83ef0bb6a304f2e78a669502a1bdd1f6dcc4bd
2017-11-22 18:17:36 +01:00
Thorsten Behrens
c8833fd9df gpg4libre: enable gpgme support for Windows and OSX
Change-Id: Ifa266e1c18a8a09cd5c815adc70d0236e00f72b5
Reviewed-on: https://gerrit.libreoffice.org/45092
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-22 17:58:36 +01:00
Thorsten Behrens
17c7d87643 gpg4libre: fix warnings
This code was not previously built on Windows

Change-Id: I9394907f143d862f40c95672f4e3398b65b7bd2c
Reviewed-on: https://gerrit.libreoffice.org/45091
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-22 17:57:56 +01:00
Thorsten Behrens
50a55d8620 gpg4libre: cleanup gpgme & add gbuild lib for gpgmepp
This moves the external to gpgmepp, since that's what we _actually_
link against; plus tons of enablement for Windows build, mostly
related to linker probs integration.

There's still no good way to build a DLL with autotools, so we fall
back to gbuild manual make, see also tdf#91480

Change-Id: Ifd8217ef58536612d2389d48e343db133a13fb9c
Reviewed-on: https://gerrit.libreoffice.org/44970
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-22 17:57:08 +01:00
David Ostrovsky
bafbaa3fed gpg4libre: build gpgme natively on windows
Change-Id: I0b77ba0c1b8f84affa483181e26a26beaf39e878
Reviewed-on: https://gerrit.libreoffice.org/42838
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-22 17:56:08 +01:00
David Ostrovsky
5f981d30e2 gpg4libre: build libassuan natively on windows
Change-Id: Id374ebc5ed70a1b4313dc74461524ac2b864b114
Reviewed-on: https://gerrit.libreoffice.org/42745
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-22 17:54:58 +01:00
Thorsten Behrens
4be15fdd79 gpg4libre: build libgpg-error natively on windows
Change-Id: I479b79a7626469169af582dc79c4e99dc4620546
Reviewed-on: https://gerrit.libreoffice.org/34530
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-22 17:54:02 +01:00
Caolán McNamara
1dcfa88c30 ofz#4386/ofz#4387 Abrt
Change-Id: I2ed1ade1322102a0d6ac623156b9d3c2084b481c
Reviewed-on: https://gerrit.libreoffice.org/45102
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22 17:53:28 +01:00
Dennis Francis
df5a0a62a3 clang-format on non-blacklisted file interpretercontext.hxx
which is a new header file introduced in calc formulagroup threading
work.

Change-Id: I8203ce392b36581f64457edb52449df3e84fb216
Reviewed-on: https://gerrit.libreoffice.org/45080
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-22 16:58:54 +01:00
Stephan Bergmann
2da9e68369 Help old GCC
Change-Id: I29093aa7975394b74952a4856632e8e657b33ae0
2017-11-22 16:40:57 +01:00
Caolán McNamara
366e35799d fuzzing: common case of embedded charts in docx
Change-Id: Idc6fdc221ce60e33e6b9fcb1689840dd96570d6b
Reviewed-on: https://gerrit.libreoffice.org/45089
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22 16:20:41 +01:00
Christian Lohmaier
74b77481b4 fix duplicate strings in notebookbar ui
Change-Id: I13ba872b8d3b8108384dc0fa4436ccaa1eedefa8
2017-11-22 15:56:26 +01:00
Caolán McNamara
129852d379 turn some eof checks to eof or error
Change-Id: I4592d7aa86c2cc2f420bccc622ffb95aa5cefa17
Reviewed-on: https://gerrit.libreoffice.org/45077
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22 15:55:55 +01:00
Caolán McNamara
97f087f4b2 ofz#4381 Divide-by-zero
Change-Id: I608ea751cec11935f37b625ebde0798f8887e225
Reviewed-on: https://gerrit.libreoffice.org/45081
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22 15:55:17 +01:00
Arkadiy Illarionov
0c358f71e2 Modernize benchmark-document-loading script
- use argparse instead of getopt
 - use with statement for opening files
 - refactor writeReport function to reduce copypaste
 - various fixes to make code more pythonic

Change-Id: I6569dfc856040e1e75b550135f4092cc27bef7f5
Reviewed-on: https://gerrit.libreoffice.org/43644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-22 15:19:43 +01:00
jan Iversen
7329b4423c cpuid is only for x86 processors.
clang for macOS did not like cpuid when compiling for arm cpu.

Change-Id: Iede658a524e5c3e1aa2d33137ed399679b021987
2017-11-22 14:49:31 +01:00
Christian Lohmaier
57768926f3 add missing context to translatable strings in .ui file
Change-Id: I52f01046ccc1da8aec483766371e12fe06c82b8a
2017-11-22 13:33:38 +01:00
Caolán McNamara
df2e78f1a8 replace check of eof and GetError with good
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291
Reviewed-on: https://gerrit.libreoffice.org/45076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22 13:33:46 +01:00
Caolán McNamara
2161d04688 drop duplicate method
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12
Reviewed-on: https://gerrit.libreoffice.org/45075
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22 13:33:25 +01:00
Caolán McNamara
041e1ba318 good() includes !IsEof() already
Change-Id: I6eddd347333638c0a8ea924e6062f8e4d379a20e
Reviewed-on: https://gerrit.libreoffice.org/45074
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22 12:51:14 +01:00
Noel Grandin
3fbbd74b7b loplugin:flatten in svx
Change-Id: Idc4d0186ecc6f0722c2b1358486a2430f037ae29
Reviewed-on: https://gerrit.libreoffice.org/45036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22 12:15:38 +01:00
Yousuf Philips
4b7490fe49 tdf#113880 a11y: improve accessibility of table background tab
Change-Id: I978340f88a8e007dbf080113a933063c5546fd51
Reviewed-on: https://gerrit.libreoffice.org/45011
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-22 12:05:05 +01:00