Commit graph

56 commits

Author SHA1 Message Date
Shivam Kumar Singh
03685b1ab8 tdf#96505 Get rid of cargo cult "long" integer literals .
In some places the integers end with L which denotes that the number is in long long format.
This representation was not required .

Change-Id: Ia8ae328ee943780ccbfb7ce15013f3ac0365a3db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86842
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-04 18:27:25 +01:00
Andrea Gelmini
40b9e26fe2 Fix typo
Change-Id: Ia26d1d8fbeafe936b2b52919188093cb6729e7eb
Reviewed-on: https://gerrit.libreoffice.org/75585
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-14 22:50:27 +02:00
Gabor Kelemen
54515a6a01 tdf#42949 Fix IWYU warnings in salhelper/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and only for files that are actually compiling

Change-Id: I70357eade9552984fdb3b7590f1e8237a02a7d1d
Reviewed-on: https://gerrit.libreoffice.org/65650
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-09 08:41:50 +01:00
Andrea Gelmini
161a366356 Fix typos
Change-Id: I5437180fd019ec3b9e2ccaa245b852f37cc091cd
Reviewed-on: https://gerrit.libreoffice.org/63400
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-15 11:47:38 +01:00
Stephan Bergmann
c5483edae0 Drop workaround for old MSVC that no longer appears necessary with MSVC 2017
The comments talk about unspecific "compilation and/or linking errors" with MSVC
2008 and 2013, but building with latest MSVC 2017 at least works fine now, so
assume the workaround is no longer needed.  (Theoretically, external code being
compiled with older MSVC could run into problems now, but lets take that risk of
becoming slightly build-time incompatible here.)

Change-Id: I9e20be355c765c3a881502773963a61305eb00f3
Reviewed-on: https://gerrit.libreoffice.org/60135
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07 20:07:45 +02:00
Gabor Kelemen
d1a19ef614 tdf#42949 Fix IWYU warnings in include/salhelper/*
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Iaef3e980a96e8a831458e42540795b922bec5ab4
Reviewed-on: https://gerrit.libreoffice.org/58810
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-10 14:13:16 +02:00
Stephan Bergmann
ba26314403 salhelper: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)
...by removing explicitly user-provided functions that do the same as their
implicitly-defined counterparts, but may prevent implicitly declared copy
functions from being defined as non-deleted in the future

Change-Id: I58b1b41823fa9eb5f37187272e38a2df80c48afb
Reviewed-on: https://gerrit.libreoffice.org/58103
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27 08:25:28 +02:00
Andrea Gelmini
a3ecd60aa0 Fix typos
Change-Id: I8758872f6a5270de3f9b9dea750b9d40c7a446db
Reviewed-on: https://gerrit.libreoffice.org/57800
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2018-07-24 08:21:32 +02:00
Stephan Bergmann
6ebc026e34 salhelper::SingletonRef copy ctor is broken, mark as deleted
If that (implicitly defined) ctor had ever been used, it would have failed to
increment m_nRef, so could have caused m_pInstance to be deleted too early.  So
better mark it as deleted.  (LO itself apparently didn't call it.  If 3rd party
code would want to call it after all, it could be changed from deleted to
properly user-provided, incrementing m_nRef, in the future.)

The implicitly defined copy assignment op happens to already do the right thing,
and /is/ used, e.g., during

>         m_aNode = _rhs.m_aNode;

in DriversConfig::operator= (connectivity/source/commontools/DriversConfig.cxx).
Mark it as defaulted to avoid -Wdeprecated-copy with GCC trunk towards GCC 9.

Change-Id: I527123d9de837c311d30a270feb09dc173d9f411
Reviewed-on: https://gerrit.libreoffice.org/56512
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-27 10:57:59 +02:00
Noel Grandin
5dd762ddc1 hold MetaAction by rtl::Reference
instead of yet another private implementation of manual reference
counting

Change-Id: Iefb1d2e595e45a2dfdc3be54e1c51b64afeaf9d8
Reviewed-on: https://gerrit.libreoffice.org/52753
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-12 12:24:28 +02:00
Andrea Gelmini
9ec6f974a3 Fix typos
Change-Id: I4f15a41b7a67abe9f2c45b6004948decd58a8360
Reviewed-on: https://gerrit.libreoffice.org/48832
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-29 15:33:05 +01:00
Andrea Gelmini
8efd39be74 Fix typos
Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f
Reviewed-on: https://gerrit.libreoffice.org/46599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19 07:19:35 +01:00
Stephan Bergmann
189abcf0db loplugin:includeform: UNO API include files
Change these back to consistently use the "..." form to include other UNO API
include files, for the benefit of external users of this API.

Change-Id: I9c9188e895eb3495e20a71ad44abfa2f6061fa94
2017-10-23 22:22:50 +02:00
Andrea Gelmini
08c1acee80 Fix typos
Change-Id: Iba6b13871222d591bce49d04990e7c85ff154cce
Reviewed-on: https://gerrit.libreoffice.org/38915
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-18 21:10:42 +02:00
Chris Sherlock
a607c1dedc salhelper: typo in dynload.hxx
Change-Id: I06d0cd4c7986a59f54102f945a560f710887ad8b
Reviewed-on: https://gerrit.libreoffice.org/38514
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-16 16:50:14 +02:00
Chris Sherlock
3c354ea9ed tdf#43157 - salhelper: convert from OSL_ASSERT to assert
Change-Id: I8691a627bbf78ce83db595053d6e254557641408
Reviewed-on: https://gerrit.libreoffice.org/38506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12 12:33:20 +02:00
Caolán McNamara
d0069e5189 add COVERITY_NOEXCEPT_FALSE
to markup dtors that coverity warns might throw exceptions
which won't throw in practice, or where std::terminate is
an acceptable response if they do

Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4
Reviewed-on: https://gerrit.libreoffice.org/38318
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06 14:15:43 +02:00
Chris Sherlock
97eb00c75e revert OSL_ASSERT changes
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07 17:03:35 +10:00
Chris Sherlock
85c7782eb8 tdf#43157: convert salhelper from OSL_ASSERT to assert
Change-Id: Ibbb8cf124b79626e89938a79f40f8ee714af8e86
2017-05-07 07:55:23 +10:00
Chris Sherlock
3961387192 salhelper: change oslCondition to osl::Condition
Condition is deprecated already, but there is no need for the
us to use the low-level C-API, when in fact there is a C++ fascade
that calls on this via the C++ abstraction, osl::Condition.

This will make it much easier to switch to using std::condition_variable

Change-Id: Ia362666ff241293e143de0fa1dc0bc3a990bef82
Reviewed-on: https://gerrit.libreoffice.org/35388
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18 08:24:25 +00:00
Stephan Bergmann
6cb9e6dad7 Remove redundant 'inline' keyword
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03 20:55:50 +00:00
Andrea Gelmini
bcb402298f Fix typos
Change-Id: I5e3c9683741ddc66283008c20794be5c2b2bc53f
Reviewed-on: https://gerrit.libreoffice.org/34804
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03 06:56:42 +00:00
Noel Grandin
2670ca3fc5 a whole bunch of SAL_WARN_UNUSED
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6
Reviewed-on: https://gerrit.libreoffice.org/33693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31 05:32:03 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Stephan Bergmann
4500e89f7f New loplugin:dynexcspec: Add @throws documentation, salhelper
Change-Id: Icd2a5dd5602cdf9cb4435bfcb4fe355689677fbe
2017-01-19 18:03:16 +01:00
Andrea Gelmini
c7114b66bd Fix typos
Change-Id: I7000efdb7276053c16de992fa8f9a4e614ecb3e2
Reviewed-on: https://gerrit.libreoffice.org/29434
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03 08:59:34 +00:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin
eb1afabe91 use NULL instead of nullptr in external facing code
Change-Id: I9f0846f06e0b42af841d575de5196fae78840c53
2016-06-08 10:32:38 +02:00
Noel Grandin
4bdbfdd642 fix release in ODynamicLoader
otherwise, if the refcount goes to zero, we delete the object,
and the static pointer is now pointing to freed memory.

Change-Id: I0cdd303590e4e70797bfddb8b403db4d831aab04
Reviewed-on: https://gerrit.libreoffice.org/26045
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-08 07:32:49 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Stephan Bergmann
4a1edf626a More loplugin:nullptr automatic rewrite (within templates)
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
2015-12-10 17:34:31 +01:00
Stephan Bergmann
0813839682 Missing includes (for NULL)
Change-Id: Id2359f6ff4bddb2afbc0b346e17cd858f00179e3
2015-11-10 13:14:21 +01:00
Stephan Bergmann
de63cac20f loplugin:nullptr (automatic rewrite)
Change-Id: If341fc7d18bb6f07d76dd259f5dd77b447c93566
2015-11-10 10:31:35 +01:00
Stephan Bergmann
b190574b6a tdf#84323: Make osl::Thread::wait more readable
Change-Id: I33eb6970050a103404344c7f16dd33349c154347
Reviewed-on: https://gerrit.libreoffice.org/15018
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-08-17 15:37:22 +00:00
Noel Grandin
e963a88912 formatting of public/private/protected section qualifiers
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 09:49:35 +00:00
Noel Grandin
ba233e87ef remove unnecessary parenthesis in return statements
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
Stephan Bergmann
cfa3d6e562 loplugin:deletedspecial
Change-Id: I28d39fc455560f0ad89390bd463e0fa470dde439
2015-02-07 12:36:01 +01:00
Stephan Bergmann
846d340d6a Deprecate salhelper::SimpleReferenceObject
Change-Id: I0721c0b620a7de994d71752034daeeb4d00659f7
2015-02-05 16:54:10 +01:00
Riccardo Magliocchetti
2c1bf30bda More iwyu suggested headers removal
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was
detrimental to loplugin:unreffun

Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
2014-11-18 10:32:40 +01:00
Michael Stahl
e9a7ff9880 salhelper: include-what-you-use cleanup of public headers
Change-Id: Ie778e541cecadeefc5ee5f30af9577a00c870a58
2014-11-17 11:06:53 +01:00
Noel Grandin
fbf3aa391b spelling: instanciated -> instantiated
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-08 11:02:55 +02:00
Noel Grandin
ed75aa2719 create clang plugin to warn about C-style casts
We don't like C-style casts in our nice C++ code

Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d
Reviewed-on: https://gerrit.libreoffice.org/10367
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-07 02:42:30 -05:00
Noel Grandin
0c6c66b64a remove IReference
now that it is unused

Change-Id: I95d9f4cc50114dd9f9c9f5d095372766f44b3094
2014-07-14 11:07:47 +02:00
Noel Grandin
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
Pedro Giffuni
820a29950b Many spelling fixes: directories r* - z*.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.

(cherry picked from commit 28206a7cb43aff5adb10f8235ad1680c3941ee3e)

Conflicts:
	include/osl/file.hxx
	include/osl/pipe_decl.hxx
	include/osl/socket.h
	include/osl/socket_decl.hxx
	include/sal/main.h
	include/svx/dbaexchange.hxx
	include/svx/dlgctrl.hxx
	include/svx/msdffdef.hxx
	include/svx/sdr/contact/objectcontactofpageview.hxx
	include/svx/svdpntv.hxx
	include/ucbhelper/content.hxx
	include/ucbhelper/interceptedinteraction.hxx
	include/ucbhelper/resultsethelper.hxx
	include/unotools/sharedunocomponent.hxx
	include/unotools/viewoptions.hxx
	include/vcl/pdfwriter.hxx
	include/xmloff/txtparae.hxx
	include/xmloff/uniref.hxx
	rhino/rhino1_7R3.patch
	rsc/inc/rscrsc.hxx
	sal/inc/osl/conditn.h
	sal/inc/osl/security.h
	sal/inc/osl/semaphor.h
	sal/inc/osl/semaphor.hxx
	sal/inc/rtl/string.hxx
	sal/inc/rtl/tres.h
	sal/inc/systools/win32/StrConvert.h
	sal/osl/os2/file_path_helper.h
	sal/osl/os2/file_path_helper.hxx
	sal/osl/os2/file_url.cxx
	sal/osl/os2/file_url.h
	sal/osl/os2/makefile.mk
	sal/osl/os2/pipe.cxx
	sal/osl/os2/process.c
	sal/osl/os2/profile.c
	sal/osl/os2/socket.c
	sal/osl/os2/system.h
	sal/osl/unx/asm/interlck_sparc.s
	sal/osl/unx/file_url.cxx
	sal/osl/unx/signal.c
	sal/osl/unx/system.h
	sal/osl/w32/MAKEFILE.MK
	sal/osl/w32/interlck.c
	sal/osl/w32/module.cxx
	sal/osl/w32/security.c
	sal/qa/buildall.pl
	sal/qa/osl/file/osl_File.cxx
	sal/qa/osl/module/osl_Module_Const.h
	sal/qa/osl/mutex/osl_Mutex.cxx
	sal/qa/osl/pipe/osl_Pipe.cxx
	sal/qa/osl/process/osl_Thread.cxx
	sal/qa/osl/socket/osl_StreamSocket.cxx
	sal/qa/osl/socket/sockethelper.cxx
	sal/qa/rtl_strings/rtl_OUString.cxx
	sal/rtl/source/unload.cxx
	sal/systools/win32/kill/kill.cxx
	sal/systools/win32/uwinapi/MoveFileExA.cpp
	sal/test/bootstrap.pl
	sal/typesconfig/typesconfig.c
	sal/workben/tgetpwnam.cxx
	sax/inc/sax/parser/saxparser.hxx
	sc/addin/datefunc/dfa.cl
	sc/addin/datefunc/dfa.src
	sc/addin/rot13/rot13.cl
	sc/addin/rot13/rot13.src
	sc/inc/attarray.hxx
	sc/inc/chgtrack.hxx
	sc/inc/column.hxx
	sc/inc/compressedarray.hxx
	sc/inc/document.hxx
	sc/inc/table.hxx
	sc/source/core/data/column.cxx
	sc/source/core/data/dptablecache.cxx
	sc/source/core/data/dptabres.cxx
	sc/source/core/data/dptabsrc.cxx
	sc/source/core/data/global.cxx
	sc/source/core/tool/chgtrack.cxx
	sc/source/core/tool/compiler.cxx
	sc/source/filter/excel/xestyle.cxx
	sc/source/filter/excel/xichart.cxx
	sc/source/filter/inc/fapihelper.hxx
	sc/source/filter/inc/xistyle.hxx
	sc/source/filter/xml/xmlsubti.cxx
	sc/source/ui/Accessibility/AccessibleCell.cxx
	sc/source/ui/Accessibility/AccessibleContextBase.cxx
	sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx
	sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
	sc/source/ui/Accessibility/AccessibleEditObject.cxx
	sc/source/ui/Accessibility/AccessiblePreviewCell.cxx
	sc/source/ui/app/inputwin.cxx
	sc/source/ui/docshell/docfunc.cxx
	sc/source/ui/drawfunc/fupoor.cxx
	sc/source/ui/miscdlgs/linkarea.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	sc/source/ui/unoobj/nameuno.cxx
	sc/source/ui/vba/vbacharacters.hxx
	sc/source/ui/vba/vbarange.cxx
	sc/source/ui/vba/vbawindow.cxx
	scaddins/source/analysis/analysishelper.cxx
	scaddins/source/analysis/analysishelper.hxx
	scaddins/source/datefunc/datefunc.cxx
	scripting/examples/python/Capitalise.py
	scripting/source/pyprov/officehelper.py
	sd/source/filter/eppt/eppt.cxx
	sd/source/filter/eppt/epptso.cxx
	sd/source/ui/dlg/prltempl.cxx
	sd/source/ui/dlg/tpoption.cxx
	sd/source/ui/func/fuediglu.cxx
	sd/source/ui/func/fupoor.cxx
	sd/source/ui/func/fusel.cxx
	sd/source/ui/func/smarttag.cxx
	sd/source/ui/inc/OutlinerIteratorImpl.hxx
	sd/source/ui/inc/SlideViewShell.hxx
	sd/source/ui/inc/fuediglu.hxx
	sd/source/ui/inc/fusel.hxx
	sd/source/ui/slideshow/slideshowimpl.cxx
	sd/source/ui/slidesorter/cache/SlsQueueProcessorThread.hxx
	sd/source/ui/slidesorter/controller/SlsHideSlideFunction.cxx
	sd/source/ui/slidesorter/controller/SlsSelectionCommand.hxx
	sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx
	sd/source/ui/slidesorter/view/SlsButtonBar.cxx
	sd/source/ui/view/Outliner.cxx
	sd/source/ui/view/drviewsh.cxx
	sd/source/ui/view/frmview.cxx
	sdext/source/presenter/PresenterFrameworkObserver.hxx
	sdext/source/presenter/PresenterSlideShowView.cxx
	setup_native/scripts/deregister_extensions
	setup_native/scripts/register_extensions
	setup_native/source/opensolaris/bundledextensions/README
	setup_native/source/opensolaris/bundledextensions/svc-ooo_bundled_extensions
	setup_native/source/win32/customactions/patch/swappatchfiles.cxx
	setup_native/source/win32/customactions/reg4msdoc/registrar.cxx
	setup_native/source/win32/customactions/reg4msdoc/userregistrar.cxx
	sfx2/inc/sfx2/sfxbasemodel.hxx
	sfx2/qa/complex/sfx2/DocumentProperties.java
	sfx2/source/appl/appopen.cxx
	sfx2/source/appl/appquit.cxx
	sfx2/source/appl/appserv.cxx
	sfx2/source/bastyp/sfxhtml.cxx
	sfx2/source/dialog/dockwin.cxx
	sfx2/source/doc/docfile.cxx
	sfx2/source/doc/docvor.cxx
	sfx2/source/doc/graphhelp.cxx
	sfx2/source/doc/objcont.cxx
	sfx2/source/doc/objserv.cxx
	sfx2/source/doc/objstor.cxx
	sfx2/source/doc/objuno.cxx
	sfx2/source/doc/objxtor.cxx
	sfx2/source/doc/printhelper.cxx
	sfx2/source/doc/sfxbasemodel.cxx
	sfx2/source/notify/eventsupplier.cxx
	sfx2/source/view/frmload.cxx
	sfx2/source/view/sfxbasecontroller.cxx
	shell/qa/zip/ziptest.cxx
	shell/source/backends/wininetbe/wininetbackend.cxx
	shell/source/win32/shlxthandler/util/utilities.cxx
	solenv/bin/build.pl
	solenv/bin/build_release.pl
	solenv/bin/cws.pl
	solenv/bin/download_external_dependencies.pl
	solenv/bin/make_download.pl
	solenv/bin/make_installer.pl
	solenv/bin/modules/Cws.pm
	solenv/bin/modules/ExtensionsLst.pm
	solenv/bin/modules/installer/control.pm
	solenv/bin/modules/installer/downloadsigner.pm
	solenv/bin/modules/installer/javainstaller.pm
	solenv/bin/modules/installer/packagepool.pm
	solenv/bin/modules/installer/patch/InstallationSet.pm
	solenv/bin/modules/installer/scriptitems.pm
	solenv/bin/modules/installer/windows/feature.pm
	solenv/bin/modules/installer/windows/msiglobal.pm
	solenv/bin/modules/installer/windows/sign.pm
	solenv/bin/modules/installer/worker.pm
	solenv/bin/modules/installer/xpdinstaller.pm
	solenv/bin/modules/osarch.pm
	solenv/bin/modules/packager/work.pm
	solenv/bin/modules/pre2par/parameter.pm
	solenv/bin/patch_tool.pl
	solenv/bin/transform_description.pl
	solenv/doc/gbuild/doxygen.cfg
	solenv/gbuild/LinkTarget.mk
	solenv/gbuild/gbuild.mk
	solenv/inc/os2gcci.mk
	solenv/inc/settings.mk
	solenv/inc/startup/Readme
	solenv/inc/target.mk
	solenv/inc/tg_compv.mk
	solenv/inc/tg_javav.mk
	solenv/inc/unitools.mk
	solenv/inc/unxbsdi.mk
	solenv/inc/unxbsdi2.mk
	solenv/inc/unxbsds.mk
	solenv/inc/unxfbsd.mk
	solenv/inc/unxlng.mk
	sot/source/sdstor/stg.cxx
	sot/source/sdstor/stgelem.cxx
	sot/source/sdstor/ucbstorage.cxx
	starmath/inc/toolbox.hxx
	starmath/source/mathmlexport.cxx
	starmath/source/node.cxx
	starmath/source/toolbox.cxx
	starmath/source/view.cxx
	stoc/source/bootstrap/bootstrap.xml
	stoc/source/corereflection/criface.cxx
	stoc/source/invocation/invocation.cxx
	stoc/source/security/access_controller.cxx
	stoc/source/servicemanager/servicemanager.cxx
	stoc/source/tdmanager/tdmgr.cxx
	stoc/test/javavm/testjavavm.cxx
	stoc/test/testconv.cxx
	stoc/test/testcorefl.cxx
	stoc/test/testintrosp.cxx
	svl/inc/svl/inettype.hxx
	svl/inc/svl/urihelper.hxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.cxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.hxx
	svl/source/config/itemholder2.hxx
	svl/source/items/itemset.cxx
	svl/source/numbers/zforlist.cxx
	svl/source/numbers/zformat.cxx
	svl/source/numbers/zforscan.cxx
	svtools/bmpmaker/bmp.cxx
	svtools/inc/svtools/helpagentwindow.hxx
	svtools/inc/svtools/menuoptions.hxx
	svtools/inc/svtools/miscopt.hxx
	svtools/inc/svtools/optionsdrawinglayer.hxx
	svtools/inc/svtools/stringtransfer.hxx
	svtools/inc/svtools/svlbitm.hxx
	svtools/inc/svtools/svtdata.hxx
	svtools/inc/svtools/valueset.hxx
	svtools/source/brwbox/editbrowsebox.cxx
	svtools/source/config/itemholder2.hxx
	svtools/source/contnr/contentenumeration.hxx
	svx/inc/svx/fmsrcimp.hxx
	svx/inc/svx/svdobj.hxx
	svx/inc/svx/xtable.hxx
	svx/source/accessibility/DGColorNameLookUp.cxx
	svx/source/accessibility/svxrectctaccessiblecontext.cxx
	svx/source/dialog/pfiledlg.cxx
	svx/source/fmcomp/fmgridcl.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/fmcomp/gridctrl.cxx
	svx/source/form/filtnav.cxx
	svx/source/form/fmPropBrw.cxx
	svx/source/form/fmshimp.cxx
	svx/source/form/fmsrcimp.cxx
	svx/source/gallery2/galtheme.cxx
	svx/source/inc/docrecovery.hxx
	svx/source/sdr/event/eventhandler.cxx
	svx/source/svdraw/svdedtv2.cxx
	svx/source/svdraw/svdedxv.cxx
	svx/source/svdraw/svdhdl.cxx
	svx/source/svdraw/svdobj.cxx
	svx/source/svdraw/svdograf.cxx
	svx/source/svdraw/svdoole2.cxx
	svx/source/svdraw/svdotxtr.cxx
	svx/source/svdraw/svdundo.cxx
	svx/source/svdraw/svdxcgv.cxx
	svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
	sw/inc/SwNumberTree.hxx
	sw/inc/ndnotxt.hxx
	sw/source/core/access/acccell.cxx
	sw/source/core/access/acccell.hxx
	sw/source/core/access/accframebase.cxx
	sw/source/core/access/accframebase.hxx
	sw/source/core/access/accmap.cxx
	sw/source/core/access/accpage.cxx
	sw/source/core/access/accpage.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/access/accpara.hxx
	sw/source/core/bastyp/swrect.cxx
	sw/source/core/crsr/findtxt.cxx
	sw/source/core/doc/docdde.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/docnode/section.cxx
	sw/source/core/draw/dcontact.cxx
	sw/source/core/edit/edlingu.cxx
	sw/source/core/inc/anchoredobjectposition.hxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/layout/tabfrm.cxx
	sw/source/core/layout/trvlfrm.cxx
	sw/source/core/ole/ndole.cxx
	sw/source/core/text/atrstck.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/itratr.cxx
	sw/source/core/text/itrform2.cxx
	sw/source/core/text/itrform2.hxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtedt.cxx
	sw/source/core/uibase/dochdl/swdtflvr.cxx
	sw/source/core/uibase/docvw/PostItMgr.cxx
	sw/source/core/uibase/docvw/SidebarWin.cxx
	sw/source/core/uibase/docvw/edtwin.cxx
	sw/source/core/uibase/envelp/labimg.cxx
	sw/source/core/uibase/uiview/pview.cxx
	sw/source/core/uibase/uno/unomailmerge.cxx
	sw/source/core/undo/unattr.cxx
	sw/source/core/undo/untbl.cxx
	sw/source/core/unocore/unochart.cxx
	sw/source/core/view/vdraw.cxx
	sw/source/core/view/vnew.cxx
	sw/source/filter/basflt/fltini.cxx
	sw/source/filter/html/wrthtml.cxx
	sw/source/filter/inc/wwstyles.hxx
	sw/source/filter/rtf/rtffly.cxx
	sw/source/filter/rtf/swparrtf.cxx
	sw/source/filter/ww8/docxattributeoutput.cxx
	sw/source/filter/ww8/dump/msvbasic.cxx
	sw/source/filter/ww8/dump/ww8scan.cxx
	sw/source/filter/ww8/dump/ww8scan.hxx
	sw/source/filter/ww8/dump/ww8struc.hxx
	sw/source/filter/ww8/wrtww8.cxx
	sw/source/filter/ww8/ww8graf.cxx
	sw/source/filter/ww8/ww8par.cxx
	sw/source/filter/ww8/ww8par2.cxx
	sw/source/filter/ww8/ww8par2.hxx
	sw/source/filter/ww8/ww8par3.cxx
	sw/source/filter/ww8/ww8par6.cxx
	sw/source/filter/ww8/ww8scan.cxx
	sw/source/filter/ww8/ww8scan.hxx
	sw/source/ui/dbui/dbinsdlg.cxx
	sw/source/ui/inc/tablemgr.hxx
	sw/source/ui/inc/uitool.hxx
	sw/source/ui/lingu/olmenu.cxx
	sw/source/ui/uiview/viewport.cxx
	sysui/desktop/productversion.mk
	sysui/desktop/slackware/makefile.mk
	testgraphical/source/CallExternals.pm
	testgraphical/source/fill_documents_loop.pl
	testgraphical/ui/java/ConvwatchGUIProject/src/IniFile.java
	toolkit/doc/layout/notes.txt
	toolkit/doc/layout/oldnotes.txt
	toolkit/source/awt/vclxtabcontrol.cxx
	toolkit/src2xml/source/srcparser.py
	toolkit/workben/layout/editor.cxx
	tools/inc/tools/simplerm.hxx
	tools/inc/tools/solar.h
	tools/source/communi/geninfo.cxx
	tools/source/fsys/dirent.cxx
	tools/source/fsys/filecopy.cxx
	tools/source/fsys/os2.cxx
	tools/source/inet/inetmime.cxx
	tools/source/rc/resmgr.cxx
	ucb/source/core/ucbcmds.cxx
	ucb/source/ucp/file/filglob.cxx
	ucb/source/ucp/odma/odma_content.cxx
	ucb/source/ucp/tdoc/ucptdoc.xml
	ucb/source/ucp/webdav/makefile.mk
	ucbhelper/inc/ucbhelper/simplecertificatevalidationrequest.hxx
	ucbhelper/source/client/content.cxx
	ucbhelper/source/client/interceptedinteraction.cxx
	udkapi/com/sun/star/beans/XPropertiesChangeListener.idl
	udkapi/com/sun/star/io/ObjectOutputStream.idl
	udkapi/com/sun/star/io/XMarkableStream.idl
	udkapi/com/sun/star/io/XTextOutputStream.idl
	udkapi/com/sun/star/reflection/CoreReflection.idl
	udkapi/com/sun/star/reflection/XTypeDescriptionEnumerationAccess.idl
	udkapi/com/sun/star/test/XSimpleTest.idl
	unodevtools/source/skeletonmaker/skeletoncommon.cxx
	unodevtools/source/skeletonmaker/skeletoncommon.hxx
	unotools/inc/unotools/cacheoptions.hxx
	unotools/inc/unotools/cmdoptions.hxx
	unotools/inc/unotools/dynamicmenuoptions.hxx
	unotools/inc/unotools/extendedsecurityoptions.hxx
	unotools/inc/unotools/fontoptions.hxx
	unotools/inc/unotools/historyoptions.hxx
	unotools/inc/unotools/idhelper.hxx
	unotools/inc/unotools/internaloptions.hxx
	unotools/inc/unotools/localisationoptions.hxx
	unotools/inc/unotools/moduleoptions.hxx
	unotools/inc/unotools/printwarningoptions.hxx
	unotools/inc/unotools/securityoptions.hxx
	unotools/inc/unotools/startoptions.hxx
	unotools/inc/unotools/workingsetoptions.hxx
	unotools/source/config/cmdoptions.cxx
	unotools/source/config/compatibility.cxx
	unotools/source/config/configitem.cxx
	unotools/source/config/configmgr.cxx
	unotools/source/config/dynamicmenuoptions.cxx
	unotools/source/config/fontcfg.cxx
	unotools/source/config/itemholder1.hxx
	unotools/source/config/moduleoptions.cxx
	unotools/source/config/pathoptions.cxx
	unotools/source/config/viewoptions.cxx
	unotools/source/misc/sharedunocomponent.cxx
	uui/source/fltdlg.cxx
	uui/source/iahndl-filter.cxx
	vbahelper/inc/vbahelper/collectionbase.hxx
	vbahelper/source/msforms/vbacontrol.cxx
	vbahelper/source/vbahelper/collectionbase.cxx
	vcl/aqua/source/gdi/atsfonts.cxx
	vcl/inc/aqua/salmathutils.hxx
	vcl/inc/graphite_cache.hxx
	vcl/inc/jobset.h
	vcl/inc/os2/salgdi.h
	vcl/inc/osx/saldata.hxx
	vcl/inc/salgdi.hxx
	vcl/inc/salwtype.hxx
	vcl/inc/unx/wmadaptor.hxx
	vcl/inc/vcl/print.hxx
	vcl/inc/vcl/strhelper.hxx
	vcl/os2/source/app/salinst.cxx
	vcl/os2/source/app/saltimer.cxx
	vcl/os2/source/gdi/salgdi2.cxx
	vcl/osx/salframeview.mm
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/dndtest.cxx
	vcl/source/app/dbggui.cxx
	vcl/source/control/ilstbox.cxx
	vcl/source/gdi/cvtsvm.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/outdev4.cxx
	vcl/source/gdi/outdev6.cxx
	vcl/source/gdi/pdfwriter_impl.cxx
	vcl/source/gdi/pdfwriter_impl2.cxx
	vcl/source/gdi/print.cxx
	vcl/source/gdi/print2.cxx
	vcl/source/glyphs/gcach_layout.cxx
	vcl/source/glyphs/glyphcache.cxx
	vcl/source/glyphs/graphite_layout.cxx
	vcl/source/window/printdlg.cxx
	vcl/source/window/tabdlg.cxx
	vcl/source/window/window.cxx
	vcl/source/window/winproc.cxx
	vcl/unx/generic/app/saldisp.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/gtk/app/gtkdata.cxx
	vcl/win/source/gdi/salgdi2.cxx
	vcl/win/source/gdi/salgdi3.cxx
	vcl/win/source/window/salframe.cxx
	vos/inc/vos/pipe.hxx
	vos/inc/vos/process.hxx
	vos/inc/vos/signal.hxx
	vos/inc/vos/socket.hxx
	vos/inc/vos/thread.hxx
	vos/source/pipe.cxx
	vos/source/socket.cxx
	wizards/com/sun/star/wizards/agenda/AgendaTemplate.java
	wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java
	wizards/com/sun/star/wizards/agenda/TopicsControl.java
	wizards/com/sun/star/wizards/web/FTPDialog.java
	wizards/com/sun/star/wizards/web/ImageListDialog.java
	wizards/com/sun/star/wizards/web/Process.java
	wizards/com/sun/star/wizards/web/ProcessStatusRenderer.java
	wizards/com/sun/star/wizards/web/TOCPreview.java
	wizards/com/sun/star/wizards/web/WWD_Startup.java
	wizards/com/sun/star/wizards/web/data/TypeDetection.java
	wizards/com/sun/star/wizards/web/export/ImpressHTMLExporter.java
	writerfilter/inc/doctok/WW8Document.hxx
	writerfilter/source/dmapper/DomainMapper.cxx
	writerfilter/source/dmapper/NumberingManager.cxx
	writerfilter/source/dmapper/PropertyMap.cxx
	writerfilter/source/dmapper/StyleSheetTable.cxx
	writerfilter/source/doctok/WW8StructBase.hxx
	writerfilter/source/doctok/resources.xmi
	writerfilter/source/ooxml/README.efforts
	xmerge/source/activesync/XMergeFilter.cpp
	xmerge/source/minicalc/java/org/openoffice/xmerge/converter/xml/sxc/minicalc/SxcDocumentDeserializerImpl.java
	xmerge/source/palmtests/qa/comparator/pdbcomparison.java
	xmerge/source/palmtests/qa/test_spec/convertor_test_spec.html
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefinedName.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Workbook.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Worksheet.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/SymbolLookup.java
	xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentDescriptor.java
	xmerge/workben/jstyle.pl
	xmlhelp/source/cxxhelp/provider/databases.hxx
	xmlhelp/source/cxxhelp/provider/provider.cxx
	xmlhelp/source/treeview/tvread.cxx
	xmloff/inc/txtfldi.hxx
	xmloff/inc/xmloff/xmlmultiimagehelper.hxx
	xmloff/inc/xmloff/xmluconv.hxx
	xmloff/source/core/xmlexp.cxx
	xmloff/source/draw/shapeexport2.cxx
	xmloff/source/draw/shapeexport3.cxx
	xmloff/source/meta/xmlversion.cxx
	xmloff/source/style/impastp4.cxx
	xmloff/source/style/xmlaustp.cxx
	xmloff/source/text/XMLSectionExport.cxx
	xmloff/source/text/txtflde.cxx
	xmloff/source/text/txtimp.cxx
	xmloff/source/text/txtparae.cxx
	xmloff/source/text/txtparai.cxx
	xmloff/source/text/txtvfldi.cxx
	xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx

Change-Id: Ie072e7c3a60c5dae16a67ac36d1f372c5065c99c
2014-05-01 08:59:14 +01:00
Tor Lillqvist
728ec86062 Typo: s/cant/can't/
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Alexander Wilms
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
Stephan Bergmann
c19cb642db Adapt to osl_atomic_inc-/decrement
Change-Id: I848873b07ab05cefdc755a8bf1301907fdfbc299
2014-02-24 08:08:00 +01:00
Stephan Bergmann
8f408fd559 salhelper: Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Change-Id: I2c7779ad07daa77ae06709c1f6512f2fa25fcd36
2014-01-28 15:54:49 +01:00