Bogdan Buzea
3c32c93239
tdf#163486: PVS: Identical branches
...
V1037 Two or more case-branches perform the same actions. Check lines: 1114, 1129, 1261
Change-Id: I661f54f3aaa84002e3013439ea762afa4a251857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175210
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-06 18:16:19 +01:00
László Németh
3056c75db5
tdf#95239 sw: fix wrong order of PDF ToC, if headings put in text frames
...
PDF outlines (called also as PDF bookmarks or ToC) contained headings in
the wrong order if they were placed in a text frame:
Heading 2 (frame) ... 2
Heading 3 (frame) ... 2
Heading 1 ........... 1
Now PDF export didn't list text frame headings only at the start of the
ToC, but in their correct position and hierarchy, based on the page
and vertical position of the headings:
Heading 1 ................ 1
Heading 2 (frame) ...... 2
Heading 3 (frame) ... 2
This is useful for the recently implemented inline headings, where
e.g. APA Style Heading 4 and Heading 5 are there in text frames
anchored as characters, see tdf#48459.
Extend PDFium test environment for bookmarks, and add tdf#131728 DOCX
and an APA Style .fodt unit tests.
Note: if the higher headings are only in text frames, but not the
lower ones, only the order corrected, but not the full hierarchy, yet.
This is a follow-up to commit d87cf67f8f
"tdf#131728 sw inline heading: fix missing/broken DOCX export",
commit a1dcbd1d1c
"tdf#48459 sw inline heading: add Inline Heading frame style" and
commit 49765a9e7b
"tdf#48459 tdf#131728 sw inline heading: new frame style: fix DOCX
export".
Change-Id: I87dffb9244d8aea553c98bf16c70955bb9b732d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176050
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
2024-11-06 17:46:59 +01:00
Andrea Gelmini
315180b2a3
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 69d616f2dc90236195aedcc59d0b4ce1765f8cb1
- Removed exec bits on png files
Change-Id: I114b102191774199016e83e404396b6e5b9f8e6b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176140
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 16:18:00 +01:00
Caolán McNamara
9a96f11eb0
make the autotext shortcut warning dialog async
...
Change-Id: I8fb0e61d48400d001cf6a3918c638bc087723288
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175985
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-06 16:17:32 +01:00
Mike Kaganski
18a9092d7b
Simplify a bit
...
Change-Id: I62299212957f491ff0ead9e64816d70cb7f19e08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176061
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-06 15:49:32 +01:00
Noel Grandin
a6c3f0b62a
loplugin:passstuffbyref in svx
...
Change-Id: Ic5fd72cb64208c278ffc129591cd3d1131efdc08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176137
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 15:45:24 +01:00
Noel Grandin
d5b55513cd
loplugin:passstuffbyref in basic
...
Change-Id: I1aee08f0ff2a3dabcedc49a31e7ff4de9428007e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176136
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 15:45:14 +01:00
Olivier Hallot
95911bf6b8
Update git submodules
...
* Update helpcontent2 from branch 'master'
to a82bde73fdb8cd157cb1f76518f6ad5ef0badd44
- tagalog add slantcornertabpage + refresh
Change-Id: I71f5a3bd90fcd27e18438b15c19bd0a600497d29
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176134
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
2024-11-06 15:39:57 +01:00
Olivier Hallot
868cda6b33
Update git submodules
...
* Update helpcontent2 from branch 'master'
to d58643f5775cd5684bfe83d26596791d9e533bfe
- tagalog add pageformatpage + refresh
Change-Id: Ie475fe669ce2ba1ebfbf7f0a2bcd5970f4a0f4a7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176133
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 15:39:46 +01:00
Olivier Hallot
b62db9ec69
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 27aaf37df77ab9380c4375cb4ebd40e587a969b5
- tagalog add optviewpage + refresh
Change-Id: Ifcc791a0b6a7a013f94afe007439003c9e431b96
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176132
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
2024-11-06 15:39:33 +01:00
Olivier Hallot
fcf7dcb56a
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 7cd7cc5ef283cd3f0156a88646a5fee21ca12a89
- tagalog add optsecuritypage + refresh
Change-Id: Iec3bf839ea7317f126d5bd5faeda5a15a33c0018
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176129
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
2024-11-06 15:39:19 +01:00
Olivier Hallot
96529c2d7f
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 2312f595505f21c2d1e114b64649ebba9e74c622
- tagalog add optlanguagepage + refresh
Change-Id: Iae5525ed545cd6711793f23d4b83a6aa72b9062b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176128
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
2024-11-06 15:39:07 +01:00
Olivier Hallot
bd8675f8a2
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 74ab7f1b9d07618843ff721543c38866a9e3639e
- tagalog add opthtmlpage + refresh
Change-Id: I17a32e55977e07db591567d4ed4f1bf13997070b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176127
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 15:38:55 +01:00
Olivier Hallot
9fab4c29c9
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 9d980a2674ca20d5fa84aa657382e747a250375a
- tagalog add optgeneralpage + refresh
Change-Id: I41ef17f489b077362525a0c572f10b8fb5a95e8d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176126
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 15:38:42 +01:00
Olivier Hallot
6a89f7b9d0
Update git submodules
...
* Update helpcontent2 from branch 'master'
to cc787c47259c7cbbfcec1aff3e3685832afb382e
- tagalog add optfltrlpage + refresh
Change-Id: I157460629f8d191b97b1e9aa16c9b04814807d6e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176125
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 15:38:28 +01:00
Olivier Hallot
8ee1472785
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 369d452ac5cf65193f7a8c04b0e381dfa3eea69f
- tagalog add optactlpage + refresh
Change-Id: I24d7d18bf213b0674b24b277ec66bf02e0e21182
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176124
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 15:38:15 +01:00
Olivier Hallot
6decaaaabc
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 13e4c3be51c804c1be38660c50d93f25b1e7a3ca
- tagalog add optasianpage + refresh
Change-Id: I0629c9f8b777e840232519514f366d08e89c6fed
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176123
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 15:37:56 +01:00
Olivier Hallot
c562e39e86
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 68422153146e6763b59c6d2ef02cc5a2918e7bae
- tagalog add optadvancedpage + refresh
Change-Id: I4aa465c674a75a0883674013c315aee129ebe2be
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176122
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 15:31:24 +01:00
Noel Grandin
0269fb72e8
ignore TypedWhichId in loplugin:rangedforcopy
...
where using a "&" in a for loop is overkill
Change-Id: Ic0d14f6d19c50b49cf7ce3bf2166d546a4d2685b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176130
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-11-06 15:18:15 +01:00
Noel Grandin
2796d979fa
loplugin:passstuffbyref in editeng
...
Change-Id: I015616d7a008692b63586cd5d2ae9cc5586ead4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176135
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 14:28:35 +01:00
Michael Weghorn
a43b5e3de4
win: Prefer integers instead of strings for OS version comparison
...
* Add a WinOSVersionInfo struct holding the major and minor
version and build number for a Windows release.
* Extract a static WinSalInstance::getWinOSVersionInfo from
WinSalInstance::getOSVersion that returns a corresponding
version info.
* Adjust the local getOSVersionString helper to take integers
for major and minor version instead of an "NT version" string
that is a dot-separated version number containing both of these.
* Use WinSalInstance::getWinOSVersionInfo in ImplDrawNativeControl
to compare the major version + build number to identify Windows 11
instead of relying on WinSalInstance::getOSVersion to return
a string starting with "Windows 11".
Change-Id: I6fe727c1c0f928c03216e406cdb1b7735c1ab3ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176059
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-06 14:06:27 +01:00
Caolán McNamara
92f5913aef
cid#1556442 COPY_INSTEAD_OF_MOVE
...
and
cid#1607753 COPY_INSTEAD_OF_MOVE
cid#1554790 COPY_INSTEAD_OF_MOVE
cid#1556463 COPY_INSTEAD_OF_MOVE
cid#1554838 COPY_INSTEAD_OF_MOVE
cid#1556231 COPY_INSTEAD_OF_MOVE
cid#1556878 COPY_INSTEAD_OF_MOVE
cid#1554913 COPY_INSTEAD_OF_MOVE
cid#1558064 COPY_INSTEAD_OF_MOVE
cid#1557043 COPY_INSTEAD_OF_MOVE
cid#1556985 COPY_INSTEAD_OF_MOVE
cid#1556766 COPY_INSTEAD_OF_MOVE
cid#1557351 COPY_INSTEAD_OF_MOVE
cid#1554863 COPY_INSTEAD_OF_MOVE
cid#1556764 COPY_INSTEAD_OF_MOVE
cid#1556279 COPY_INSTEAD_OF_MOVE
cid#1555970 COPY_INSTEAD_OF_MOVE
cid#1556942 COPY_INSTEAD_OF_MOVE
cid#1557964 COPY_INSTEAD_OF_MOVE
cid#1555166 COPY_INSTEAD_OF_MOVE
cid#1556496 COPY_INSTEAD_OF_MOVE
cid#1557175 COPY_INSTEAD_OF_MOVE
cid#1558054 COPY_INSTEAD_OF_MOVE
cid#1557392 COPY_INSTEAD_OF_MOVE
cid#1557850 COPY_INSTEAD_OF_MOVE
cid#1555118 COPY_INSTEAD_OF_MOVE
cid#1557131 COPY_INSTEAD_OF_MOVE
cid#1556614 COPY_INSTEAD_OF_MOVE
cid#1609650 COPY_INSTEAD_OF_MOVE
cid#1555114 COPY_INSTEAD_OF_MOVE
cid#1555241 COPY_INSTEAD_OF_MOVE
cid#1555442 COPY_INSTEAD_OF_MOVE
cid#1556473 COPY_INSTEAD_OF_MOVE
cid#1557654 COPY_INSTEAD_OF_MOVE
cid#1554689 COPY_INSTEAD_OF_MOVE
cid#1556316 COPY_INSTEAD_OF_MOVE
cid#1557929 COPY_INSTEAD_OF_MOVE
cid#1554807 COPY_INSTEAD_OF_MOVE
cid#1554858 COPY_INSTEAD_OF_MOVE
cid#1555103 COPY_INSTEAD_OF_MOVE
cid#1555517 COPY_INSTEAD_OF_MOVE
cid#1556424 COPY_INSTEAD_OF_MOVE
cid#1557252 COPY_INSTEAD_OF_MOVE
cid#1557566 COPY_INSTEAD_OF_MOVE
cid#1608020 COPY_INSTEAD_OF_MOVE
cid#1557742 COPY_INSTEAD_OF_MOVE
cid#1555884 COPY_INSTEAD_OF_MOVE
cid#1554809 COPY_INSTEAD_OF_MOVE
cid#1555336 COPY_INSTEAD_OF_MOVE
cid#1555173 COPY_INSTEAD_OF_MOVE
cid#1556067 COPY_INSTEAD_OF_MOVE
cid#1557040 COPY_INSTEAD_OF_MOVE
cid#1556235 COPY_INSTEAD_OF_MOVE
cid#1557366 COPY_INSTEAD_OF_MOVE
cid#1555910 COPY_INSTEAD_OF_MOVE
cid#1556716 COPY_INSTEAD_OF_MOVE
cid#1558022 COPY_INSTEAD_OF_MOVE
cid#1555769 COPY_INSTEAD_OF_MOVE
cid#1555940 COPY_INSTEAD_OF_MOVE
cid#1557077 COPY_INSTEAD_OF_MOVE
cid#1555270 COPY_INSTEAD_OF_MOVE
cid#1555660 COPY_INSTEAD_OF_MOVE
cid#1556302 COPY_INSTEAD_OF_MOVE
cid#1555678 COPY_INSTEAD_OF_MOVE
cid#1556538 COPY_INSTEAD_OF_MOVE
cid#1557689 COPY_INSTEAD_OF_MOVE
cid#1555009 COPY_INSTEAD_OF_MOVE
cid#1555433 COPY_INSTEAD_OF_MOVE
cid#1555671 COPY_INSTEAD_OF_MOVE
cid#1555255 COPY_INSTEAD_OF_MOVE
cid#1557681 COPY_INSTEAD_OF_MOVE
cid#1557512 COPY_INSTEAD_OF_MOVE
cid#1554958 COPY_INSTEAD_OF_MOVE
cid#1555758 COPY_INSTEAD_OF_MOVE
cid#1555597 COPY_INSTEAD_OF_MOVE
cid#1558040 COPY_INSTEAD_OF_MOVE
cid#1556476 COPY_INSTEAD_OF_MOVE
cid#1557646 COPY_INSTEAD_OF_MOVE
cid#1557950 COPY_INSTEAD_OF_MOVE
cid#1557019 COPY_INSTEAD_OF_MOVE
cid#1557885 COPY_INSTEAD_OF_MOVE
cid#1556402 COPY_INSTEAD_OF_MOVE
cid#1557906 COPY_INSTEAD_OF_MOVE
cid#1556619 COPY_INSTEAD_OF_MOVE
cid#1554683 COPY_INSTEAD_OF_MOVE
cid#1556549 COPY_INSTEAD_OF_MOVE
cid#1554747 COPY_INSTEAD_OF_MOVE
cid#1554929 COPY_INSTEAD_OF_MOVE
cid#1555362 COPY_INSTEAD_OF_MOVE
cid#1557053 COPY_INSTEAD_OF_MOVE
cid#1557891 COPY_INSTEAD_OF_MOVE
cid#1555043 COPY_INSTEAD_OF_MOVE
cid#1555107 COPY_INSTEAD_OF_MOVE
cid#1557203 COPY_INSTEAD_OF_MOVE
cid#1556728 COPY_INSTEAD_OF_MOVE
cid#1557773 COPY_INSTEAD_OF_MOVE
cid#1556845 COPY_INSTEAD_OF_MOVE
Change-Id: I001fb67e597b096e992fd8a0cd6f3ec577767c33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176098
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-11-06 13:58:54 +01:00
Caolán McNamara
c235e6af91
cid#1606953 Overflowed constant
...
Change-Id: Ife4caf4251076be5ddf289c701ec52c9828b9665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176119
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-06 13:58:45 +01:00
Olivier Hallot
adfab29d83
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 410f88c0a7b8fc67bac17bc2c81d03d0ef509cb8
- tagalog add optaccessibilitypage + refresh
Change-Id: Ifb5f7fd72bb15c052a49b46537ca235e23e4566a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176121
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 12:38:00 +01:00
Noel Grandin
9a608faf3c
loplugin:passstuffbyref in xmloff
...
Change-Id: I4837cb60c2c78b5a9008b6ffbb6323da50c7c705
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176111
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 12:34:34 +01:00
Noel Grandin
327c5dd146
loplugin:passstuffbyref in ucbhelper
...
Change-Id: I70f0774ec2f38c0ba250aee7999d72eaa4a82673
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176110
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-11-06 12:34:26 +01:00
Noel Grandin
2e60bca0b8
loplugin:passstuffbyref in vcl
...
Change-Id: Id152f7321bb81ecb17b31775277d1466ccd91ab4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176108
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-11-06 12:34:18 +01:00
Miklos Vajna
bb51c57fd5
sw lok: async readonly dialog when pressing delete key on protected content
...
Open online.git/test/samples/writer.fodt, ctrl-a, del, the read-only
dialog is blocking.
This was working already for the character insert case, but not when going
via KEY_DELETE.
Fix the problem similar to what commit
0c03a97fb8
(sw edit win: fix read-only
selections while handling ExtTextInput, 2021-01-13) did, by switching to
the async path here.
There doesn't seem to be any reason for the old sync behavior, other
than the safe "keep things unchanged" default in InfoReadOnlyDialog().
Change-Id: I9330cb235bf6c19f96e9d21889eb9639725daf8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176113
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-06 12:32:48 +01:00
Noel Grandin
bcf9699a82
tdf#163731 Style names cropped in Stylist in Writer's Sidebar
...
regression from
commit 7f42f031ed
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu Oct 10 09:39:14 2024 +0200
tdf#100894 speed up style tree creation
Change-Id: I94f7f3edd4dc31a2a86ddd73a79f276d6c30509c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176107
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 12:10:29 +01:00
Noel Grandin
5c59d82142
fix memcpy in ImplExpandCompressedPortion
...
regression from
commit 11b1557147
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Wed Oct 30 09:51:26 2024 +0200
convert KernArray from sal_Int32 to double
Change-Id: I43a3af79159944ac84cb473a0f258f0815228bfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176109
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 12:10:12 +01:00
Andreas Heinisch
9879cadfc5
tdf#162753 - Hyperlink dialog: preset only syntactically valid hyperlinks
...
Change-Id: I682acfa4e41a3cce5f4639d79004bea985cabce3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176112
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-06 12:02:51 +01:00
Olivier Hallot
a74c599ea2
Update git submodules
...
* Update helpcontent2 from branch 'master'
to 0ef21717396d8d0b92791b9ee79a1af4f63050b1
- tagalog add hyperlinknewdocpage + refresh
Change-Id: I0e3026cc92892fb254f3f40a08cb57582bc8ec93
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176116
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 10:54:03 +01:00
Olivier Hallot
af039ec90b
Update git submodules
...
* Update helpcontent2 from branch 'master'
to a58060c90a04d99e87144b6b47eb89573424480c
- tagalog add hyperlinkmailpage + refresh
Change-Id: I3bc0bc3e15d9db9ad70e78eed14f7a8c40371950
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176115
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 10:53:51 +01:00
Olivier Hallot
cca1ff25db
Update git submodules
...
* Update helpcontent2 from branch 'master'
to c2b41423924611c97c70b6cb4a8b49e455c84a80
- tagalog add hyperlinkinternetpage + refresh
Change-Id: I307dc8753d39035439f34f6df10e6ad6bb446816
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176114
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
2024-11-06 10:53:40 +01:00
Javiya Vivekkumar Dineshbhai
43c4488e58
Fix: Make the repeat slideshow property independent of the TransitionType
...
Change-Id: I60b00f2935df8dc224736120b1e0d70c2821c0cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176105
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-06 10:10:44 +01:00
Caolán McNamara
797e215f79
cid#1634477 COPY_INSTEAD_OF_MOVE
...
and
cid#1634476 COPY_INSTEAD_OF_MOVE
cid#1634474 COPY_INSTEAD_OF_MOVE
cid#1634473 COPY_INSTEAD_OF_MOVE
Change-Id: Iefa96ce12bc787bf86e3f02066c46e943d8b3ebd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176097
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-06 09:28:00 +01:00
Caolán McNamara
3cf64b9d57
cid#1608064 silence Data race condition
...
Change-Id: Ib8fa1a1027bef3516665f17c8c4c19b6d571e7ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176096
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-06 09:27:52 +01:00
Noel Grandin
52357eefa7
loplugin:passstuffbyref in svl
...
Change-Id: Ibc4628941b40159aa35a0a55900efb3dd882369e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176056
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 09:25:46 +01:00
Noel Grandin
54a91f287f
loplugin:passstuffbyref in tools
...
Change-Id: Id902f711d14eb21dc14366e8fe8fc5a96c0afec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176055
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 09:25:37 +01:00
Noel Grandin
69f4abaffd
loplugin:passstuffbyref in unotools
...
Change-Id: I0a63fc95f76664408a7ec3ee53a8d025eb5f560d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176054
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 09:25:28 +01:00
Noel Grandin
47a1dccd17
loplugin:passstuffbyref in comphelper
...
Change-Id: I2c94b6e0bbdce4f4236815df8c4841327a33939e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176053
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 09:25:20 +01:00
Noel Grandin
bd8539dfd1
add an EMPTY_OUSTRING in OUString header
...
we already declare the same thing in various places,
and I intend to be using this some more, so it makes
sense to only declare it in one place
Change-Id: Ifea6b589e992dd9f6cd8f2301f837e71397481c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176046
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06 09:25:10 +01:00
Olivier Hallot
34099cedc5
Update git submodules
...
* Update helpcontent2 from branch 'master'
to c0aba512effb26006837e7f9c9d3517f5f167e3a
- tagalog add screenshot for effectpage and hyperlinkdocpage
+ refresh screenshots
Change-Id: Idf0cbc11bdaa0ef61f84887f573bdda68964f2a1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176102
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-06 09:08:46 +01:00
Olivier Hallot
d67c7f3895
Update git submodules
...
* Update helpcontent2 from branch 'master'
to a9056f80c82213fee22c37d0815ec06ad5a651f6
- tagalog: add screenshot colorpage colorpickerdialog
+ update respective screenshots for all languages
Change-Id: I26c50fe9c55c28760c160238513c1499d17a4bb3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176101
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
2024-11-06 09:04:05 +01:00
Miklos Vajna
27753561a1
cool#9992 lok doc sign, create-certs.sh password-less mode: still create a .p12
...
I have a case where LOK convert-to with ODT->PDF and
SignCertificateCaPem/SignCertificateCertPem/SignCertificateKeyPem set
creates a corrupted PDF signature, while more or less the same on the
desktop works.
The PDF signature is a hex dump, and once converted to binary, one can
analyze the content using 'openssl asn1parse -inform der -in ... -i'.
Still, the LOK and the desktop case differs, because this script
generates random certificates and then the binary output in the two
cases differs, so hard to see the actual difference.
Fix the problem by still generating .p12 output (needed for the desktop
case) in the no-password case, so a single run can emit ca/cert/key PEM
files and a .p12 archive, so exactly the same input can be used for
desktop and LOK signing.
It turns out the actual problem I looked at was some setup problem,
because now that the same input can be used in the two cases, the LOK
signing during PDF export works fine.
Change-Id: Ifc5ff73cd6fbbc057af536c84e4367ce1d489931
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176081
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2024-11-06 08:54:56 +01:00
Mike Kaganski
0c1ae785e3
tdf#122716: take encoding defined for font into account
...
Before this, the non-ASCII Windows-1252 characters get exported to RTF
without Unicode markup, regardless of the font-defined charset; and on
import to Writer (and other compliant RTF readers), this 8-bit markup
was interpreted using the font data, producing different characters.
Change-Id: I2032930b6585287fde3eb3b5e6abed0298d29330
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176048
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-06 08:32:16 +01:00
Stephan Bergmann
dc9dcb5c00
loplugin:redundantcast
...
...after 11b1557147
"convert KernArray from
sal_Int32 to double"
Change-Id: I61e7f25f1e1b1493d1f1164f96e09eb3ba14baa8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176052
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-11-06 08:24:15 +01:00
Stephan Bergmann
72890bd3b9
loplugin:staticconstexpr (macOS)
...
Change-Id: I294b9476413a0d7b12daef9f26881241afcbde29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176051
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2024-11-06 08:23:54 +01:00
Stephan Bergmann
e7cbcdf86e
external/zxing: Missing include (for std::nullptr_t)
...
Change-Id: I731eb3039f9f43ac05d3b60d5387ff44c5986a71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176049
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-11-06 08:23:21 +01:00
Mike Kaganski
e1beaf844f
Related: tdf#163730 Release the object in separate thread
...
Using a local build having both commits
9f53d40fd1
"Related: tdf#163730 Avoid
deadlock", 2024-11-02, and 3015db08c9
"Related: tdf#163730 Avoid potential deadlock", 2024-11-03, I got
another deadlock (unfortunately, I didn't copy call stacks), where
main thread, holding soler mutex, called CWinClipboard::setContents,
and that tried to lock solar mutex in CMtaOleClipboard::run thread,
which released the m_foreignContent data.
This change releases m_foreignContent in a separate thread, which
has no dependencies, and so its wait wouldn't block other threads.
Change-Id: If4c486e6f3ba9201c4c9c6991992e38929ab3b81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176047
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-11-06 06:22:22 +01:00