and only allow dockable type docking windows to be undocked/docked
Change-Id: Ia1b0ccbdd911c24f83baf1c0514954e354c9070b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129650
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
The order was wrong since commit dd1df645b4 which moved them from
independent entries in extrusioncontrols.src to an ordered array in
extrusioncontrols.cxx.
Change-Id: I346a40a0506d9103a33eb9f06c7017663d61949e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131086
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
because I want to ref-count SdrObject, which changes the lifecycles
of these objects, and then if an SdPage dies before an SdrObject
we have a dangling m_pUserCall pointer.
Change-Id: Ia08178c1b2f288f6d9d489fb9fd79e67bc3ea61c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131065
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
It's set for every cell with value.
Change-Id: Ie46617a621e6eb16b5f67d92e85bf2155e650fb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131072
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
These classes are used extensively during some operations in Calc,
and not even LTO can inline these when they end up in different
binaries.
Change-Id: I5b17a004c6cc039508b76d557d58714c83f237a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131071
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Sorting ends tells all listeners on all the sorted cells to end
listening to stop updates, then sorts the cells and starts
listening again. This will cause all broadcasters for the sorted
cells to temporarily stop having any listeners, so they'll be
deleted and removed from the mdds vector (which may additionally
cause moving large parts of the mdds vector repeatedly). And
since all listeners will want to listen again after the sort,
this will all need to be reconstructed. To avoid this,
temporarily block this removal and then later just checks
and remove any possibly left-over broadcasters that ended up
with no listeners.
Change-Id: Ie2d41d9acd7b657cf31a445870ce7f18d28d5ebb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131069
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
... which changed in commit 281989007f
Author Noel Grandin <noel@peralex.com>
Date Tue Jul 01 13:17:01 2014 +0200
Use standard library optimised routines for OUString/OString
for optimized cases: strchr/wcschr/strrchr/wcsrchr find trailing zero
character, and strstr/wcsstr find empty string; previous/unoptimized
code does not find these. This introduced inconsistency between char
and sal_Unicode functions on non-Windows, and for sal_Unicode between
Windows and non-Windows (because on Windows, optimized code is used
for sal_Unicode, while on other platforms, unoptimized code is used).
Change-Id: I68529c91b26f4113d9bd7777fc5ac4809349864b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131064
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
AppendContent() does something only if the cells differ, which can't
be the case if they're both empty, so skip unallocated cells.
Change-Id: I367801bac30a8ee641b4ce608392124bac6ef47a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131060
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
There's no point scanning for non-empty cells after the last data
cell, and this avoids processing mdds structures (such as repeated
creating of flat_segment_tree).
Change-Id: Ibec324aa2de457e8439c38a561f55ced9f478899
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131059
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
To avoid some regression, consider that transparency should be enabled by default.
So only remove transparency if it's required explicitely.
+ change QA test since "Translucent" property isn't a bool but a sal_Int32
In officecfg/registry/schema/org/openoffice/Office/Common.xcs:
<prop oor:name="Translucent" oor:type="xs:int" oor:nillable="false">
Change-Id: I9bfb6aae8e2e8a31dee82f73a9165989129f222a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131057
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Instead of using a plain char, create a key event using a Unicode
character, otherwise the key event creates texts including rectangles or
wrong characters.
Change-Id: I9ec0d64998927d54eb3ae90a192c3b28e235f56d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130721
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
'row1' is not a valid named range with 16k columns, it's a cell
address. Since the named range is constructed by the test,
not even 582fc887f1 can take
care of it, so rename such ranges.
Change-Id: I6643953d41e391c8c3cfc55768b06d61d9fcb0a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131046
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
E.g. sctablesheetobj test had the limits hardcoded, even as actual
numbers. Apparently some tests cannot easily access global
settings, but this at least makes it easy to check all tests
after modifying ScSheetLimits::CreateDefault().
Change-Id: I6cff577fb01b1ea262dcd1f9fde24e114e19abdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131040
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
I don't see how it possibly could be nullptr in a correct situation,
ScColumn::Init() is called right after creating ScColumn.
Also make a bunch of trivial forwarding functions inline.
Change-Id: I710d3cd86a660a8b4dcfbb9966a685b657b93c18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131035
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Since columns are allocated dynamically on demand, up until
this commit ScTable had ScPatternAttr member for unallocated
columns that it was using in place of those unallocated columns.
But that meant either copy&pasting pieces of code from ScColumn,
or having extra slightly more cumbersome shared function
in ScColumn, or even nothing.
Improve this by creating ScColumnData, which will be used as
ScColumn base class to keep things working as before, but
ScTable now also contains one ScColumnData instance and
so it can also call its functions.
Change-Id: If1d842c4a5aec32e2a7729358006d79cd831349f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131034
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
