Commit graph

391386 commits

Author SHA1 Message Date
Douglas Mencken
1206e59953 libsvtlo: convert set of #define to enum class
Change-Id: Iade24fc589e5325bf6fb1a2e5f2d609ddb3f5ec5
Reviewed-on: https://gerrit.libreoffice.org/23544
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-29 06:42:39 +00:00
Oliver Specht
df90b5a1c9 Revert "add additional modules to merged lib"
Breaks tinderbox build in cppumaker

This reverts commit 3393e04edd.
2016-04-28 20:04:55 +02:00
Oliver Specht
3393e04edd add additional modules to merged lib
acc, expwrap and store are loaded at startup anyway

Change-Id: I28020962238be3fe73a1b1dbba59a45c7d3c1e1d
Reviewed-on: https://gerrit.libreoffice.org/23459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-29 06:13:22 +00:00
Oliver Specht
523a3d18e9 tdf#99434: import/export documentProtection-forms from .docx incl. test
the setting <w:documentProtection w:edit="forms"> disables editing of content
outside of form controls.

Change-Id: I0d11373d9010778ed5798598020e453cde06fa0f
Reviewed-on: https://gerrit.libreoffice.org/24365
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-29 06:12:55 +00:00
Stanislav Horacek
16777b6bb0 mark numbers in mail merge dialogs as untranslatable
Change-Id: I4dd5d8914e637ee3e8c89752e2daf563222cc494
Reviewed-on: https://gerrit.libreoffice.org/24467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-29 05:42:13 +00:00
Eike Rathke
37b071c933 move to ScDocument::CopyAdjustRangeName() and namespace
Change-Id: I1ec3c8cc1b8d3cb899d49192295b14ffac02849a
2016-04-28 22:43:09 +02:00
Eike Rathke
75d588556e move to ScDocument::FindRangeNamesReferencingSheet()
Change-Id: I8ddd83eca3eaf0bd04c8c73a16329517ec3c21b3
2016-04-28 21:29:27 +02:00
Eike Rathke
c692b9cda1 adjustCopyRangeName: pass rSheet, rIndex; encapsulate nNewSheet
Change-Id: I3de5982b8b8ad179010787ed7be721be54f761af
2016-04-28 21:29:27 +02:00
Miklos Vajna
1d4974ba06 i18npool: fix Android build
Change-Id: If7321acf4cb8542709cd3f2b418af97586862d46
2016-04-28 21:26:03 +02:00
Jochen Nitschke
f8eb7f9c7d use initialization list
use anonymous union to make initialization and
access easier
prevent overwriting type and use scoped enum

Change-Id: I76037ec666c5740096849b0c58fd9a187ada1d54
Reviewed-on: https://gerrit.libreoffice.org/24455
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28 18:31:40 +00:00
Noel Grandin
2e2781d054 move stylepolice back to store
recent updates did not meet with universal approval

Change-Id: Ic059729797049361c7a8a4ae000cd39a5993f6af
2016-04-28 15:39:29 +02:00
Stephan Bergmann
786f29a9ed Use COMPILER_PLUGINS_CXX during configure
Change-Id: I600a6b96a64fc82cde72200b78f60001a2dba82a
2016-04-28 15:00:48 +02:00
Noel Grandin
26d73dbf53 loplugin:stylepolice
Change-Id: I151e4d94f1f5dc84ef3f91218686ca9d1b9bc36f
2016-04-28 14:06:18 +02:00
Miklos Vajna
2465cb2676 vcl: fix loplugin:stylepolice
Change-Id: I40455e04a5f69dc0956ccb01c48d8a40245a4506
2016-04-28 14:04:44 +02:00
Michael Stahl
e2b37bfb8a framework: CheckXTitle still sometimes fails on WNT...
... when dispatching the .uno:CloseWin.

Change-Id: Iaf0651ea7e05bd8a6629d5af6e62f5918ef241ce
2016-04-28 13:10:34 +02:00
Jorenz Paragas
29c4f7bd58 tdf#42949: prefer including Reference.hxx over Reference.h...
...and so on for Any.hxx and Sequence.hxx.

This commit follows up on two of my previous commits, which are
6a4a15c87c and
474eca1f9b.

Many non-static inline functions that are declared in Reference.h and
similar files are not defined in the .h file, but their definitions
are in the corresponding .hxx files instead. Thus, let's prefer
including the .hxx files over the .h one so that we don't include
inline functions without their definitions.

In practice, the corresponding .hxx file is included transitively
from many other places, but it's better not to rely on that.

Change-Id: I3bada39eb879ae736c0360f435b16cd5a61adba8
Reviewed-on: https://gerrit.libreoffice.org/24456
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28 09:59:39 +00:00
Caolán McNamara
02c5ab3507 FixedLine copyspacer was removed from .ui but referenced in .cxx
since

commit 4e6fd4f4b5
Author: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Date:   Wed Apr 27 13:48:34 2016 -0500

    Print dialog: minor spacing tweaks

    Change-Id: I58ea5ec681746b36d6eb1899b7fd9a42adb29dae

Change-Id: I79eccb80108c1ceea52deae6c3116e8325356aed
2016-04-28 10:54:22 +01:00
Oliver Specht
5f63e19ddf tdf#74328: loading section page no. as 16 bit unsigned
The sprm sprmSPgnStart97 contains a 16 bit unsigned value. Test included.

Change-Id: I300e9a94c13666cf8e71d3613b8f1171c7314cdd
Reviewed-on: https://gerrit.libreoffice.org/24431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-28 09:40:02 +00:00
Muhammet Kara
376c337d46 tdf#97087 Give comprehensible, unique names to idles
Timers and idles should have programmer comprehensible, unique names

Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101
Reviewed-on: https://gerrit.libreoffice.org/24388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-28 09:34:30 +00:00
Noel Grandin
91adb929d7 clang-tidy modernize-loop-convert in h-l/*
Change-Id: I843528327b25d18476f8959cabba16371213a48a
Reviewed-on: https://gerrit.libreoffice.org/24460
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28 09:31:29 +00:00
Noel Grandin
43b4903db3 teach stylepolice plugin about ref-counted-pointer naming
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752
Reviewed-on: https://gerrit.libreoffice.org/24459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28 09:31:16 +00:00
Noel Grandin
7d6308dad9 loplugin:stringconstant
Change-Id: I780775ed5fa516d10c787ac2e11a034a7fc7da9c
2016-04-28 09:55:46 +02:00
Akshay Deep
d3d546a8e1 tdf#98037 - SIDEBAR: Replacing 'Speed' drop downs with comboboxes
Changed speed dropdown in SlideTransitionPanel to Duration combobox.
Used Custom Widget VclComboBoxNumeric with MetricBox class.
Unit set in seconds.

Change-Id: Id295b0ecbd62c60e434d8c65f74d50cdc39c9ecc
Reviewed-on: https://gerrit.libreoffice.org/22865
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-28 07:50:37 +00:00
Miklos Vajna
b94d753ac9 Related: tdf#65642 RTF filter: import \pgndec
This as a side effect also implements support for DOCX <w:pgNumType
w:fmt="decimal" .../>.

Change-Id: I747c3f610dc13f614b6f962c2a498c987765ebb6
Reviewed-on: https://gerrit.libreoffice.org/24457
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-04-28 07:45:15 +00:00
tymyjan
1269415560 tdf#97499 Fixed containers parameters clearing #7
Change-Id: Ieb9ab0f9c011a24ba329cfb063e3d7733dd1afcb
Reviewed-on: https://gerrit.libreoffice.org/24440
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28 07:26:58 +00:00
tymyjan
6dbcebab6d tdf#97499 Fixed containers parameters clearing #6
Change-Id: I89ad45eacfffd3783687b158a45f3eda0b95dece
Reviewed-on: https://gerrit.libreoffice.org/24433
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28 07:26:39 +00:00
Guillaume Smaha
4d2bb79582 Unit test for tdf#96097: Can't save/pointer null
Change-Id: I56af30142bba8579ca7f24bbbb2d12390832051b
Reviewed-on: https://gerrit.libreoffice.org/24372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-28 07:20:05 +00:00
Szymon Kłos
b4bbca013e RemoteFilesDialog: icons for view mode buttons
Start Center > Remote files
Deleted text and icons inserted into view mode buttons.

Change-Id: I0f3caad792d2b87993c08014f38d4f68599132ae
Reviewed-on: https://gerrit.libreoffice.org/23249
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-28 06:42:06 +00:00
Guillaume Smaha
d7ef7e3e4b tdf#96097: Can't save a doc with signed macro after autosave/save a copy
Change-Id: Icc886a8d228cb786c6f318cfa2556ef113c553eb
Reviewed-on: https://gerrit.libreoffice.org/24081
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-04-28 06:20:32 +00:00
Adolfo Jayme Barrientos
45217f70ff Some Tango updates
As usual, mainly from Adwaita, with minor adaptations by me.

Change-Id: I719d5e4c9c51c6f9476eb6b6bce0e117dc24d5e5
2016-04-27 20:55:55 -05:00
Adolfo Jayme Barrientos
212bb39bb6 Updated core
Project: help  743ed49ef0759b6cbd65d707ae9b8bba90e81a4d

“Mail & News” is just “Mail” now

Support for the news:// protocol was removed in core commit 6d089a4c7

Change-Id: I858331b9fc73502915cbd5fc2a8618e0837ba2a6
2016-04-28 01:52:02 +00:00
Adolfo Jayme Barrientos
42d7c0d8c5 Updated core
Project: help  32a855a02c55f864af7b2d1a7ebddd55043e297b

tdf#92825 Update Impress’ Master menus

For now I removed the tip paragraph on “Format > Slide Layout”, which is
a very old window (from ~2004-era OOo) that nowadays is replaced with the
Sidebar (and before the Sidebar, it was replaced with the Tasks pane).
This tip linked to more obsolete content… It’s a growing snowball. We
really need to get ourselves busy and rewrite all that.

Change-Id: I70e48f7613a0b17649e88f12c986a5ff1969deba
2016-04-28 01:28:00 +00:00
Takeshi Abe
615e3502c5 Resolves: tdf#88320 parsing fails with a subscript number
... ending with comma and followed by non-space.

Change-Id: Ia00c662e31940270690c64e1840417436565a6c7
Reviewed-on: https://gerrit.libreoffice.org/24260
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-27 23:40:37 +00:00
Xisco Fauli
a7bd0355cc vcl: remove unused variable and redundant method
Change-Id: Id3662a21b6a687f9283f93778e5b70183e4f0c04
Reviewed-on: https://gerrit.libreoffice.org/24435
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-04-27 21:33:35 +00:00
Markus Mohrhard
f710c017a6 add todo list with open performance problems in calc
Change-Id: I3f9969b142b2673aadc9b85c77e226c7b2806d51
2016-04-27 22:42:46 +02:00
Maxim Monastirsky
e4ae5e2d40 SubToolBarController: Use initialize to change tb bits
update is called so late that the dropdown addition is
noticeable by the user.

Change-Id: I36d76770125f927a851caef010e81f12f40d4405
2016-04-27 22:20:22 +03:00
Eike Rathke
f5cd030ee0 extract adjustCopyRangeName() from adjustRangeName()
Change-Id: I1dd41a4fe96187750d4269e732ca39c19de3c060
2016-04-27 21:06:21 +02:00
Eike Rathke
bd2800df84 make findRangeNamesReferencingSheet() independent from a passed FormulaToken
Preparing to extract some functionality.

Change-Id: Ic0e298273f6f047a7d35aaa31fb99d9a45128ad0
2016-04-27 21:06:21 +02:00
Eike Rathke
cc5f8c6bf0 FindRangeNameByIndexAndSheet() to FindRangeNameBySheetAndIndex()
index,sheet was slightly confusing as we lookup an index within a sheet.

Change-Id: I164dd48187e6652639094e33ca83a91a96c893a0
2016-04-27 21:06:20 +02:00
Adolfo Jayme Barrientos
4e6fd4f4b5 Print dialog: minor spacing tweaks
Change-Id: I58ea5ec681746b36d6eb1899b7fd9a42adb29dae
2016-04-27 13:52:37 -05:00
Xisco Fauli
80590c1162 tdf#62525 vcl: use cow_wrapper for Hatch
Change-Id: I520b2a6a8c309b3702208633ed86225f61b7368c
Reviewed-on: https://gerrit.libreoffice.org/24376
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-04-27 18:48:53 +00:00
Maxim Monastirsky
579c2de3a8 tdf#80999 Canceling password prompt should abort detection
... instead of continuing the detection loop and being
"detected" as plain text. The detection API will from now
return a type based on the file extension only, which is
far more useful than "plain text" anyway. Plus the media
descriptor has a flag to indicate that the detection wasn't
completed, which can be also used by the loading code to
abort the loading process.

Change-Id: Ida37e2687bd5cd86b5780620724e9bce82e11946
Reviewed-on: https://gerrit.libreoffice.org/24428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-04-27 18:36:57 +00:00
Michael Stahl
ef52ce82bf tdf#89866 tdf#96504 vcl: fix printing of form controls with images
Originally in 2004 commit 0339e43208 added a
"DBG_ASSERT( GetOutDevType() != OUTDEV_PRINTER, "DrawImage(): Images can't
 be drawn on any mprinter" );"

Recently commit f749ffbdf4 made the mistake
of trusting this assertion to be correct and added Printer::DrawImage()
overrides that do a hard "assert()" now and don't do any drawing.

Armin claims that the implementation of OutputDevice::DrawImage() should
actually work for Printer as well due to fall-backs and thus the
original DBG_ASSERT was misleading.

This matters when printing documents that contain form controls
such as ImageControl.

Additionally, Image::Draw() should not return early when
IsDeviceOutputNecessary() is false, because that is the case when
printing, where instead a meta-file is recorded.
The called OutputDevice::DrawBitmapEx() will check
IsDeviceOutputNecessary() internally anyway.

This check was actually always there, so i do not understand how this
should have worked in LO 4.2, as the bug reporters claim.

Change-Id: I92ba19e7036197d1dde88c361f8e1cb59fae3a60
2016-04-27 18:46:25 +02:00
Miklos Vajna
db4cba7603 beans: if loading a library fails, show the reason
Don't do it for the MSVC libraries though, e.g. on my system loading
msvcr70 fails, but the SDK example works without problems.

Change-Id: I81bc0b64967e7abb74ca1fff7a2e4b4dbd75d5a5
Reviewed-on: https://gerrit.libreoffice.org/24432
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-04-27 16:42:31 +00:00
Caolán McNamara
b71f470e37 Resolves: tdf#99498 don't overwrite trwWidth value if set on a table
Change-Id: Ia39da999a2de1ca2b8bec5fc7f35d2f9ffe2dd19
Reviewed-on: https://gerrit.libreoffice.org/24430
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-04-27 16:30:07 +00:00
Eike Rathke
0445de5e0d accept UTF8 as explicit charset value
... to follow the (wrong) docs on the net.. it doesn't harm.

Change-Id: I30c34edb6dc1c56084625de8e52bfb5afe82fcf7
2016-04-27 18:06:32 +02:00
Luke Deller
817c3b17fa tdf#99474 close direct char fmt at end of para
When exporting to doc, ensure that the FKP entry for direct character
formatting is closed at the end of a paragraph, so that any direct
character formatting in the next paragraph does not apply to the
end-of-paragraph marker (CR).

Also revert the changes for i#119650 and tdf#87437 which targetted
more specific examples of this problem, as those issues should now be
covered by this fix.

Add a test case for the example from tdf#99474

Change-Id: I2cb482adb39a84f152707dafcb18f289ca0bd550
Reviewed-on: https://gerrit.libreoffice.org/24402
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-27 15:17:22 +00:00
Miklos Vajna
99ea437f75 lokdocview: log postMouseEvent() arguments
Change-Id: Idd4db9259448d3dcf4e0820b8845a1ab395f0bff
Reviewed-on: https://gerrit.libreoffice.org/24427
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-04-27 15:00:36 +00:00
Jorenz Paragas
de4b758ff3 Improve the gen-iwyu-dummy-lib script a bit.
- Fix the check for --enable-compiler-plugins not being included in
  the resulting StaticLibrary_iwyudummy.mk file.
- Disable warnings about unused const variables to reduce noise.

Change-Id: If54dfd55f46631bbc526326bed5c272358fb9cf3
Reviewed-on: https://gerrit.libreoffice.org/24419
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-27 14:34:05 +00:00
Michael Stahl
4ec7128470 convwatch: use PerTestConnection by default
It's more robust to restart soffice after every file, even if it takes
more time, overall it's better than having to prune all the files that
are invalid or cause loops before running convwatch.

Change-Id: I7f7155f71bb2522ae48182aa1b5ca61fc47ae4d5
2016-04-27 15:52:42 +02:00