In pivot table cache, data rows are always zero-based, and are
different from the rows of cells from which the data are pulled.
This error resulted in incorrect pivot table result when the "skip
empty rows" option was set.
Change-Id: I4fccb37a8667f7e40d6130ac641d7b2a1daa7694
when loading broken xls files with change tracking we may crash because
of invalid memory access that results from loading to few bytes and then
using the originally created array
the patch changes it to check for the right amount of loaded bytes and
otherwise skips this change tracking record
Change-Id: I0795104284479368e26b8411336cee690abffd06
Import (ab)used ScFormulaCell::SetHybridDouble() in the sense that
actually it is not a hybrid (no formula string, the token array is
present in binary import) and during interpretation a matrix was
expected but instead the hybrid encountered.
Introduced ScFormulaCell::SetResultDouble() for exactly this case as a
workaround.
Change-Id: I4da3812ef4974380224b5a2bf42d0b62c14d121b
This reverts commit 0d53a8336b.
This file isn't referenced in any other file. For me those icon
files are not in any images*.zip file. But the update extension
seems to use the Throbber class, which refers to this icons.
To be absolutely sure I revert the change. Maybe someone else wants
to have a look at this.
Previously we only considered the first page of the whole document as
first page, which was incorrect.
Change-Id: I2e37fe504a5baee986d63d0cdef166f836877174
Errors during compile:
* sc/source/core/tool/interpr1.cxx: In member function ‘const String& {anonymous}::VectorMatrixAccessor::GetString(SCSIZE) const’:
sc/source/core/tool/interpr1.cxx:4629:71: error: returning reference to temporary [-Werror]
* with --enable-werror
* sc/source/core/tool/interpr1.cxx: In function ‘void {anonymous}::lcl_GetLastMatch(SCSIZE&, const {anonymous}::VectorMatrixAccessor&, SCSIZE, bool)’:
sc/source/core/tool/interpr1.cxx:4724:52: error: ambiguous overload for ‘operator==’ in ‘aStr == (& rMat)->{anonymous}::VectorMatrixAccessor::GetString((rIndex + -1u))’
sc/source/core/tool/interpr1.cxx:4728:52: error: ambiguous overload for ‘operator==’ in ‘aStr == (& rMat)->{anonymous}::VectorMatrixAccessor::GetString((rIndex + 1u))’
Change-Id: I28eb3d23f4d5c08a30534abdf940597923cbb68c
* ./logerrit review did not resolve the ChangeId to a SHA
* ./logerrit did still echo the command instead of executing it.
Change-Id: Ie4f8630f7a83134d6eb7992f4a61b5d3faf7e138
- the reverse_iterator actually points to the element preceding the
original "it", so on the first iteration it shouldn't be incremented,
as that has happened implicitly already
- it's best to use iterators to iterate over maps
- also fix some pre-existing operator delete[] mismatch
Change-Id: I969d1b79eb970792ee8b0578347ffb59d5a64379
SvxIconChoiceCtrl_Impl::GetColumn: pColumns is now a map, so don't test
the index against the size, but check the index only via find.
Change-Id: I9451000f8c2fe7a7b0c745f3b8c8d61e35879b43
