For multi-column sections in Writer, HTMLMODE_FRM_COLUMNS controlled
whether column settings for the section were exported to html or not.
This was disabled for Internet Explorer and enabled for other browsers.
The export was implemented using non-standard MULTICOL html element
and did not actually work in any modern browser (apparently only
some versions of Netscape have ever supported this). This patch
- exports the column count also using "column-count" CSS attribute
which is supported by latest versions of Opera and IE. Firefox and
Webkit based browsers would currently require -moz-column-count and
-webkit-column-count but I have not added these since the browsers
will likely stop requiring the prefix in the future anyway.
- removes HTMLMODE_FRM_COLUMNS conditional so that this export will
happen with all html compatibility options, including IE.
Remaining issue: Using the MULTICOL element (as opposed to DIV element)
confuses at least Opera so that it ignores all style attributes applied
on the element. But corresponding html import code in LibreOffice still
relies on MULTICOL. I will work on a separate patch to add support for
column-count CSS attribute to the import code and switch export to use
DIV instead.
Change-Id: I82a065fdda0e074fbfcd0007e6ff6e46185be3f5
Reviewed-on: https://gerrit.libreoffice.org/2950
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
- twas more of a proof-of-concept anyway
- its more clumsy than both:
- git-review https://wiki.documentfoundation.org/Development/GitReview
- or simply using the web UI
Change-Id: Id7a11fcdaf95386c451d0e6421d32de7d1d02721
Reviewed-on: https://gerrit.libreoffice.org/3070
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
...instead of "SHELL=@BASH@" from d3f7d05d1b
"Clean up OOO_SHELL" which could expand to SHELL=/bin/sh which, at least on
Mac OS X 10.7 with /usr/bin/make 3.81, could apparently lead to recipe lines
calling ooinstall being directly exec'ed from make and failing to find ooinstall
in solenv/bin, instead of going via the shell and taking into account PATH from
included config_host.mk.
Change-Id: I841dc30f72d1d8841c64f48408a669eb6a37a1f3
Encapsulate whole switch case code by #if
so it does not produce unreachable code when TRUE
Also found second occurence in function overload.
Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96
Reviewed-on: https://gerrit.libreoffice.org/3066
Reviewed-by: Christoph Brill <egore911@gmail.com>
Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
Tested-by: Tomáš Chvátal <tchvatal@suse.cz>
There were two issues here:
1) The export filter never exported these keywords.
2) The "flymaincnt" RTF extension we inherited from OOo actually never
worked (i.e. it's like this since 7b0b5cdf, the initial import...), as
RTFVertOrient / RTFHoriOrient's second parameter was stored in 1 bit, so
text::RelOrientation::PAGE_FRAME (7) was read back as 1 instead.
Note that I want to get rid of this flymaincnt extension in the exporter
anyway soon, so killing the RTFVertOrient / RTFHoriOrient duplication is
pointless: the sw version will go away.
Change-Id: I5335567833ecf87e6b0ba7c73150a7b95c57f237
Defines HAVE_FEATURE_{DESKTOP,HELP,MULTIUSER_ENVIRONMENT} for
now. Using <config_features.h> will supersede checking the
LIBO_FEATURE_DESKTOP and LIBO_FEATURE_HELP passed on the compilation
command-line.
Change-Id: I9866e2fd142f5c1a64c8f5c74452a20de23c66e3
