warning says the item pool is not empty,
so test item pointers for not null.
ever since initial commit cf7e1f9cc9
and make warning more descriptive by adding pool names
Change-Id: I3a8a6ca69e319d01418eac527b15f61adfd0fb13
Reviewed-on: https://gerrit.libreoffice.org/34589
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Instead of a minimal margin, default margins were being applied
because an exception was thrown when trying to set a negative
value to top and bottom margins in SvxULSpaceItem::PutValue
Change-Id: I0a9fc2c7cb996efbd26abfdbed27ea0bcb86d9a5
Reviewed-on: https://gerrit.libreoffice.org/34598
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
... if that toolbox is in popup mode (e.g. shapes toolbar
dropdowns, or the toolbar overflow floater). Same behavior
was introduced for non menu based dropdowns in
81d4fbc0da ("tdf#42029 Use a
floating toolbar to show clipped items"), and is similar
to what we had already in ToolBox::Select, i.e. when the
user made a selection, the floating windows should close.
This must be done before executing the menu selection
handler, because such handler might execute stuff
synchronously (e.g. MenuBarManager::Select), and if it
will open a modal dialog, the floating toolbox will stay
visible after the dialog shows.
Change-Id: Ie93e71fa4dea80ba444aebccacf6adb926a39224
... after commit fde6bbe41d
("right click to insert image"), added .uno:InsertGraphic
to the slide's context menu.
Change-Id: Ib801899c17cc4f765f46fd4b8884e6b57b455f6d
rSecondStart.nContent in this case has no m_pIndexReg
just move on with our lives wrt this sorting
Change-Id: I9642c5d345dabd02f3feea83bc2ffbf3f7adb082
Reviewed-on: https://gerrit.libreoffice.org/34336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
results in a disposed submenu in the menu, we need to flag with bSubPop4
that we have inserted the submenu into the parent menu to not dispose
it
Change-Id: I5b9711c0bba750c11d64dc175efd452f4bc8f4e5
...so the functions operating on them can all just return osl_File_E_INVAL. (The
way to create an oslVolumeDeviceHandle is via osl_getVolumeInformation storing
it into oslVolumeInfo.pDeviceHandle. But the unx implementation of
osl_getVolumeInformation never sets that, so it'll stay at the null value that
callers must initialize it to.)
Change-Id: Ibabd89e8f9de0892a0e815d30b6397f869e7df70
If the inserted string contains "\r", such as when importing
lp556169-2.rtf before the previous fix, the given cursor has one of its
positions mangled because its nNode will be on the new node, but the
nContent that is restored here is on the old node.
The invalid cursor causes an assert in the subsequent SetPropertyValues.
Change-Id: I73a2e6ecd02ccf75f7b9ffd89d90ae1e3a93ceb2
... in Word 2010, while the spec doesn't say what they do.
So just handle \'0d and \'0a like \par.
This fixes an assert failure on importing lp556169-2.rtf, where
insertTextPortion was called with a string containing "\r", which split
the paragraph and that messed up the SwPaM.
Change-Id: Iee8b5b47e15d18232de841adfbc9c6498727c384
In case the bitmap is large enough, the bitmap for the PDF image is a
JPG one, not a PNG one. Handle this case as well.
Also stop compressing the PDF data: Adobe Acrobat gets confused when the
second bugdoc is compressed and it doesn't provide much as most of a PDF
is already compressed anyway.
The rest is just refactoring to decouple the reference XObject code from
PNG, to be able to use it for JPG as well.
Change-Id: I5314a39b0f6d8c6493ecb36a0c588c895f5a70ee
One can set the a document attribute to open the doc read-only.
In this case the read-only infobar should not be shown.
Change-Id: I92b78dc3e20ccf0d258cdf3e4a79530f87a2e311
Reviewed-on: https://gerrit.libreoffice.org/34581
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
let's see if it appeases the tinderboxes
Change-Id: Icfe97381395f5554d51cfb52289b3de89abbbb68
Reviewed-on: https://gerrit.libreoffice.org/34569
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
...where -Werror -Wunknown-pragmas command line arguments will trivially make
the test always fail, anyway
Change-Id: Iae5534054331d41508f39d5cf141803ab5bc8ba7
...instead of a warning (as with Clang), so this follow-up to
e16644fa1c "external/mysqlcppconn: Silence
-Wdynamic-exception-spec errors" patches the (few) dynamic exception
specifications out of external/mysqlcppconn completely
Change-Id: I83a42f1c09e60c15fad1564cf7c42eb3370485da
...to avoid having to generate a temporary in e.g.
SwXParagraphEnumeration::Create (sw/source/core/unocore/unoobj2.cxx), and thus
to avoid <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79679> "[7 Regression]
[C++17] Missing destruction of temporary within constructor's
mem-initializer-list"
Change-Id: Ifaa5a6d0e9baa77a19752f54e7765783139bea95
Which is not even built since gbuildification.
Change-Id: I5fbacc32289c4a534d49ca9042cca4e40fa53815
Reviewed-on: https://gerrit.libreoffice.org/34565
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
in particular, the one from gpgme project. configure check is set
up in such a way that it will fail with older gpgmepp that depends
on KDE development packages.
This means Linux distros released before 2016 have to rely upon
in-tree version, but such is life ...
Change-Id: I5cdceffad6e81643603fcdee57a7656218f76834
Reviewed-on: https://gerrit.libreoffice.org/34130
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
...implying that pLocalThreadId, nRefCountOfCurrentId, pCurrentId are
initialized, implying that zero-initializing them during construction isn't
necessary.
Change-Id: I98399203694edde14abc664a82861ba50dfb357c
