Commit graph

461189 commits

Author SHA1 Message Date
Rizal Muttaqin
d0e3c935bc elementary: tdf#141285 new icons for status bar selection type
Change-Id: I5f3ad22132360c2d8a148dc42099c8b5b09e47b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113242
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-28 08:27:47 +02:00
Rizal Muttaqin
cf38327eb0 Breeze: tdf#141285 new icons for status bar selection type
Change-Id: I01afb5e1e1c42a4e4e852836512bf3d3b8ad44a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113241
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-28 06:59:36 +02:00
Rizal Muttaqin
e3b86616ef tdf#126689 Sukapura: Continue Previous Numbering icons
Change-Id: Ifb85f3cff2e37cf9ae37cdaab419a09135a9f9e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113238
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-28 04:19:36 +02:00
Seth Chaiklin
35a06c6770 Update git submodules
* Update helpcontent2 from branch 'master'
  to 5a458a01e0c029938da4a9f9bd4bb4a89215655e
  - correction of control label in Outline & List tab for Paragraph
    
    Change-Id: I6ffc931e459eda7774e9bd72f288277c51a93071
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113220
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
    Tested-by: Jenkins
2021-03-27 23:31:32 +01:00
Seth Chaiklin
db7b7d4316 Update git submodules
* Update helpcontent2 from branch 'master'
  to 2833c3df390906bccc99da5117ccb6e989473412
  - tdf#118834 dialog buttons to Character Style,Organizer,Font,Outline&List
    
      also changed heading "Numbering" -> "Apply List Style"
      in swriter/01/05030800.xhp (Outline & List tab) because
      this heading was changed with tdf#139667
    
    Change-Id: I78e2704d4e1bea677b8bf6f8456cd11af0e4b27a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113122
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
    Tested-by: Jenkins
2021-03-27 22:30:49 +01:00
Seth Chaiklin
ad826c2809 Update git submodules
* Update helpcontent2 from branch 'master'
  to 155384c51ee22314c18a428ec7c1c773b222e804
  - tdf#137715 add "text in data range" note to diverse functions
    
      ( scalc/01/04060118.xhp )
        FVSCHEDULE
    
     ( scalc/01/04060103.xhp )
       IRR
    
     ( scalc/01/04060105.xhp )
       AND, OR
    
     ( scalc/01/04060106.xhp )
       SUBTOTAL
    
     ( scalc/01/04060107.xhp )
       FREQUENCY
    
     ( scalc/01/04060119.xhp )
       NPV
    
    Change-Id: I6b6fe55f232bf4aa5e66db1f7fb8e6f6255b15e9
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113219
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 22:11:07 +01:00
Seth Chaiklin
2b09ddd1df Update git submodules
* Update helpcontent2 from branch 'master'
  to 267f7663e5705dcf822f317ad386130b853fd484
  - tdf#137715 add "text in data range" note to statistical functions
    
      ( scalc/01/04060181.xhp )
        COUNT
    
      ( scalc/01/04060182.xhp )
        FTEST, GEOMEAN, HARMEAN, TRIMMEAN, ZTEST
    
      ( scalc/01/04060183.xhp )
        KURT, LARGE, SMALL
    
      ( scalc/01/04060185.xhp )
        DEVSQ, STDEVP, VAR, VARP, RANK, SKEW, STDEV
    
      ( scalc/01/func_skewp.xhp )
        SKEWP
    
    Change-Id: I4ddfadff93bb39ff426f8d6887009cdf6c261e08
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113218
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 22:10:40 +01:00
Seth Chaiklin
9c9382dc29 Update git submodules
* Update helpcontent2 from branch 'master'
  to 9535013762e34c86cc4fa19a1ae94d346899a821
  - tdf#137715  text in range note for SUM, AVERAGE, SUMSQ, PRODUCT
    
      This patch started as a repair for the revert of
      11e69d34205bf773f2aa4f4be5c8fa08566ed7d7
      by using a new approach to adding a note for SUM, AVERAGE,
      SUMSQ, and PRODUCT.
    
      Because some other functions in the same files also need
      the note, they were included as part of this patch.
    
      The additional functions are:
    
      ( scalc/01/04060184.xhp )
        MODE, QUARTILE, AVEDEV, MAX, MEDIAN, MIN, PERCENTILE,and
        PERCENTRANK
    
      ( scalc/01/04060106.xhp )
        MULTINOMIAL, GCD, LCM
    
    Change-Id: I969a65a6410372561de4df39444cdac9b4bc96f6
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113215
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 22:10:12 +01:00
Caolán McNamara
780e1ffb99 cid#1473755 Untrusted loop bound
deem_sanizize isn't sufficiently complex to sanize its input apparently

Change-Id: Id1d73feefce9b587a8024021d8766267b105b4f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113234
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-27 21:55:55 +01:00
Caolán McNamara
618cb39b55 tdf#141141 sync SalFrame::GetFrameWeld and weld::GetPopupParent
so they both use the same FrameWindow

Change-Id: I7c58a4f2c8e82abc45eaf1dfee8eb2720503ecc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113209
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-27 20:10:49 +01:00
Caolán McNamara
18a0a72a94 make deem_sanitized a constexpr
Change-Id: I30e9b42fa0a296faafbb51634dcbc1a56adb2d41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113208
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-27 20:10:26 +01:00
Andrea Gelmini
a35a318b04 Update git submodules
* Update helpcontent2 from branch 'master'
  to beea8e159de2edc366aa1b37524124220999cd76
  - Fix typo
    
    Change-Id: I23bc6c6fdb13bc41b39e6d6d05886738c5e9bd5e
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113210
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-27 18:57:50 +01:00
Lionel Elie Mamane
d0efd1e280 tdf#141115 semi-userfriendly message on UNION query on file driver
Rather than silently returning only the first (left) part of the
UNION, error out.

Change-Id: I6ed1eba55ad33f149d9010933a3c7a835fce0451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113207
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Tested-by: Jenkins
2021-03-27 17:34:13 +01:00
Seth Chaiklin
052d3625c7 Update git submodules
* Update helpcontent2 from branch 'master'
  to 938d18980a672859c4e9b754df10bf18fa6b1cd4
  - Revert "tdf#137715 add "note" to AVERAGE, SUMSQ, PRODUCT in Calc function help"
    
    This reverts commit 11e69d34205bf773f2aa4f4be5c8fa08566ed7d7.
    
    Reason for revert: A new, better solution is found for adding a
    note to these functions that avoids retranslation and avoids technical
    problems with <embedvar>. That solution will be used in a new patch
    for these functions.
    
    Change-Id: I614eb2020b77715b5785ad3a2934cc359f0b8ef9
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113214
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 16:26:30 +01:00
Seth Chaiklin
ba4b18db8c Update git submodules
* Update helpcontent2 from branch 'master'
  to 4de9606186a78818a49c1f8d687b30d0e09fda9b
  - tdf#137715 add "note" to DateSequence functions about text in range
    
       + add generic <note> in scalc/01/common_func.xhp about text
         in data ranges, which can be used for all functions that
         can be affected by this problem.
       + embed this note for all relevant DateSequence functions.
    
    Change-Id: If1c245d70f2b4aa464c50e502eed387b1d39f081
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113129
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 15:40:18 +01:00
Rizal Muttaqin
085e2a876f Colibre: tdf#141284 Inconsistent Track Changes icons
Change-Id: Ib2ff76d83e49b6ba5c68d3b461c0608bd589f955
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113201
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-27 14:57:28 +01:00
Rizal Muttaqin
2eb3c3ebfa Sukapura: tdf#141282 fix wrong icon for Demote One Level with Subpoints
Change-Id: I63ee5a71f52a51a1682f924982c68c33c60781be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113203
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-27 14:09:39 +01:00
Seth Chaiklin
86bac23f38 Update git submodules
* Update helpcontent2 from branch 'master'
  to ec604892f94f779a80a69ca25c975b4a992a7620
  - tdf#118834 add Apply, Reset, Ok, Cancel to Page and List style help
    
    Change-Id: Ia01264b80ba1e8d30133a097c32f147a7b433af7
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113120
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 13:32:14 +01:00
Seth Chaiklin
61d61fbc1e Update git submodules
* Update helpcontent2 from branch 'master'
  to 087fe6b4f1605bd4a81a95457742bced294a0b2e
  - related: tdf#118834 explain Apply, Reset, Cancel in style dialogs
    
    Change-Id: I8c791ec71b4716e03742eefca5a71444ac5aff0c
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113117
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-27 13:28:40 +01:00
Caolán McNamara
b2a782b725 cid#1209863 silence Untrusted loop bound, it *is* tested here
Change-Id: Ie7e1bc3d8cfa8029569259487ea8f8a0d1b6245b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113173
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-27 12:13:05 +01:00
Lionel Elie Mamane
f4367cfd69 tdf#141115: correctly find the ORDER BY clause of a UNION
instead of blindly assuming a SELECT is not a UNION, leading to an
out-of-bounds array access when it is.

Change-Id: I8f904ae65acba8d8ee23b95299058207af68c0ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113189
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Tested-by: Jenkins
2021-03-27 11:49:51 +01:00
anirudh4583
6e1bd835ed tdf#124176 Use pragma once
Change-Id: I58e9a50587d2f815ca09939a650debaa9a0a4969
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113187
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-27 11:10:41 +01:00
Seth Chaiklin
53c6aaac23 Update git submodules
* Update helpcontent2 from branch 'master'
  to 11e69d34205bf773f2aa4f4be5c8fa08566ed7d7
  - tdf#137715 add "note" to AVERAGE, SUMSQ, PRODUCT in Calc function help
    
       ( scalc/01/04060106.xhp  )
        + add two variables "ignores" and "look" to <tip> in SUM
        + use two new variables to compose similar tip for
          "PRODUCT" and "SUMSQ"
    
        ( scalc/01/04060184.xhp )
        + use two new variables to compose similar tip for AVERAGE
    
    Change-Id: Id6fd2f38a3f3d7c381b3efe99a98303a81e0c1d6
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105535
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 09:33:08 +01:00
Seth Chaiklin
e49da2a340 tdf#139667 add or improve List Style tab tooltips
* added tooltips to tabs that did not have them and
     adapted existing one to the fact that this is a style
     dialog, and the tabs must be understood in relation to
     editing a list style.

Change-Id: I316f8c4cc2e486476334c703916b5851905169fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111776
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-27 09:26:18 +01:00
Jim Raykowski
e18b743a84 tdf#140936 statusbar selection mode control improvements
- shows different image for each selection mode
- tooltip indicates the current selection mode and mouse click hint
- replaces left-click cycle selection mode with context menu popup

Change-Id: Ieb2662de99cf42d4ada4c1a590bebc8363861c7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112367
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-27 09:01:30 +01:00
Steve Fanning
30b85dd258 Update git submodules
* Update helpcontent2 from branch 'master'
  to a502c5a5959e7c01b7769bf20778d7791876bde0
  - Fix minor typo in recently-updated help file describing Calc's database functions (04060101.xhp).
    
    Change-Id: Ia7b9092a03164722fe9ddb97816195dcb3fb9d2b
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113126
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-27 09:01:01 +01:00
Jim Raykowski
2981e49878 Sw Navigator: Improve chapter delete
by selecting to the start of the next outline node vs selecting to end
of the last paragraph before the next outline node.

Change-Id: I5a51ff5c1ced8d9ab0aee7c7b38fc5235027f384
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113140
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-27 08:22:59 +01:00
Michael Meeks
f960040962 lok: mark strings static after pre-init, not after the fork.
Change-Id: I1fbd4a9ef1e07ec87ca194128ed35de1dc429993
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113127
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-03-26 20:42:35 +01:00
Caolán McNamara
2ebc8433fb cid#1474320 silence Untrusted allocation size
Change-Id: I919e7dad4f03e9c9b4edce1959717c344c6e6134
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113170
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 20:41:33 +01:00
Caolán McNamara
65b99967c4 split this to give a sanitizing return pass through
Change-Id: I81eba14e31fe12fc92403c15e5d46f0493022f50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113169
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 20:41:12 +01:00
Caolán McNamara
5b462dff91 cid#1242796 Untrusted loop bound
Change-Id: I04e5df04747b764d4bfe035662b07a450ae0e5c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113168
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 20:40:49 +01:00
Caolán McNamara
4c9e40653c cid#1474321 make it a little more clear that the size *is* checked
Change-Id: I07632cbb9722f409877a426000eedc47822fdc44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 20:39:57 +01:00
Caolán McNamara
5da1aa90bd improve scoping
Change-Id: I560e02d7a6a2685f98e55a66b2805217f1dfcbff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113166
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 20:39:29 +01:00
Caolán McNamara
9befa8b174 cid#1474452 Unchecked dynamic_cast
Change-Id: Ib50140fad741d34eae0dfe28fd4ed03024d11e96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113165
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 20:39:11 +01:00
Caolán McNamara
5c5eeecfd5 drop unused argument
Change-Id: I4df204cd26046e7b767adf5b5e9ab568a4f8501c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113159
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 18:03:51 +01:00
Caolán McNamara
c700ded8cf cid#1474074 silence bogus Dereference before null check
Change-Id: I31a64f1f0765659c61fbf5f1a5b32d9705bcc2f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113160
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 18:03:30 +01:00
Noel
b624b13b3d loplugin:flatten
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-26 18:02:19 +01:00
Miklos Vajna
8136620ff4 sw define bibliography entry dialog: recognize file:// URLs
Give them a separate type at a UI level, so later a file picker can be
shown for the local file case.

Change-Id: If0ed639ea3d196da70fded6d1eb606f1ef4f2082
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113161
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2021-03-26 17:59:14 +01:00
Jean-Pierre Ledure
c1f5d07f35 ScriptForge - (scriptforge.py) Session class
Full support of the session class methods from Python

The InvokeSimpleScript() python method has been
extended to support broader scopes (extensions and user documents)
and ParamArray arguments in Basic.

Indeed the SF_Session.ExecuteBasicScript() and
SF_Session.ExecuteCalcFunction() require a varying number
of arguments.

No regression found in unit tests

Change-Id: I0899bc6535b00340ed82b46336d60a7bb23b2098
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113154
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-03-26 17:31:39 +01:00
Xisco Fauli
bcfad35ee4 tdf#116216: sc_ucalc: Add unittest
Change-Id: I07237a491e3018b1d54794ac8456ea0fce3ae07d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113153
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-26 17:30:49 +01:00
Xisco Fauli
c46d3b5204 tdf#46062: sc: Add UItest
Change-Id: Ie4fbb34712fd4c9eb97f70e2ef575f4d830d27b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113155
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-26 15:34:06 +01:00
Mike Kaganski
ed9ff1a397 Drop these defines
Change-Id: I7ff56d6f016ea90c4b5cdcbbb36141627037c0ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113125
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-26 15:05:44 +01:00
Tibor Nagy
967e0cc303 tdf#119292 sc layout: fix overlapping wrapped cell texts
if rotated by 90 or 270 degrees using clipping to
cell boundaries, like MSO does. E.g. this avoid of
importing MSO documents with unreadable header cells.

Note: it's possible to improve the patch extending
clipping for the neighboring empty area instead of
clipping all text exceeding the cell boundary
(as in the case of the non-rotated, non-wrapped text).

Co-authored-by: Attila Szűcs (NISZ)

Change-Id: Idd37f7eb7208ff3818dcdab93ef0ec57275db954
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111964
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-26 14:41:03 +01:00
Tomaž Vajngerl
ed62bbc71a devtools: move UI root element from GtkGrid to GtkBox
This triggered an assert in VclBuilder where it expects a weld::Box
and not weld::Grid when accessing the root.

Change-Id: Ifc0d7c7e8d52c5383aecd9814329e10bf55e6c89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113151
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-26 14:25:55 +01:00
Daniel Arato (NISZ)
797fef3861 tdf#118535 DOCX export: save header image once
Writer used to dump the same image file as many times
as it was featured in different headers or footers in
the document, bloating the .docx file size.

This is countered by making all "relationships" in the
header*.xml.rels files point to the same image.

Change-Id: I44d72630289c721d58d8f7e208517df2f1fe621c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112656
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-26 13:07:57 +01:00
Caolán McNamara
2f2475bb5d ofz#32111 Timeout
keep continuing on a short read, zeroing out the rest of the block, if
something was read, but give up if nothing could be read.

vcl/qa/cppunit/graphicfilter/data/png/pass/invalid-chunk.png remains
working after this. Though to be honest it is also unchanged if
we just png_error intead of png_warning

Change-Id: I7dc24bcfc0b33e534a3f9665b11cd9aca8003a89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113152
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 12:50:55 +01:00
Noel
83b011b61e create operator bool for Bitmap
so we can use a more natural syntax than "!!"

Change-Id: I8152a0d3ce37115fc83d332a26725ca1d28d959a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113147
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-26 11:58:03 +01:00
Xisco Fauli
f3b98808b1 sc: fix incorrect comment
it's wrong since it was introduced in 12c95935f2
$SC_FORCE_CALCULATION to force Calc use opencl/threads for everything

See sc/source/core/tool/calcconfig.cxx:39

Change-Id: I5569e220059d66a4bf71ec267cae603810c066c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113149
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Jenkins
2021-03-26 11:52:40 +01:00
Miklos Vajna
3b857c1d19 sw edit bibliography entry dialog: apply after edit
Steps to reproduce the problem:

1) double-click on a bibliography entry field -> edit bibliography entry
dialog appears

2) click on "edit" button -> define bibliography entry sub-dialog
appears

3) change e.g. the URL there -> OK -> sub-dialog closes

4) click "close" -> outer dialog closes

And now the user is confused, because the field is not updated. This
works as expected if "apply" is pressed instead of "close".

This happens because the SwAuthMarkModalDlg that hosts the
SwAuthorMarkPane can be in insert or edit mode. The inner dialog just
updates in-memory state outside the doc model. This makes sense in
insert mode, so the user can fine-tune where to insert the field; but
a separate "apply" step in edit mode makes little sense.

Fix the problem by automatically applying the changed values in edit
mode.

Change-Id: I333225328d103f160f8120a2abc7a264322437a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113146
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2021-03-26 11:52:31 +01:00
Caolán McNamara
5453c8b927 ofz#32499 overflowing pos
Change-Id: I164537acbb4d4bcf7dee51a029ffb518a3687fda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113150
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26 11:51:21 +01:00