* Update translations from branch 'master'
to b3af6d45ec04aa0bb3861e7fb1eab95a66c822f2
- update translations for 7.0 beta2
and force-fix errors using pocheck
Change-Id: I41df06b7c762dcaf88812f2667f02a6fae639e62
During the loading of numeric constants in StepLOADNC, create variables
of type Variant and convert them to the requested type, i.e.
Variant/Type in order to prevent type conversion errors, when they are
passed to a method with variant parameter types.
Change-Id: I2ab0111b5b53dd2de9523ba7cf12bd2519d050b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96402
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
when mnCheckWidthReq is available
Change-Id: I9964b1df9e025ab737d0d306148930c34b7d7148
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96474
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
We had a mix of 'using namespace vcl;' and 'namespace vcl {',
standardize on the later.
Change-Id: I088bb0e0c03f712242427bf6a0b31dd17755b9dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96475
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(also after right-aligned and decimal-aligned tabs)
before the page break in a justified paragraph.
Justify only after left-aligned tabs, like MSO does.
Regression from commit 07dcbed5fb
(INTEGRATION: CWS fmebugs01 (1.15.104); FILE MERGED
2004/02/09 15:13:57 fme 1.15.104.1: #i13507# Justified
alignment for lines containing manual breaks).
See also commit 5d7b347527
(INTEGRATION: CWS swqbf34 (1.17.96); FILE MERGED
2005/06/29 12:12:25 fme 1.17.96.2: #i49277# New
compatibility option bDoNotJustifyLinesWithManualBreak).
Change-Id: Ib92e301aaf46eec283c0850d23549b1b54106068
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96438
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
For cases when there are multiple matching apps where the Languagepack
might be installed to, the "make sure to launch LO once before
installing the langpack" mechanism can fail.
Even if it is the call "tell application <selection> to activate" that
fails, the error handler assumes that the untar operation didn't work
and suggests to retry with admin privileges, modifying the .app bundle
before having it started once (AKA verified by gatekeeper), breaking
the app.
Passing the full path to the application object should fix that.
Change-Id: I47d61ad68e225fbdba191702ba85598164602e81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96449
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
PDFDocument::WriteAppearanceObject() is where we can turn the pdf data
(containing a single shape only) into a form XObject, later.
Change-Id: Id042c95af4a867d3997d6f7742a18659b8925c12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96455
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
It no longer triggers an assert in --enable-assert-always-abort builds since
2293aa3a15 "Remove dubious assert 'Forbidden
Access to empty bitmap!'".
Change-Id: I1c50b7f167fa1e1ba0b465934eabd195285abd4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/80437
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
I think this is leftover from very early development stages when it
didn't have placeholders, but literal OpenOffice or similar at the time.
Not matching for wildcard but for full LibreOffice/LibreOfficeDev string
makes removing the languagepacks from the match superfluous
It was wrong anyway, since kMDItemDisplayName has the name without the
.app extension (you'd have to use _kMDItemDisplayNameWithExtensions for
that)
Change-Id: I37b1ed2d23ea18fd81a8844f35c9cb0d5dc34211
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96441
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
So that later this can be used when writing the appearance object of the
pdf signature.
Change-Id: I98517b88723de8ffdc982d4eaae7225289603f1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96451
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
3a02841819 removed the string from
Info.plist, but the languagepack install script tried to use that to
make sure whatever the user selects/is found is from the dame type (dev
vs release and codeline/version). Instead of doing multiple
greps/multiline ones (there are multiple version strings in that file,
only one being from LO itself…) use mdls instead to pick the interesting
properties to build a "PRODUCTNAME FULLVERSION" string again we can
match against. --raw switch is nul separated, so add additional xargs -0
in there instead of trying to match a nul with grep
(without --raw it is a nice human readable multiline string)
Change-Id: I049a8425709a0c41b61aa09452490b481d39e4d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96439
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Previous implementation was not aware about ilvl value which
declares a level number it is defining. So LO was able correctly
handle only lists were levels are defined in increasing order
starting from zero. Same problem was also with override lists: if
we just override only one some random level (for example ilvl=2
in bugdoc) it was applied to level 0.
Change-Id: If1f466fcbae0c82a8601e5b638e541d75aab665c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96268
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This avoids the need for the tricky osl::Condition::reset calls. For example,
the first one (in the "disposed !" case) had been added with
2a3ed89284 "sb132: #i112448# proper clean up in
JobQueue::enter (patch by olistraub)" as
> if( 0 == m_lstCallstack.front() )
> {
> // disposed !
> + if( m_lstJob.empty() )
> + {
> + osl_resetCondition( m_cndWait );
> + }
> break;
> }
>
and then change to
> if( 0 == m_lstCallstack.front() )
> {
> // disposed !
> - if( m_lstJob.empty() )
> + if( m_lstJob.empty()
> + && (m_lstCallstack.empty()
> + || m_lstCallstack.front() != 0) )
> {
> osl_resetCondition( m_cndWait );
> }
with cba3ac1eab "Avoid deadlocks when disposing
recursive JobQueue::enter", which prevented the reset from ever hapening
(because m_lstCallstack.front() cannot both be zero and non-zero here at the
same time). The std::condition_variable semantics nicely avoid any reasoning
whether or not a reset would be necessary here.
Change-Id: Ic9b57b836bb6679829f4aa3b68679256726acf60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96406
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Heading for version info added with a tool button
to copy info using also the shortcut ctrl/cmd+C
* Copy button from the footer buttonbox removed
Change-Id: I47d77ea1bc1ac2df25c1fb035abcb96d56a5f4f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95791
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Non-antialised adjacent polygons line up perfectly when drawn, and
LO code assumes this is the case even when AA is enabled, which
seems to work with Cairo, but not with Skia. So add a hack.
Ideally LO code should not use such polygons.
Change-Id: Ib46139db80f7bda78fde3aac4244da391133b7cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96369
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
when changing paragraph. previous para undo info needs to be discarded, but
that cannot be done properly if there is an open undo group. So pass the
optional undo group guard down to GetNextSentence_Impl which can close it
before it needs to set the new paragraph.
Change-Id: I595c3598b15b6b1fdace045c3879617ecfea3faa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96397
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
like writer's form drop down which makes it a more natural menu-alike thing
Change-Id: I526e0d8efe166596ecb91576ebf9b359b3239526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96365
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Perhaps it did something useful in the past, but it's better to expand
it in its current form.
Change-Id: I404e8d274f15a178f519d42a1ecd993c1e530f91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96384
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Regression from commit 4814e8caa5
(tdf#124601 sw: add ContinuousEndnotes layout compat option,
2019-09-30), the problem was that SwFrame::GetPrevFootnoteLeaf() did not
take the new compat flag into account when determining the previous
footnote page for endnotes.
Do the same pattern here as the cases already handled in the above
commit, just try to get the "last but one" and not the "last" page,
since we try to move these endnotes to a previous page.
Change-Id: I77841a3a0fb68f054941184ee2a8aca0707d2a9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96395
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
... instead of testing SvNumFormatType::DEFINED for each type
individually.
Change-Id: I539ad1c9a6b17ed788c26b75b7e673aaae3a6a2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96389
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
This way it'll properly scale, instead of using the fixed 28 pixel
dimension. This is a hack, which is used a few more times in VCL.
Still this should not be needed, but done automatically.
If there aren't any constraints, just return the optimal size!
Change-Id: I8aa32645ea95cba28d0daf56f0be27c15153b6c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96390
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
getLanguage() only returns the language code which can be
ambiguous in case of UI localization, when there are more
than one language variants. Fallback to the first variant
caused mixed language UI, e.g. en-US vs. en-GB, pt vs. pt-BR,
zh-CN vs. zh-TW.
Change-Id: I888423cd4b3c65dbdb900ff3b6bc308fa119be4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96285
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This reverts commit 80eb0eb251. The three changes
it had made to CppunitTest_sw_uiwriter CPPUNIT_TEST_NAME=testTdf132725::TestBody
started to each fail now with b314735568
"tdf#132321 tdf#133957 sw: for at-para fly, ignore anchor SwIndex".
Change-Id: I8bb4063713a9f3705120dd39943dabe24301f345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96386
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
Use Add/Delete decimal to change precision of time and duration
Apply only to 100th second
Change-Id: I2ff1b01db7ee67645511fcf7ea6bf65055e92a8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94765
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
otherwise the keyboard events don't get to the dropdown
Change-Id: I6cbaea5e3cef16a39edb12fecdf1d08ab29cbd5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96366
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
...while a remote call is in progress. Otherwise, if the same thread later
makes another remote call (through another bridge), it would erroneously pair
the repsonse for the disposed call with the second call.
UITest_calc_demo started to fail that way occasionally, presumably after
77445e201c "Make Chart Creation Wizard async", but
for reasons rather unrelated to the contents of that commit. What apparently
happened is that in one test's tearDown, the bridge between the Python and the
soffice process happened to be disposed during the XDesktop::terminate call from
Python's main thread, so that the response (of type BOOLEAN) remained in the
JobQueue. Then during the next test's setUp, XUnoUrlResolver::resolve from
Python's main thread would internally make a remote queryInterface call for the
initial StarOffice.ComponentContext object, which returns an ANY of either VOID
or XInterface type. But that call was then mis-matched with the leftover
BOOLEAN response, causing failure.
I was able to reproduce that reliably on Linux with a local hack of
> diff --git a/cppu/source/threadpool/jobqueue.cxx b/cppu/source/threadpool/jobqueue.cxx
> index 6c9324521f40..a87770bf8935 100644
> --- a/cppu/source/threadpool/jobqueue.cxx
> +++ b/cppu/source/threadpool/jobqueue.cxx
> @@ -71,6 +71,7 @@ namespace cppu_threadpool {
> }
>
> m_cndWait.wait();
> + timespec ms{0, 1000000}; nanosleep(&ms, nullptr);
>
> struct Job job={nullptr,nullptr};
> {
introducing a sleep, so that other threads have a higher chance to dispose the
bridge (when the call being processed here is that XDesktop::dispose) after the
successful wait() but before the response is processed. UITest_calc_demo then
failed with
[...]
> Execution time for create_chart.CalcChartUIDemo.test_activate_chart: 6.520
> tearDown: calling terminate()...
> caught while TearDown:
> Traceback (most recent call last):
> File "uitest/libreoffice/connection.py", line 127, in tearDown
> xDesktop.terminate()
> libreoffice.connection.com.sun.star.lang.DisposedException: Binary URP bridge disposed during call binaryurp/source/bridge.cxx:611
>
> ok
> test_cancel_immediately (create_chart.CalcChartUIDemo) ...
[...]
> warn:sal.osl.pipe:423851:425076:sal/osl/unx/pipe.cxx:442: recv() failed: ECONNRESET
> warn:binaryurp:423851:425076:binaryurp/source/bridge.cxx:843: undisposed bridge "" in state 2, potential deadlock ahead
[...]
> ======================================================================
> ERROR: test_cancel_immediately (create_chart.CalcChartUIDemo)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "uitest/uitest/framework.py", line 25, in setUp
> self.connection.setUp()
> File "uitest/libreoffice/connection.py", line 176, in setUp
> conn.setUp()
> File "uitest/libreoffice/connection.py", line 57, in setUp
> self.xContext = self.connect(socket)
> File "uitest/libreoffice/connection.py", line 107, in connect
> xContext = xUnoResolver.resolve(url)
> uno.com.sun.star.uno.RuntimeException: initial object queryInterface for OID "StarOffice.ComponentContext" returned ANY of type boolean binaryurp/source/bridge.cxx:883
[...]
Change-Id: Icf9aadbb38e7aafffff844fe8e9ae99e165c1f33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96326
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Ctrl+A should select everything in the section; if the section is empty,
there's no text to select, and then the shell will cancel the selection
because SwCursorShell::HasSelection() returns false - so check if
there are flys anchored there, which fixes the Copy.
To fix Delete, a few more checks for empty selection need to be changed.
Change-Id: If54160bdca976ad5f153b89cf8492f4da1e774b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96324
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
