part of the process of hiding the internals of SwPosition
Change-Id: Id56cbeaa67cdbfc620d26c8590f1c9eeaea26281
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138172
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
GetListFormat DEPENDS on having managed prefix/suffix itself,
since it uses their getLength to modify the sListFormat.
So any modification via SetPrefix/Suffix
(potentially) invalidates the ListFormat.
I added some code to ensure this doesn't get out of sync.
One place that still uses PREFIX/SUFFIX is old ODT files.
After import they are updated, but during import they use
the old UNO properties, so I didn't add any assert here.
Change-Id: I3bab780fb8e8e985c3573075bc7aac9216d116d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138073
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-by: Justin Luth <jluth@mail.com>
This reverts most of commit 09558e2f45,
the problem is that GetNextToken_() resets aToken, overwriting the value
created by this function.
Change-Id: I1daca07a6e01cfecfeff9fbf7c311b0d392d84d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138190
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Glyphs in RTL mode are in reverse, which includes the fast that
a cluster start is last, not first. So going back requires means
going back just one glyph, not a whole cluster. I'm not sure why
I originally did it this way, tdf#148954 works fine even this way,
so presumably I got confused.
Change-Id: I6ed0caf4e64e93e0643f7b88099bc7c992ea3329
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138144
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Otherwise OutputDevice::ImplLayout() might use a temporary cache
just for the subtext while SalLayoutGlyphsCache would use cache
for the whole string, and those two might differ e.g. with an arabic
string starting with numbers when the subset is just the numbers.
Change-Id: Idea7ef277beae07e39e4a714088a7585361d13e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138143
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
The context menu is called "Edit", so let's put dialog in edit mode.
Change-Id: Ib3a2b164e4d6a0b93e3a5aac26125a20d41a60dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138155
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
0 is an invalid year
Change-Id: I2c638e2e2c1db628b4014a04a1c26231c236075b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138152
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
... and export of border on paragraph that clears the border from the
paragraph style.
The import problem is that a lone \brdrcf17 without any preceding
keyword about which border it belongs to (as required by the EBNF in the
RTF spec) is apparently handled by Word as overriding/clearing all
paragraph borders that may be inherited from the paragraph style.
The export problem is that a null SvxBorderLine isn't exported at all,
but there needs to be a \brdrnone to override the definition from the
style.
There was also an API problem that the null SvxBorderLine is wrongly
converted to a table::BorderLine2 with LineStyle SOLID.
Change-Id: I5fa3857de2ef843f5194e12dd0c3e57bcf1ca52b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138089
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
See https://crashreport.libreoffice.org/stats/signature/connectivity::OConnectionPool::propertyChange(com::sun:⭐🫘:PropertyChangeEvent%20const%20&)
To reproduce this, blow away your config and start writer, visit tools,
options, base, connections and enable connection pooling enabled, find
com.sun.star.sdbcx.comp.hdqldb.Driver and "enable pooling for this
driver" and "apply" with the default 120 seconds, ok and exit
then open a database (based on hsqldb) and click on "tables" (to start a
connection) that default 120 seconds is the input for calculateTimeOuts
(this becomes a final m_nALiveCount of 10 by the divide by 20), now
visit the options again and change the 120 to something else and ok and
the input for calculateTimeOuts is the old "10" calculated before and
not the new expected value.
The reason appears to be in OConnectionPool::propertyChange, it expects
to get the new value of the property from evt.NewValue but it gets an
empty Any so the m_nALiveCount is not actually changed, so the
assumption it was set and will be >= 20 and sanely divisible by 20
doesn't hold.
For this easy fix, fetch the new value explicitly from the config
Change-Id: Ie91bf5328634f9aafbda1814b10c29b86a3f9cbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138111
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Commits prior to this handled all the instances that were caught
by a make check. I found a few more by temporarily setting an additional
boolean parameter on SetPrefix/SetSuffix which let me catch these.
This means we don't have unit tests related to these.
Change-Id: I1b3bb1e6eec7878e43ccf546f6df7cb38ac5299e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138072
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
otherwise lok cannot save them directly because
libreoffice will try to open a save-as dialog
For odg, change the draw8_template type draw8
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I34b0ed03adcac89eaa926f8ae6c57e6f622a90f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132633
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138074
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138098
Tested-by: Jenkins
The mention of a `TRUE` value when the return type is
an `XAccessible` rather than a boolean looks like a
copy-paste error from the
`XAccessibleComponent::containsPoint` doc just above.
While at it, also fix a typo present in both.
Change-Id: I9b597f3e500c7f4e448e228ebc27c45d8dc420a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138095
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
from the sidebar tab due to the accelerators in there
its a bogus check in gtk3 in this case of a menu attached to a MenuButton
Change-Id: Ie5216e749993f3d44bfc2e4560cd3b2f49aa8aec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138086
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Loongarch is a new RISC ISA , which includes a 32-bit version and a 64-bit version, Here are some documents about Loongarch：
https://github.com/loongson/LoongArch-Documentation.
The loongarch64 bridges implementation refers to mips64 bridges, and the code related to abi and asm has been modified
Change-Id: I1d9cd3aadf63046c8cdecc9a64842567bfa1cecc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137486
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This required to move the code calling Help::ShowQuickHelp from
weld objects into SvTreeListBox::RequestHelp, and have it only
request the tooltip text from those objects.
Change-Id: I25c97360bbaac4705830a13aa06e0992b68fffff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138084
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
