Commit graph

6623 commits

Author SHA1 Message Date
Tor Lillqvist
59a9190675 Remove a couple of unused private fields
Change-Id: Ia28d6befe63453ced7c623e76abc7a0ec7d6cbeb
2013-03-25 21:44:13 +02:00
Tor Lillqvist
aac64d030f Fix warning: unused variable 'aMutex' [loplugin]
Change-Id: I1dc2d18f285bbd7fc4316a7a194a21769b11d545
2013-03-25 21:44:13 +02:00
Tor Lillqvist
97a72b42c0 Fix warning: unused variable 'sColumnName' [loplugin]
Change-Id: I3b4267f9782bc7bc71247523c8fd5940bc8cef38
2013-03-25 21:44:13 +02:00
Stephan Bergmann
fa545023ad Introduce HAVE_GCC_PRAGMA_DIAGNOSTIC_{MODIFY,SCOPE}
...replacing hard-coded GCC version checks.  Those checks that guard

  #pragma GCC diagnostic ignored "-Wnon-virtual-dtor"

appear relevant only for GCC itself, not Clang (which used to fail the old
guards because it typically announces itself with a rather low
__GNUC__/__GNUC_MINOR__ version), see 6e67c03dc0
"Enable -Wnon-virtual-dtor for GCC 4.6"

Change-Id: I6bfa4d5caa6192e7a203ce829682bf6bb8d61a1b
2013-03-25 08:52:54 +01:00
Julien Nabet
f9122b3297 coverity#704216 Logically dead code
Change-Id: I83af7c87576c185b4884a2a6ceaea5274efa7c37
2013-03-23 14:52:25 +01:00
Ricardo Montania
9c281fda84 String::AppendAscii cleanup
Change-Id: I3c1ff291488b7747e143982aa7ea95169175c2c2
Reviewed-on: https://gerrit.libreoffice.org/2914
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-22 17:17:18 +00:00
Timothy Pearson
3e33adc4b0 Fix single core builds when TDE integration is enabled
Change-Id: I3a28d843e567db2a905125424615cba0bd28c7b4
Reviewed-on: https://gerrit.libreoffice.org/2882
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-21 07:43:39 +00:00
Thomas Arnhold
3c5b085394 no need for include guard value
Change-Id: Ib12b2c975d90cf842381916f3eb98dad3b4b3b4d
2013-03-20 15:07:00 +01:00
Stephan Bergmann
2d9ce9191d Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)
...which is a confusing overload with unexpectedly different semantics from the
one-parameter form.  In preparation of marking it as deprecated.

Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-20 13:05:35 +01:00
Luboš Luňák
52f8321c41 use #if instead of #ifdef for testing config_xxx.hxx macros
http://lists.freedesktop.org/archives/libreoffice/2013-March/047769.html

Change-Id: I81ed4500878ff3193e028410a1f0205e28d17fc3
2013-03-20 11:34:18 +01:00
Chr. Rossmanith
b2f8318dbd simplify OUString assignments
Change-Id: Ieffd80aa84c9a041785bb81b3a904a32d00cb2bb
Reviewed-on: https://gerrit.libreoffice.org/2863
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-03-20 10:28:58 +00:00
Noel Grandin
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20 07:32:53 +02:00
Julien Nabet
b0149eccbf coverity#704590 Explicit null dereferenced
Change-Id: I787a39959a1558fe4f284bc1941194a841e2d600
Reviewed-on: https://gerrit.libreoffice.org/2860
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-19 23:43:11 +00:00
Thomas Arnhold
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
Stephan Bergmann
4c0c23af21 Simplify equalsIgnoreAsciiCaseAscii[L] calls
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19 11:32:20 +01:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
Timothy Pearson
edd2531f5d Fix single core build when TDE integration is enabled
Change-Id: I15d537a8ea7d3a42c9a1924dd81e83ba9b4aa421
Reviewed-on: https://gerrit.libreoffice.org/2830
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-19 06:58:18 +00:00
Luboš Luňák
a09124e6f5 avoid Wundef in cases where the usage seems otherwise ok
Change-Id: Iabccc31c59cec32235661f5225f45bb13f76a68f
2013-03-18 17:15:56 +01:00
Julien Nabet
c3d1c45e51 coverity#705135 Missing break in switch
Change-Id: Ie610b3b10b5d83b772ad96e455d59360368086a4
Reviewed-on: https://gerrit.libreoffice.org/2779
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-18 07:42:44 +00:00
Christian Lohmaier
2bc7d0534c fix makeAny calls
checks failed on Mac/PPC - setValue expects sal_Bool, not plain bool
for bool there's assignment operator. Similar for unsigned short -
there's dedicated operator to assign sal_uInt16 - no need to cast to
signed sal_Int23 that then fails to convert properly.

Change-Id: I6c67a3741cf2d7910fc543c9c71db1c6e816bea6
Reviewed-on: https://gerrit.libreoffice.org/2805
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-18 06:55:50 +00:00
Kohei Yoshida
f63423d585 Revert "cleanup sqlflex and sqlbison options"
This reverts commit b659d7c33f.

That commit appears to have broken the build on Linux. Reverting it
fixes it.

Change-Id: I70d62c04e9fb284ed2c360c0976d0cbeafc2ddc2
2013-03-15 23:11:33 -04:00
Peter Foley
b659d7c33f cleanup sqlflex and sqlbison options
Change-Id: I3f01636ef861828fdbe87e4057b6dc293ca63576
2013-03-15 21:19:13 -04:00
Michael Meeks
79b0046ba0 remove legacy build.pl prj/build.lst files. 2013-03-14 17:05:51 +00:00
Luboš Luňák
8563f011ab update pch headers
Change-Id: Ibb368e6a806666a73bf6bf1a097d14bc6e75b24d
2013-03-12 18:24:10 +01:00
Lionel Elie Mamane
6ea6850908 janitorial: readability
Change-Id: Iaab09826d79b0fbcd3104d33d1f159767a09921a
2013-03-12 16:26:41 +01:00
Thomas Arnhold
224fbad7ab fix my previous commit (compareToAscii)
Change-Id: I06885691c1fb3cfa0824f2ac1307ae4d9f3c9d40
2013-03-11 17:16:34 +01:00
Thomas Arnhold
937b63af33 use startsWith() instead of compareToAscii()
brain damage...

Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-11 11:07:09 +01:00
David Ostrovsky
6f28efc2a8 fdo#61726: rename report-builder package to org.libreoffice.report
To prevent future clashes with uno name space rename the
com.sun.star.report package to org.libreoffice.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
Reviewed-on: https://gerrit.libreoffice.org/2578
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-03-11 08:56:40 +00:00
Thomas Arnhold
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
Thomas Arnhold
a2454a42ad fdo#43460: use isEmpty()
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-09 20:32:39 +01:00
Borim
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
Mathias Hasselmann
b2983b4653 evoab2: Follow API changes in EDS 3.8
EDS 3.8 deprecates e_book_client_new() and replaces it with various
e_book_client_connect() functions. This patch follows the change
and enables direct read access for the addressbook. That means
instead of receiving contacts via the D-Bus session bus, the
connectivity driver now directly accesses the underlaying SQLite
data base (for reading).

This patch also shuffles code in EApiInit() slightly to avoid
excessive if/else nesting.

Change-Id: If41fb92eed2ea26bbf2d3125a9ba2250f142c5a2
2013-03-08 13:57:24 +00:00
Mathias Hasselmann
c20518286c evoab2: Move get_e_source_registry() to EApi.cxx
get_e_source_registry() was declared in EApi.hxx, but defined in
NDatabaseMetaData.cxx. This doesn't seem right, the header file
and the purpose of the function indicate that it belongs into
EApi.cxx.

Change-Id: Iea3f11a901398aa3f467b96fbe8778c403887bcb
2013-03-08 13:53:34 +00:00
Mathias Hasselmann
e3645fad6b evoab2: Avoid G_N_ELEMENTS when loading symbols
With G_N_ELEMENTS() the array name has to be twice, which can cause
hard to spot typos in code derived from copy-and-paste, as we have
here in the module loader. C++ can avoid the duplication by using
the proper templates.

Change-Id: I485e28a92e74b7e24f4a59cced6e5635f3a53a38
2013-03-08 13:52:36 +00:00
Thomas Arnhold
4bf95c4c31 make use of startsWith()
Change-Id: Ie70097de550ddd1cddc6714f8f86f9723cb36679
Reviewed-on: https://gerrit.libreoffice.org/2599
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-08 13:16:49 +00:00
nccuong
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
Thomas Arnhold
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
Peter Foley
b00254ab2a make lto work
Change-Id: Iab6892368c6ba6bb5b83132cdcd6aa959c3b0e1f
2013-03-04 17:58:53 -05:00
Takeshi Abe
ce33f85ffd sal_Bool to bool
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
Thomas Arnhold
33d6a7b2d7 doubled namespaces
Change-Id: I0f6a34a459c1492a69afa3ef6bcbaa8ed7639a22
2013-03-04 13:58:40 +01:00
Thomas Arnhold
57d169b606 doubled namespace
Change-Id: I756f4a98b1eedcbe7674e9afd9b06816141688b9
2013-03-04 13:58:39 +01:00
Thomas Arnhold
5b04c9063c remove unused and commented out code
This code gets never called.

Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04 11:34:07 +00:00
Lionel Elie Mamane
8f113d08ce coverity: merge traverse{OR,AND}Criteria into traverseSearchCondition
Meaning, these two functions have the same behaviour,
they produce the same output (and side-effects)
when called on the same input.

traverseORCriteria handles only the actual "foo OR bar" case,
and hands off all other cases to traverseANDCriteria.
But, lo and behold, traverseANDCriteria also handles
the "foo OR bar" case, in the same manner!

Change-Id: I10410e88ce48852b60d1d688fe2865923de9d80b
2013-03-04 11:09:25 +01:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
Thomas Arnhold
ecf0040337 loplugin: improve indentation
Change-Id: If0ddaa8fd7cfaf4df8589422cb50ce37f1be2ad1
2013-03-03 17:14:15 +01:00
Vojta Koukal
9a6ab1568d fdo#60724: fix paramater -> parameter misspelling found by lintian
Change-Id: I6c09767211817533494df34744a265cf28a76105
2013-03-03 12:42:47 +01:00
Thomas Arnhold
919e277466 loplugin: unused variables and commented code
Change-Id: I01f1f1d112767b576d7cfc6e25fe95385de2c0cf
2013-03-03 11:48:02 +01:00
Markus Mohrhard
21171e0a7f coverity#736112: make clear that this is not part of the if
Change-Id: I442d7e363f7594d1fae5e2afdde71ff6670b1962
2013-03-03 04:35:15 +01:00
Markus Mohrhard
bcca57ac42 coverity#736111: make clear that this is not part of the if
Change-Id: Iab61e80a7fa8f01d826ac90e184d09d0e2358b40
2013-03-03 04:35:15 +01:00
Markus Mohrhard
77c0cc3b75 coverity#736110: make clear that this is not part of the if
Change-Id: I709672e9e2789213c85878d2bd0194ad5bc34060
2013-03-03 04:35:14 +01:00