Noel Grandin
dac4ca5f68
new loplugin: externalandnotdefined
...
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
Matúš Kukan
d01e35e120
Clean up usage of 'this' and constness.
...
Change-Id: I35085bebdec47598a5f927924b429b02b44c0e65
2014-07-11 09:32:08 +02:00
Kohei Yoshida
4ce9e4a68f
Head cleanup - use forward declarations.
...
Change-Id: Icc4fa0acad77d61200eb77cc70e21866590b658e
2014-07-10 14:13:57 -04:00
David Tardon
86c6f18c27
avoid problems detecting HTML files with .xls ext.
...
Change-Id: I9955223aac20f3f640fde51bb7231666c269ca70
2014-07-08 17:03:42 +02:00
Tor Lillqvist
579d9ae1c5
Include <algorithm> for std::min()
...
Change-Id: Ieb01023b93923777cf53a2fc8d7198d88422e8a4
2014-07-08 12:06:48 +03:00
Tor Lillqvist
845e8427fc
Include <algorithm> for std::min() and max()
...
Change-Id: I88a590344292b4adf562ca83f5072d543b5924ad
2014-07-08 11:38:54 +03:00
Michael Meeks
0f8cf397d4
fdo#80955 - add a unit test.
...
Change-Id: Ie79a86827c4ee9feabcabf2530b30466f95905ed
2014-07-07 18:05:18 +01:00
David Tardon
a3338f8969
fdo#78989 set preferred filters for ODF types
...
We do not want to randomly pick FlatODF as the filter for
libreoffice --convert-to od?
Change-Id: Id04e10120786ef6a2c2b0eaf2b20a256d8daa7dc
2014-07-07 17:04:00 +02:00
Caolán McNamara
e110726bab
don't terminate via unhandled exception on loading rhbz1013280-2.ppt
...
Change-Id: Ie2bff125f6839d99280d441b823eb6e0a712844d
2014-07-07 15:44:00 +01:00
David Tardon
24d20bce78
fdo#80955 make calc_MS_Excel_97 filter default for xls ext.
...
Change-Id: I8fa095b45ea2fe1a07c1660d2efc24c73f7082da
2014-07-07 16:34:59 +02:00
Caolán McNamara
0d78ad871e
DBG_ASSERT->assert when followed by dereference
...
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
Armin Le Grand
1a0b8d8e6c
Resolves: #i124825# secure usage of object ID...
...
in preparation of names for line start/end geometry
(cherry picked from commit 246d1ce469c155b81743cb6eaa065da2b19d7dcc)
Conflicts:
filter/source/svg/svgwriter.cxx
Change-Id: I1a267b33f87cbb935c783670a51853832d483b1a
2014-07-04 16:17:07 +01:00
Noel Grandin
4ff115b3e7
drop UniReference in favour of rtl::Reference
...
since they're doing the same thing.
Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-07-02 15:23:52 +02:00
Stephan Bergmann
e50ef195bc
New loplugin:stringconcat
...
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Armin Le Grand
3ea1707311
Resolves: #i125187# more precision where the BLIP graphic is located
...
(cherry picked from commit 2be700effa5568859a0c6ba5f596e35ffc600320)
Conflicts:
filter/source/msfilter/msdffimp.cxx
Change-Id: I3926d5f47469049662a292063f9810826c575154
2014-07-01 13:50:09 +01:00
Caolán McNamara
5ace3f3b4f
clang scan-build: various warnings
...
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
Julien Nabet
a0233e6e03
Typo: habe->have
...
Change-Id: Ic76a399fc4073fcb713bb566f3fbee2077e20e52
2014-06-29 13:15:52 +02:00
Julien Nabet
430484932e
Typo: beeing->being
...
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
Julien Nabet
b232607e45
Typo: easiear->easier
...
Change-Id: I4e10f74e46ef79c3a56dcfb3d1e1bb90d8b5aecf
2014-06-29 00:11:19 +02:00
Michael Meeks
e820df579d
filters: Batch fetch filter config properties.
...
Also re-use a single set of OUString property names in
a sequence rather than re-allocating them constantly.
Change-Id: I7f0afc52363e57ea0c63f46f1e1f63cb752bb302
2014-06-28 14:37:23 +01:00
Michael Meeks
556981f078
filter: remove redundant macro wasting time.
...
Allocating and freeing strings thousands of times just to compare
them is not a great idea - 0.5% of startup.
Change-Id: I076bc961d3612143b7f81ef024e261ec3ed4ff76
2014-06-27 16:05:01 +01:00
David Tardon
516fb340b1
integrate libpagemaker
...
Change-Id: I077d7c9a41793abdf5f001386f44ac407f94a6d3
2014-06-27 10:39:29 +02:00
Caolán McNamara
4079089d0a
clang: Dead increment
...
Change-Id: I231218ab7a7984943470b62339e34801fb5fb9e3
2014-06-26 16:29:15 +01:00
Noel Grandin
533c6cb6ba
fixes for up-casting to Reference<XInterface>
...
Fix regressions introduced with
6a043e9c0a
"Use the new type-checking
Reference constructor to reduce code noise"
Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-25 17:10:43 +02:00
Caolán McNamara
46b6721c03
coverity#706534 Uncaught exception
...
Change-Id: Iac2e63ee2588148f8c29c46684288f1fc69d4ff1
2014-06-24 14:28:27 +01:00
Joren De Cuyper
171efcb7ac
fdo#76203 - use consistent titlecase for UI title labels
...
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23 09:01:25 +00:00
Caolán McNamara
f162b156b0
coverity#736036 Missing break in switch
...
someone's odd ": ;" habit
Change-Id: I4a3e3b89bb31764056c844286561e31ae4621036
2014-06-17 10:58:00 +01:00
Noel Grandin
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Stephan Bergmann
dfb908c07b
loplugin:staticcall
...
Change-Id: I447500c4695b45afe86a8b8d6b6294507f58cd3f
2014-06-13 17:54:26 +02:00
Stephan Bergmann
5037dc7c46
Unnecessary #include
...
Change-Id: Ib6048bb694c84a1386d70a72c6e6e942b246a80d
2014-06-12 10:54:02 +02:00
Stephan Bergmann
bb761be472
Change SfxTabPage ctor SfxItemSet param from ref to pointer
...
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions. There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.
Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
Caolán McNamara
c8d8bcf3fd
callcatcher: update unused code
...
Change-Id: Iee19af81c648cb82074d8cabc13716b0d38c7ff6
2014-06-11 10:47:30 +01:00
Jan Holesovsky
0d7cfb772a
No need for PCT_DLLIMPLEMENTATION any more.
...
7b72e50514
removed the need for that.
Change-Id: I1fa635eab33bf259bcb4e229e9a0deac5fc987d6
2014-06-11 08:53:30 +02:00
Stephan Bergmann
7b72e50514
Access code under test via gb_Library_use_library_objects
...
Change-Id: Ib92dc55827b69cf33a04fe4084cf296049efc9c6
2014-06-11 07:46:03 +02:00
Jan Holesovsky
ad2cc2323f
pct import: Fix build on Windows.
...
Change-Id: Iddd0299f2229383c0d8368d117e6175887931978
2014-06-10 20:18:59 +02:00
Jan Holesovsky
71457cb2cb
pct import: Unit test for the clipping import fix.
...
Change-Id: I8f9df1d92c86c087e37f77209f413ff8c1c6358f
2014-06-10 19:33:12 +02:00
Jan Holesovsky
0048709ce4
pct import: Reset clip region before closing the metafile.
...
Otherwise parts of the image are missing.
Change-Id: If9018c32807359862a9be825b0ebdaacce2d3490
2014-06-10 19:33:11 +02:00
Jan Holesovsky
e7944dabfb
pct import: Add logging.
...
Change-Id: Ia3fe1ff0075434d0b6903bf978c16499e07d699d
2014-06-10 19:33:11 +02:00
David Tardon
be4b837ed2
move UOF and Office 2003 filters to xsltfilter module
...
Change-Id: I6e5ac310567bb7bd12fbba444e4e1deb9fea30d5
2014-06-09 14:07:44 +02:00
David Tardon
9266664937
rebuild filter config. after makefile change
...
Change-Id: Ibc788e248ea0c63e05c55d78ec059c48cff5dd72
2014-06-09 12:08:09 +02:00
David Tardon
6e299a555d
rhbz#1105376 move FlatODF filter config to right place
...
This has been broken since 3.3(!), when the old XSLT based import/export
was replaced by a library.
Change-Id: Id335f296c5a0e2c15d1748f8a14ac8d4001e1d15
2014-06-09 12:08:09 +02:00
Noel Grandin
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Stephan Bergmann
f7fac10510
...which empirically shows that LateInitThread is useless
...
Change-Id: Ic2946eef616eae39576d162ca534831753bd3c89
2014-06-05 22:16:59 +02:00
Stephan Bergmann
416367380c
Make warning more useful
...
Change-Id: I58226f74e644e2aa65dddf5bcb0832dc67c8a6e3
2014-06-05 22:16:59 +02:00
Stephan Bergmann
b07438bda1
...and so m_lDetectServices is never read
...
Change-Id: I3ea0c037d2b614b010093692dc6451110d2b342c
2014-06-05 22:16:58 +02:00
Stephan Bergmann
9f45761365
impl_resolveItem4TypeRegistration can be static
...
Change-Id: Ie2b83a472972194210c3b579a041a11a2ff76786
2014-06-05 22:16:58 +02:00
Stephan Bergmann
a2f6587974
...and so m_lChangedDetectServices is alway empty
...
Change-Id: I9a4ef55eb243f5aabd0c909b0e4594c928e459cd
2014-06-05 22:16:58 +02:00
Stephan Bergmann
db4d07e3a8
...and E_DETECTSERVICE is just as unused
...
Change-Id: I6f7c230e83a58f4889696b98fcd7bf24d0853ce0
2014-06-05 22:16:58 +02:00
Stephan Bergmann
936f197887
E_CONTAINS_DETECTSERVICES does nothing
...
...ever since its inception in 16ac873302
and
9b79c1d48c
"INTEGRATION: CWS filtercfg."
Change-Id: I34422a1c5641802bfb15720f5bfa8ca16fb54aab
2014-06-05 22:16:57 +02:00
Stephan Bergmann
570a719abf
Simplify SAL_WARN
...
Change-Id: I76c03d5e846fae6cba87be522a10d20e45528e4c
2014-06-05 22:16:57 +02:00