* Update helpcontent2 from branch 'master'
- related topics section title miss
+ related topics legibility improvement in compatible.xhp
Change-Id: I59ce332560d99b949f180cd37cfd61c40d9ff3f9
Reviewed-on: https://gerrit.libreoffice.org/83981
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
For numeric types, take into consideration different locales
Change-Id: I815c195e7ef53a7b958f85932415a16c9a8a1e35
Reviewed-on: https://gerrit.libreoffice.org/83683
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
regression from
commit 8f6f9e4217
tdf#127958 crash adding 2 or more files into writer master document
just make SfxMedium use shared_ptr, rather than the sometimes yes,
sometimes no, ownership.
Change-Id: I77559e9f766d84aca0f9dc0bd1b856c69f0f62f1
Reviewed-on: https://gerrit.libreoffice.org/83930
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
to center when importing oox document.
Using MS Office, the default aligment of a (text) paragraph
inside a shape is centered.
Change-Id: Id9bcaaab109df65f4124f733b2cfee438e82b79b
Reviewed-on: https://gerrit.libreoffice.org/83193
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
SwXDrawPage is inserting frame styles without name. This is confusing
undo/redo code which is operating styles by names.
Change-Id: Ibcda01fbd3ec88e9cdbde446c3f18c7ad6b0cbc8
Reviewed-on: https://gerrit.libreoffice.org/83415
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
UI uses SdrEditView::MirrorMarkedObjVertical() to flip a line shape
vertically, handle it similarly at import time as well.
Also note that this flips in-place, while the naive '*= -1' for the
height would have an incorrect vertical position.
Change-Id: I42b7feb5f799b99337ddec734dcf98dd1d553755
Reviewed-on: https://gerrit.libreoffice.org/83929
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
From all I could find, a single (back-)slash file URI is fine as
a local file path.
Change-Id: I75e95c809894cdef88f708d0477cb98eb114a107
Reviewed-on: https://gerrit.libreoffice.org/83837
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
This basically reverts the patches for tdf#125670. Instead this
just checks the mpGraphics in InitClipRegion() before using it,
to prevent the crash from the tdf#125670 bug report.
Additionally it drops the early mbOutputClipped return, as the
output device doesn't matter for the metafile drawing and the
preview of the tdf#125670 bugdoc and the Impress full screen
view otherwise don't show the gradients.
This patch works for me in the following tested scenarios:
1. Bugdoc tdf#125670 doesn't crash
2. Bugdoc tdf#125670 draws gradients in Impress full screen
3. Correct thumbnail pictures for both bug documents
With all these side effects, I have no idea, if this is finally
the correct fix and doesn't break anything else...
Change-Id: I8c48210d4255e50339710fc14819d15686417c9c
Reviewed-on: https://gerrit.libreoffice.org/83722
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
cut and paste from the GtkCheckButton example which does I guess
Change-Id: I864ee54d9541a1c29605c697a73f8f63fb543334
Reviewed-on: https://gerrit.libreoffice.org/83926
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
which is a favorite input document for crashes and assert apparently,
this is the third time it has triggered a different problem
this one is new since...
commit 9fdf8c0a5c
Author: Mike Kaganski <mike.kaganski@collabora.com>
Date: Sat Nov 16 16:34:25 2019 +0300
Also consider saved exceptions when terminating parse
Change-Id: I394b650613e8a835fe8a9f216a48864bdbc5065b
Reviewed-on: https://gerrit.libreoffice.org/83924
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
In case "rotated textbox in a custom shape" handle
draw:text-rotate-angle attribute while exporting
ODP to PPTX.
Change-Id: I13b99da586af5e77e51a7cc93a751ab21bed7170
Reviewed-on: https://gerrit.libreoffice.org/83888
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
defer until the color selectors are activated to grab focus, otherwise
esc doesn't work to close a dialog under gtk3 until focus is put
into some visible widget
Change-Id: I297c2738c4103024bbefd70bbcb5d72b8429dd3e
Reviewed-on: https://gerrit.libreoffice.org/83917
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
* Update helpcontent2 from branch 'master'
- tdf#129057 Correct DURATION and PDURATION Help
+ some refactor on the 2 pages
Change-Id: I997a3ed484c6cccf71d9726444ca75ded7d48d32
Reviewed-on: https://gerrit.libreoffice.org/83942
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
This indicates that the build targets the Online-based Android app, for
which we need to avoid various tweaks that are needed for the 'old'
Android app present in the android/ subdir of core.git.
In particular, the switch used in this patch fixes a RGBA vs. BGRA
confusion that caused yellow <-> cyan switch in the Online-based Android
app.
Change-Id: I5f394868f51ce87013677834cfafb967b9bb333e
Reviewed-on: https://gerrit.libreoffice.org/83342
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 49002a143a)
Reviewed-on: https://gerrit.libreoffice.org/83718
Tested-by: Jenkins
a happy mix of $1 %1 $(ARG1) %s %FOO and $bar$ and more is used, so
don't claim it needs to be c-format as that will trigger false alerts
for strings that use the percent sign as just percent sign.
Change-Id: I5ad604e842f850550aeb38b10edd7f0ab215a0c9
Reviewed-on: https://gerrit.libreoffice.org/83784
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
> In file included from vcl/skia/gdiimpl.cxx:20:
> In file included from vcl/inc/skia/gdiimpl.hxx:28:
> In file included from workdir/UnpackedTarball/skia/include/core/SkSurface.h:13:
> workdir/UnpackedTarball/skia/include/core/SkSurfaceProps.h:66:5: error: definition of implicit copy assignment operator for 'SkSurfaceProps' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
> SkSurfaceProps(const SkSurfaceProps& other);
> ^
> workdir/UnpackedTarball/skia/tools/sk_app/DisplayParams.h:16:8: note: in implicit copy assignment operator for 'SkSurfaceProps' first required here
> struct DisplayParams {
> ^
> workdir/UnpackedTarball/skia/tools/sk_app/VulkanWindowContext.h:57:24: note: in implicit copy assignment operator for 'sk_app::DisplayParams' first required here
> fDisplayParams = params;
> ^
with recent Clang 10 trunk, similar to ae71a0adef
"Remove some redundantly user-declared copy ctors and assignment ops"
Change-Id: I71263d8b3725478afc3a72f6f3ee9d73a277a8fd
Reviewed-on: https://gerrit.libreoffice.org/83907
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Michael Stahl <michael.stahl@cib.de>
Missing const leads to overload resolution ambiguity when a synthesized
candidate of operator == for a reversed-argument rewrite conflicts with the
actual operator ==, due to the asymmetric const-ness of the implicit object
parameter and the RHS parameter:
> In file included from workdir/UnpackedTarball/skia/src/shaders/SkLightingShader.cpp:15:
> In file included from workdir/UnpackedTarball/skia/src/core/SkReadBuffer.h:13:
> In file included from workdir/UnpackedTarball/skia/include/core/SkFont.h:13:
> In file included from workdir/UnpackedTarball/skia/include/core/SkTypeface.h:16:
> In file included from workdir/UnpackedTarball/skia/include/core/SkString.h:15:
> workdir/UnpackedTarball/skia/include/private/SkTArray.h:389:35: error: use of overloaded operator '!=' is ambiguous (with operand types 'SkLights::Light' and 'SkLights::Light')
> if (fItemArray[index] != right.fItemArray[index]) {
> ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~
> workdir/UnpackedTarball/skia/src/shaders/SkLightingShader.cpp:268:35: note: in instantiation of member function 'SkTArray<SkLights::Light, false>::operator==' requested here
> return fDirectionalLights == lightingFP.fDirectionalLights &&
> ^
> workdir/UnpackedTarball/skia/src/shaders/SkLights.h:90:14: note: candidate function
> bool operator!=(const Light& other) { return !(this->operator==(other)); }
> ^
> workdir/UnpackedTarball/skia/src/shaders/SkLights.h:83:14: note: candidate function
> bool operator==(const Light& other) {
> ^
> workdir/UnpackedTarball/skia/src/shaders/SkLights.h:83:14: note: candidate function (with reversed parameter order)
Change-Id: I61b28e191b36f84df6920b4143809d1f497b9113
Reviewed-on: https://gerrit.libreoffice.org/83900
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Michael Stahl <michael.stahl@cib.de>
For some reason, navigator.userAgent in WebKit on iOS 13 claims it to
be a Macintosh, so our old code to recognise iOS did not work any
longer. Also the Hammer.js included in this file looked at
navigator.userAgent and its decision what to do based on that did not
work properly either.
Simplify our code by handling swipe gestures all the time, even when
such won't be generated (on mouse-only devices).
Also, Hammer.JS was too eager to think it detected a pointer-only
device based on the presense of window.PointerEvent. That sems to be
present now in iOS 13. Let's not blindly think that means it is a
pointer-only device. If the device supports touch events, don't bother
with PointerEvents.
Change-Id: I57d972415798967e871c6e262f16043561ed6af5
Reviewed-on: https://gerrit.libreoffice.org/81404
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 8f78d6a0d1)
Reviewed-on: https://gerrit.libreoffice.org/83731
Reviewed-on: https://gerrit.libreoffice.org/83883
Tested-by: Jenkins
Do not need to set the "AnchorPosition" value, when we move
the legend object. It is enough to set only the "Expansion" as
custom, so we keep the previously set "AnchorPosition" value
and we can use the lcl_calculatePositionAndRemainingSpace function
to calculate the remaining space of the inner chart area.
Change-Id: I7b577bc6acf2de9b6755329b92603ea5ba631d57
Reviewed-on: https://gerrit.libreoffice.org/83399
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
...since we do not want to find DocDefaults or pool defaults.
This patch mainly does two things.
1.) Since DocDefaults get merged into root-level styles,
this patch identifies these DocDefaults as values that
can be overwritten by table style properties.
2.) Some properties (like left/right margins) are paired
together, so if one is SET, the other is also initialized
and reported as SET. These are identified, and
followed to see if they actually inherit from pool defaults.
Change-Id: I4291c77073858ae23360a9f34d3650bfd5df86ca
Reviewed-on: https://gerrit.libreoffice.org/81413
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Skia takes precedence, if enabled. And I'm not going to add Skia text
to the titlebar, it'd need to include whether it's raster or vulkan,
which would be longer, and I don't see why this information needs
to be in the titlebar in the first place (or if it needs, then
it should be consistent and include also gtk3, qt5, etc.).
Change-Id: I9b95c1a986a38293ee65ee49d1a1970c75b3d202
ever since a system update, this test receives an
IllegalIdentifierException thrown by
ContentProvider::queryContent
in
ucb/source/ucp/webdav-neon/webdavprovider.cxx
Given that
(1) On a system where the test passes, no IllegalArgumentException is
thrown
(2) Comment in the test indicates that the test should be run with proxy
enabled, which is not the case in our build
(3) I am running with a system proxy enabled
(4) the IllegalIdentifierException looks quite valid
I suspect that I am the victim of a dodgy test and some new proxy
behaviour in Fedora31.
Change-Id: Id3fb3499a44b5672e4eed0a2749dc287d6e7a3cc
Reviewed-on: https://gerrit.libreoffice.org/83853
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
