instead of random data
Change-Id: Iba020ea3a2386e3ad940cc85aac18047c3773967
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132066
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Move each test case into its own test function. Also add the
missing test for ValueRestorationGuard.
Change-Id: I588ab67f82ba82ef67939dac3d22438e8799ce11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133917
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sc/qa/perf/scperfobj.cxx: In member function ‘void sc_apitest::ScPerfObj::testSheetFindAll()’:
/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sc/qa/perf/scperfobj.cxx:169:51: error: ‘makeAny’ was not declared in this scope
xSearchProp->setPropertyValue("SearchStyles", makeAny(true));
Change-Id: I484a17fb80c86694d0221670afbcba80fbe14c4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133916
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
In windows, and SAL_USE_VCLPLUGIN=gen ./instdir/program/soffice
the style filter on the conditional tab was disabled.
It worked fine in gtk3 though.
This fixes a 7.2 regression from tdf#82802's
commit 1f06631321
Change-Id: I1e6bb8d589224e4ad51ae0057d5278e3888cc3b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133910
Tested-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Regression from 30735bdb5a (sd theme: add PPTX
import for shape fill color effects, 2022-04-27), the bugdoc's A2 cell
lost its tinting (its background color is no longer lighter than A1)
after saving back to PPTX + import again.
The code assumed that in case a fill color has effects, it can only be
luminance offset or modulation, since that's what the PowerPoint UI
generates when setting a fill color explicitly. This did not take the
table style case into account, which uses tinting to make a color
lighter.
Fix the problem by not importing the theme index / effects if tinting is
used -- the current doc model is limited to theme index + lum mod/off
with effects.
This limitation can be removed while text color / fill color effects are
not limited to lum mod/off, but also support tinting/shading.
Change-Id: I382cc0067518cc262e261a462999170cb7db261b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133908
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
- Added .emz and .wmz file opening support
- Added a function to check for Z compression that
all z comp. formats can use
- Added 3 unit tests for emf/emz/wmz files
and the example files have been checked with
a different tool (File Viewer 4)
- emf/emz file detection changed from magic byte checking
to extension checking, like wmf/wmz does
Change-Id: I3e433fd23d18482648a51cd04b8f467368e97b62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132456
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
getting different results vs the real world wrt glyph caching, go back
to normal and try a different approach when timeouts return
Change-Id: Ifb335888615b82c9bea83bd19a1cabcf8660dc74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133909
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
and don't just position with the selected entry at the top so it's quick
to pick preceeding adjacent entries
Change-Id: I20103200c34037fb02b3c0dcc29d154c1197549d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133893
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The current solution checks implicit moveTo only on the first arc in
a sequence of arcs. The patch moves it into the loop, so that the
implicit moveTo is done for each command in a sequence.
Change-Id: I400fa8fc96d7377ede55296c71e7a82ce891cc24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133896
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
(Instead of just removing any hunks that no longer applied,
86132d8188 "upgrade to cairo 1.17.6" had dropped
it completely presumably in error.)
Change-Id: I98fe20fc96bd5ce9400b6ad6a9837b21f08cdff0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
During the compilation with Visual Studio 2019 v16.5, the dragonbox
was failing the build, but it was OK when ugprading to the latest
version, 16.11.
It should be noted that according to the list of predfined macros in
Visual Studio, v16.10 and v16.11 use the same value for _MSC_VER,
which is 1929. Thus, the distinction between these 2 versions can not
be distinguished.
Predefined macros
https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
For not having the Visual Studio version > 16.10, a warning is
shown, and if the Visual Studio version is < 16.5, just like before,
an error is generated.
Change-Id: I6661ee5121b03ca43e1f7503b74191abcc8d6b40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132907
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
Text was lost from the text boxes with empty first paragraph. The
problem was happening when there was 2 paragraphs in a text box, in
which the first paragraph was completely empty. The regression was
introduced in cf2449aac0 because of the
bad handling of the paragraphs, and only looking at the size of the
text of the first paragraph.
This is fixed by looking at mpOutliner->GetEditEngine().GetTextLen(i)
for all i=1..k where k=min(2,mpOutliner->GetParagraphCount()).
I have negated the condition to provide a better explanation of what
the condition should be.
Change-Id: Id5d8787df5111c734760afdd98a6fbe832047f32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133527
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
There is just no good reason not to use a css::uno::Any constructor instead, so
simplify the code base. For URE backwards compatibility, keep it around as
deprecated for !LIBO_INTERNAL_ONLY.
Change-Id: I9409d8853cac270d47377a31ba35a1fc23fa9800
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133879
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
COM might need to forward the call to another thread (with corresponding
apartment); if that thread happens to wait for solar mutex, COM call may
deadlock.
Change-Id: I8fcf04619cd29b678fd7ade87254b9aad2f639a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133853
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
The exception is actually caught in an inner catch block; it was like
this already when added in commit
b4576f3da4.
Change-Id: I054c59493efe7d2d69877559b048bcf3c1f173e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133837
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Sharepoint may reject LOCK with HTTP/1.1 403 FORBIDDEN
and then a dialog pops up via UUIInteractionHelper that says
"Server error message: ."
Let's actually put some error message in the dialog, why not the
HTTP status line, plus a little prefix to see which method failed.
Change-Id: Ied895787f813c5cddcb18eb4f693d5bfc8c62076
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133835
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
- add a generic SwContentControlButton, to be used for dropdowns, but
meant to be useful for other types in the future (e.g. date picker)
- add a contentcontroldropdown .ui file for the welded list items
- add a SwDropDownContentControlButton, which contains the
drop-down-specific logic
- invoke content control button from HighlightContentControl(), so list
items are shown on button click
Change-Id: Ib3c6765020c5b3b1dd343a40a2b1862c73feaac8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133874
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
found by examining the call sites of OString::getToken
which means I needed to add a new o3tl::equalsAscii function
Change-Id: I7dc0ea1cf5ce8090a708d44f2cf7c938fa200c5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133826
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Revert
commit b6fe3b1320.
no need to have two weak references to SdrObject in SvxShape
Change-Id: Ie29d0002fd86226eb7634f621b43e7cb8dfc8aa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133833
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This conversion of double to single spaces had been done ever since
84a3db80b4 "initial import", but it is unclear to
me why.
The same conversion functionality is also used at two places in
sw/source/ui/dialog/uiregionsw.cxx. Not sure if it has any motivation there, so
lets keep that intact for now.
Change-Id: I0558f015c53f69a9a405891b9dad21a98de3533c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133841
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
