Commit graph

491369 commits

Author SHA1 Message Date
Tomaž Vajngerl
bfbbf06bce tdf#126084 support writing SVG images into OOXML using the MS OOXML extension
SVG files aren't supported in OOXML, but we can write it using the
MS OOXML extension, which is supported in the latest MSO versions.

For now this only implements the support in the exporter.

Change-Id: I688180fb5772f3999c2ee3020bc234f90d57cc2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157237
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-04 10:33:34 +01:00
Julien Nabet
09200875ce cid#1546325, cid#1546212: invalid iterator (xmloff/namespacemap.cxx)
Change-Id: I7a3377326daa5a0d933a68b9d4f5a64983ba2ab8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160278
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-04 09:26:45 +01:00
Andrea Gelmini
4852c601be Fix typo
Change-Id: I55e1b250f35adb11169267d5f8f1dbaca9ad802d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160282
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-04 09:26:15 +01:00
Stephan Bergmann
5d38c69833 -Werror,-Wunused-private-field
Change-Id: I45e52154cede5a4ea3cc1007fa8f1bbf74c4dd3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160291
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-04 08:56:44 +01:00
Andrea Gelmini
43967453e1 Update git submodules
* Update helpcontent2 from branch 'master'
  to 167b6b1ec40f44ab450a3c9a1fdaed8edac3742e
  - Fix typo
    
    Change-Id: I684dadb65f9f41b89d74532cf6bb2b76d01de5f5
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160281
    Tested-by: Jenkins
    Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-12-04 00:06:39 +01:00
Taichi Haradaguchi
e1473bc935 Upgrade lcms2 to 2.15
Added Windows-ARM64 support in release 2.13, so external/lcms2/lcms2-win-arm64.patch.1
and external/lcms2/lcms2_sln are not neccesary now.

Fix external/lcms2/lcms2-2.4-windows.patch.

Change-Id: I3b1ca0e715a5f500966d58971188f95a1f232883
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157100
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-12-04 00:05:56 +01:00
Caolán McNamara
59d2678458 cid#1557920 COPY_INSTEAD_OF_MOVE
a better example conversion

Change-Id: I120fb8e4b505bc5d761f6e7c69766cd610c8a662
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160271
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-03 22:12:27 +01:00
Caolán McNamara
44739ff1ee cid#1546503 Using invalid iterator
and:

cid#1546480 Using invalid iterator
cid#1546479 Using invalid iterator
cid#1546454 Using invalid iterator
cid#1546419 Using invalid iterator
cid#1546410 Using invalid iterator
cid#1546150 Using invalid iterator
cid#1546039 Using invalid iterator
cid#1545831 Using invalid iterator
cid#1545736 Using invalid iterator
cid#1545701 Using invalid iterator
cid#1545630 Using invalid iterator
cid#1545381 Using invalid iterator

Change-Id: I9e151b623f751ee1e982b5da0011ff08ab0ad5e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160270
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-03 22:12:17 +01:00
Rafael Lima
5f17c6385f Update git submodules
* Update helpcontent2 from branch 'master'
  to 7829aba61ee098e59768600c532c8a31cf25ee34
  - Document SF Database transaction handling methods
    
    Change-Id: Id5eadea4d55cfba1b240967f76096142af04d00e
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160174
    Tested-by: Jenkins
    Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-12-03 22:09:37 +01:00
Caolán McNamara
abd967ed31 cid#1546453 COPY_INSTEAD_OF_MOVE
a sample commit

Change-Id: I226569c5d3b066a5c328b67a36c17df57b5a668d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160215
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-03 20:20:05 +01:00
Noel Grandin
29fc0ec993 Split the *Bitmap::CopyPixel functions
into the two entire separate cases they want to handle, there is
no reason to mix the two different cases like this.

Change-Id: I38e99e7ad6168a84e7a744f61407887825158902
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160248
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-03 17:39:43 +01:00
Julien Nabet
033f973e22 Mysql/Mariadb: implement Users::appendObject to allow users creation
Change-Id: I49d4b08470a741bfb15d5d473ba6ccf19c55c964
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160266
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-03 17:38:11 +01:00
Noel Grandin
f861062206 ProcessAndBlurAlphaMask should take an AlphaMask as param
Change-Id: I9235e74499d95750ca93da050014657b418c27d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160249
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-03 16:36:18 +01:00
Julien Nabet
38fe084882 Mysql/Mariadb: implement Users::dropObject (so you can remove a user from UI)
Change-Id: Ic8fee60e1182303469b5c74598d0ff6ec24667a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160259
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2023-12-03 13:26:25 +01:00
Julien Nabet
dd011c3c1d Mysql/Mariadb: implement changePassword
Change-Id: I565bd96324044bb30b1e096c56e845766663ded1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160258
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2023-12-03 13:26:06 +01:00
Tomaž Vajngerl
1be8b2752d oox: Refactor and simplify writing to storage with GraphicExport
Change-Id: I743dc99e0228b59050fb4926c8ef56bed8e82060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160252
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-03 11:09:25 +01:00
Olivier Hallot
1229f09369 Update git submodules
* Update helpcontent2 from branch 'master'
  to c099ceeaf1cb4651bbca712ba19d16ee4206ab0f
  - tdf#155876 UI cmds Calc-Format menu (24)
    
    + Sparklines and more
    + refactoring
    
    Change-Id: Ie320018d7c3cf13d25bed7f6d7b6af4b2c9f9b26
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160251
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-03 10:50:57 +01:00
Alain Romedenne
3b354c2ee5 Update git submodules
* Update helpcontent2 from branch 'master'
  to 3b321caecd0c27ae01afb12924f4f2cb12593dd8
  - Python example shared macros documentation
    
    Change-Id: If312091c487fd062ec7af24bc4c368bae7b0d748
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160172
    Tested-by: Jenkins
    Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-12-03 10:09:40 +01:00
Julien Nabet
7265820661 Mysql/Mariadb: implement User and ODatabaseMetaData privileges methods
User::getPrivileges
User::getGrantablePrivileges
+ create ancillary User::findPrivilegesAndGrantPrivileges

ODatabaseMetaData::getTablePrivileges

Change-Id: Ib189aa121a3096aab412be68c76a3edaa11af1ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160247
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2023-12-02 22:45:34 +01:00
Mike Kaganski
18ff318c75 Revert "Drop allownonascii check from pre-commit checks"
This reverts commit 8a0015c35f.

See https://lists.freedesktop.org/archives/libreoffice/2023-December/091265.html
for details.

Change-Id: I9bfa893af935587c7a4681e71b13a734d5f50b5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160177
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-02 21:55:33 +01:00
Mike Kaganski
fbf025b490 Make testHybridPDFFile Windows-only, and filenames in repo ASCII-only.
See https://lists.freedesktop.org/archives/libreoffice/2023-December/091265.html
for details.

Change-Id: I73f4a48c9b71adc42354f099dcc98aff56e3fc43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160246
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-02 21:55:03 +01:00
Noel Grandin
52512614d2 Simplify some AlphaMask code
AlphaMask has an operator=, no need for extra complication

Change-Id: Ib0f4aba4e1c9a4a594cc1cbc92f3a335dc9295a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160243
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02 21:27:15 +01:00
Noel Grandin
1c1806724d AlphaMask::ReleaseAccess is unnecessary
There is no way the format can change via the Bitmap*Access
mechanisms, and we already perform these asserts in
the constructor and operator=.

The code has been there since
    commit 8ab086b6cc
    Author: Jens-Heiner Rechtien <hr@openoffice.org>
    Date:   Mon Sep 18 16:07:07 2000 +0000
   initial import

Change-Id: I75195f6fd4e29d7133e787131b6c8479a9188d1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160242
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02 20:20:40 +01:00
Julien Nabet
4f928a5823 Mysql/Mariadb: implement refreshUsers so get access to users admin page
There's still work to do:
- retrieve privileges of each table since it's empty for the moment
- make the checkboxes editable (it seems read only)
- make the user management work (creating one doesn't work for example)

Change-Id: Ia1d9c4db7faae16ec1903c5d7aa5e679ce5e944a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160244
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-02 18:35:20 +01:00
Julien Nabet
20661c3748 Extended loplugin:ostr: sw/qa/extras/layout/layout3.cxx
Change-Id: I1b86da0ef1ccdd2ccb83f489563f634605c25b0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160245
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2023-12-02 17:45:25 +01:00
Tomaž Vajngerl
91b39a9dad remove printf
Change-Id: Ib83b5c3b0f80310cd11f7cd8cd83e82d11e12eb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160241
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-02 13:44:38 +01:00
Stéphane Guillou
98db315322 Update git submodules
* Update helpcontent2 from branch 'master'
  to c1e282a842285a55a3f42c62dc1d74c60a8fb3e6
  - tdf#135089 update location of Presenter Console settings
    
    ...and update various headings and section order.
    
    Change-Id: Ib1e19581def728ea35ac8ab837665ffcf482bfb9
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159893
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02 12:59:05 +01:00
Stanislav Horacek
573f538424 Update git submodules
* Update helpcontent2 from branch 'master'
  to a1840f2baee7b129990d6c0b218aae1b8d0304d7
  - mark untranslatable code and control name in SF Dialog and DialogControl
    
    also fixed typos caused by split paragraph
    
    Change-Id: I6c4d3badb30629c4bf58011089b4beeb1438204a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160051
    Tested-by: Jenkins
    Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-12-02 12:58:35 +01:00
Stanislav Horacek
6991f62ef8 Update git submodules
* Update helpcontent2 from branch 'master'
  to a0058e57883886e2249e4fc2d03e15454f267f4b
  - mark bookmarks and paragraph in SF FormDocument as translatable
    
    Change-Id: I5867af5313ca86b11b79d59b6a042b16ce9dfee0
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160053
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02 12:57:52 +01:00
Stanislav Horacek
81a9dacb34 Update git submodules
* Update helpcontent2 from branch 'master'
  to 34d58970fae2b79958754584c3892512e5648bde
  - fix label of Select Table icon
    
    Change-Id: I33fc0fee719c45447cfbbf3baad52770c0329b02
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159951
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02 12:57:09 +01:00
Stanislav Horacek
3377903c2f Update git submodules
* Update helpcontent2 from branch 'master'
  to ef8dd17a74f17232e65cc64132d4918024952345
  - fix description of ResizeWindowToInitialPage PDF export option
    
    Change-Id: I0611e69f0fd7a7c7a05f737264442c07bc629c28
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159800
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02 12:55:32 +01:00
EMartinGube
c05bed5317 tdf#152307 sw: layout: invalidate more frames when footer grows
Unit test added.

Change-Id: Ibcdb504c57c020cde9b76994cb54e744d1a12888
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157905
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-02 12:38:53 +01:00
Tomaž Vajngerl
f5cf0c10eb tdf#123396 actually use the mimetype set in the from document
In the document we set the mime type for the images stored, but
at import we never actually used the mime types. We always did
mime type detection from the filename extension. The problem with
this is that files stored as base64 streams don't have a filename
so it is also not possible to determine the mime type from the
file name.

The consequence of this is that we can't know which image to take
if we have multiple images (fallback images) so we always take the
last one, which could be the wrong one. This happend in the test
document.

This changes the behavior so that we always first use the document
set mime type as there is no reason to not trust that. Only if the
mime type isn't provided by the document we use other mime type
detection methods.

Change-Id: I175c509ce5f11eab2c0454d4d9901ca1fe975272
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160237
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-02 11:10:34 +01:00
Andrea Gelmini
e320518eaf Update git submodules
* Update helpcontent2 from branch 'master'
  to f7f1aa0417dc645fe1a70022dbd58ef5063f5aac
  - Fix typos
    
    Change-Id: I9dd8a05048631cf0f1b8ec1f2ccef4d800e42e7d
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160239
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-02 10:51:30 +01:00
Laurent Balland
2a0b9ebf39 tdf#158205 Blueprint Impress template background
On first master page, move picture from page background to an object at
the background

Change-Id: I0e01ee9cad4a282c98e3678a7a45cfe13698e0e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159807
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-02 09:58:49 +01:00
Laurent Balland
29a86b7866 Beehive Impress template: restore indentation
Indentation was broken in content.xml

Change-Id: Ia9f05d5af286aa1e3b8ddd9bb205769550d25e42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160088
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-02 09:57:45 +01:00
Noel Grandin
c4228a798e pass BitmapBuffer around by std::optional
instead of allocating on the heap, it is small

Change-Id: I79eec6605a04c09d9a984cd1a719affb5b06dff3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160195
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02 09:07:15 +01:00
Caolán McNamara
dfe551c816 Related: tdf#158450 use SfxTabPage::GetFrameWeld
to get the parent window.

SfxTabPage::GetDialogController

returns mpImpl->mpSfxDialogController

and that is set in SfxTabPage::SfxTabPage ctor with

mpImpl->mpSfxDialogController = dynamic_cast<SfxOkDialogController*>(m_pDialogController);

and GetDialogController returns that mpImpl->mpSfxDialogController

while nearly everything is derived from OKDialogController, not
everything, like this column dialog case is, so
mpImpl->mpSfxDialogController is null and it all fails.

This same page is inside format, page styles as "columns" but that's the
usual multi-page dialog derived from SfxOkDialogController, its just
this single page dialog that is different.

The original idea was to wait until this parent dialog is needed to
figure out what to use. We have this SfxTabPage::SetDialogController so
the dialog controller and page can theoretically change after the ctor,
though maybe that doesn't happen in this case.

Looking at SfxTabPage::GetFrameWeld that one always returns the current
parent (of m_pDialogController, not the dynamically casted
mpImpl->mpSfxDialogController) so in the best choice to use in general.

Change-Id: I4617212fb27fdeeb0afc41123f7bc1b73f495c32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160223
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01 21:57:50 +01:00
Caolán McNamara
35c536023a we need these label placeholders for gtk
Change-Id: If86e0d1ff4259613bfc20b3ede873dc56ca59206
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160222
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01 21:57:40 +01:00
Rafael Lima
e8f3caea8c Update git submodules
* Update helpcontent2 from branch 'master'
  to 3d13c05329657af7015c298220855c4fddabd73d
  - Document new SF IncludeSubfolders argument
    
    Change-Id: I360b504446185870e8ea89843e834006f56e2af8
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160041
    Tested-by: Jenkins
    Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-12-01 21:07:50 +01:00
Michael Weghorn
08ba31da63 android: Update Android Gradle Plugin to 8.2.0
... and gradle to 8.2, as suggested by Android Studio.

Change-Id: I1a1df5f43b7a95d24308873b708d3d21b76aa7f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160200
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-01 20:34:02 +01:00
Olivier Hallot
0905043ad2 Update git submodules
* Update helpcontent2 from branch 'master'
  to 00f8970a292d6876c29f2d2d4ca7958d832743e9
  - CSS: "literal" must wrap normally.
    
    Change-Id: Ib0ee56bd4a93d14467bec0ae607477dbbd86cbd8
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160226
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-01 19:48:41 +01:00
Julien Nabet
4f8bb26748 tdf#158450: fix crash when picking custom colour for column separator line
bt:
0x00007ffeed9c4a2b in SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0::operator()() const (this=0x5555574a8e38) at /home/julien/lo/libreoffice/sw/source/ui/frmdlg/column.cxx:396
396	                [this]{ return GetDialogController()->getDialog(); }))
0  0x00007ffeed9c4a2b in SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0::operator()() const (this=0x5555574a8e38) at /home/julien/lo/libreoffice/sw/source/ui/frmdlg/column.cxx:396
1  0x00007ffeed9c4a05 in std::__invoke_impl<weld::Dialog*, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&>(std::__invoke_other, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&) (__f=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61
2  0x00007ffeed9c4985 in std::__invoke_r<weld::Window*, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&>(SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&) (__fn=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:114
3  0x00007ffeed9c489d in std::_Function_handler<weld::Window* (), SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0>::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:290
4  0x00007ffff1cb89e5 in std::function<weld::Window* ()>::operator()() const (this=0x5555574a8e38) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591
5  0x00007ffff1c94604 in ColorWindow::OpenPickerClickHdl(weld::Button&) (this=0x5555574a8db0) at /home/julien/lo/libreoffice/svx/source/tbxctrls/tbcontrl.cxx:2283
6  0x00007ffff1c9356d in ColorWindow::LinkStubOpenPickerClickHdl(void*, weld::Button&) (instance=0x5555574a8db0, data=...) at /home/julien/lo/libreoffice/svx/source/tbxctrls/tbcontrl.cxx:2279

See complete bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=191146

Regression from:
862fd2fa19
defer getting toplevel for color picker until we need it

Change-Id: I2932281cb3b1cb510013a19f6bcf3d9f9c6cdb7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160164
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01 18:09:35 +01:00
Caolán McNamara
97d3389f32 cid#1557920 COPY_INSTEAD_OF_MOVE
a sample commit to test this

Change-Id: Ibc1a1f75b908e245395a05e81c26158c67e36257
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160214
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01 18:07:00 +01:00
Caolán McNamara
004807caaa cid#1546413 silence Using invalid iterator
sample to test silencing this

Change-Id: I73a8e22a5266367d7b2c76aa00d38d40431b4841
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160213
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01 18:06:54 +01:00
Caolán McNamara
fc288036a5 cid#1555476 silence Unchecked return value
Change-Id: I55db6a470a2aca5ebcbace7859236b08bb67e25b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160212
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01 18:06:46 +01:00
Caolán McNamara
e0014555f5 cid#1558172 Division or modulo by zero
Change-Id: I4060b003fc03c8fe3e0396f9618e64a69715131c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160211
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01 18:06:40 +01:00
Julien Nabet
735b6b3861 tdf#158452: FB: impossible to change field to "entry required" in GUI
... after table has been saved.

There was an hack due to the fact that before FB 3.0, it wasn't possible to use ALTER TABLE to change nullable.
See https://bugs.documentfoundation.org/show_bug.cgi?id=158452#c1
Since the hack doesn't work and since FB 3.0 since several years, let's remove the hack and use ALTER TABLE command.

Change-Id: I145077bb4c4874f5fe31e375cfb64176a1293575
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160220
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2023-12-01 17:23:23 +01:00
Andrea Gelmini
6744434127 Fix typo
Change-Id: Iae999cd64ca73f178e4e1148af71b47fe03c8e2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160206
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-01 17:05:29 +01:00
Andrea Gelmini
18a505f973 Fix typo
Change-Id: Ie5cb165cce88c44004ff37692bfb3c0438c26ccb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160209
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-01 17:05:11 +01:00