Commit graph

9564 commits

Author SHA1 Message Date
Lionel Elie Mamane
b89da4bbb9 Type: BROWSER_INVALID_ID -> BROWSER_INVALIDID 2011-09-12 17:46:56 +02:00
Lionel Elie Mamane
f7ed67f2cf cleanup BrowseBox, DbGridControl & friends handle & invalid column handling
- BrowseBox: Check Handle column-related invariants when adding a
   column:
   # only one handle column
   # it is the first

 - BrowseBox: Check column id-related invariants when adding a column:
   # Id is not the special "handle column" value
   # Id is not the special "invalid ID" value
   # unicity of the ID among columns

 - GetColumnId: return BROWSER_INVALIDID, not 0 (== id of handle
   column) for an invalid column; adapt code calling GetColumnId to
   this change.

 - Use the correct const or #define'd symbol instead of magic
   constants; introduce such a symbol if needed

 - General other miscellaneous cleanups:
   # Translation of comments
   # typo/spelling in comments, error messages and the like
   # parenthesise #define'd value
   # use SAL_MAX_UINT16 instead of USHRT_MAX where a sal_uInt16 is
     expected
   # BrowseBox::SetColumnTitle: nItemId is checked to be non-zero, so
     don't test if for zeroness again.
2011-09-12 16:40:51 +02:00
Lionel Elie Mamane
fea84e0041 typo in parameter name 2011-09-12 16:40:51 +02:00
Caolán McNamara
07f9a847f0 callcatcher: various unused methods 2011-09-12 09:09:59 +01:00
Jenei Gábor
bc0a497f08 Fixes fdo#36594 Syntax error in SQL on "--" comment (and "//" and "/**/")
The SQL parser implementation does not handle comments.
Temporarily remove "-- ..." and "// ..." end-of-line comments and "/* ... */"
inline comments of a query and append comments after recomposition of the
query.

NOTE: The original comment positions are not preserved, all comments are
      appended to the query!

Based on the original patch further development was done for inline comments
and preserving comments' line order.
2011-09-03 01:19:51 +02:00
Julien Nabet
78c1a9f5c4 Some cppcheck cleaning 2011-09-01 21:34:19 +02:00
Caolán McNamara
8de61c9fb6 grabbag of unused code 2011-08-31 10:43:23 +01:00
Caolán McNamara
2f5856b20d WaE: dbglevel=2 2011-08-30 09:32:23 +01:00
Caolán McNamara
01f5362e79 String::CreateFromInt64->rtl::OUString::valueOf 2011-08-25 09:42:07 +01:00
Noel Power
117281ba12 fix leaking 'Pictures' streams from basic dialogs in base
With database document, any contents of the Pictures folder ( afaics only basic dialogs store content here ) is never cleaned up between saves.
2011-08-22 15:44:55 +01:00
Caolán McNamara
d1fb13adf9 convert tools::Config to rtl::OString 2011-08-19 09:30:44 +01:00
Caolán McNamara
58ee09b87b ByteString, shrink api 2011-08-12 11:51:11 +01:00
Kohei Yoshida
f871b281c9 No more FORWARD_DECLARE_INTERFACE in dbaccess. 2011-08-11 19:53:21 -04:00
Gabor Jenei
8dd90858a2 patch for xmlfilter.cxx 2011-08-09 14:48:08 +01:00
Caolán McNamara
13ff96fe03 fix assert, names expected to be sorted 2011-08-08 13:04:43 +01:00
Caolán McNamara
4b596c2e54 use SAL_N_ELEMENTS 2011-08-08 13:04:43 +01:00
Kohei Yoshida
fdfc75797e Use rtl::OUStringHash. 2011-08-04 21:31:14 -04:00
Caolán McNamara
b82efddccf callcatcher: remove unused code 2011-07-31 23:52:16 +01:00
Caolán McNamara
f014ba75fd convert to new api
this code looks suspiciously like a no-op, i.e. that the intent
is to append the generated string, but the old code threw
away the string, so not a new bug but in there since 2001
2011-07-31 21:12:56 +01:00
Jan Holesovsky
c2a7f87b92 Merge commit 'libreoffice-3.4.2.3' 2011-07-28 10:14:00 +02:00
Caolán McNamara
bc04067352 catch by const reference 2011-07-26 23:02:25 +01:00
Bjoern Michaelsen
d8fa358911 Merge branch 'master' into feature/gnumake4 2011-07-24 19:22:58 +02:00
Bjoern Michaelsen
dae8595066 revert to dbaccess gbuildization from master mostly
* only add JunitTest_dbaccess_complex, which was missing on master
* disable complex.dbaccess.DatabaseDocument in JunitTest_dbaccess_complex for
  now as it fails
2011-07-23 10:13:13 +02:00
Kohei Yoshida
2835baa19e Adjusted for HTMLParser::GetOptions return type change. 2011-07-22 16:04:43 -04:00
Tor Lillqvist
c7ed86bbe6 Plug MinGW gaps 2011-07-22 14:58:37 +03:00
Bjoern Michaelsen
923db2bcda resyncing to master 2011-07-21 18:30:24 +02:00
Caolán McNamara
93e5a0b132 ByteString::CreateFromAscii->rtl::OStringBuffer::valueOf 2011-07-19 21:50:47 +01:00
Caolán McNamara
09ec854d98 callcatcher: remove unused methods 2011-07-14 22:05:39 +01:00
Matúš Kukan
c8d7891600 Add prefixes for component_getFactory methods
Also remove accidentally kept .dxp files from gnumake'd module
2011-07-13 17:56:47 +02:00
Matus Kukan
22d4188f57 Remove component_getImplementationEnvironment 2011-07-12 11:10:12 +02:00
Matus Kukan
0eec34568c Move methods from component_getImplementationEnviron to component_getFactory 2011-07-11 20:34:42 +01:00
Jan Holesovsky
5a6934c6f0 Don't crash when selecting target to db document, fdo#36545.
Signed-off-by: Michael Meeks <michael.meeks@novell.com>
2011-07-01 14:48:08 +01:00
David Tardon
15c80d4db0 make this more readable 2011-06-23 06:11:02 +02:00
Bjoern Michaelsen
81ca9771b7 gnumake4: postmerge fixes in dbaccess reportdesign 2011-06-21 12:50:12 +02:00
Bjoern Michaelsen
e70b1417d2 Merge branch 'master' into feature/gnumake4
Conflicts:
	dbaccess/AllLangResTarget_adabasui.mk
	dbaccess/AllLangResTarget_dba.mk
	dbaccess/AllLangResTarget_dbmm.mk
	dbaccess/AllLangResTarget_sdbt.mk
	dbaccess/Executable_odbcconfig.mk
	dbaccess/JunitTest_dbaccess_unoapi.mk
	dbaccess/Library_adabasui.mk
	dbaccess/Library_dba.mk
	dbaccess/Library_dbaxml.mk
	dbaccess/Library_dbmm.mk
	dbaccess/Library_sdbt.mk
	dbaccess/Makefile
	dbaccess/Module_dbaccess.mk
	dbaccess/Package_inc.mk
	dbaccess/Package_uiconfig.mk
	dbaccess/prj/build.lst
	dbaccess/qa/unoapi/Test.java
	dbaccess/source/core/api/CacheSet.hxx
	dbaccess/source/core/dataaccess/SharedConnection.hxx
	dbaccess/source/core/dataaccess/connection.cxx
	dbaccess/source/filter/xml/xmlAutoStyle.cxx
	dbaccess/source/filter/xml/xmlColumn.cxx
	dbaccess/source/filter/xml/xmlComponent.cxx
	dbaccess/source/filter/xml/xmlConnectionData.cxx
	dbaccess/source/filter/xml/xmlConnectionResource.cxx
	dbaccess/source/filter/xml/xmlDataSource.cxx
	dbaccess/source/filter/xml/xmlDataSourceInfo.cxx
	dbaccess/source/filter/xml/xmlDataSourceSetting.cxx
	dbaccess/source/filter/xml/xmlDataSourceSettings.cxx
	dbaccess/source/filter/xml/xmlDatabaseDescription.cxx
	dbaccess/source/filter/xml/xmlDocuments.cxx
	dbaccess/source/filter/xml/xmlFileBasedDatabase.cxx
	dbaccess/source/filter/xml/xmlHelper.cxx
	dbaccess/source/filter/xml/xmlHierarchyCollection.cxx
	dbaccess/source/filter/xml/xmlLogin.cxx
	dbaccess/source/filter/xml/xmlQuery.cxx
	dbaccess/source/filter/xml/xmlServerDatabase.cxx
	dbaccess/source/filter/xml/xmlTable.cxx
	dbaccess/source/filter/xml/xmlTableFilterList.cxx
	dbaccess/source/filter/xml/xmlTableFilterPattern.cxx
	dbaccess/source/ui/app/AppDetailPageHelper.cxx
	dbaccess/source/ui/app/AppDetailView.cxx
	dbaccess/source/ui/app/AppIconControl.cxx
	dbaccess/source/ui/app/AppSwapWindow.cxx
	dbaccess/source/ui/app/AppTitleWindow.cxx
	dbaccess/source/ui/app/AppView.cxx
	dbaccess/source/ui/browser/AsyncronousLink.cxx
	dbaccess/source/ui/browser/genericcontroller.cxx
	dbaccess/source/ui/control/ColumnControlWindow.cxx
	dbaccess/source/ui/control/RelationControl.cxx
	dbaccess/source/ui/control/SqlNameEdit.cxx
	dbaccess/source/ui/control/TableGrantCtrl.cxx
	dbaccess/source/ui/control/VertSplitView.cxx
	dbaccess/source/ui/control/toolboxcontroller.cxx
	dbaccess/source/ui/dlg/CollectionView.cxx
	dbaccess/source/ui/dlg/ConnectionHelper.cxx
	dbaccess/source/ui/dlg/ConnectionPageSetup.cxx
	dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
	dbaccess/source/ui/dlg/RelationDlg.cxx
	dbaccess/source/ui/dlg/TextConnectionHelper.cxx
	dbaccess/source/ui/dlg/detailpages.cxx
	dbaccess/source/ui/dlg/dlgsize.cxx
	dbaccess/source/ui/dlg/queryorder.cxx
	dbaccess/source/ui/dlg/tablespage.cxx
	dbaccess/source/ui/misc/TableCopyHelper.cxx
	dbaccess/source/ui/misc/ToolBoxHelper.cxx
	dbaccess/source/ui/misc/WExtendPages.cxx
	dbaccess/source/ui/misc/WNameMatch.cxx
	dbaccess/source/ui/misc/WTypeSelect.cxx
	dbaccess/source/ui/querydesign/ConnectionLine.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	dbaccess/source/ui/querydesign/ConnectionLineData.cxx
	dbaccess/source/ui/querydesign/JAccess.cxx
	dbaccess/source/ui/querydesign/JoinController.cxx
	dbaccess/source/ui/querydesign/JoinDesignView.cxx
	dbaccess/source/ui/querydesign/JoinExchange.cxx
	dbaccess/source/ui/querydesign/JoinTableView.cxx
	dbaccess/source/ui/querydesign/QTableConnection.cxx
	dbaccess/source/ui/querydesign/QTableConnectionData.cxx
	dbaccess/source/ui/querydesign/QTableWindow.cxx
	dbaccess/source/ui/querydesign/QTableWindowData.cxx
	dbaccess/source/ui/querydesign/QueryDesignView.cxx
	dbaccess/source/ui/querydesign/QueryTabConnUndoAction.cxx
	dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx
	dbaccess/source/ui/querydesign/QueryTextView.cxx
	dbaccess/source/ui/querydesign/QueryViewSwitch.cxx
	dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
	dbaccess/source/ui/querydesign/TableConnection.cxx
	dbaccess/source/ui/querydesign/TableConnectionData.cxx
	dbaccess/source/ui/querydesign/TableWindow.cxx
	dbaccess/source/ui/querydesign/TableWindowAccess.cxx
	dbaccess/source/ui/querydesign/TableWindowData.cxx
	dbaccess/source/ui/querydesign/TableWindowListBox.cxx
	dbaccess/source/ui/querydesign/TableWindowTitle.cxx
	dbaccess/source/ui/querydesign/querydlg.cxx
	dbaccess/source/ui/querydesign/queryview.cxx
	dbaccess/source/ui/relationdesign/RTableConnection.cxx
	dbaccess/source/ui/relationdesign/RelationDesignView.cxx
	dbaccess/source/ui/relationdesign/RelationTableView.cxx
	dbaccess/source/ui/tabledesign/FieldDescGenWin.cxx
	dbaccess/source/ui/tabledesign/FieldDescriptions.cxx
	dbaccess/source/ui/tabledesign/TEditControl.cxx
	dbaccess/source/ui/tabledesign/TableDesignHelpBar.cxx
	dbaccess/source/ui/tabledesign/TableDesignView.cxx
	dbaccess/source/ui/tabledesign/TableFieldControl.cxx
	dbaccess/source/ui/tabledesign/TableRow.cxx
	dbaccess/source/ui/tabledesign/TableRowExchange.cxx
	dbaccess/source/ui/tabledesign/TableUndo.cxx
	dbaccess/source/ui/uno/ColumnControl.cxx
	dbaccess/source/ui/uno/ColumnPeer.cxx
	reportdesign/AllLangResTarget_rpt.mk
	reportdesign/AllLangResTarget_rptui.mk
	reportdesign/Library_rpt.mk
	reportdesign/Library_rptui.mk
	reportdesign/Library_rptxml.mk
	reportdesign/Module_reportdesign.mk
	reportdesign/Package_uiconfig.mk
	reportdesign/Package_xml.mk
	reportdesign/prj/build.lst
	reportdesign/prj/makefile.mk
2011-06-20 09:52:21 +02:00
Ocke Janssen [oj]
3c93ed792e gnumake4: converted dbaccess [hg:8113b354673f] 2011-06-17 14:35:26 +02:00
Caolán McNamara
f1ea4ba447 fix tinderboxes 2011-06-14 09:54:19 +01:00
Kohei Yoshida
38c0147475 (Hopefully) fix the ambiguity error that the tinderboxes kept complaining. 2011-06-13 20:46:43 -04:00
Joseph Powers
5324c50280 Change ScTreeEntryList to no longer depend on class List. 2011-06-09 21:24:14 -07:00
Caolán McNamara
eb139d063e use standard template here 2011-06-02 00:06:10 +01:00
Jan Holesovsky
37032dc9dc Merge commit 'libreoffice-3.4.0.2' 2011-05-30 13:12:13 +02:00
Jan Holesovsky
ee6238002e Merge branch 'master' of git://anongit.freedesktop.org/libreoffice/base 2011-05-27 20:49:14 +02:00
Jan Holesovsky
5d178b6a19 Merge remote-tracking branch 'origin/integration/dev300_m106'
Conflicts:
	dbaccess/source/ui/app/makefile.mk
2011-05-27 20:39:17 +02:00
Joseph Powers
0f994a061c Revert TreeList to vector<> conversion.
This fixes a bug in Options->Path. I'll need to rework the conversion
later.
2011-05-26 20:16:11 -07:00
Thorsten Behrens
2f76d4b430 Remove hc paramater from aImageProvider.getFolderImage
This fixes the m106 merge.
2011-05-23 18:33:42 +02:00
Joseph Powers
3a2a53da02 class SvTreeEntryList is no longer dependant on class List 2011-05-22 20:27:19 -07:00
Tor Lillqvist
4233db9d50 Drop OS2 2011-05-21 15:41:03 +03:00
Caolán McNamara
5d6f7edfbb adjust for return by ref instead of pointer 2011-05-20 15:21:26 +01:00
Caolán McNamara
49a5cd8537 config leaks: drop dodgy LegacySingleton foo 2011-05-20 15:21:26 +01:00
Joseph Powers
1be46ab5d7 Remove an un-needed #include <svtools/treelist.hxx> 2011-05-20 05:56:35 -07:00