Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.
This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.
Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
The tab area page has a magic bit which is set when the page is activated that
enables its properties to be applied on ok. If another page is activated that
also affects area fill using an alternative set of properties, then the bit is
unset.
For layout we have to activate all pages that don't exist yet to get their
optimal size. So we need to re-activate the original/current page after forcing
the other pages to exist in order to make this trickery work.
Change-Id: I90cac4624a12e6c29f6b226ce831f71c7cc49117
Just sprinkle #ifdef SOLAR_JAVA into the code instead.
In the source for jvmaccess and jvmfwk such ifdefs can be removed as
it isn't compiled unless SOLAR_JAVA.
Change-Id: Ia8614f8bd6d833582d3b79b5fb75f9153fa79606
Restore removed spinner artwork, cleanup the code: hicontrast - is now
a function of icon theme, not a global boolean.
uwith thanks to Ariel Constenla-Haile)
Change-Id: I68d4c7293a6faa130274cf45f53509ce140fa8c0
So no point in checking font *family* names like "arial" or
"times". Actually, I doubt this whole block of heuristics is
necessary.
Change-Id: I6965c27a7c4bed53db0e7ddaa40b1d09ccc4ad43
As its name says, CFDictionaryGetValue() follows "The Get Rule",
i.e. you don't have ownership of the object returned, so it shouldn't
be released.
Change-Id: Ie605ac21754ed479911d8f4ceb00744a6df600aa
The functionality was removed by fdo#48549.
This partially reverts
0f6101cfef0bdf6fc7c785cb908453
I changed the behavior to always beep, because only the basic macro
function is using Beep(). Looks like the Beep macro function didn't
even work correctly before the removal, because the default was to
not beep for most platforms. So I set the volume from disable (0)
to 50% for XBell().
Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a
Reviewed-on: https://gerrit.libreoffice.org/3124
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
Used multithreaded when SdrGrafObj is on asynchronous loading. It was not safe
due to using VirtualDevices on occasions where needed (mostly Font stuff).
Extends fix of 6280a1e310 for fdo#36991
(cherry picked from commit a379ffae809a4b9f92fbde9b9699f5353f7b3472)
Conflicts:
svtools/source/filter/wmf/winmtf.cxx
svtools/source/filter/wmf/winmtf.hxx
svtools/source/filter/wmf/winwmf.cxx
Change-Id: Ifd1d23217c0fbe22edbd1b1995286846e19030de
When initially calling lo_render_windows() from a redrawRect(), just
post the user event asking for a redraw of the (headless) windows, and
return without actually drawing anything to the context.
Then when the RenderWindows() callback for that user event eventually
gets called (which during startup and/or loading of a document might
be several seconds later, as there is lots of other activity going on
also as "user events"), ask the UI thread for a fresh redraw, and wait
for lo_render_windows() in that phase to signal the actual redraw of
the "headless" windows into the context.
Unfortunately this doesn't work well enough. It is not a good idea to
not draw anything in response to a drawRect() it seems. The affected
rectangle gets initialised to black. So there is now irritating
flashing. One sees an almost ready document (and the UI elements which
still are there), but then it goes away for some time before finally
re-appearding. Quite silly. So I will revert this, and I am committing
it just to keep the code for reference in git.
Change-Id: I9ee490345f093d80113c36f9e3268cab5a810dd0
_PC_NAME_MAX is a symbolic constant meant to be used as a pathconf()
argument, not a buffer length.
This piece of code was even "honored" in
http://womble.decadent.org.uk/readdir_r-advisory.html
"The code that enumerates fonts and plugins in the appropriate
directories uses a stack buffer of type long[sizeof(struct dirent) +
_PC_NAME_MAX + 1]. I can only assume this is the result of a programmer
cutting his crack with aluminium filings."
Thanks to Heiner Rechtien for pointing this out.
Note: declaring the buffer of type long instead of char looks weird but
probably has the reason that it is casted to struct dirent* for the
readdir_r() call that might not work on architectures that forbid
arbitrary alignment on non-even boundaries.
Change-Id: Ie959b8905d1328c6fcaefbf6f6c915cc430e85b6
I am not really satisfied yet with how the UI redrawing in the app now
works (during startup, which of course is more or less all the app
does so far).
It can take quite some time before a "link" (function to be called)
posted with PostUserEvent() gets run (if there are lots of
time-consuming other "user events" in the queue already, or
something?), and blocking the UI thread for that time is not
acceptable. Will have to come up with some more complicated solution.
Change-Id: Icab20183df3bc4980ae33f0502d10397802cc391
We used to render them in the app main (GUI) thread, which is
dangerous, accessing the headless frames in one thread while the LO
thread (where the "main" LibreOffice code is running) might be
updating and changing them.
This fixes some problems like that part of the document did not show
up. If I would test the app on a multi-core iPad, presumably I would
have seen even more problems.
But this also introduces new problems: Now the UI doesn't appear
incrementally (for instance, with an actually progressing progress bar
during the loading of the document) as it used to. Now it all appeads
all of a sudden, everything at once. Which would be fine if it
happened very quickly after starting the app, but it doesn't... on the
original iPad it takes half a minute.
Change-Id: I04068e0d884aa5cb86acefa76449aac4e081b193
No, it isn't any closer to being "ready" despite the name, but still,
using the current approach, it clearly isn't restricted to be just a
viewer.
Also drop the verbose LOViewer prefix from class and file names in it.
Change-Id: Ib4e8a31d6fa1b35169ee98cf2aa8f0f22957164c
In other files in vcl/unx/kde4/, those defines are apparently needed to resolve
a clash between class Region from vcl/region.hxx and typedef Region from
/usr/include/QtGui/qwindowdefs.h. But in these two files those two clashing
headers appear not to be included both, so the define would be flagged by
-Wunused-macros.
Change-Id: Ib5bb62867dd3b3ea4c0a9f4b461efcecd92bc4b7
FYI: there is some code duplication noticeable between slider and scrbar
Conflicts:
vcl/source/control/longcurr.cxx
vcl/source/control/lstbox.cxx
vcl/source/control/menubtn.cxx
vcl/source/control/morebtn.cxx
vcl/source/control/prgsbar.cxx
vcl/source/control/scrbar.cxx
Change-Id: I736cf155e252293ed571cd44a6a395b15c4bf576
Reviewed-on: https://gerrit.libreoffice.org/2966
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Bin the SAL_FRAMESTATE_* defines which as the comment said had to be the same
as the WINDOWSTATE_*] in syswin.hxx.
Change-Id: I42fcd91db543821f007038e558872ba8f69e4a78
7d1f4cdec3 changed some String to OUString
and replaced Search...() with indexOf() but still compared the result
against STRING_NOTFOUND instead of the -1 required now.
Change-Id: I94ecdd1741554d8ac401f9cc2ffe8456e3184394
The reason why a 1bpp virtual device is used in these two places in sc
and sw is unclear to me. It causes complications on iOS as such a
bitmap gets passed to CGBitmapContextCreate() which does not accept
1bpp bitmaps. But let's keep the 1bpp for other platforms.
Change-Id: Ia34927cf728d4be05a31e88b7da78200d0b799ba
A bit scary that the linker didn't notice the duplicate symbols, but
instead apparently just picked the first (or an arbitrary) one. Need
to look into that. Anyway, now when the correct SetTextColor is linked
in the coloured text in the demo document shows up in all its glory.
The code that is partially shared between the headless, OS X CoreText
and iOS backends should to be refactored a bit, I guess.
Change-Id: Id341298f72dc253380d9b2319032e0a9a8bdd0f6
Pass -DLIBO_FEATURE_FOO to compiler for some elements in BUILD_TYPE.
BUILD_TYPE has at least two kinds of elements: Those that indicate
building a bundled copy of some 3rd-party library, and those that
indicate some specific feature of the LibreOffice platform or
build-time configuration choice. This is for the latter kind.
Change many of the checks for Android and/or iOS in the source code to
check LIBO_FEATURE_DESKTOP, LIBO_FEATURE_HELP or DISABLE_EXTENSIONS
instead, in cases where that is what is meant, not Android or iOS
specifically.
Change-Id: I2cd3f3bb99e953c7754dcea76a426f8f9d61e4db
...replacing hard-coded GCC version checks. Those checks that guard
#pragma GCC diagnostic ignored "-Wnon-virtual-dtor"
appear relevant only for GCC itself, not Clang (which used to fail the old
guards because it typically announces itself with a rather low
__GNUC__/__GNUC_MINOR__ version), see 6e67c03dc0
"Enable -Wnon-virtual-dtor for GCC 4.6"
Change-Id: I6bfa4d5caa6192e7a203ce829682bf6bb8d61a1b
Remove unnecessary commented out code, remove comment "spacer" lines,
in general tidy up this code to make it easier to read.
Change-Id: I37a19177795aa93d63f736e1933924605fbf2146
Reviewed-on: https://gerrit.libreoffice.org/2921
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Those were DBG_ERRORn before and were falsely changed to OSL_TRACE by me.
See:
1707a350af533f89e493
Change-Id: I4f4188ba25b988128a539542f49797ea6985702e
Reviewed-on: https://gerrit.libreoffice.org/2900
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
As I don't see a point in comparing a mimetype with only a
substring, it probably could be a simple compareToAscii, but
play it save and use startsWith.
Change-Id: Ic33c8089283def615999ddf80cd12f6fe219ed17
Reviewed-on: https://gerrit.libreoffice.org/2907
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
On x64 Windows there is no name mangling for Win32 API calls, so a
plain extern "C" CreateBitmap() function clashes.
Change-Id: I39ca92c259f660f00952ec0a8065bae1e747cffb
Don't try to use similar code as for OS X to manage windows, events
etc. I.e. don't use UIKit in vcl to do that. Instead, just do as in
the Android port, use the "headless" vcl backend. Do keep using
CoreText, though, not FreeType & fontconfig.
Start changing the iOS "Viewer" app to correspond to the Android
"desktop" app (so it should be renamed).
Work in progress since a long time, several crucial details still
missing, but committing for now.
Change-Id: Iac5fbf8def415e4d0d21e5200450a373420ad7ee
This was a kludge from back in the day when pdfimport was an
extension and could not link against office libs.
While at it, fix mirror method to handle unicode surrogates
correctly.
Change-Id: I3582a7870efdfea50446d3604a185025b1d5a196
Some extensions in the wild, for example Impress Photo Album Creator,
manage to call the file picker dialog with an empty URL. The resulting
error message is not very helpful: "Operation not supported" dialog.
Therefore we assign a default URL when empty URL is passed.
Change-Id: Icf71142411a79e1fe2d1d5918d2a400b174acc00
Reviewed-on: https://gerrit.libreoffice.org/2390
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Change-Id: Iac5de5ea434e843c4bbf27763f16751d75e798ec
Reviewed-on: https://gerrit.libreoffice.org/2806
Reviewed-by: Joren De Cuyper <joren.libreoffice@telenet.be>
Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
Tested-by: Tomáš Chvátal <tchvatal@suse.cz>
According to documentation, the system does it automatically. Testing
seemed to confirm that, with the code still in I got mysterious
crashes.
Not sure if the corresponding code is unnecessary or wrong on OS X,
too.
Change-Id: I14e9f5bcc0376e9235f8d36b484b38c1e44932c4
Suggested Easy Hack: Replace all instances of // -------- comments
including surrounding newlines with a single newline.
Another Easy Hack, slightly harder to automate: Remove all the
pointless comments that just tell the class name right before the
declaration of that class.
Change-Id: Ia890ed613b53c5d719988697e20a983d62334123
No need to refer to some source files in a few random places in
headers, using ancient UPPER-CASE file names even.
Change-Id: Ia0827be34046f25fd769466c41dab017b4935a37
Esp hard was ImpSdrGDIMetaFileImport, but working now. Needed to hand-craft
alpha addition for alpha in Metafile content and gradient of action. Also added
better BitmapEx creation for convert to bitmap for draw objects.
Conflicts:
svx/source/svdraw/svdxcgv.cxx
vcl/source/gdi/impgraph.cxx
Change-Id: Ic6ac9fb3132dd122e16a5cd8f9c5ddd155ec9882
we go to some effort to determine the right value of ret
and then throw it away and return 0
regression since 4a7e348291
Change-Id: I652cfbe44fdab6560c1c8dc8fe25d6211b5357cb
regression from String->OUString conversion with
tricky unsigned xub_StrLen of 0xFFFF for not-found
> any found position, vs -1 for OUString for not-found
Change-Id: I4a2babae085916a86cd1e60b74b4ea839dd8b87a
Add some code needed for commit 684c502ed0
This fixes the infinite loop that allocates gigs of memory in sc_unoapi test.
The problem was that instead of PixelToLogic overload an implicit Region
ctor was called.
Change-Id: Iefcd453a5c6327964c219074239ac65be737da6e
* subversion/main/vcl/source/gdi/pdfwriter_impl.cxx
[]Change nXOffset value from the distance of axis Y between two points to the distance between two points.
Patch by: Tang Meng<tmyl2010@gmail.com>
Suggested by: Wang Zhe <kingwisemmx@gmail.com>
Found by: Tang Meng <tmyl2010@gmail.com>
Review by: Wang Zhe <kingwisemmx@gmail.com>
to SdrObjects (ImpSdrGDIMetaFileImport) as good as possible with Metafile usage
Conflicts:
svx/source/svdraw/svdfmtf.cxx
svx/source/svdraw/svdfmtf.hxx
Change-Id: I41422696e97f919e618f7e385c68d4ac737a52c1
The hex literal 0x00000001 is a 32-bit unsigned int on all our platforms. Here
it is being cast to a pointer,resulting in 32 or 64 bits. Using exactly eight
hex digits with leading zeroes gives the impression that the leading zeroes
and the total number of hex digits would have some significance.
Change-Id: I75904dc4261c195dfaaf45aa3de729994da6d8dc
The necessary build stuff was apparently silently dropped during gbuild
conversion and never noticed.
Change-Id: Ib1f530b92618a9d4f11c54818e984f737abaa283
