Commit graph

3100 commits

Author SHA1 Message Date
Thomas Arnhold
89003e9bd8 loplugin: unused variables
Change-Id: I63553a09eec81e5ae28aa79ee1d3281053b23d06
2013-02-25 03:14:01 +01:00
Thomas Arnhold
d5caf6898b loplugin: unused variables
Change-Id: I7fc203900256839e679bf73b717d121fedc42087
2013-02-24 17:44:31 +01:00
Tor Lillqvist
5f3dacaeef Try ignoring IPC pipe errors on Android
Change-Id: I906df7fb65226422973e11ad69abdcc4fbd980c9
2013-02-22 18:15:57 +02:00
Tor Lillqvist
b7777dbf8e Rename the package and .apk of the "desktop" test app to avoid confusion
It used the same package name as DocumentLoader and the same .apk name as the
eary sc cppunit test app. Probably having two unrelated apps with the same
package name causes some confusion somewhere.

Change-Id: I11414b9cd59694eb97d39bfaeac4ed1066ae3aab
2013-02-22 18:15:57 +02:00
Caolán McNamara
1a4bcd1b0d these stray fprintfs drive people demented
Change-Id: Ifee5c39423957bcc4708a7933c760d9467e2ac27
2013-02-22 12:59:02 +00:00
Julien Nabet
1443a9f7ab [Uu]sefull -> [Uu]seful
Change-Id: I5dad83789ff9b6815561208679a5e19821041e1f
2013-02-22 11:12:33 +01:00
Tor Lillqvist
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
Tor Lillqvist
a07dd698bf Remove leftover debugging printf
Change-Id: I90a75a3d2eed8929b21eef3f710aec37a9f9c5bd
2013-02-21 23:31:26 +02:00
Michael Meeks
4d25878755 android: finally starting and rendering at least something again.
Only renders on very-first-start after install (oddly).
We initialize vcl in it's own thread to avoid problems.
Thanks to tml for fixing a linking issue.
Change-Id: I960d11c6098681356fea0634970545aa9af9bacb
2013-02-21 22:54:36 +02:00
Stephan Bergmann
b6ff19fba3 Clean up code that sends and recvs strings accross the OfficeIPC pipe
Change-Id: I5e85d5e0e4e53f3c61e59430afea15028444018f
2013-02-21 10:33:45 +01:00
Julien Nabet
eda11cbfaf Some cppcheck cleaning
Change-Id: I0b9d3b5f8283e2fddc96b220a755ba6bcdd11606
2013-02-20 22:39:00 +01:00
Tor Lillqvist
2d907dcca7 s/FaultBack/Fallback/
Change-Id: I9ecf4f57770151c1e4976c57d1f93982f35ac0fb
2013-02-20 16:43:21 +02:00
Julien Nabet
7d9a7020eb Good way to initialize array of char char var[NB]={0}
See http://stackoverflow.com/questions/1920430/c-array-initialization

Change-Id: Ibbbe249684dc34f8aa44868c99cc1344a2928ade
2013-02-19 22:05:35 +01:00
Norbert Thiebaud
6c8f448cff coverity#983483 String not null terminated
Change-Id: I4cefa485b52afcdb761bfea99dd2515a206812a8
Reviewed-on: https://gerrit.libreoffice.org/2199
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-19 03:05:55 +00:00
Stephan Bergmann
15003612ae Clean up some supportsService implementations
Change-Id: Ib74400765a6e0ef203e751afa5433a01c8564fee
2013-02-16 12:32:24 +01:00
Christopher Hotchkiss
b4d3f5c2b0 Added the current commit to "soffice --version". Fixes bug 60688.
Change-Id: I95300b093b4fabc9a52f9c92de874f7c8e4d2869
Reviewed-on: https://gerrit.libreoffice.org/2160
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-02-15 13:04:44 +00:00
Jean-Noël Rouvignac
77fd448d09 Removed several useless macros: UNISTRING, USTR, USTR_ASCII, ASCII_STR, ASCII_STRING, CONST_ASCII, ASCSTR, ASCII, DEFINE_CONST_UNICODE, DEFINE_CONST_OUSTRING
Change-Id: I96d690bf9f9b319e9eeafcf218ec5ce87f21215f
Reviewed-on: https://gerrit.libreoffice.org/1954
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-02-14 13:20:14 +00:00
Stephan Bergmann
1b0109aeda Undefined UpdateRequiredDialog::selectEntry
Change-Id: I7319b4bc276a38cf94aa90934529835ac38f57fa
2013-02-12 15:58:49 +01:00
Stephan Bergmann
4a6c72e3b1 Clean up EXTENSION_LISTBOX_ENTRY_NOTFOUND
Change-Id: Ie491835b854bf59694a20c4f94e2333b72142d08
2013-02-12 15:58:49 +01:00
Noel Grandin
4b51374a70 fdo#46808, Adapt ui::dialogs::FilePicker UNO service to new style
Change-Id: I1cafbfc53994e5d74241042dbd1d292ddbda67d5
2013-02-12 10:14:45 +02:00
Noel Grandin
0cd4caa547 fdo#46808, convert code in desktop module to XComponentContext
Change-Id: I79a22f52ebe59f8f89291d4e6e78bd37817cd047
2013-02-11 08:02:18 +02:00
Noel Grandin
f53517a5b0 fdo#46808, convert xml::xpath::XPathAPI to new-style service
Change-Id: I54bb0eb08d687e7d54c42601c826c580a7a17ebb
2013-02-11 08:02:14 +02:00
Noel Grandin
591ef78440 fdo#46808, Use singleton util::theMacroExpander new-style constructor
And deprecate the old-style service util::MacroExpander

Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-02-11 08:02:13 +02:00
Stephan Bergmann
57955e1961 Revert "Cleanly remove an extension again that cannot be activated while installing it"
This reverts commit 3c71fa1e5e.  There are cases
(like failure to install a per-user extension during upgrade), where the user
may want to still see the broken extension in the Extension Manager, instead of
it "disappearing completely."  A better fix would be to roll back registration
of the broken extension completely, so that "unopkg list" would not list the
first half of its parts as "is registered: yes" and the second half as "is
registered: no."
2013-02-07 15:42:39 +01:00
Tor Lillqvist
e98861f1ae The resstart crack causes a crash when running sandboxed on OS X
I doubt any other app would intentionally do such a restart trick, so
it isn't surprising that the app sandbox designers have not taken such
a possibility into account.

So instead of crashing, display a dialog informing the user that LO
must be restarted manually once after installation (or after being
updated, presumably).

Change-Id: I0e6ea8384fe5a9b3a8b3ddb07743374a4c2300cd
2013-02-06 00:57:26 +02:00
Stephan Bergmann
4bbc91d5c5 Better error reporting
Change-Id: Icb083795c9c00a9ca33c2a901b4183b81c98918c
2013-02-05 17:31:17 +01:00
Stephan Bergmann
2a31dd4025 Cleanly remove components from rdb again that fail during live insertion
Such failure happens e.g. for components that bring along duplicate UNO
implementation names, and if they ever got added to an rdb, LO would afterwards
refuse to start forever.

Change-Id: Ia62ac496547a45f5a72fdc81543f15a417c09687
2013-02-05 13:08:22 +01:00
Stephan Bergmann
3c71fa1e5e Cleanly remove an extension again that cannot be activated while installing it
...otherwise, it will needlessly be carried forward marked "broken."

Change-Id: I12fbd4430e1ecc11f1969ae5f49aed43668f2c27
2013-02-05 13:08:22 +01:00
Stephan Bergmann
3d23c626e6 Avoid a SAL_WARN caused by IllegalArgumentEx now being a RuntimeEx
Change-Id: I6fad4e840cf47b4d41592ff179f66943a4469760
2013-02-05 13:08:22 +01:00
Tor Lillqvist
701d19fb4f Ignore IPC socket setup errors on OS X as they occur always when sandboxed
In a sandboxed LibreOffice, on 10.8.2 at least, creating the Unix
domain socket fails. Ignore that as hopefully people running a
sandboxed LO won't attempt starting it from the command-line or in
other tricky ways, so the normal OS X mechanism that prevents multiple
instances of an app from being started should work fine. I hope.

Change-Id: I4e0aa0c823328d00c8ff1c039859e78ba8ae92c5
2013-02-05 01:52:41 +02:00
Stephan Bergmann
1e33b3dc73 osl::{File,Directory}::getURL() had curiously been missing
Change-Id: I0af83e7aeaf681440d4bbb50d8b00390f8464b1a
2013-01-30 16:29:27 +01:00
Stephan Bergmann
67d23e3a99 fdo#57061: Use a new MIGRATION4 flag file for profile migration LO 3 -> 4
...to avoid missing migrations on Windows and Mac OS X, where existing "3" user
profiles got the "MIGRATED" flag file erroneously added when running LO 3
already, presumably due to 6b52267337 "default
config location has changed, look in old config dir when migrating."

Change-Id: I8dd50a36450c167d47411834cc06a754affadf6d
2013-01-25 18:30:23 +01:00
Stephan Bergmann
59afa90803 Improve debug error reporting
Change-Id: I6798f7f855ed65a7628b4a178497205bce2e6060
2013-01-24 10:25:20 +01:00
Michael Stahl
c106167f5f PRODUCTEXTENSION: fix various obvious strings and such...
... to look pretty; most of these expect PRODUCTEXTENSION to be a word
like "Beta" but nowadays it is ".micro.rc.alphabeta" numbers so there
should be no space before it.

ReplaceStringHookProc adds insult to injury by refusing to
replace %ABOUTBOX variables unless some %PRODUCT is in the string.

Change-Id: Ib676f3837ab0785529a226fc9359e8defacf3459
2013-01-18 23:46:34 +01:00
Noel Grandin
54f1418824 fdo#46808, Adapt frame::SessionListener UNO service to new style
The service already existed, it just did not have an IDL file.

Change-Id: I88b914995eaa52708c1d51271455478fedb65a63
2013-01-15 09:56:01 +02:00
Noel Grandin
e7018375cd fdo#46808, Adapt frame::StartModule UNO service to new style
The service already existed, it just did not have an IDL file.

Change-Id: I400551d34d074cc8cf36fad58badc921422a2efa
2013-01-15 09:56:00 +02:00
Stephan Bergmann
34d63e34d9 Use std::back_inserter
Change-Id: If87f96b5c616ee6ec70de6aa7f2a58c044f04f3a
2013-01-14 17:21:02 +01:00
Tor Lillqvist
e103887c8c QUARTZ is equivalent to MACOSX
So just check MACOSX in the sources, and don't pass any -DQUARTZ to
compilations.

Change-Id: Ia1de6024810f81f1eea01b8eb0b885d9d1ee8e20
2013-01-11 11:16:59 +02:00
Stephan Bergmann
8dd405d32c fdo#58909: Missing BAK_EXTENSIONS bootstrap variable
daeed90f45 "re-base on ALv2 code" had incorporated
from <http://svn.apache.org/viewvc?view=revision&revision=1172102> "imported
patch extensions_i117681.patch" the parts using BAK_EXTENSIONS in
desktop/source/deployment/manager/, but not the parts setting BAK_EXTENSIONS in
scp2/source/ooo/.

Also, setting the stamp for "bak" in PackageManagerImpl::create needed to be
adapted to bee742eb7a "Fix sense of r/o detection
code, and clean up" and 61eeb689d7 "fix smoketest
- need to check read-only-ness of non-existent paths."

Change-Id: If7cc363b3cf21fd13fb467f5f672eda5312515c8
2013-01-10 12:15:43 +01:00
Caolán McNamara
d9e3efbc0e add a CloseButton to vcl for convenience
does exactly the same default action as a CancelButton except with "Close" as
the label

Change-Id: I538e8fc761cde4a1050d066ef935df1ecd930414
2013-01-09 11:40:53 +00:00
Stephan Bergmann
57eff6cf9d Fix MigrationImpl::subtract
"The original code is broken to begin with, as it ignores the return values from
the std::unique calls, so excess elements remain at the end of va and vb."
(<http://lists.freedesktop.org/archives/libreoffice/2013-January/043552.html>
"[PATCH] Simplify MigrationImpl::subtract in desktop;" see that mail thread also
for the inspiration to use std::set_difference.)

This fix is not very relevant though, as there are no "ExcludedFiles" lists in
officecfg/registry/data/org/openoffice/Setup.xcu, so the second argument is
always empty, so the return value is always a (sorted) copy of the first
argument, and the "IncludedFiles" lists in Setup.xcu produce no duplicates, so
std::unique does not shrink the first argument anyway.

Change-Id: Ie9fb64ee40fef6e7bdf0f5d0eca5717fec7b0d50
2013-01-08 17:30:34 +01:00
Aurimas Fišeras
3616640054 fdo#57203 Unknown option: -Embedding
Ignore this option on Windows.
This work-arounds a regression introduced by f4a4ba9ac
Windows appends -Embedding when LibreOffice is called by COM+
Before f4a4ba9ac this option was silently ignored.

Change-Id: I8a727895c9ec8fa4b06aea8ad66b2791ada66dd5
Reviewed-on: https://gerrit.libreoffice.org/1514
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07 13:27:00 +00:00
Matteo Casalin
a4c7ded1fd Cleanup: #include <tools/gen.hxx>
Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530
Reviewed-on: https://gerrit.libreoffice.org/1484
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07 13:14:57 +00:00
Tor Lillqvist
9bdaff431b Typo 2013-01-06 17:00:34 +02:00
Tor Lillqvist
4427bb0c58 The "ProductSource" (MWS name) makes no sense any more 2013-01-06 15:30:04 +02:00
Jan Holesovsky
0c22f3eadd Make LO buildable again after the GraphicFilter move.
Change-Id: I3455a7294b136400f32163626d5a7a7f2bfa898c
2013-01-04 22:02:51 +01:00
Chr. Rossmanith
f9f9fa1ef7 RTL_CONSTASCII_(U)STRINGPARAM removed in desktop
Change-Id: I23bd979aa39a8062f65f66e701cfd8ca3a18da8c
2013-01-01 22:04:36 +01:00
Peter Foley
c20147bb64 fix fallout from string cleanup
Change-Id: Ibd1bf217a6cb2b34eac67b0c3066f5800b584905
2012-12-30 09:55:24 -05:00
Chr. Rossmanith
8736d50780 RTL_CONSTASCII_(U)STRINGPARAM removed in desktop/source/deployment/manager
removed OUSTR() as well and replaced .equals() with ==

Change-Id: I3cbf3654f64bbc906352efc34d1458b00db3ddef
2012-12-30 11:30:48 +01:00
Chr. Rossmanith
d1bab2c273 RTL_CONSTASCII_(U)STRINGPARAM removed in desktop/source/app
removed OUSTRING() as well

Change-Id: Ib074d4729370a921b6b51d50360e4fa92f3d5ddf
2012-12-30 11:21:15 +01:00